From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAFF9A0540 for ; Fri, 8 Jul 2022 10:08:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD222410E8; Fri, 8 Jul 2022 10:08:27 +0200 (CEST) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 57564406B4 for ; Fri, 8 Jul 2022 10:08:26 +0200 (CEST) Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 478593F1CA for ; Fri, 8 Jul 2022 08:08:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1657267704; bh=nul61l1GBehPkT/viLpnZ/iZ5N2JHbffg96PNA8AGD0=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=fk6RtTBgiU5Ry1D4q0NcP5QZImxmFmNsqvV0iDOQUlGQEXon2WcLozMIw6qyy123n Kcdhl2nft3Lq5oBECb7tXaJagyXF9HttCa4IN0V9VdHpupsvjazH2s3zEg8ORfyhLe 9uuUJmQPxxxMDejBL6xDNa/GNwzJq+Kmmxmje81yJ4bolqLTxEWHmSI4psIPI/jZZ1 AbbOnx6aF8DotsHws68H/J7XwuurhMLwxKdTGk7RkMx0XxsYlAeCXrFdWuLomWA6g0 jmkyLw2+Jtk/dVrGTOTx+2yjRHEfDFJsbEURkj1KhobhtdEFAcUI7AVHhCF3jUYxU9 q018H+dCSqmkQ== Received: by mail-lj1-f197.google.com with SMTP id 1-20020a2eb941000000b0025bf383b681so5717460ljs.1 for ; Fri, 08 Jul 2022 01:08:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nul61l1GBehPkT/viLpnZ/iZ5N2JHbffg96PNA8AGD0=; b=b1Es1NYDV7Cryuo0Bw7nA/FK3ez5L9Bojnc3lQ9sDgxpyuHbfIALtpCuVtc0Ta1nxg vN2ETrd1TgWfgxVIo4oQN0XLqwanWJRJrzBcUalqnkZZXNTYd6RjZjJKVhnSOXidAfk2 9jK/xSCxqBcGGIflqCZu7pef07IwueWoxPbM19lG2XwAhjtESv/ow6L2rwc0uW8Tv4hv hE1FfqtH87QZJoBTMhL+q4b5boP5vNAgTAXdjhzuIV41QAvOIV050sLNbsPXRQu+Wbvl H6rW+sFuPOAwYw3oCQvFauEcsTeCrk2f9+LFj7vYbbQ9WZwiFgq8kJxOMvp6NwQEOqLl 0QTQ== X-Gm-Message-State: AJIora8RLibL1kcfAxrliDukzqLKXzEZ4lnQuPYbVuZtLWxADVUeB/DO dumWRR5fLeVMnwiJ4cEHCx2ho+qJ9Z4FdQx8mc6fgF7ZjM7qT+DxGWFxHO2ASarvFoNVfAEtIvK QiDC2bkIFVnv4dQq6vVd3pWJDuXeuS6XiTNw1WcDd X-Received: by 2002:a05:6512:3b83:b0:47f:7419:5e58 with SMTP id g3-20020a0565123b8300b0047f74195e58mr1577644lfv.302.1657267702680; Fri, 08 Jul 2022 01:08:22 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sCXr+m/nlLX0B5eyqtN76SzcCDK9Dc0BrKseXlgVKRJDOuvS3T0C+Q4PE+8eenuDZZRAcO/3SkEAZsJWA0khM= X-Received: by 2002:a05:6512:3b83:b0:47f:7419:5e58 with SMTP id g3-20020a0565123b8300b0047f74195e58mr1577630lfv.302.1657267702347; Fri, 08 Jul 2022 01:08:22 -0700 (PDT) MIME-Version: 1.0 References: <20220707094756.20142-1-kda@semihalf.com> In-Reply-To: <20220707094756.20142-1-kda@semihalf.com> From: Christian Ehrhardt Date: Fri, 8 Jul 2022 10:07:56 +0200 Message-ID: Subject: Re: [PATCH 19.11] config: fix C++ cross compiler for ARM To: Stanislaw Kardach Cc: stable@dpdk.org, Bruce Richardson Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, Jul 7, 2022 at 11:48 AM Stanislaw Kardach wrote: > > [ upstream commit f75dd6d3b1215c2e7cdbdc290b5789517c8cfe10 ] Thank you, applied to the WIP branch for 19.11.13 > Through some mixup all cross-files for ARM platform were using C > Preprocessor (cpp) instead of GCC (g++). > This caused meson to fail detecting the C++ compiler presence and > therefore disabling some targets (i.e. C++ include file checks). > > Fixes: e53a5299d219 ("build: support vendor specific ARM cross builds") > > Signed-off-by: Stanislaw Kardach > Acked-by: Bruce Richardson > --- > config/arm/arm64_armada_linux_gcc | 2 +- > config/arm/arm64_armv8_linux_gcc | 2 +- > config/arm/arm64_bluefield_linux_gcc | 2 +- > config/arm/arm64_dpaa_linux_gcc | 2 +- > config/arm/arm64_emag_linux_gcc | 2 +- > config/arm/arm64_n1sdp_linux_gcc | 2 +- > config/arm/arm64_octeontx2_linux_gcc | 2 +- > config/arm/arm64_thunderx2_linux_gcc | 2 +- > config/arm/arm64_thunderx_linux_gcc | 2 +- > 9 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/config/arm/arm64_armada_linux_gcc b/config/arm/arm64_armada_linux_gcc > index fa40c0398f..d78c99e8e8 100644 > --- a/config/arm/arm64_armada_linux_gcc > +++ b/config/arm/arm64_armada_linux_gcc > @@ -1,6 +1,6 @@ > [binaries] > c = 'aarch64-linux-gnu-gcc' > -cpp = 'aarch64-linux-gnu-cpp' > +cpp = 'aarch64-linux-gnu-g++' > ar = 'aarch64-linux-gnu-ar' > as = 'aarch64-linux-gnu-as' > strip = 'aarch64-linux-gnu-strip' > diff --git a/config/arm/arm64_armv8_linux_gcc b/config/arm/arm64_armv8_linux_gcc > index 88f0ff9dae..057d70bbdd 100644 > --- a/config/arm/arm64_armv8_linux_gcc > +++ b/config/arm/arm64_armv8_linux_gcc > @@ -1,6 +1,6 @@ > [binaries] > c = 'aarch64-linux-gnu-gcc' > -cpp = 'aarch64-linux-gnu-cpp' > +cpp = 'aarch64-linux-gnu-g++' > ar = 'aarch64-linux-gnu-gcc-ar' > strip = 'aarch64-linux-gnu-strip' > pkgconfig = 'aarch64-linux-gnu-pkg-config' > diff --git a/config/arm/arm64_bluefield_linux_gcc b/config/arm/arm64_bluefield_linux_gcc > index 86797d23cd..616e633495 100644 > --- a/config/arm/arm64_bluefield_linux_gcc > +++ b/config/arm/arm64_bluefield_linux_gcc > @@ -1,6 +1,6 @@ > [binaries] > c = 'aarch64-linux-gnu-gcc' > -cpp = 'aarch64-linux-gnu-cpp' > +cpp = 'aarch64-linux-gnu-g++' > ar = 'aarch64-linux-gnu-gcc-ar' > strip = 'aarch64-linux-gnu-strip' > pkgconfig = 'aarch64-linux-gnu-pkg-config' > diff --git a/config/arm/arm64_dpaa_linux_gcc b/config/arm/arm64_dpaa_linux_gcc > index 1a46821543..0108bb952a 100644 > --- a/config/arm/arm64_dpaa_linux_gcc > +++ b/config/arm/arm64_dpaa_linux_gcc > @@ -1,6 +1,6 @@ > [binaries] > c = 'aarch64-linux-gnu-gcc' > -cpp = 'aarch64-linux-gnu-cpp' > +cpp = 'aarch64-linux-gnu-g++' > ar = 'aarch64-linux-gnu-ar' > as = 'aarch64-linux-gnu-as' > strip = 'aarch64-linux-gnu-strip' > diff --git a/config/arm/arm64_emag_linux_gcc b/config/arm/arm64_emag_linux_gcc > index 8edcd3e976..3bb5134224 100644 > --- a/config/arm/arm64_emag_linux_gcc > +++ b/config/arm/arm64_emag_linux_gcc > @@ -1,6 +1,6 @@ > [binaries] > c = 'aarch64-linux-gnu-gcc' > -cpp = 'aarch64-linux-gnu-cpp' > +cpp = 'aarch64-linux-gnu-g++' > ar = 'aarch64-linux-gnu-gcc-ar' > strip = 'aarch64-linux-gnu-strip' > pkgconfig = 'aarch64-linux-gnu-pkg-config' > diff --git a/config/arm/arm64_n1sdp_linux_gcc b/config/arm/arm64_n1sdp_linux_gcc > index 022e063039..421d06c77f 100644 > --- a/config/arm/arm64_n1sdp_linux_gcc > +++ b/config/arm/arm64_n1sdp_linux_gcc > @@ -1,6 +1,6 @@ > [binaries] > c = 'aarch64-linux-gnu-gcc' > -cpp = 'aarch64-linux-gnu-cpp' > +cpp = 'aarch64-linux-gnu-g++' > ar = 'aarch64-linux-gnu-gcc-ar' > strip = 'aarch64-linux-gnu-strip' > pkgconfig = 'aarch64-linux-gnu-pkg-config' > diff --git a/config/arm/arm64_octeontx2_linux_gcc b/config/arm/arm64_octeontx2_linux_gcc > index 365bd7cbdd..0d7a66c97e 100644 > --- a/config/arm/arm64_octeontx2_linux_gcc > +++ b/config/arm/arm64_octeontx2_linux_gcc > @@ -1,6 +1,6 @@ > [binaries] > c = 'aarch64-linux-gnu-gcc' > -cpp = 'aarch64-linux-gnu-cpp' > +cpp = 'aarch64-linux-gnu-g++' > ar = 'aarch64-linux-gnu-gcc-ar' > strip = 'aarch64-linux-gnu-strip' > pkgconfig = 'aarch64-linux-gnu-pkg-config' > diff --git a/config/arm/arm64_thunderx2_linux_gcc b/config/arm/arm64_thunderx2_linux_gcc > index 2b41acc615..24346ffe71 100644 > --- a/config/arm/arm64_thunderx2_linux_gcc > +++ b/config/arm/arm64_thunderx2_linux_gcc > @@ -1,6 +1,6 @@ > [binaries] > c = 'aarch64-linux-gnu-gcc' > -cpp = 'aarch64-linux-gnu-cpp' > +cpp = 'aarch64-linux-gnu-g++' > ar = 'aarch64-linux-gnu-gcc-ar' > strip = 'aarch64-linux-gnu-strip' > pkgconfig = 'aarch64-linux-gnu-pkg-config' > diff --git a/config/arm/arm64_thunderx_linux_gcc b/config/arm/arm64_thunderx_linux_gcc > index 6572ab615d..cbf60bac73 100644 > --- a/config/arm/arm64_thunderx_linux_gcc > +++ b/config/arm/arm64_thunderx_linux_gcc > @@ -1,6 +1,6 @@ > [binaries] > c = 'aarch64-linux-gnu-gcc' > -cpp = 'aarch64-linux-gnu-cpp' > +cpp = 'aarch64-linux-gnu-g++' > ar = 'aarch64-linux-gnu-gcc-ar' > strip = 'aarch64-linux-gnu-strip' > pkgconfig = 'aarch64-linux-gnu-pkg-config' > -- > 2.34.1 > -- Christian Ehrhardt Senior Staff Engineer, Ubuntu Server Canonical Ltd