patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "Xueming(Steven) Li" <xuemingl@nvidia.com>,
	Luca Boccassi <bluca@debian.org>,
	 Kevin Traynor <ktraynor@redhat.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [19.11][20.11][21.11] ppc64 fixes backport
Date: Thu, 7 Jul 2022 09:44:28 +0200	[thread overview]
Message-ID: <CAATJJ0JCD2TNvW+PwiV4-kx=T5_jt4q+q2J72KxH4cnxdjm_1w@mail.gmail.com> (raw)
In-Reply-To: <6239212.097qLLJo0e@thomas>

On Thu, Jul 7, 2022 at 8:51 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 06/07/2022 20:53, Luca Boccassi:
> > On Wed, 29 Jun 2022 at 14:40, Xueming(Steven) Li <xuemingl@nvidia.com> wrote:
> > >
> > > Hi LTS maintainers,
> > >
> > > Confirmed with Thomas, mlx5 PMD needs the following patches to compile with the upstream rdma-core lib.
> > >
> > > 2022-05-25 2022-06-01 b251bb7630  eal/ppc: undefine AltiVec keyword vector      @Thomas Monjalon
> > > 2022-05-03 2022-05-25 64fcadeac0  avoid AltiVec keyword vector  @Thomas Monjalon
> > >
> > > I tried to backport to 20.11.6 LTS, cherry-pick works without conflicts.
> > >
> > > Best Regards,
> > > Xueming Li
> >
> > Hi,
> >
> > This patch:
> >
> > 2022-05-25 2022-06-01 b251bb7630  eal/ppc: undefine AltiVec keyword
> > vector      @Thomas Monjalon
> >
> > Looks like an incompatible change? Commit message says so too:
> >
> > "This is a compatibility breakage for applications which were using
> > the keyword "vector" for its AltiVec meaning."
> >
> > The first one looks like but I don't think we should pick up the
> > second one for the LTS branches?
>
> Yes if we undefine "vector", we break applications using this syntax.
> That's a required change for recent rdma-core which uses the name "vector"
> for another purpose.
> I don't know what is best/worst.

It is ok for new DPDK releases to add this, but not for LTS backports.

In general LTS releases are usually updated and rebuild against their
own older environment.
So if "new rdma-core" is a problem it only is a  problem for "new DPDK".

IMHO LTS versions of DPDK should not take such a change.


>


-- 
Christian Ehrhardt
Senior Staff Engineer, Ubuntu Server
Canonical Ltd

  reply	other threads:[~2022-07-07  7:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-29 13:40 Xueming(Steven) Li
2022-07-06 18:53 ` Luca Boccassi
2022-07-07  6:51   ` Thomas Monjalon
2022-07-07  7:44     ` Christian Ehrhardt [this message]
2022-07-07  8:21       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAATJJ0JCD2TNvW+PwiV4-kx=T5_jt4q+q2J72KxH4cnxdjm_1w@mail.gmail.com' \
    --to=christian.ehrhardt@canonical.com \
    --cc=bluca@debian.org \
    --cc=ktraynor@redhat.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=xuemingl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).