From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D5954A0540
	for <public@inbox.dpdk.org>; Thu,  7 Jul 2022 09:44:58 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C7B75406B4;
	Thu,  7 Jul 2022 09:44:58 +0200 (CEST)
Received: from smtp-relay-internal-0.canonical.com
 (smtp-relay-internal-0.canonical.com [185.125.188.122])
 by mails.dpdk.org (Postfix) with ESMTP id 73818406B4
 for <stable@dpdk.org>; Thu,  7 Jul 2022 09:44:57 +0200 (CEST)
Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com
 [209.85.208.200])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 232A73F496
 for <stable@dpdk.org>; Thu,  7 Jul 2022 07:44:57 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;
 s=20210705; t=1657179897;
 bh=e8XQXPQ65UbOkpdjJ5QsagTqrgY8S2ZQ8as8W3NWFOA=;
 h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:
 To:Cc:Content-Type;
 b=RkJxvZbmuiiM3p39fmSaldavvTbBzfkzv1bZC/CaqkvBl5LfMJziZIC4wco7H7GPH
 ipBo1FzFx3dlsUbnny/BIkWceKvCZSxkcx4LwTwMqoHdw+nEQl8v2dsnAH0VZLmbg3
 CjYnSM/4jJe6cjc0BIWnPN9DnJPECDWtssoGaMk27e7E0ksznNzwX7LXvDQC3pbp4j
 LHpN8vc9N6A6o9LvLUjl7tnu0e2KTQ/a6q50OWdiviTxqmPj+CmNzoUilHU6gl/oOZ
 PtipT/I82RwFU435XbFqvQRM1af22SthtHTunGIChEHes+Q0MB4vxU3uA2Zj18wUe0
 I7v4k05hN7fIA==
Received: by mail-lj1-f200.google.com with SMTP id
 h9-20020a2eb0e9000000b0025d3255018dso2103415ljl.6
 for <stable@dpdk.org>; Thu, 07 Jul 2022 00:44:57 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=e8XQXPQ65UbOkpdjJ5QsagTqrgY8S2ZQ8as8W3NWFOA=;
 b=ofL1bM6h0F5SrJUWEOiiwbKg7ElKJwdeFHYLTYV6WZxCD2iIyWL9RBINEw8n9DwVBS
 s6hEQL3TCFeOFbLqgfulVFVC+lrpqbdMj6+eGMDBNm2bbDcoOle7ho+XX/0iMTpU1zT7
 cAbK11ZeaILCDjHRlUdBc5BMo9vcCjhgvc5z68s2LS48ho6aw939aBvW4G2r6CuYSCcB
 KhCdJ++PCawysdqH7c6y+ITyfwQsoe6KsobBoczfZQbwsxH7vZwiiTbyKcPabStMZ2hU
 /jkjBZ/oR/e5Tk/0H0Qj0yme4dDQMWBf18K0pmWaBPruuY3Ub2+DoNVY0E47KbfxJu6r
 RdUw==
X-Gm-Message-State: AJIora8mMVhvkwHdBRuSeTuHiJLF9NY+DOx+YlpPzTupB6zrhU8FLpBz
 kOOl0RdRnJON7xKtlBkMkJmMDmrtnq4Z2+h/vlaGQUF1fCh0+YLZv+net431MEu0mnw4eXPiUER
 imHEaMvam7KEN0XJb1pPhyZMTxJrIp3y8vXSKXLPt
X-Received: by 2002:a05:651c:1542:b0:249:a87f:8a34 with SMTP id
 y2-20020a05651c154200b00249a87f8a34mr25626451ljp.442.1657179895053; 
 Thu, 07 Jul 2022 00:44:55 -0700 (PDT)
X-Google-Smtp-Source: AGRyM1uwtepxbocxEK5/3vdUXyikc/twVsHWLxtwaHSTKDVfxOWBW8juV51L7I4vT+u0Zk9LsOA6viI1Wqw3zuwpXCo=
X-Received: by 2002:a05:651c:1542:b0:249:a87f:8a34 with SMTP id
 y2-20020a05651c154200b00249a87f8a34mr25626440ljp.442.1657179894852; Thu, 07
 Jul 2022 00:44:54 -0700 (PDT)
MIME-Version: 1.0
References: <BN9PR12MB5366E0E8FD5257498BB76449A1BB9@BN9PR12MB5366.namprd12.prod.outlook.com>
 <CAMw=ZnR6Ef9x=hc1iT+8Eu=sn8gfahAY3+c4y0ePtH5R6mcVoA@mail.gmail.com>
 <6239212.097qLLJo0e@thomas>
In-Reply-To: <6239212.097qLLJo0e@thomas>
From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Date: Thu, 7 Jul 2022 09:44:28 +0200
Message-ID: <CAATJJ0JCD2TNvW+PwiV4-kx=T5_jt4q+q2J72KxH4cnxdjm_1w@mail.gmail.com>
Subject: Re: [19.11][20.11][21.11] ppc64 fixes backport
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "Xueming(Steven) Li" <xuemingl@nvidia.com>,
 Luca Boccassi <bluca@debian.org>, 
 Kevin Traynor <ktraynor@redhat.com>, "stable@dpdk.org" <stable@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org

On Thu, Jul 7, 2022 at 8:51 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 06/07/2022 20:53, Luca Boccassi:
> > On Wed, 29 Jun 2022 at 14:40, Xueming(Steven) Li <xuemingl@nvidia.com> wrote:
> > >
> > > Hi LTS maintainers,
> > >
> > > Confirmed with Thomas, mlx5 PMD needs the following patches to compile with the upstream rdma-core lib.
> > >
> > > 2022-05-25 2022-06-01 b251bb7630  eal/ppc: undefine AltiVec keyword vector      @Thomas Monjalon
> > > 2022-05-03 2022-05-25 64fcadeac0  avoid AltiVec keyword vector  @Thomas Monjalon
> > >
> > > I tried to backport to 20.11.6 LTS, cherry-pick works without conflicts.
> > >
> > > Best Regards,
> > > Xueming Li
> >
> > Hi,
> >
> > This patch:
> >
> > 2022-05-25 2022-06-01 b251bb7630  eal/ppc: undefine AltiVec keyword
> > vector      @Thomas Monjalon
> >
> > Looks like an incompatible change? Commit message says so too:
> >
> > "This is a compatibility breakage for applications which were using
> > the keyword "vector" for its AltiVec meaning."
> >
> > The first one looks like but I don't think we should pick up the
> > second one for the LTS branches?
>
> Yes if we undefine "vector", we break applications using this syntax.
> That's a required change for recent rdma-core which uses the name "vector"
> for another purpose.
> I don't know what is best/worst.

It is ok for new DPDK releases to add this, but not for LTS backports.

In general LTS releases are usually updated and rebuild against their
own older environment.
So if "new rdma-core" is a problem it only is a  problem for "new DPDK".

IMHO LTS versions of DPDK should not take such a change.


>


-- 
Christian Ehrhardt
Senior Staff Engineer, Ubuntu Server
Canonical Ltd