From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 369B8A0548 for ; Fri, 3 Dec 2021 07:13:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EA26040041; Fri, 3 Dec 2021 07:13:10 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id D7DFE40041 for ; Fri, 3 Dec 2021 07:13:09 +0100 (CET) Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 902363F1B7 for ; Fri, 3 Dec 2021 06:13:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638511989; bh=cyll1YKSkDBg2XTtsMkFBzRy4plKjCuLnpYJA3wvBjo=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Wyog8jLI5IsdeU4Gvr2o8DXO7NltVGEaWdHNXGR6bxlMOOvs4QN3S3uKjH3Hzcgcc P7nUm3uNZdPrOQwNFXYOZLXoEwhXUBL76hldJLWHUgDw+dh8K4BOtd7jmpW1p0I89h HncKSOcmfFxZN0Mp06hkQl6Pxi1cNBJk6UqG/ftLbrZNzd6drdls7nxWjQzIquFay4 qLxdrSJxIkM7IGo09nZJ9qZnd9XzNNACo9qrpjffk6Yam3pqzUqjRDpP9trNDW2WFZ AxcKt2FNKMfOjPf3OQEWedfMly1O/8cSQ9zjZ5T4z40RgnGyNcZ2lPIYCBlkYmPYnO foqzevZDob2+A== Received: by mail-qt1-f198.google.com with SMTP id u14-20020a05622a198e00b002b2f35a6dcfso2388859qtc.21 for ; Thu, 02 Dec 2021 22:13:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cyll1YKSkDBg2XTtsMkFBzRy4plKjCuLnpYJA3wvBjo=; b=S0YFfq/A1ctrIOgd+hncn8wfjF+yr1nEvSuvFeTn3DKn9LheD6b4C52ADlF1J5l60F 90NMjxR/8T3SDy0aWyf+/3wikEAhzeoxGN8K3YeKmzKe3mVlreEAa7jEeKifrQ9YBda0 L56W+C0YPJvRLeuSckYE6ECGYmXKZv+HXu7Ya9HLcvf8JDyL/gz0zkzvz9T5jRdGT2ch ZByJpg9IHWUDIWVGpI6/uiSyS9zo7vCjZ+XXkxMfRLLJXTqlmdsRizGYs/stb6mON5AX pbY/HOPPpZ5Uf+B0QAVot8t9rqpt9LSq+NLa88whCf1jodML21q3MCpkjDpsYTjJw/pm c+uw== X-Gm-Message-State: AOAM532rYvPfbCFPOOD3peW8x/IjHBUOEqKVfaGcwc4ARa6uci2+wayL e+1BTK0RQ0x+EAe7sqh8+xQugVwFPMJ0rBT3DXZnEIIPxhJqn+s4pJDv9fu/YO6VjKdM86EZalZ np48h/BFxs+Lj8nRJ/UFYKdLI7uVVdYvggk+dQanW X-Received: by 2002:a05:620a:1aa0:: with SMTP id bl32mr16706578qkb.140.1638511988643; Thu, 02 Dec 2021 22:13:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJxtCWLg7esIAK9Hs8UoaYnNOrBMXCDP9TnFlZUmkVcxPc8YaxEp2FyIOfj7Le5pLXz6v/gB+YQhCWiNifVmRP4= X-Received: by 2002:a05:620a:1aa0:: with SMTP id bl32mr16706532qkb.140.1638511988389; Thu, 02 Dec 2021 22:13:08 -0800 (PST) MIME-Version: 1.0 References: <20211130165631.2467343-1-christian.ehrhardt@canonical.com> In-Reply-To: From: Christian Ehrhardt Date: Fri, 3 Dec 2021 07:12:42 +0100 Message-ID: Subject: Re: To: David Marchand Cc: dpdk stable , Aaron Conole , Abhinandan Gujjar , Ajit Khaparde , Akhil Goyal , Alexander Kozyrev , Ali Alnubani , Alvin Zhang , Aman Singh , Anatoly Burakov , Andrew Boyer , Andrew Rybchenko , Andy Moreton , Anoob Joseph , Apeksha Gupta , Arek Kusztal , Ashish Gupta , Baruch Siach , Beilei Xing , Bernard Iremonger , Bruce Richardson , Chandubabu Namburu , Chas Williams , Chenbo Xia , Chengchang Tang , Chengwen Feng , Ciara Loftus , Ciara Power , Conor Fogarty , Conor Walsh , Cristian Dumitrescu , Dan Nowlin , Dapeng Yu , Dariusz Sosnowski , David Christensen , David Hunt , Declan Doherty , Deepak Kumar Jain , Devendra Singh Rawat , Dmitry Kozlyuk , Dmitry Kozlyuk , Dmitry Malloy , Eli Britstein , Evgeny Schemeilin , Fan Zhang , Feifei Wang , Ferruh Yigit , Fiona Trahe , Gagandeep Singh , Gaoxiang Liu , Gregory Etelson , Guoyang Zhou , Haiyue Wang , Harman Kalra , Harry van Haaren , Heinrich Kuhn , Hemant Agrawal , Honnappa Nagarahalli , Huichao Cai , Huisong Li , Hyong Youb Kim , Idan Hackmon , Igor Chauskin , Igor Romanov , Igor Russkikh , Igor Ryzhov , Ilyes Ben Hamouda , Ivan Ilchenko , Ivan Malov , Jakub Grajciar , Jasvinder Singh , Jay Jayatheerthan , Jay Zhou , Jerin Jacob , Jian Wang , Jiawen Wu , Jie Wang , Jingjing Wu , John Daley , John Griffin , John McNamara , "John W. Linville" , Joyce Kong Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, Dec 2, 2021 at 3:12 PM David Marchand wrote: > > Hello, > > On Tue, Nov 30, 2021 at 5:56 PM wrote: > > Applying but breaking the build: > > > > 86e361cdeb David Marchand test/cmdline: fix memory leak > > It is not marked for backport: it fixes 6ad06203a587 ("cmdline: free > on exit") that introduced an API change (making it itself not > backportable). > Why did you consider this patch? Hi David, the tooling selects initially any patch that fulfils either condition 1. marked for stable@dpdk 2. has a Fixes: entry 3. has "fix" in the subject We (the stable maintainers) then do some filtering for patches that we find non-needed or ABI affecting. This time for example I cut down an initial 516 to 274. But we might miss one and hence the requests to the Authors (as they know best) and the further testing from there. > > --- > > > > Not Applying > > > > fe629897de David Marchand app/testpmd: remove double dependency on bitrate lib > > Looking at 19.11 branch, this backport is not needed as Luca already > dropped double reference in a 19.11 only patch: > a7a21ffad191 ("Revert "app/testpmd: fix name of bitrate library in > meson build"") Ok > > b72099be7f David Marchand net/virtio-user: fix init when using existing tap > > This was not supported before, and it is not marked for backport, on purpose. > > > > 4a985f4e84 David Marchand test/service: fix race in attr check > > It fixes another fix which is not in 19.11: > 52bb6be259ff ("test/service: fix race condition on stopping lcore") > > You can skip it. Ok Thanks for your expertise on your changes! > Thanks. > > -- > David Marchand > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd