From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: Ali Alnubani <alialnu@nvidia.com>
Cc: stable@dpdk.org, dkozlyuk@nvidia.com
Subject: Re: [PATCH 19.11] net/mlx5: fix netlink header path
Date: Thu, 31 Mar 2022 11:51:41 +0200 [thread overview]
Message-ID: <CAATJJ0JHXUUhwgtYxCYOXSLT0W-HxNxjtduZwXsGL5FFkztsdg@mail.gmail.com> (raw)
In-Reply-To: <20220329130051.3493478-1-alialnu@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1675 bytes --]
On Tue, Mar 29, 2022 at 3:01 PM Ali Alnubani <alialnu@nvidia.com> wrote:
> Use netlink.h provided by the kernel headers instead
> of adding a dependency on the headers provided by the libnl package,
> which weren't being found in some cases, even with libnl-3 and
> libnl-route-3 libs installed via the package manager.
> Also see usage in netlink(3).
>
Thank you, indeed various other includers of netlink.h already use the
kernel headers and this makes this consistent.
Applied to the WIP 19.11.12
Since it is only a build fix - unless someone is totally blocked on
verifying 19.11.12 - this isn't forcing a new round with an -rc2.
I'll do a cross arch/distro rebuild test to be sure it has no unexpected
side effects ...
Resolves the build error:
> drivers/net/mlx5/mlx5.h:15:10:
> fatal error: netlink/netlink.h: No such file or directory
> The error reproduces on Ubuntu 16.04/18.04/20.04, openSUSE Leap 15.3,
> and CentOS 7/8. It reproduces with Make and Meson.
>
> Fixes: 7bd18f45ed47 ("common/mlx5: add Netlink event helpers")
> Cc: dkozlyuk@nvidia.com
>
> Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
> ---
> drivers/net/mlx5/mlx5.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
> index 1cf5f41689..9f6b355182 100644
> --- a/drivers/net/mlx5/mlx5.h
> +++ b/drivers/net/mlx5/mlx5.h
> @@ -12,7 +12,7 @@
> #include <limits.h>
> #include <net/if.h>
> #include <netinet/in.h>
> -#include <netlink/netlink.h>
> +#include <linux/netlink.h>
> #include <sys/queue.h>
>
> /* Verbs header. */
> --
> 2.25.1
>
>
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
[-- Attachment #2: Type: text/html, Size: 2591 bytes --]
prev parent reply other threads:[~2022-03-31 9:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 13:00 Ali Alnubani
2022-03-31 9:51 ` Christian Ehrhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAATJJ0JHXUUhwgtYxCYOXSLT0W-HxNxjtduZwXsGL5FFkztsdg@mail.gmail.com \
--to=christian.ehrhardt@canonical.com \
--cc=alialnu@nvidia.com \
--cc=dkozlyuk@nvidia.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).