From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D27FBA04FF for ; Thu, 31 Mar 2022 11:52:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B543940DF6; Thu, 31 Mar 2022 11:52:13 +0200 (CEST) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 22C9740DF6 for ; Thu, 31 Mar 2022 11:52:12 +0200 (CEST) Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 4DAFB3F7F3 for ; Thu, 31 Mar 2022 09:52:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1648720329; bh=whfblEN6NadTtIg2Ev0WSHiU/PiSjzYV6vBhoq7R/fM=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=pGEmtib5wNI2355oQZKItejBoReZhSedx02E0SHl9awFkBwiuSZXhOdyPkWlAQ2gt R7z7ReZKHG7z2IOfsc1Mu4av5Gj0kn53sUx+MFnooCY8p8FRf/wj6Bz8B42WSzAzjo Yrf0z2hngWbOX+6eR+0bGS4fhI44pAJHD3qroLDZld67hwBcjQ+apBHopIVdomVb18 Jv6EDYwoPPv4UEjKzLTheduPg72XWjw7bG421O6En6/GP+QNVRt+/egDZk5dEraZNM MxMuWT91Jk+tAUdKVe3PUP/aM0VI5lygptdTEi2poZNVJjAANAq6Z0zNrJpZMoMHPh F+fxS4DUrRiCw== Received: by mail-qt1-f200.google.com with SMTP id t26-20020ac8739a000000b002e06aa03d4cso19663660qtp.13 for ; Thu, 31 Mar 2022 02:52:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=whfblEN6NadTtIg2Ev0WSHiU/PiSjzYV6vBhoq7R/fM=; b=mJZoCLllIVQGPyqLznRtUO0YZ+qfHOS5p9tlegNEdhiTj9OiCjSiCMrRKm1PQv30P2 JkFEBu2qQCiWH25Mev7t7YWKjDXk6LNOmccXgys9fdN9CMl7rWoB7kzEgfUJMfqcWtkQ /Yyth1D92U1U8wJ/nOaMvuQBSolqGPjxNv9eOwnyd1aPXbfk7NUq4EWUcVNHD+FevfVP nLcbe/kUOOXLSKtsjRmMBAsFQ7ThnscpR6j97jgGwPEcAph5JCNCQLJ3dmtFQudr0S1y OKE8Jy6CK1AoSacxmXAa9tJ5zv9XgvFe/Xt6RdNEroAuG+vJ17zu38+/zwg3GDMGbhjD lVDg== X-Gm-Message-State: AOAM533k39GxwIzCsuV/pFFbXep3UpuXknyVW1NJfYSNc+ElSyD6Ud37 4SgqcIr2sPYzX+7Br5GWpVDKODYVdozg27snxh4WHQm7qSkJpoLfcFGmpFyIc6rdH8nPVGR99Fo DgYqqrLAQOj9g/t9revQPP2YKr/+Elvfxux2G5qQF X-Received: by 2002:a05:620a:f03:b0:67e:1e38:4a0 with SMTP id v3-20020a05620a0f0300b0067e1e3804a0mr2753064qkl.86.1648720327781; Thu, 31 Mar 2022 02:52:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx9sD5j/Zds8cGdTUnuPBt0c+SfuzbOFrxxajcaJGypzOwV3FewH5nMk1LMotBftUDX5MGPKIA2wHsnqqA5Gp8= X-Received: by 2002:a05:620a:f03:b0:67e:1e38:4a0 with SMTP id v3-20020a05620a0f0300b0067e1e3804a0mr2753053qkl.86.1648720327568; Thu, 31 Mar 2022 02:52:07 -0700 (PDT) MIME-Version: 1.0 References: <20220329130051.3493478-1-alialnu@nvidia.com> In-Reply-To: <20220329130051.3493478-1-alialnu@nvidia.com> From: Christian Ehrhardt Date: Thu, 31 Mar 2022 11:51:41 +0200 Message-ID: Subject: Re: [PATCH 19.11] net/mlx5: fix netlink header path To: Ali Alnubani Cc: stable@dpdk.org, dkozlyuk@nvidia.com Content-Type: multipart/alternative; boundary="000000000000757eea05db809d66" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org --000000000000757eea05db809d66 Content-Type: text/plain; charset="UTF-8" On Tue, Mar 29, 2022 at 3:01 PM Ali Alnubani wrote: > Use netlink.h provided by the kernel headers instead > of adding a dependency on the headers provided by the libnl package, > which weren't being found in some cases, even with libnl-3 and > libnl-route-3 libs installed via the package manager. > Also see usage in netlink(3). > Thank you, indeed various other includers of netlink.h already use the kernel headers and this makes this consistent. Applied to the WIP 19.11.12 Since it is only a build fix - unless someone is totally blocked on verifying 19.11.12 - this isn't forcing a new round with an -rc2. I'll do a cross arch/distro rebuild test to be sure it has no unexpected side effects ... Resolves the build error: > drivers/net/mlx5/mlx5.h:15:10: > fatal error: netlink/netlink.h: No such file or directory > The error reproduces on Ubuntu 16.04/18.04/20.04, openSUSE Leap 15.3, > and CentOS 7/8. It reproduces with Make and Meson. > > Fixes: 7bd18f45ed47 ("common/mlx5: add Netlink event helpers") > Cc: dkozlyuk@nvidia.com > > Signed-off-by: Ali Alnubani > --- > drivers/net/mlx5/mlx5.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h > index 1cf5f41689..9f6b355182 100644 > --- a/drivers/net/mlx5/mlx5.h > +++ b/drivers/net/mlx5/mlx5.h > @@ -12,7 +12,7 @@ > #include > #include > #include > -#include > +#include > #include > > /* Verbs header. */ > -- > 2.25.1 > > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd --000000000000757eea05db809d66 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Mar 29, 2022 at 3:01 PM Ali A= lnubani <alialnu@nvidia.com>= ; wrote:
Use net= link.h provided by the kernel headers instead
of adding a dependency on the headers provided by the libnl package,
which weren't being found in some cases, even with libnl-3 and
libnl-route-3 libs installed via the package manager.
Also see usage in netlink(3).

Thank you= , indeed various other includers of netlink.h already use the kernel header= s and this makes this consistent.
Applied to the WIP 19.11.12

Since it is only a build fix - unless someone is tota= lly blocked on verifying 19.11.12 - this isn't forcing a new round with= an -rc2.

I'll do a cross arch/distro=C2=A0reb= uild test to be sure it=C2=A0has no unexpected side effects ...
<= br>
Resolves the build error:
=C2=A0 drivers/net/mlx5/mlx5.h:15:10:
=C2=A0 =C2=A0 fatal error: netlink/netlink.h: No such file or directory
The error reproduces on Ubuntu 16.04/18.04/20.04, openSUSE Leap 15.3,
and CentOS 7/8. It reproduces with Make and Meson.

Fixes: 7bd18f45ed47 ("common/mlx5: add Netlink event helpers") Cc: dkozlyuk@nvidi= a.com

Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
---
=C2=A0drivers/net/mlx5/mlx5.h | 2 +-
=C2=A01 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
index 1cf5f41689..9f6b355182 100644
--- a/drivers/net/mlx5/mlx5.h
+++ b/drivers/net/mlx5/mlx5.h
@@ -12,7 +12,7 @@
=C2=A0#include <limits.h>
=C2=A0#include <net/if.h>
=C2=A0#include <netinet/in.h>
-#include <netlink/netlink.h>
+#include <linux/netlink.h>
=C2=A0#include <sys/queue.h>

=C2=A0/* Verbs header. */
--
2.25.1



--
Christian Ehrhardt
Staff Engineer, Ubuntu Ser= ver
Canonical Ltd
--000000000000757eea05db809d66--