patches for DPDK stable branches
 help / color / Atom feed
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] build: avoid --as-needed as it causes overlinking
       [not found]             ` <CAATJJ0L0sAYsKs1JNW4FNkS5uZEPWqZYoNdvfjRZHHa8cMeHpQ@mail.gmail.com>
@ 2019-09-12 13:43               ` Christian Ehrhardt
  2019-10-12 13:02                 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Ehrhardt @ 2019-09-12 13:43 UTC (permalink / raw)
  To: Bruce Richardson, stable; +Cc: Luca Boccassi, dev, Kevin Laatz, Thomas Monjalon

On Tue, Sep 10, 2019 at 8:48 AM Christian Ehrhardt
<christian.ehrhardt@canonical.com> wrote:
>
> On Wed, Sep 4, 2019 at 11:18 AM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > On Wed, Sep 04, 2019 at 11:13:34AM +0200, Christian Ehrhardt wrote:
> > > On Mon, Sep 2, 2019 at 9:09 AM Christian Ehrhardt
> > > <christian.ehrhardt@canonical.com> wrote:
> > > >
> > > > On Thu, Aug 29, 2019 at 6:02 PM Luca Boccassi <bluca@debian.org> wrote:
> > > > >
> > > > > On Thu, 2019-08-29 at 16:34 +0100, Bruce Richardson wrote:
> > > > > > On Thu, Aug 29, 2019 at 05:30:03PM +0200, Christian Ehrhardt wrote:
> > > > > > > A while ago telemetry was added in 57ae0ec6 and it also added as-
> > > > > > > needed
> > > > > > > to config/meson.build. This seems no more needed these days as due
> > > > > > > to other
> > > > > > > build changes the ordering in buildlogs is:
> > > > > > >   [...] -lrte_telemetry [...] -Wl,--no-as-needed [...]
> > > > > > > Which means telemetry no more benefits from --no-as-needed anyway.
> > > > > > >
> > > > > > > Overlinking problems get triggered by the meson generated pkgconfig
> > > > > > > which
> > > > > > > will have:
> > > > > > >    [...] -Wl,--no-as-needed <somelibsusedbydpdk>
> > > > > > > This will overlink <somelibs> and in addition anything that follows
> > > > > > > as it also doesn't wrap back to --as-needed. So if a projects
> > > > > > > includes
> > > > > > > dpdk libs + <other> it will also consider <other> with --no-as-
> > > > > > > needed.
> > > > > > >
> > > > > > > Fixes:
> > > > > > > https://bugs.launchpad.net/ubuntu/+source/dpdk/+bug/1841759
> > > > > > >
> > > > > > >
> > > > > > > Signed-off-by: Christian Ehrhardt <
> > > > > > > christian.ehrhardt@canonical.com
> > > > > > > >
> > > > > > > Acked-by: Luca Boccassi <
> > > > > > > bluca@debian.org
> > > > > > > >
> > > > > > > ---
> > > > > > >  config/meson.build | 1 -
> > > > > > >  1 file changed, 1 deletion(-)
> > > > > > >
> > > > > > > diff --git a/config/meson.build b/config/meson.build
> > > > > > > index 2bafea530..a27f731f8 100644
> > > > > > > --- a/config/meson.build
> > > > > > > +++ b/config/meson.build
> > > > > > > @@ -94,7 +94,6 @@ dpdk_conf.set('RTE_TOOLCHAIN_' +
> > > > > > > toolchain.to_upper(), 1)
> > > > > > >  dpdk_conf.set('RTE_ARCH_64', cc.sizeof('void *') == 8)
> > > > > > >
> > > > > > >  add_project_link_arguments('-Wl,--no-as-needed', language: 'c')
> > > > > > > -dpdk_extra_ldflags += '-Wl,--no-as-needed'
> > > > > > >
> > > > > >
> > > > > > This seems strange to me. What is it about linking the dpdk apps that
> > > > > > require the argument, but makes it safe for non-builtin apps to avoid
> > > > > > having the arg?
> > > > >
> > > > > We've been wondering about that for a while :-) It also seems to be not
> > > > > reproducible on Ubuntu 18.04/gcc 7.4.
> > > > >
> > > > > Can the verbose linking log be shared here, so that we can have a look
> > > > > at where no-as-needed lands? Might provide some clue
> > > >
> > > > That would be the verbose linking log of the Travis CI run right?
> > > > I currently have no idea which knob to turn to get this :-/
> > > >
> > > > Having it accepted in upstream would make it more easy to fix this in
> > > > the soon to be released Ubuntu 19.10.
> > > > Is there a path to consider taking this fix as-is and continue the
> > > > debug/discussion how the removal of the second line can even cause the
> > > > symptoms that we have seen later?
> > >
> > > re-ping for the above ^^
> > >
> >
> > I'm ok with what you propose above.
>
> Thanks Bruce!
>
> Is there anything else we'd need to do to get this committed?

And actually 18.11 stable would make sense as well IMHO.
Could one who commits could add that as:
Fixes: 57ae0ec62620 ("build: add dependency on telemetry to apps with meson")

> --
> Christian Ehrhardt
> Software Engineer, Ubuntu Server
> Canonical Ltd



-- 
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] build: avoid --as-needed as it causes overlinking
  2019-09-12 13:43               ` [dpdk-stable] [dpdk-dev] [PATCH v2] build: avoid --as-needed as it causes overlinking Christian Ehrhardt
@ 2019-10-12 13:02                 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2019-10-12 13:02 UTC (permalink / raw)
  To: Christian Ehrhardt
  Cc: stable, Bruce Richardson, Luca Boccassi, dev, Kevin Laatz

12/09/2019 15:43, Christian Ehrhardt:
> > On Wed, Sep 4, 2019 at 11:18 AM Bruce Richardson
> > <bruce.richardson@intel.com> wrote:
> > > > On Mon, Sep 2, 2019 at 9:09 AM Christian Ehrhardt
> > > > <christian.ehrhardt@canonical.com> wrote:
> > > > > > On Thu, 2019-08-29 at 16:34 +0100, Bruce Richardson wrote:
> > > > > > > On Thu, Aug 29, 2019 at 05:30:03PM +0200, Christian Ehrhardt wrote:
> > > > > > > > --- a/config/meson.build
> > > > > > > > +++ b/config/meson.build
> > > > > > > >  add_project_link_arguments('-Wl,--no-as-needed', language: 'c')
> > > > > > > > -dpdk_extra_ldflags += '-Wl,--no-as-needed'
> > > > > > > >
> > > > > > >
> > > > > > > This seems strange to me. What is it about linking the dpdk apps that
> > > > > > > require the argument, but makes it safe for non-builtin apps to avoid
> > > > > > > having the arg?
[...]
> > > > > Having it accepted in upstream would make it more easy to fix this in
> > > > > the soon to be released Ubuntu 19.10.
> > > > > Is there a path to consider taking this fix as-is and continue the
> > > > > debug/discussion how the removal of the second line can even cause the
> > > > > symptoms that we have seen later?
> > >
> > > I'm ok with what you propose above.
[...]
> And actually 18.11 stable would make sense as well IMHO.
> Could one who commits could add that as:
> Fixes: 57ae0ec62620 ("build: add dependency on telemetry to apps with meson")

+Cc stable@dpdk.org in the commit log

Applied, thanks
Title reduced to "avoid overlinking" because --as-needed mention looks wrong.

Please continue the investigation to remove
the other line "add_project_link_arguments()".



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CAATJJ0KUN93UctTPeP_eH-k+UmtZSjqK-NJ9RWQGrtEswq5V2A@mail.gmail.com>
     [not found] ` <20190829153003.7974-1-christian.ehrhardt@canonical.com>
     [not found]   ` <20190829153431.GA624@bricha3-MOBL.ger.corp.intel.com>
     [not found]     ` <dfa09a89e1a2cb61295659b00c315de2d77762b9.camel@debian.org>
     [not found]       ` <CAATJJ0KBVCxYpJcA8s2dkwXTDVKO3SFF+kLjaG0FJVqfcmA26g@mail.gmail.com>
     [not found]         ` <CAATJJ0JcNder5ycE8q9utunLawqq0u6Mz2tE9W5-k3dUYtwp0w@mail.gmail.com>
     [not found]           ` <20190904091805.GA1145@bricha3-MOBL.ger.corp.intel.com>
     [not found]             ` <CAATJJ0L0sAYsKs1JNW4FNkS5uZEPWqZYoNdvfjRZHHa8cMeHpQ@mail.gmail.com>
2019-09-12 13:43               ` [dpdk-stable] [dpdk-dev] [PATCH v2] build: avoid --as-needed as it causes overlinking Christian Ehrhardt
2019-10-12 13:02                 ` Thomas Monjalon

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox