From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 374A7A04A6 for ; Fri, 7 Jan 2022 11:04:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 22F1A40042; Fri, 7 Jan 2022 11:04:48 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id CB1B540042 for ; Fri, 7 Jan 2022 11:04:46 +0100 (CET) Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 88E653F17B for ; Fri, 7 Jan 2022 10:04:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1641549886; bh=gHYtZMtma9S065nWPdYH3GosdIb8Gc7lu47k4ib8ZxU=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=pWUSD/x3dheoykZjkAqE7fFgQFL09U3iB68jAJhw9oSloMXI5Wj5WR0baCjP4nyYF MEZ4zbFDURorNFSGUanlE+ap4Df/j21ozU/ofdBHKHKGuvCot5ylkwvoUyRbg09OdV BvdcY+Qw8fj3Y8JWp2VhV5M6tLjFh3S0RbtFT2zpkhTY2HJG+yCLuvAvyeoj4Lt2HR 8Jer951Huk9DafJKY2X8x4U4UrD3RkFNhbYBB/EMSaKDKRoSda/+b4+rUD2koTiX+B Mw4c32BmRG0SmrvoE/ONGgfTIsO6dLn1UVkcel1uCUnlwOT2MOoE1T/CxEh9iXdK2I 6Hqc6VfaE9WtQ== Received: by mail-qk1-f200.google.com with SMTP id x189-20020a37aec6000000b004779e432215so726247qke.15 for ; Fri, 07 Jan 2022 02:04:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gHYtZMtma9S065nWPdYH3GosdIb8Gc7lu47k4ib8ZxU=; b=Pjlg1vXYhd1KiAwzyhBzL73F/4ALhGLJu+eJERvofrO0a5KyqUDRJymD/hVa8+Unb8 IslneYxMHcRUkk0ey4TnXZFtrnPstsmJT4jzoDD6kDHdEPB5ALvyXf270/GmVB7qPeTT /YIxVYYHWK99M64iDs4wPJrVRJxwVMEcq/t2gfoJslbFqtXphZ8RLTI58iyooBnYbkm8 ReCmwy7LV7NU0VsPRPe6yd3T5nbiCe+53TOD24c93EnHlBOtpvhvSk+nA8OrBuofDi3d urCBS5ynYYrGlEzaB/+czO0fa5v39hY8uKXWDUx5CVpK8vjXej5camaLiV1X/NCbpFak GVJw== X-Gm-Message-State: AOAM532cNXH0U4NYN1dskjY8sH+vlmr8iMwJdAvLdQ0IYZsDNiEutHKT kKTqqGKXL7eJ75Ob/Ctb3gINRS6nsd4OYmz3uVW5RYvy64KfSvjNjTaavyZdz5qPMJMUP5gfMOU 01RZoC0czHPLmFuV14RH4joYEjiZGPatRzCa0//gt X-Received: by 2002:a05:620a:2407:: with SMTP id d7mr45006729qkn.114.1641549885631; Fri, 07 Jan 2022 02:04:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJxChWDrzYMGTHAQzGOAhZXkJCB69wjn33RyymolHHzJwMTC2ZI7iVylg2lWOmxj8+EGHIUhO0Lns7/esu9HI/s= X-Received: by 2002:a05:620a:2407:: with SMTP id d7mr45006718qkn.114.1641549885429; Fri, 07 Jan 2022 02:04:45 -0800 (PST) MIME-Version: 1.0 References: <20220107095002.1253288-1-christian.ehrhardt@canonical.com> In-Reply-To: From: Christian Ehrhardt Date: Fri, 7 Jan 2022 11:04:19 +0100 Message-ID: Subject: Re: [PATCH] 5-make-release-commit: fix rstheader To: David Marchand Cc: dpdk stable , Thomas Monjalon , Luca Boccassi , Xueming Li , Kevin Traynor Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Fri, Jan 7, 2022 at 11:00 AM David Marchand wrote: > > On Fri, Jan 7, 2022 at 10:50 AM wrote: > > > > From: Christian Ehrhardt > > > > The printf magic fails trying to interpret "-" as option and thereby breaking > > the top level headers. > > printf: -%: invalid option > > printf: usage: printf [-v var] format [arguments] > > That's getopt that caught the -. > You could also fix by prefixing with --: > - printf "${rchar}%.0s" $(seq 1 ${#msg}) > + printf -- "${rchar}%.0s" $(seq 1 ${#msg}) I know, but since it broke us once I wanted to make it dead-simple (also less printf magic) by just looping around printing a char once every time. > > > > Instead of relying printf expansion, fall back to the more trivial > > printf n times which works with any char. > > > > Signed-off-by: Christian Ehrhardt > > --- > > 5-make-release-commit | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/5-make-release-commit b/5-make-release-commit > > index 374154f..00acf92 100755 > > --- a/5-make-release-commit > > +++ b/5-make-release-commit > > @@ -29,7 +29,7 @@ function rstheader() > > > > echo > > echo "${msg}" > > - printf "${rchar}%.0s" $(seq 1 ${#msg}) > > + for i in $(seq 1 ${#msg}); do printf "${rchar}"; done > > # break after line plus one empty line > > echo > > echo > > Either form works for me. Thanks for the review, yeah to me either way is fine as well. If there are strong opinions we can switch to yours, otherwise keep mine as suggested. > Reviewed-by: David Marchand > > > -- > David Marchand > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd