[dpdk-stable] [PATCH] 5-make-release-commit: tolerate longer versions

[dpdk-stable] [PATCH] 5-make-release-commit: tolerate longer versions

[christian.ehrhardt]

From: Christian Ehrhardt <christian.ehrhardt@canonical.com>

Without this we have tool warnings and ugly headers like
  19.11.10 Foo
  -----------

The static underlines need to adapt to the length of the string.

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
---
 5-make-release-commit | 39 ++++++++++++++++++++-------------------
 1 file changed, 20 insertions(+), 19 deletions(-)

diff --git a/5-make-release-commit b/5-make-release-commit
index 832e8e4..374154f 100755
--- a/5-make-release-commit
+++ b/5-make-release-commit
@@ -21,41 +21,42 @@ change_version()
 	fi
 }
 
-update_release_note()
+function rstheader()
 {
-	{
+	msg=${1}
+	rchar=${2}
+	n=0;
 
 	echo
-	echo "$stable_release Release Notes"
-	echo "---------------------"
-
+	echo "${msg}"
+	printf "${rchar}%.0s" $(seq 1 ${#msg})
+	# break after line plus one empty line
 	echo
-	echo "$stable_release Fixes"
-	echo "~~~~~~~~~~~~~"
 	echo
+}
+
+
+update_release_note()
+{
+	{
+
+	rstheader "$stable_release Release Notes" "-"
+
+	rstheader "$stable_release Fixes" "~"
 
 	$GIT log --oneline v${last_release}..HEAD | cut -d ' ' -f 2-  | sort | sed 's/^/* /'
 
-        echo
-        echo "$stable_release Validation"
-        echo "~~~~~~~~~~~~~~~~~~"
-        echo
+	rstheader "$stable_release Validation" "~"
 
 	echo "$(cat $stable_release/validation)"
 
 	if [ -e $stable_release/known_issues ]; then
-		echo
-		echo "$stable_release Known Issues"
-		echo "~~~~~~~~~~~~~~~~~~~~"
-		echo
+		rstheader "$stable_release Known Issues" "~"
 		echo "$(cat $stable_release/known_issues)"
 	fi
 
 	if [ -e $stable_release/failed_list ]; then
-		echo
-		echo "$stable_release Fixes skipped and status unresolved"
-		echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"
-		echo
+		rstheader "$stable_release Fixes skipped and status unresolved" "~"
 		echo "$(cat $stable_release/failed_list)"
 	fi
 
-- 
2.32.0

Re: [dpdk-stable] [PATCH] 5-make-release-commit: tolerate longer versions

[Luca Boccassi]

On Mon, 2021-09-06 at 12:29 +0200, christian.ehrhardt@canonical.com
wrote:
> From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> 
> Without this we have tool warnings and ugly headers like
>   19.11.10 Foo
>   -----------
> 
> The static underlines need to adapt to the length of the string.
> 
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> ---
>  5-make-release-commit | 39 ++++++++++++++++++++-------------------
>  1 file changed, 20 insertions(+), 19 deletions(-)

Acked-by: Luca Boccassi <bluca@debian.org>

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-stable] [PATCH] 5-make-release-commit: tolerate longer versions

[Christian Ehrhardt]

On Mon, Sep 6, 2021 at 12:34 PM Luca Boccassi <bluca@debian.org> wrote:
>
> On Mon, 2021-09-06 at 12:29 +0200, christian.ehrhardt@canonical.com
> wrote:
> > From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> >
> > Without this we have tool warnings and ugly headers like
> >   19.11.10 Foo
> >   -----------
> >
> > The static underlines need to adapt to the length of the string.
> >
> > Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > ---
> >  5-make-release-commit | 39 ++++++++++++++++++++-------------------
> >  1 file changed, 20 insertions(+), 19 deletions(-)
>
> Acked-by: Luca Boccassi <bluca@debian.org>

Thanks - pushed

> --
> Kind regards,
> Luca Boccassi



-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd