From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17F58A04AC for ; Tue, 1 Sep 2020 14:32:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D7E551C1B7; Tue, 1 Sep 2020 14:32:55 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by dpdk.org (Postfix) with ESMTP id A8D381C1B7 for ; Tue, 1 Sep 2020 14:32:54 +0200 (CEST) Received: from mail-vs1-f70.google.com ([209.85.217.70]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kD5T4-0001pq-9k for stable@dpdk.org; Tue, 01 Sep 2020 12:32:54 +0000 Received: by mail-vs1-f70.google.com with SMTP id s201so264026vsc.2 for ; Tue, 01 Sep 2020 05:32:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w7ZVdiXgXAlUgL7jiHTEf8Lwcuzf8+cJkT2QhbZ7AX8=; b=p7e0VXIzx8TOlhRg0v7yFCockGnFZR8xEu0SidQkzKoW6kuaGke5cen51M28legqfi 5rYTaCPYhiLSFbQmxKrUvqblmqjh7ZYZFg3cIdDN+iiwnVpVSLGgKOjsVH8Im4Ic712U yDlvGeK6GHbimDqHWnqYNv/Zqx8Vb1FRf0YItf5BgZ0fxcY2TT6tUd+sziALDHtPtfuq +j/YNMBLyM3GepDLQSLK1cIyCzQbkIkqzVRUVHaCj4bs+lxH2pNmRBZXLQu/sCs4b+iI IjnpXUIOEgKVrGO6YckkHJm5Mf4rVLjJZNrabSKFxlYbaD1JGjzDdqPbJZO5GRn6q+xI 14ng== X-Gm-Message-State: AOAM531pPWBTp3poihNPxCC8PTE16kc4lfkivdpElKq29DRALOXEj8sQ tjpx4an3qz+JOy+5ClNZPdMSYet0msVsEVmRm3cqYHdt5DWsNVsmiJxAeyYQFNrtiyZ+Sk/Svaw 8h4vZLr1FofAHTxyZg1BJDATUvTZ/82W3WbinKueq X-Received: by 2002:a67:e3cc:: with SMTP id k12mr1014118vsm.173.1598963573328; Tue, 01 Sep 2020 05:32:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyP/qDrfRbe2Fo/kDMGWlqozH/qbx+JkIMc0cXtWp8fpTJBvASC8NVQyOAH34hfOv9nz+aF5epz1PsQjH67tj0= X-Received: by 2002:a67:e3cc:: with SMTP id k12mr1014096vsm.173.1598963572924; Tue, 01 Sep 2020 05:32:52 -0700 (PDT) MIME-Version: 1.0 References: <20200818181222.8462-1-bluca@debian.org> In-Reply-To: From: Christian Ehrhardt Date: Tue, 1 Sep 2020 14:32:26 +0200 Message-ID: To: Luca Boccassi Cc: stable@dpdk.org, dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [dpdk-dev] 19.11.4 patches review and test X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Tue, Sep 1, 2020 at 10:30 AM Luca Boccassi wrote: > > On Tue, 2020-08-18 at 19:12 +0100, Luca Boccassi wrote: > > Hi all, > > > > Here is a list of patches targeted for stable release 19.11.4. > > > > The planned date for the final release is August 31st. > > > > Please help with testing and validation of your use cases and report > > any issues/results with reply-all to this mail. For the final release > > the fixes and reported validations will be added to the release notes. > > > > A release candidate tarball can be found at: > > > > https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.4-rc1 > > > > These patches are located at branch 19.11 of dpdk-stable repo: > > https://dpdk.org/browse/dpdk-stable/ > > > > Thanks. > > > > Luca Boccassi > > Microsoft's regression tests are still running, delaying until Thursday > the 3rd. Apologies for any inconvenience. Due to report on OVS failing to build I happened to find that 19.11.4 has massively changed linking. => https://paste.ubuntu.com/p/znCRR4gpjP/ This was meant to be helpful for sure and I assume is around: 48f7fd27f6 build/pkg-config: prevent overlinking 2d1535d592 build/pkg-config: improve static linking flags 9fb13a12c1 build/pkg-config: output drivers first for static build 59b108d824 build/pkg-config: move pkg-config file creation aea915e944 devtools: test static linkage with pkg-config But overlinking has effectively become underlinking now https://launchpadlibrarian.net/495845224/buildlog_ubuntu-groovy-amd64.openvswitch_2.13.1-0ubuntu2~ppa1_BUILDING.txt.gz /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux-gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o): in function `rte_eth_from_rings': (.text+0x91c): undefined reference to `rte_vdev_init' /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux-gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o): in function `vdrvinitfn_pmd_ring_drv': (.text.startup+0x28): undefined reference to `rte_vdev_register' collect2: error: ld returned 1 exit status Also as you can see in the pastebin above, CFlags and Libs massively shrunk and likely too much so. Given that this should be a stable release I'd ask to back out those changes so that a test build creates the same .pc file as before - would that make sense? > -- > Kind regards, > Luca Boccassi -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd