From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74C9AA0C4D for ; Mon, 6 Sep 2021 10:20:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3FEDB40C35; Mon, 6 Sep 2021 10:20:29 +0200 (CEST) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id 2062C40C35 for ; Mon, 6 Sep 2021 10:20:28 +0200 (CEST) Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id DEA413F31E for ; Mon, 6 Sep 2021 08:20:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1630916427; bh=s4mecJ8M8EMoY7IkPNbWNaTvgFkZTSb3fZqmSah9+Mw=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=qMPIbzhbvNe8NbTLN1eWb6T0fZvcMhW3RtJwuecI+egAdYnkA0f/ko7tv+nZMuYGp OL7WuN8bjLs3nZa94mzVMcAhIR6rqiYFtIaVeYz/kLBfzlkQhrZ62sUW1OrnHMjC23 lY855RxtWqoO2GH5B3/4dKdDqDnVOJmjk08glrukchGFwL6NNoKKb+NG8gnCzfmYZ8 1o/6yULuAxTPrPCkde9/VLLE+Qbt8qdnv1/NavEBT4GDahFBbngMAZJ9YLHRIa8jFI 1Np45qIu2tJatuhKQ014mgnoCfW5tvH2Fzt7HIbAXUlqLgo3jOd4DvQn2jLsx0mPYG Epn6UhIJNwn3A== Received: by mail-qv1-f70.google.com with SMTP id l3-20020a056214104300b00366988901acso10675462qvr.2 for ; Mon, 06 Sep 2021 01:20:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s4mecJ8M8EMoY7IkPNbWNaTvgFkZTSb3fZqmSah9+Mw=; b=g+u9/U3zgxqlkGTIcd45e9vDmIKEN2zgqWuy4JaNf0FDypAISEuS5BMs3ZorwVFmUB qQ5QNF2SOPB9pC8IyRo6EwD6u33XI2hmxrBTTIHq7DgMBgARylSyb0+1H3+0rOI1bUwl 0g8toUUtNGye0AryHH4g4dDA7uk9eP2tdbYJNGj0AVmOYnlw4HF4gewQ1gSckqkVXfb1 v3kAd8TP4pw0dUjDZWRCxowSKNWny1lUJKzOI5WC9b5Zje76+SJXTvj1B2GjLYAIBNj7 mndvlO+c60H9ex5uXcz7u0OENOYoEAtb7Aek87DjWdbF646sSepxUcWnpaMFANQtXSLB Yzvg== X-Gm-Message-State: AOAM532P315gGEXHOjkEqTaGH1C5h8jKU25FKFPgi0tvOZaFaIUf9A9V TuL7s9e/YeTIUtk6AC87U/eFF/8NlEHdhBjkFQQTnTA9ej0kzN9wkO6sDfXMvFc7zzrhJIT5bQk lFjRR2bJEbUktUq5IOsgEUiqxcP6RpfMRdPhymQpq X-Received: by 2002:a37:2788:: with SMTP id n130mr9786498qkn.143.1630916426688; Mon, 06 Sep 2021 01:20:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJysmEOZTqKkfv1LzcNcDM73B+ZMWS9iCjTHXABKBHvsN2Tcx2v3VHtzyjMYTdGXQWzcN3TdwcVirLGmaDk/EQE= X-Received: by 2002:a37:2788:: with SMTP id n130mr9786483qkn.143.1630916426476; Mon, 06 Sep 2021 01:20:26 -0700 (PDT) MIME-Version: 1.0 References: <20210906073152.552244-1-christian.ehrhardt@canonical.com> In-Reply-To: <20210906073152.552244-1-christian.ehrhardt@canonical.com> From: Christian Ehrhardt Date: Mon, 6 Sep 2021 10:20:00 +0200 Message-ID: To: dpdk stable Cc: Yury Kylulin , Ashish Paul Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [19.11 PATCH] net/i40e: support 25G AOC/ACC cables X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Mon, Sep 6, 2021 at 9:32 AM wrote: > > From: Yury Kylulin > > [ upstream commit b1daa3461429e7674206a714c17adca65e9b44b4 ] FYI - this commit is in 21.05 but was initially not targettet at stable@dpdk. In some tests (the linked bug) it was found that it resolves issues with newer hardware and therefore I did the backport (no changes) and submitted it here for discussion. It might be too late for 20.11.3/19.11.10 which are supposed to release today, but we could queue them right away. I'm mostly interested in feedback from the Authors if they think this could be an issue (e.g. due to unidentified dependencies). > Enable additional PHY types (25G-AOC and 25G-ACC) for set PHY config > command. > > Ubuntu bug: https://bugs.launchpad.net/ubuntu/+source/dpdk/+bug/1940957 > Cc: stable@dpdk.org > > Signed-off-by: Yury Kylulin > Tested-by: Ashish Paul > Signed-off-by: Christian Ehrhardt > --- > drivers/net/i40e/i40e_ethdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c > index 508f90595f..0c896ea915 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -2264,7 +2264,8 @@ i40e_phy_conf_link(struct i40e_hw *hw, > phy_conf.phy_type = is_up ? cpu_to_le32(phy_type_mask) : 0; > phy_conf.phy_type_ext = is_up ? (I40E_AQ_PHY_TYPE_EXT_25G_KR | > I40E_AQ_PHY_TYPE_EXT_25G_CR | I40E_AQ_PHY_TYPE_EXT_25G_SR | > - I40E_AQ_PHY_TYPE_EXT_25G_LR) : 0; > + I40E_AQ_PHY_TYPE_EXT_25G_LR | I40E_AQ_PHY_TYPE_EXT_25G_AOC | > + I40E_AQ_PHY_TYPE_EXT_25G_ACC) : 0; > phy_conf.fec_config = phy_ab.fec_cfg_curr_mod_ext_info; > phy_conf.eee_capability = phy_ab.eee_capability; > phy_conf.eeer = phy_ab.eeer_val; > -- > 2.32.0 > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd