From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BA42A0C4D for ; Mon, 6 Sep 2021 13:02:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7EE92410E6; Mon, 6 Sep 2021 13:02:05 +0200 (CEST) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 56FD0410E6 for ; Mon, 6 Sep 2021 13:02:04 +0200 (CEST) Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 2442E3F32C for ; Mon, 6 Sep 2021 11:02:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1630926124; bh=J/Ttv2RQSOvpoS6Y9VA2dKXRxdT/6Tk2F1bEgJBA4Xk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=TxiO5e685hV14p6dUwrjDegF/iKp7y1yeznhFPtre6qn9bL4g82SudWWrBGnVsDY3 Qc+oQYhlOSpOh4GxikCPIQNa/heUJvissHitDjbVOMra9a9a+ThG+7erhqe6hz1L+K y2kyHUjoV5nFZkgJA+kV/dTrFKFg50typ6T0k+RLoKWPNokzcGT7g6UgwC0ePoVOlM AaOuoHRgEHH5bLjfceMqu4arVk8VDSWQaxX//niJn16wgrhPGM9pi+D0Cq4otypvZp 28QAsPRr/PuWfYi4o46Mxmu35gUkS4MT6Jd5dJnPC0P7UxFIEcB/trlmmkan5Lzhi+ 9fd1vZCf6blXw== Received: by mail-qt1-f199.google.com with SMTP id c22-20020ac80096000000b0029f6809300eso9039715qtg.6 for ; Mon, 06 Sep 2021 04:02:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J/Ttv2RQSOvpoS6Y9VA2dKXRxdT/6Tk2F1bEgJBA4Xk=; b=A960/AIuFmsf/YSCX1PIXU+VvOa8w2slV9Ft8ukES1uX+goA8lcPhhaVbPX6g+tznH Ivpf5aQ6KhkN/hV1qGxtq52E8t6dOdsDJEpbx3+oDQO+CG8f6Q0oGymQY/GKIVAjCdcu KDvcMZrl/0bubKS+JiM2S6ifLUTptlKtNw1xakdpfSteclemx1zxwSmE1KRLT/bgZZ0K P82zWNBtcU9ZPNsMPD1Os6Y2wsXYKMTTXzsfxsFZiJhs7RXprhPHoJLFqUARs+9t3K5H sPvJLVi9vraU1w4raMNzE6MMNWFRQ2tpu5rwFIgOZLWfxfY1x+HbQV5svJQzmYLfuBQ+ EoMw== X-Gm-Message-State: AOAM533vA9Dg3lq6/T4uA9GYsD0LuAaBAz6SxxmWdpoyPUEddtNkuu2u fut17sne6luen6v+HWVdm4hejL59NFOad1k3LFSkez7ebUyA8cwRkE0n6RMv8ij/0VgrjmjKISr LBYDwfZSxzLX+pnpblMzZGCgcqjdzmDgWbu+IJv2w X-Received: by 2002:a05:620a:2097:: with SMTP id e23mr10073981qka.455.1630926123001; Mon, 06 Sep 2021 04:02:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJygZWftvXPgRp3eVQ1ZA1fAzwn8CL+1ej6eBU/TO6TRYwVcTx/T+nwPo1vhOG4xEoP/V+bEgzHhf3reNi9QuQE= X-Received: by 2002:a05:620a:2097:: with SMTP id e23mr10073962qka.455.1630926122778; Mon, 06 Sep 2021 04:02:02 -0700 (PDT) MIME-Version: 1.0 References: <20210906073152.552244-1-christian.ehrhardt@canonical.com> In-Reply-To: From: Christian Ehrhardt Date: Mon, 6 Sep 2021 13:01:36 +0200 Message-ID: To: dpdk stable Cc: Yury Kylulin , Ashish Paul Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [19.11 PATCH] net/i40e: support 25G AOC/ACC cables X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Mon, Sep 6, 2021 at 10:20 AM Christian Ehrhardt wrote: > > On Mon, Sep 6, 2021 at 9:32 AM wrote: > > > > From: Yury Kylulin > > > > [ upstream commit b1daa3461429e7674206a714c17adca65e9b44b4 ] FYI - I got an ack by Tmonjalo on IRC and enqueued this for 19.11.11 (not 19.11.10 that has released today). > FYI - this commit is in 21.05 but was initially not targettet at stable@dpdk. > In some tests (the linked bug) it was found that it resolves issues with newer > hardware and therefore I did the backport (no changes) and submitted it here > for discussion. > > It might be too late for 20.11.3/19.11.10 which are supposed to > release today, but we could queue them right away. > I'm mostly interested in feedback from the Authors if they think this > could be an issue (e.g. due to unidentified dependencies). > > > Enable additional PHY types (25G-AOC and 25G-ACC) for set PHY config > > command. > > > > Ubuntu bug: https://bugs.launchpad.net/ubuntu/+source/dpdk/+bug/1940957 > > Cc: stable@dpdk.org > > > > Signed-off-by: Yury Kylulin > > Tested-by: Ashish Paul > > Signed-off-by: Christian Ehrhardt > > --- > > drivers/net/i40e/i40e_ethdev.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c > > index 508f90595f..0c896ea915 100644 > > --- a/drivers/net/i40e/i40e_ethdev.c > > +++ b/drivers/net/i40e/i40e_ethdev.c > > @@ -2264,7 +2264,8 @@ i40e_phy_conf_link(struct i40e_hw *hw, > > phy_conf.phy_type = is_up ? cpu_to_le32(phy_type_mask) : 0; > > phy_conf.phy_type_ext = is_up ? (I40E_AQ_PHY_TYPE_EXT_25G_KR | > > I40E_AQ_PHY_TYPE_EXT_25G_CR | I40E_AQ_PHY_TYPE_EXT_25G_SR | > > - I40E_AQ_PHY_TYPE_EXT_25G_LR) : 0; > > + I40E_AQ_PHY_TYPE_EXT_25G_LR | I40E_AQ_PHY_TYPE_EXT_25G_AOC | > > + I40E_AQ_PHY_TYPE_EXT_25G_ACC) : 0; > > phy_conf.fec_config = phy_ab.fec_cfg_curr_mod_ext_info; > > phy_conf.eee_capability = phy_ab.eee_capability; > > phy_conf.eeer = phy_ab.eeer_val; > > -- > > 2.32.0 > > > > > -- > Christian Ehrhardt > Staff Engineer, Ubuntu Server > Canonical Ltd -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd