Re: [PATCH 19.11] test/crypto: fix unnecessary stats retrieval

[Christian Ehrhardt <christian.ehrhardt@canonical.com>]

On Wed, Dec 1, 2021 at 12:03 PM Ciara Power <ciara.power@intel.com> wrote:
>
> [ upstream commit c0daf3bd4b4e36375f8c338092975d61ec03a98f ]
>

Thanks, applied

> The device stats are retrieved in the testcase teardown function,
> but are not being used afterwards. Remove this unnecessary call.
>
> Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests")
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> Acked-by: Anoob Joseph <anoobj@marvell.com>
> ---
>  app/test/test_cryptodev.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
> index 189f7be4a..c1fee1686 100644
> --- a/app/test/test_cryptodev.c
> +++ b/app/test/test_cryptodev.c
> @@ -581,7 +581,6 @@ ut_teardown(void)
>  {
>         struct crypto_testsuite_params *ts_params = &testsuite_params;
>         struct crypto_unittest_params *ut_params = &unittest_params;
> -       struct rte_cryptodev_stats stats;
>
>         /* free crypto session structure */
>  #ifdef RTE_LIBRTE_SECURITY
> @@ -628,8 +627,6 @@ ut_teardown(void)
>                 RTE_LOG(DEBUG, USER1, "CRYPTO_MBUFPOOL count %u\n",
>                         rte_mempool_avail_count(ts_params->mbuf_pool));
>
> -       rte_cryptodev_stats_get(ts_params->valid_devs[0], &stats);
> -
>         /* Stop the device */
>         rte_cryptodev_stop(ts_params->valid_devs[0]);
>  }
> --
> 2.25.1
>


-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd