From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D0BAA0C47 for ; Wed, 1 Dec 2021 16:39:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9425240140; Wed, 1 Dec 2021 16:39:06 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 3530140140 for ; Wed, 1 Dec 2021 16:39:05 +0100 (CET) Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 1576C3F1B8 for ; Wed, 1 Dec 2021 15:39:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638373145; bh=TXAoDlXcNJa1bf7UIFkljdyDsbAe8nooq8wK/nzX/KY=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=qTs/C1jJtMoRonGi42rGK8uMKb9ZwJRmtww3c6gqW1JZrZkEFH6qNN6bZF9VpqyJI T5vMtqsSej0nx1EA6j4YxBhX/aeit9TTD6If2njwXXjSHcWJgCTmPyBh5EwKbrVpRI N2J6krVg9cF4sLfNiripjdmw6x0xvjdD6VY7q8e3Q4x1H5+mUcdyAu/JnqpEHoRmsy cjGLFmC8BZ7noLo/wxaUOcfJKRQUeGy9fqRxlUdlV7CR4HLdMCpzEBtzpsnV1/Hzvl QrtLh7u0zixD79SPbGZH2QdIh/4AFHo5TXP8X5S3si9+3QcjOrO1PkOBnkVYPwlu7Z 3c3o70bQLiJOg== Received: by mail-qv1-f72.google.com with SMTP id fn12-20020ad45d6c000000b003bd9c921c0eso34617263qvb.21 for ; Wed, 01 Dec 2021 07:39:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TXAoDlXcNJa1bf7UIFkljdyDsbAe8nooq8wK/nzX/KY=; b=rNAFA0BjBRB2tctIQP10wOxg/kfNEV1ubkm2khAey1cjuwD7U71Y5HdRsXkB3UEyNl /pQDovSD7I8ZsVwBGpCZEPCpCZx5d3WHKFYsmng1wSnq1pzyYU/Vp1MrWcxPxWtlQl5m ah6qEgXFiYsJ/4wdTDGTGgxpl5T1nN9lD0vXSTxfJMy7H7KG+4TUyOKWZFnLvVZJtk4o SHQJHi9G/tn3FOZWDIYv6sxrkguUmsmzwFf3u/Q+ETh9O7k/qJyXEiJs3ttQWgUSayKk zIDxi03blePp/zBUP/KxaFXi6kKRYQMYA7Jy+6RLkOGlLkgb5dJycMl8m+GF9u+zgY1z Z4kA== X-Gm-Message-State: AOAM532+qBUVhrIDA3SK6qr/KMk8XaKW3ScNZMTfJDqd7Ytg265W8sG8 FCWnlQAoW0rkrgBGH8bJc2nkra5t3sdk+yF3GNTAh1+r99GO07PQah/Rueaof4wx54JcrijisTD NG/0Q1BES7ebJoJRKGUt8ifCBtNjSyI+215LiR3rj X-Received: by 2002:ac8:5542:: with SMTP id o2mr7612976qtr.670.1638373144170; Wed, 01 Dec 2021 07:39:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJwJwd3S4jTCYtwPAjqRKpd6HO3W+0i5HbboGnwROTrv6CxL5rm4sRHvvzk4aC5trfMUtEsLKTLVHjqisnWhsDY= X-Received: by 2002:ac8:5542:: with SMTP id o2mr7612964qtr.670.1638373143992; Wed, 01 Dec 2021 07:39:03 -0800 (PST) MIME-Version: 1.0 References: <20211201110312.2263792-1-ciara.power@intel.com> In-Reply-To: <20211201110312.2263792-1-ciara.power@intel.com> From: Christian Ehrhardt Date: Wed, 1 Dec 2021 16:38:38 +0100 Message-ID: Subject: Re: [PATCH 19.11] test/crypto: fix unnecessary stats retrieval To: Ciara Power Cc: stable@dpdk.org, roy.fan.zhang@intel.com, Anoob Joseph , Declan Doherty Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Dec 1, 2021 at 12:03 PM Ciara Power wrote: > > [ upstream commit c0daf3bd4b4e36375f8c338092975d61ec03a98f ] > Thanks, applied > The device stats are retrieved in the testcase teardown function, > but are not being used afterwards. Remove this unnecessary call. > > Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests") > > Signed-off-by: Ciara Power > Acked-by: Anoob Joseph > --- > app/test/test_cryptodev.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > index 189f7be4a..c1fee1686 100644 > --- a/app/test/test_cryptodev.c > +++ b/app/test/test_cryptodev.c > @@ -581,7 +581,6 @@ ut_teardown(void) > { > struct crypto_testsuite_params *ts_params = &testsuite_params; > struct crypto_unittest_params *ut_params = &unittest_params; > - struct rte_cryptodev_stats stats; > > /* free crypto session structure */ > #ifdef RTE_LIBRTE_SECURITY > @@ -628,8 +627,6 @@ ut_teardown(void) > RTE_LOG(DEBUG, USER1, "CRYPTO_MBUFPOOL count %u\n", > rte_mempool_avail_count(ts_params->mbuf_pool)); > > - rte_cryptodev_stats_get(ts_params->valid_devs[0], &stats); > - > /* Stop the device */ > rte_cryptodev_stop(ts_params->valid_devs[0]); > } > -- > 2.25.1 > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd