From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0CA8A050B for ; Wed, 30 Mar 2022 14:52:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 88A184013F; Wed, 30 Mar 2022 14:52:19 +0200 (CEST) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id 0ACE34013F for ; Wed, 30 Mar 2022 14:52:17 +0200 (CEST) Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 31E753F329 for ; Wed, 30 Mar 2022 12:52:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1648644737; bh=GVSkYvfaOoX7AUJAKWxeRyNG9/7RF5RU+32BlP12i0U=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=daA5YhKI8O5mhdcWaHb3AMe8lP3ArV/qH0q1SRkYw+47OBC38AgcC4KwxBFz6Ynzi EdlZ+G8+V42q0aXgxGJNyE9xpQL+ol9RAL5lbypOwt8jS3d3idfHMwXMp72AyFJfG+ 7x0PBjVV/UFh79wxtYFi8wdQXCmLr9rRe/WhFA36yd6la0V7KsvgwvMgodZUYpdWj8 X2YLPfq9CE9O1Pin57n81durUphqFW9gbxS4Zmln52bE56nMbmrI/wN8iWRCnyv/Ff NQR39+3Vj72iowFnFRL2xOqhrrY/vuYgrcl5grtVOmSIg4KQ9Xc5gWWnVy4f3ebGdG 6Otkb/WQt2RqA== Received: by mail-qv1-f69.google.com with SMTP id 94-20020a0c8167000000b004411702e935so15971466qvc.7 for ; Wed, 30 Mar 2022 05:52:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=GVSkYvfaOoX7AUJAKWxeRyNG9/7RF5RU+32BlP12i0U=; b=7Jao9lWIlzedhx/J2rafdz9rA0LwwITp69SZnrK9lL8EaMGMEq8g5lIC/6VVnA5VKJ 54Uv984gzbXHWIDbzoGA42mhi6I/8Y2/TngIULrLkVQBh0EK78nUrbQbTHwnS/45i3fj MmyojHE431pRL1IRbg7H+/qz9GM05akiX0AHgvZXC8SROOOmR1NnnT6jpMR2LtdLTwcc He5vzPF6C1aFAPtPpebJLCRoqWYc/oiMmbQxH+18JaehKQsDG/mribasJMZlnX940RuC rn1Smk7CtAS1ysZfhc/q+qQN6BLJG6goEE5vnTWFUeQV7UOAxUlcaxDtY35EckV7Hfup F2gw== X-Gm-Message-State: AOAM531EAojRpSFfT3L7IyReCmwuSxRd55n7A7nmmnXvYQ8JtSXfCHsn n9JjX9/xfrPQ5zXcLL1/ep6tEkhz6szc3WmlYRkLHJ6GqT+ra5a4Xqg5ojfkIJz95r+YZgrE30V cCY6Sl4MvHfv+HQDsiyvHPogVnmMq4nbvys85OFZY X-Received: by 2002:a05:620a:f03:b0:67e:1e38:4a0 with SMTP id v3-20020a05620a0f0300b0067e1e3804a0mr24130085qkl.86.1648644735892; Wed, 30 Mar 2022 05:52:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJysEadIp1EbU3jchcZFKVEZQwy/Bm6PV6aVtazmR1cBe6AukCxW8idpAfCqS/eZXxmSPEFlUZkYK74ZijxwJDg= X-Received: by 2002:a05:620a:f03:b0:67e:1e38:4a0 with SMTP id v3-20020a05620a0f0300b0067e1e3804a0mr24130071qkl.86.1648644735645; Wed, 30 Mar 2022 05:52:15 -0700 (PDT) MIME-Version: 1.0 References: <20220330121225.322838-1-luca.boccassi@gmail.com> In-Reply-To: <20220330121225.322838-1-luca.boccassi@gmail.com> From: Christian Ehrhardt Date: Wed, 30 Mar 2022 14:51:49 +0200 Message-ID: Subject: Re: [PATCH 19.11 20.11] pmdinfogen: fix compilation with Clang 3.4.2 on CentOS 7 To: luca.boccassi@gmail.com Cc: stable@dpdk.org, Luca Boccassi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Mar 30, 2022 at 2:13 PM wrote: > > From: Luca Boccassi > > $ meson --werror --buildtype=3Ddebugoptimized build && ninja-build -C bui= ld > [..] > [5/2516] Compiling C object buildtools/pmdinfogen/pmdinfogen.p/pmdinfogen= .c.o > FAILED: buildtools/pmdinfogen/pmdinfogen.p/pmdinfogen.c.o > clang -Ibuildtools/pmdinfogen/pmdinfogen.p -Ibuildtools/pmdinfogen -I../.= ./root/dpdk/buildtools/pmdinfogen -I. -I../../root/dpdk -Iconfig -I../../ro= ot/dpdk/config -Ilib/librte_eal/include -I../../root/dpdk/lib/librte_eal/in= clude -Ilib/librte_eal/linux/include -I../../root/dpdk/lib/librte_eal/linux= /include -Ilib/librte_eal/x86/include -I../../root/dpdk/lib/librte_eal/x86/= include -Ilib/librte_pci -I../../root/dpdk/lib/librte_pci -Xclang -fcolor-d= iagnostics -pipe -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Wextra -Werr= or -O2 -g -MD -MQ buildtools/pmdinfogen/pmdinfogen.p/pmdinfogen.c.o -MF bui= ldtools/pmdinfogen/pmdinfogen.p/pmdinfogen.c.o.d -o buildtools/pmdinfogen/p= mdinfogen.p/pmdinfogen.c.o -c ../../root/dpdk/buildtools/pmdinfogen/pmdinfo= gen.c > ../../root/dpdk/buildtools/pmdinfogen/pmdinfogen.c:431:27: error: missing= field 'hdr' initializer [-Werror,-Wmissing-field-initializers] > struct elf_info info =3D {0}; > ^ > 1 error generated. > [..] The change itself LGTM and works on my end for 19.11 (applied it). Maybe adding a fixes: 0decf84217f1ef8af132948a0661559a96961495 ? With or without it is fine, Reviewed-by: Christian Ehrhardt > Use structured initialization > > Bugzilla ID: 984 > > Signed-off-by: Luca Boccassi > --- > buildtools/pmdinfogen/pmdinfogen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/buildtools/pmdinfogen/pmdinfogen.c b/buildtools/pmdinfogen/p= mdinfogen.c > index a68d1ea999..534ed9f3c8 100644 > --- a/buildtools/pmdinfogen/pmdinfogen.c > +++ b/buildtools/pmdinfogen/pmdinfogen.c > @@ -428,7 +428,7 @@ static void output_pmd_info_string(struct elf_info *i= nfo, char *outfile) > > int main(int argc, char **argv) > { > - struct elf_info info =3D {0}; > + struct elf_info info =3D {}; > int rc =3D 1; > > if (argc < 3) { > -- > 2.34.1 > --=20 Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd