From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C433BA0524 for ; Mon, 31 May 2021 11:22:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8BE1140040; Mon, 31 May 2021 11:22:10 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id 2D44840040 for ; Mon, 31 May 2021 11:22:10 +0200 (CEST) Received: from mail-qk1-f200.google.com ([209.85.222.200]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lne7d-0007Co-Lj for stable@dpdk.org; Mon, 31 May 2021 09:22:09 +0000 Received: by mail-qk1-f200.google.com with SMTP id n2-20020a37a4020000b02902e9aef597f7so9019467qke.21 for ; Mon, 31 May 2021 02:22:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rIqH8ASO0/tNY7Coeo73QqfOtCDeaP/jH+2NqKndGPs=; b=JeR1lbow/Eveyd5ta9u/N5vv4jfBJx8qzSPkJENQgfP8zV9MoE/J7ILWYOtRpCh8D/ vf2zy7086o0UX4zHKsSHUPxODFH0YRMi2rDE7hgIll7eqyy5SHg8B/Zm+khL212R8eyy mH+ipFq5gaNxKFkoni/0dl1iWaWSybctOHZlbm5hUXertdwR6Kd7XFu+iylLpq1x6kdO fpgtraCVO2wvvAk57W3+NCyrIRWcE7pKcJZ2CIr0byO6qtlXBQEtDoZlOh0FnB22VUF3 ukUNEvoSUVil0CmBFslzucHs+TDMGN2cfK+on/yaOxsHNb6WQV97feuVP/my4H862cNj YT7w== X-Gm-Message-State: AOAM531eKvhgdUwqtQwS9vBmuDUNH2fSGhzqnlMLwJcwOMHaiBmNENOl yj10AgpU+f1fPODUlftM655z4EcvVsljxa8BHbs4fcayYWGOjpGrlw3uGEiEPfx5POXcb2VoTa4 J6772MVN93VjUhrTJbB3WGpS/HxG8f448E00l8uC4 X-Received: by 2002:ae9:c016:: with SMTP id u22mr15656689qkk.114.1622452928735; Mon, 31 May 2021 02:22:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzSAVqZDXPtWdCby4Bi8F2PAy4yqDQ8gumbUDzjuJTYInkEBGlIHKj0pGg9OWGdKXBxVgZKhM87wx6rA/Ghcig= X-Received: by 2002:ae9:c016:: with SMTP id u22mr15656679qkk.114.1622452928494; Mon, 31 May 2021 02:22:08 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Christian Ehrhardt Date: Mon, 31 May 2021 11:21:42 +0200 Message-ID: To: "Yu, DapengX" , Thomas Monjalon Cc: "Yu, PingX" , dpdk stable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] It there plan to queue this patch to stable release 19.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, May 26, 2021 at 5:13 AM Yu, DapengX wrote: > > Hi Christian, > Hi Dapeng > This patch: http://mails.dpdk.org/archives/stable/2021-March/029204.html This patch actually was never merged in the main branch On main we have: commit f93949c3afc39b0f610e0661f7baa21060ada13a Author: Haiyue Wang net/ice: fix memory leak on dev closed This one also refers to bd513ece3c40 for a fix and was in 19.11 already. Then quite similar to what you referred to, but a more generic (all drivers) fix on the main branch commit 30410493759f4bae3f65497737661e27b93c2d0e Author: Thomas Monjalon drivers/net: check process type in close operation See => https://github.com/DPDK/dpdk/commit/30410493759f4bae3f65497737661e27b93c2d0e This one was in 20.11 but not targeted for stable@dpdk.org The patch almost applies but since the change is mostly the same to all drivers it seems backportable. Maybe if you could sync with Thomas if this (general) solution is applicable and prepare the backport we can add it. It is close as I wanted to call for RC1 already, but if done soon it should be fine. I'll hold back 19.11.9-RC1 another day to give this a chance to be clarified until tomorrow. @Dapeng please talk to Thomas and consider providing a 19.11.9 backport of the fix that made it into the main branch. @Thomas Monjalon was there a specific reason/prereq which made you not targeting stable@ with the fix? > Is prepared for ice NIC PMD on 19.11.7, but not be merged. > > Do you have plan to merge this patch in 19.11.9? > > > > Without this patch, if there are primary and secondary process use ice PMD at the same time, the processes may crash. > > > > Best regards, > > Dapeng Yu > > > > Note: the patch details: > > ============================================================ > > From: Dapeng Yu > > > > The secondary processes are not allowed to release shared resources. > > Only process-private resources should be freed in a secondary process. > > So the close operation is just forbidden in a secondary process. > > > > Fixes: bd513ece3c40 ("net/ice: release port upon close") > > Cc: stable at dpdk.org > > > > Signed-off-by: Dapeng Yu > > --- > > PATCH 19.11.7-rc1 > > > > drivers/net/ice/ice_ethdev.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c > > index c2e659303c..2552bf228c 100644 > > --- a/drivers/net/ice/ice_ethdev.c > > +++ b/drivers/net/ice/ice_ethdev.c > > @@ -2394,6 +2394,9 @@ ice_dev_close(struct rte_eth_dev *dev) > > struct ice_adapter *ad = > > ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private); > > > > + if (rte_eal_process_type() != RTE_PROC_PRIMARY) > > + return; > > + > > /* Since stop will make link down, then the link event will be > > * triggered, disable the irq firstly to avoid the port_infoe etc > > * resources deallocation causing the interrupt service thread > > -- > > 2.27.0 > > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd