From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66F68A0524 for ; Fri, 4 Jun 2021 07:07:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3994E4003C; Fri, 4 Jun 2021 07:07:50 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id 354F54003C for ; Fri, 4 Jun 2021 07:07:49 +0200 (CEST) Received: from mail-qt1-f200.google.com ([209.85.160.200]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lp23g-0006RG-Uv for stable@dpdk.org; Fri, 04 Jun 2021 05:07:49 +0000 Received: by mail-qt1-f200.google.com with SMTP id j19-20020ac85f930000b029021f033edf60so4489988qta.10 for ; Thu, 03 Jun 2021 22:07:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=18PzxQzwPrsNjdwrWMr5y0gNEj0OYV7604U2E+vxBS8=; b=EWQwfyA5FMIj+D4Npvg6UchwplSHr6E3L88Vz3Lg6CSSLy/B5dLMytCIe5NzDX1bL5 Ir3Wmd+j+pQNPKiuqT2hhrlLQLS1P/ZqdGZq414tFa9Elr/smaKjqKR94AHDMClC6qqu xEKRfLd7leHiNvxLhdpC0w+dSw1hUZLYiKAEpVYFRdnYkGd/i5JYK76bUg4RLGVBSImF wCgIW6eeskznoHR17hT2Ev5la4mGxeXDiQaFGMaQlDTNt8mwobYOEzNkqkqb5aEIT8Y9 7R7uVBrlUoxPjw2l6NsRtD24C2w1vDxf8XsMowNUEMrk1N6e80OIHj3dUWw6kt1z10iZ 57qw== X-Gm-Message-State: AOAM531b2dLMR5HhJeCtdIXKPCTj+1NHqjkkg/FGv7yBqV1Ml9VVuuYC SOdT17eIOql698VNwdgwqegumaA8qcEzEEzKPdyyDRvwCGUGJVWUZGWTB4iSeD6d6BG/vMKriMl 4BdJj7RWoRFtNJJmy2H4NPsXhe1hde1aqhMwHqphV X-Received: by 2002:a05:620a:1667:: with SMTP id d7mr2719045qko.462.1622783268046; Thu, 03 Jun 2021 22:07:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyi7KRsjulgXHiMrmeegEGLSjUR/SqbC8nw/tti9FVTiKwm0qSwLeCAs6t2Or+bCSVf78opxkE1NfJgvRS3hbo= X-Received: by 2002:a05:620a:1667:: with SMTP id d7mr2719037qko.462.1622783267819; Thu, 03 Jun 2021 22:07:47 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Christian Ehrhardt Date: Fri, 4 Jun 2021 07:07:22 +0200 Message-ID: To: "Jiawei(Jonny) Wang" Cc: dpdk stable , Ori Kam Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] " app/testpmd: fix NVGRE encap configuration" incompatible with 19.11.x X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, Jun 3, 2021 at 4:54 PM Jiawei(Jonny) Wang wrote: > > Hello Christian, > > I applied this patch on the 19.11.9-rc1, but not found this issue during compilation. > > Could you send me your code branch then I can try on my side? Hi, For me it fails when applied on top of the 19.11.x WIP branch. You can use that from https://github.com/cpaelzer/dpdk-stable-queue/commits/19.11 But as I said it only fails in some releases/configurations. That is why I have linked the failing error logs. For example on my Ubuntu 20.04 it builds just fine. > Code base: > commit 15d8f64d18a891a70d664d18eb918eee0705993e > Author: Christian Ehrhardt > Date: Wed Jun 2 16:33:26 2021 +0200 > > version: 19.11.9-rc1 > > Signed-off-by: Christian Ehrhardt > > > #make O=x86_64-default-linux-gcc T=x86_64-native-linux-gcc config > #sed -ri 's,(RTE_MACHINE=).*,\1default,' x86_64-default-linux-gcc/.config > #sed -ri 's,(RTE_APP_TEST=).*,\1n,' x86_64-default-linux-gcc/.config > #sed -ri 's,(RTE_BUILD_SHARED_LIB=).*,\1y,' x86_64-default-linux-gcc/.config > #sed -ri 's,(RTE_NEXT_ABI=).*,\1n,' x86_64-default-linux-gcc/.config > #sed -ri 's,(LIBRTE_VHOST=).*,\1y,' x86_64-default-linux-gcc/.config > #sed -ri 's,(LIBRTE_VHOST=).*,\1y,' x86_64-default-linux-gcc/.config > #sed -ri 's,(RTE_KNI_KMOD=).*,\1y,' x86_64-default-linux-gcc/.config > #sed -ri 's,(RTE_EAL_IGB_UIO=).*,\1y,' x86_64-default-linux-gcc/.config > # > #make O=x86_64-default-linux-gcc -j3 EXTRA_CFLAGS=-Werror Yeah as I said it seems to only affect some releases/configs - I hope the logs help to find what is different between good/bad cases. > ...... > > INSTALL-APP dpdk-test-crypto-perf > INSTALL-MAP dpdk-test-crypto-perf.map > CC test_perf_queue.o > CC test_perf_atq.o > CC test_pipeline_common.o > CC test_pipeline_queue.o > CC test_pipeline_atq.o > LD dpdk-test-eventdev > INSTALL-APP dpdk-test-eventdev > INSTALL-MAP dpdk-test-eventdev.map > Build complete [x86_64-default-linuxapp-gcc] > > Thanks. > B.R. > > Jonny > > > > -----Original Message----- > > From: Christian Ehrhardt > > Sent: Wednesday, June 2, 2021 9:25 PM > > To: Jiawei(Jonny) Wang > > Cc: dpdk stable ; Ori Kam > > Subject: " app/testpmd: fix NVGRE encap configuration" incompatible with > > 19.11.x > > > > Hi, > > this change was targeted for the stable releases > > > > commit 9b0da816bdec98c0d6c5d17ccdd337bdbafc3f75 > > Author: Jiawei Wang > > Date: Tue Mar 16 06:18:27 2021 +0200 > > > > app/testpmd: fix NVGRE encap configuration > > > > But when applied it causes: > > > > [ 263s] /home/abuild/rpmbuild/BUILD/dpdk- > > 1622611368.078834f40/app/test-pmd/cmdline_flow.c: > > In function 'parse_vc_action_nvgre_encap': > > [ 263s] /home/abuild/rpmbuild/BUILD/dpdk- > > 1622611368.078834f40/app/test-pmd/cmdline_flow.c:4254:3: > > error: missing initializer for field 'protocol' of 'struct rte_flow_item_nvgre' [- > > Werror=missing-field-initializers] > > [ 263s] .item_nvgre.protocol = RTE_BE16(RTE_ETHER_TYPE_TEB), > > [ 263s] ^ > > [ 263s] In file included from > > /home/abuild/rpmbuild/BUILD/dpdk-1622611368.078834f40/x86_64- > > default-linux-gcc/include/rte_eth_ctrl.h:11:0, > > [ 263s] from > > /home/abuild/rpmbuild/BUILD/dpdk-1622611368.078834f40/x86_64- > > default-linux-gcc/include/rte_ethdev.h:978, > > [ 263s] from > > /home/abuild/rpmbuild/BUILD/dpdk-1622611368.078834f40/app/test- > > pmd/cmdline_flow.c:18: > > [ 263s] /home/abuild/rpmbuild/BUILD/dpdk- > > 1622611368.078834f40/x86_64-default-linux-gcc/include/rte_flow.h:917:13: > > note: 'protocol' declared here > > [ 263s] rte_be16_t protocol; /**< Protocol type (0x6558). */ > > [ 263s] ^ > > > > This is failing not everywhere but in: > > - SLE_12_SP4/x86_64 > > - RHEL_7/x86_64 > > - openSUSE_Leap_42.3/x86_64 > > > > The type and the init code looks the same here and in the recent main branch. > > Neither do I see recent changes that would cause this. > > And the init just looks right to me, so I'm sure I'm overlooking something. > > > > So I wondered (if you consider this patch important for 19.11.x) if you could > > have a look and consider backporting it so that it works well (or as an > > alternative let me know that it won't be needed for 19.11.x) > > > > References/Logs: > > 19.11.8 working: https://paste.ubuntu.com/p/vvm4qCcmJT/ > > 19.11.9 fail RH7: https://paste.ubuntu.com/p/2wph5nfbCg/ > > 19.11.9 fail SLE12SP4: https://paste.ubuntu.com/p/nGHhkPJbR3/ > > 19.11.9 fail openSuse42.3: https://paste.ubuntu.com/p/43mMx3sY2n/ > > 19.11.9 witzh the patch dropped works: > > https://paste.ubuntu.com/p/JGZ44BhkC6/ > > > > > > -- > > Christian Ehrhardt > > Staff Engineer, Ubuntu Server > > Canonical Ltd -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd