From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by dpdk.org (Postfix) with ESMTP id 511621B529 for ; Fri, 3 Aug 2018 09:15:11 +0200 (CEST) Received: from mail-oi0-f69.google.com ([209.85.218.69]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1flUIp-0005LZ-0z for stable@dpdk.org; Fri, 03 Aug 2018 07:15:11 +0000 Received: by mail-oi0-f69.google.com with SMTP id m197-v6so3937597oig.18 for ; Fri, 03 Aug 2018 00:15:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OW/VyYyBC4tbR7yzXDKDX3E5MKsSaeCh7BWuTYC0CNY=; b=nHoOOKjXzaIm9PL118EjeE8jn2mgEBpas8IrxAjs6zgJ908RRbWhoeqB4JmrUCV0Kz 4SmGqKDyXJpN36NnAIQxLeYZ3v/PQyK14El/A25Z5ZNvQvcQdCpRaySXErUTDO9zRlZB 8WRiioPXmHUHw+4POdxrzr7P4mPHKrenk9g30Zl7D4NltqE9zt4yogu80x4njxlLlZQk qvT1oeINRb6f+d9aCnkJatTUTdWvZbmSchTvNrcSppui0cPlsUceLrw+9YhRO3aML2Cv 11QW2uKKjlM1LkTJbtSYSyfCPX3ifcBuVP98pMh3FG2NG8MTvqr2r/swdVHcYDcbJ705 deGA== X-Gm-Message-State: AOUpUlEZTklgEBuDgeVJsELWF465TIdMsbnWoYF7vXVmSz9MNP/qPdhW 7MiP59cZisFg9LmtDpvSqLAu8GEHcL9TKWdSUgp8GKtOO+1agMy9FFK6H0UYRAoj2DI3vAI5GK7 OirhRii7G8Qy2Inr+1K+KCLAajVh9W301IEiLtVBz X-Received: by 2002:aca:3c02:: with SMTP id j2-v6mr2181258oia.50.1533280509543; Fri, 03 Aug 2018 00:15:09 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcAFsQGAXcZ+ozc6OlvLFDlhnXQq9+2o4yskPQPPHxR0lcjBZYUPf46tro0w5siUEWr1RbzBrktNgIIPxosYfM= X-Received: by 2002:aca:3c02:: with SMTP id j2-v6mr2181238oia.50.1533280509299; Fri, 03 Aug 2018 00:15:09 -0700 (PDT) MIME-Version: 1.0 References: <20180730161342.16566-1-christian.ehrhardt@canonical.com> <20180730161342.16566-155-christian.ehrhardt@canonical.com> In-Reply-To: From: Christian Ehrhardt Date: Fri, 3 Aug 2018 09:14:43 +0200 Message-ID: To: yskoh@mellanox.com Cc: adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-stable] patch 'net/mlx5: fix invalid network interface index' has been queued to stable release 18.05.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Aug 2018 07:15:11 -0000 Thanks for the feedback Yongseok! I added a fixup patch to the 18.05 stable branch for it. On Wed, Aug 1, 2018 at 10:49 PM Yongseok Koh wrote: > > > On Jul 30, 2018, at 9:13 AM, Christian Ehrhardt < > christian.ehrhardt@canonical.com> wrote: > > > > Hi, > > > > FYI, your patch has been queued to stable release 18.05.1 > > > > Note it hasn't been pushed to > https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fdpdk.= org%2Fbrowse%2Fdpdk-stable&data=3D02%7C01%7Cyskoh%40mellanox.com%7C672b= bc6bc5d74492636508d5f6387a4e%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C6= 36685644792733413&sdata=3Djqe2g7yUGj6J6lLNo0k0G4s2SUY1vf2ji98YCc0y9wM%3= D&reserved=3D0 > yet. > > It will be pushed if I get no objections before 08/01/18. So please > > shout if anyone has objections. > > > > Thanks. > > > > Christian Ehrhardt > > > > --- > > From 2049afe07c264d2e4e3754588a264dd17cadaf4f Mon Sep 17 00:00:00 2001 > > From: Adrien Mazarguil > > Date: Wed, 25 Jul 2018 13:24:33 +0200 > > Subject: [PATCH] net/mlx5: fix invalid network interface index > > > > [ upstream commit 3f8cb05df5407369025fbc8b67f0f9595b781f73 ] > > > > Network interface indices being unsigned, an invalid index or error is > > normally expressed through a zero value (see if_nametoindex()). > > > > mlx5_ifindex() has a signed return type for negative values in case of > > error. Since mlx5_nl.c does not check for errors, these may be fed back > as > > invalid interfaces indices to subsequent system calls. This usage would > > have been correct if mlx5_ifindex() returned a zero value instead. > > > > This patch makes mlx5_ifindex() unsigned for convenience. > > > > Fixes: ccdcba53a3f4 ("net/mlx5: use Netlink to add/remove MAC addresses= ") > > > > Signed-off-by: Adrien Mazarguil > > Acked-by: Nelio Laranjeiro > > Acked-by: Yongseok Koh > > --- > > drivers/net/mlx5/mlx5.h | 1 + > > drivers/net/mlx5/mlx5_ethdev.c | 20 ++++++++------------ > > drivers/net/mlx5/mlx5_nl.c | 6 +++--- > > 3 files changed, 12 insertions(+), 15 deletions(-) > > > > diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h > > index 997b04a33..8f1335200 100644 > > --- a/drivers/net/mlx5/mlx5.h > > +++ b/drivers/net/mlx5/mlx5.h > > @@ -211,6 +211,7 @@ int mlx5_getenv_int(const char *); > > > > int mlx5_get_ifname(const struct rte_eth_dev *dev, char > (*ifname)[IF_NAMESIZE]); > > int mlx5_ifindex(const struct rte_eth_dev *dev); > > +unsigned int mlx5_ifindex(const struct rte_eth_dev *dev); > > Hi Christian > > This line is to replace the upper line. In the original patch: > > -int mlx5_ifindex(const struct rte_eth_dev *dev); > +unsigned int mlx5_ifindex(const struct rte_eth_dev *dev); > > Please fix it. > > > Thanks, > Yongseok > > --=20 Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd