From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D652A034D for ; Tue, 11 Jan 2022 08:52:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2D1A411AE; Tue, 11 Jan 2022 08:52:24 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 60F94411AE for ; Tue, 11 Jan 2022 08:52:24 +0100 (CET) Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 1C47040019 for ; Tue, 11 Jan 2022 07:52:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1641887544; bh=hfL3VhM4qiNhcKiQIIL2r7GQw0IbpTtsw/iSQDoi350=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=DVrpMdtvugnRwmdG782V8/6L6ZXvQK5rhvqIsrJw/0RUnYUVnk85XMwYYaRvEX4R4 d64qy9OEaynwskmFQ3zSAGlAqmV1YxUtcOsihl7+I2lODC0TmoQ/bdvmHDaSlOhKhh PWHTDSfHif2vv4//hNf6HguRGfw7Ga8dCt8P3yeRBIOHe+WnQjM2ugGGGOBRieKjHI oJQZEiT4Vzs0wLO4zIp8Vgw+I0oP24xDldC/CugB91wBUGJ/DTMkUxN20uq86gKuta 1DvflTLfH4dI0+HuaRAp9j3VknwBAYeua43F8PpSlUP/FJe/MR5o96XzQRpUXLK6C7 2a/bXy459ImMw== Received: by mail-qv1-f71.google.com with SMTP id 13-20020a0562140d0d00b00411590233e8so15433916qvh.15 for ; Mon, 10 Jan 2022 23:52:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hfL3VhM4qiNhcKiQIIL2r7GQw0IbpTtsw/iSQDoi350=; b=iazrHt6XNNQDzRsXyTATeEuunGt28fpFUHvmbeRfY76V/cJfmOw/UoLC24PvuceIS2 IfopZDjTuVvbpF3wrM1J4+F7rjosk9vUPPm1KVFZA1AGccI3sYF1Xhe4zL4Ua0MEc0A8 QJ5hUko0rRNncbh3L9BOhNysRmCRCwuB/nCUSIJw3FkMDTyxMed1TIVYzhCFfecpulFZ IIRJDH94F6yD+n3yfmADNGpwHcYuUs5CadNTzYwKa8EM6cWbaNDD1QXwfdcXzHj4GlOt /ryfZPTu16Tgpj6WM5YuXT2n5YD0mOSgV8aOwIilRkpLcW+CvUAU/wFluVwPZwfJeQsq nFGQ== X-Gm-Message-State: AOAM532zP6uJxRTSOu4UXvmLHlijfKXciY+ebL1x+6ztTlj9MV9RleIP qJUXVI00PRnq+o1fWMuWd5SF62Ys2ubgha2xqxKQKnZLoeEvX6G/mPzu4pq8peMYYAecBlezeTw u1IRbVTJxfzBRJ+BemkQ4WtWUTkHt7NK/pWElB1nk X-Received: by 2002:a05:622a:14d0:: with SMTP id u16mr2685544qtx.641.1641887543115; Mon, 10 Jan 2022 23:52:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJya+yqquoO3aKNPmrjnglqc06P8qalH0hBOnrF3+va5233WuBctd65Lz6BLnKYZnYf5UWtw0tQs8HrgB4CrHOo= X-Received: by 2002:a05:622a:14d0:: with SMTP id u16mr2685533qtx.641.1641887542909; Mon, 10 Jan 2022 23:52:22 -0800 (PST) MIME-Version: 1.0 References: <20220107095002.1253288-1-christian.ehrhardt@canonical.com> <8984b5be-e87d-cb65-17fe-4ac248d5933c@redhat.com> In-Reply-To: <8984b5be-e87d-cb65-17fe-4ac248d5933c@redhat.com> From: Christian Ehrhardt Date: Tue, 11 Jan 2022 08:51:57 +0100 Message-ID: Subject: Re: [PATCH] 5-make-release-commit: fix rstheader To: Kevin Traynor Cc: stable@dpdk.org, Thomas Monjalon , Luca Boccassi , Xueming Li , David Marchand Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Mon, Jan 10, 2022 at 3:51 PM Kevin Traynor wrote: > > On 07/01/2022 09:50, christian.ehrhardt@canonical.com wrote: > > From: Christian Ehrhardt > > > > The printf magic fails trying to interpret "-" as option and thereby breaking > > the top level headers. > > printf: -%: invalid option > > printf: usage: printf [-v var] format [arguments] > > > > Instead of relying printf expansion, fall back to the more trivial > > printf n times which works with any char. > > > > Signed-off-by: Christian Ehrhardt > > --- > > 5-make-release-commit | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/5-make-release-commit b/5-make-release-commit > > index 374154f..00acf92 100755 > > --- a/5-make-release-commit > > +++ b/5-make-release-commit > > @@ -29,7 +29,7 @@ function rstheader() > > > > echo > > echo "${msg}" > > - printf "${rchar}%.0s" $(seq 1 ${#msg}) > > + for i in $(seq 1 ${#msg}); do printf "${rchar}"; done > > # break after line plus one empty line > > echo > > echo > > > > Acked-by: Kevin Traynor Thank you both for the review, pushed to the stable-scripts git now. -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd