From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A76C7A0548 for ; Fri, 3 Dec 2021 08:54:02 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9EE9640041; Fri, 3 Dec 2021 08:54:02 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id E8C6240041 for ; Fri, 3 Dec 2021 08:54:00 +0100 (CET) Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id C99313F316 for ; Fri, 3 Dec 2021 07:54:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638518040; bh=YY3421lLPnKcc95uICD2NI4smuPB5PgaKyxtoc0mr4U=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Content-Type; b=Iiq/qB20ycDfHtsfYkFDf02KBh0ywbj4qe6LYvCZtIO1HfP8PVzpoh+LhBlpbl58O cDsB5HgVczOpg0SkC7St0iVwtEXfGy2fnh7jVAT77FqlI7db/hxG3ugeabj2ctum35 IOuqYQD3nFSTaJ9imUtHsgABjVOrSwNrPhmukchWbXq02NFcYOrcIDZcmmd3VMISTM K3gP0BWTA9mSyGh37mhjxpQL/RS4zZDzbFI6LE5TmMe0lTNrY1sjm1mQcm9hm9N48h Zan2O5r3MIf5OsCrEhnNMe0HVbg/7hnCEb8l2BZ6lP1moNx97SMxvG9ZpKO+ujHZFY snCLe4srlvKkQ== Received: by mail-qt1-f199.google.com with SMTP id p7-20020a05622a00c700b002b2f6944e7dso2651070qtw.10 for ; Thu, 02 Dec 2021 23:54:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=YY3421lLPnKcc95uICD2NI4smuPB5PgaKyxtoc0mr4U=; b=OL9RpGvOTO4kT6odv4XB7BaDYaecgLPi1FxFXz1ukz/x9YGkcgzVCZtiXw1maukmb5 l6kb58wbI3YIEvJNaZf05jh0puSje8bwg8jocQVePjwJt0hqawmNw2fvzS7u9eMLIqmc 00L1UHmmk3S/2+2WTKOvrwgPKTtHvS/Gp5YLiik9Fu6pgLSGwU3/Wqcfm5rbWTDIBwlu uDyl/LO1IOroAkNxt8zgJskJPYXZ+bPiUnCbhJ0XE+et3p3vE0Jukq/CyJKjdzzFdKIO BjNOlsDZoJ7lsqloseR3kymXEQA/BD/uO7ysAAZ24snSWyl71eoTuGsb0Pq89jKtT0K1 nJMg== X-Gm-Message-State: AOAM531voUmzV9BXyCZLCbVb5jTajVp6laHVHfXiwxHFcBUaktx7ZznK rSuAvZ3UxIrgKE61urSQFwCs0RmBbvYONi6h7J7/jEPMr/RnYDnW4A3B8aGHIuYD7zR7slIaaFt 7iOq4UfTEhInZtJ1UndY6sn/0EgKqoPdH0WcbMScx X-Received: by 2002:a0c:ef4c:: with SMTP id t12mr18219058qvs.110.1638518039896; Thu, 02 Dec 2021 23:53:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJy23dVvIsHSscMyWjc7s54QGsqBMWRyxnLOQVhaI9wWc11vxFgTEEdGiU+wLH+J6po6h4ttvoPRA0/50jlwe1k= X-Received: by 2002:a0c:ef4c:: with SMTP id t12mr18219042qvs.110.1638518039680; Thu, 02 Dec 2021 23:53:59 -0800 (PST) MIME-Version: 1.0 References: <20211203075123.4081128-1-christian.ehrhardt@canonical.com> In-Reply-To: <20211203075123.4081128-1-christian.ehrhardt@canonical.com> From: Christian Ehrhardt Date: Fri, 3 Dec 2021 08:53:34 +0100 Message-ID: Subject: Re: [PATCH 1/2] devtools: don't include headline "fix" in backports To: stable@dpdk.org, Thomas Monjalon , Luca Boccassi , Xueming Li , David Marchand , Kevin Traynor , Maxime Coquelin Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Fri, Dec 3, 2021 at 8:51 AM wrote: > > From: Christian Ehrhardt Hmm, that probably should go to dev@ instead since that is where the script lives - resubmitting > It was important in the past to select anything with "fix" in the > headline, but recently more often created false positives and work > to sort tihngs out than identifying many helpful patches. > > The community and processes aroudn DPDK matured enough that developers > (rightfully) expect to rely on "Fixes:" and "stable@" marking for > backprots. > > Therefore do no more include patches that just include the word fix > in the backport candidate list. > > Signed-off-by: Christian Ehrhardt > --- > devtools/git-log-fixes.sh | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh > index 210c8dcf25..27ec9088d4 100755 > --- a/devtools/git-log-fixes.sh > +++ b/devtools/git-log-fixes.sh > @@ -13,7 +13,7 @@ print_help () > cat <<- END_OF_HELP > > Find fixes to backport on previous versions. > - It looks for the word "fix" in the headline or a tag "Fixes" or "Reverts". > + It looks for a tag "Fixes" or "Reverts" and for recipient stable@dpdk.org. > The oldest bug origin is printed as well as partially fixed versions. > END_OF_HELP > } > @@ -109,8 +109,7 @@ while read id headline ; do > origins=$(origin_filter $id) > stable=$(stable_tag $id) > fixes=$(fixes_tag $id) > - [ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || \ > - echo "$headline" | grep -q fix || continue > + [ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || continue > version=$(commit_version $id) > if [ -n "$origins" ] ; then > origver="$(origin_version $origins)" > -- > 2.34.0 > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd