From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD4E1A0506 for ; Tue, 29 Mar 2022 16:21:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C28DB40141; Tue, 29 Mar 2022 16:21:18 +0200 (CEST) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 14E1240141 for ; Tue, 29 Mar 2022 16:21:18 +0200 (CEST) Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id E0C873F174 for ; Tue, 29 Mar 2022 14:21:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1648563677; bh=MuC16WK809r834cYuxtbG2m9dVukHytJfAC7BU7eBtQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=qOqXJMIH0iY8aODGmoEaDC0vvtq8RIokAIUC1MdqM+7hxCKjOw9ZIyZkxEUMvsBOG nJzCPqDcUQMZMB8SfjZZ4EbtJ0V3pXfhtgRFNry/2HlzDg7Mih0F2ZbuCXnWosLQjw c+yaAzPdjcpxGxLeS0a65AUkpfG7jCpvN4LNGC+YJanLi5QYJ3BP+pUoYM3oxqQmHJ SX4xnI0noclCuxGZQjlWcYH2+GzLqmlDJTCdRaYbTWfpcL2301ThnUiOTAxRhsaWpV U4oDlxyRUlltdLakbASEPtDhQS442hSFzRyPpR1gLmG+3a1JZHj7UYrxf5p+8s9nBC w8qKEzkfEProg== Received: by mail-qv1-f69.google.com with SMTP id cl19-20020a05621404f300b0044103143211so13847091qvb.10 for ; Tue, 29 Mar 2022 07:21:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MuC16WK809r834cYuxtbG2m9dVukHytJfAC7BU7eBtQ=; b=sZiJoK8aqDB6XBVMyDiXeSwrHs2BsQsSY9/wiUoBvyMPvQfMf5BlAPOBrL+r+pk73y J6zfyK5o5vPh5BnJdj97wBe/9gxKpK0Ty6sdmRwtcYPJVRyOrDjPcs52T7jP52K7rqcu j4GkFQpXE3A8/akEtLKT3fqblH8Iy1Yw85iF4ioV8pkwCtVJ4ciSyoID1JZkPTrhWt6G CXZecmYqJMQDHNolgG1+MsAfjQ1tf9KaPpEgF+VZB0nY1nYT2AXpGqpUmW9C8xxscwyP 11Bm4PTgRWxcAj0ksMdsOR4PZCMFEjuMkbftxmIXPN7DG1B5JkKFibpi9T/aUAHYydLB MP0A== X-Gm-Message-State: AOAM533bZdnsAxLgLJ3VKtAPx5M3JVyo9ZW2rf0WzGJN2rhWzVNqYKOR gOZmraD1aNy1KRBOWwdO0fQ5HzW7Iyrahm4xCWvDPSH8l/1rdIq3uQOHJt/2X6G2I98jWEvuohz jx+PfxhoYJFrhZ+eJoK3MaybpDNyFbx/2VpfYPNg4 X-Received: by 2002:a05:622a:1188:b0:2e1:ce9c:a4aa with SMTP id m8-20020a05622a118800b002e1ce9ca4aamr28212270qtk.621.1648563676847; Tue, 29 Mar 2022 07:21:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzCacRoDiW+NYF+j3viMDn26MBKVJ9ZODShCyWq3+tdtvnvUsovOg4WPSde92hmhrQm65bx9L2JsUpREQFLktg= X-Received: by 2002:a05:622a:1188:b0:2e1:ce9c:a4aa with SMTP id m8-20020a05622a118800b002e1ce9ca4aamr28212241qtk.621.1648563676616; Tue, 29 Mar 2022 07:21:16 -0700 (PDT) MIME-Version: 1.0 References: <20220329120953.152396-1-luca.boccassi@gmail.com> <20220329120953.152396-2-luca.boccassi@gmail.com> In-Reply-To: <20220329120953.152396-2-luca.boccassi@gmail.com> From: Christian Ehrhardt Date: Tue, 29 Mar 2022 16:20:50 +0200 Message-ID: Subject: Re: [PATCH 20.11 2/2] dpaa2: fix build with RTE_LIBRTE_IEEE1588 To: luca.boccassi@gmail.com Cc: stable@dpdk.org, ktraynor@redhat.com, Luca Boccassi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, Mar 29, 2022 at 2:10 PM wrote: > > From: Luca Boccassi > > ../drivers/net/dpaa2/dpaa2_rxtx.c: In function =E2=80=98dpaa2_dev_rx=E2= =80=99: > ../drivers/net/dpaa2/dpaa2_rxtx.c:863:4: error: =E2=80=98priv=E2=80=99 un= declared (first use in this function); did you mean =E2=80=98ldiv=E2=80=99? > priv->rx_timestamp =3D > ^~~~ > ldiv > > Bugzilla ID: 982 > > Fixes: 1d10966a22ca ("net/dpaa2: fix timestamping for IEEE1588") > > Signed-off-by: Luca Boccassi It was unclear at first why it needs the if defined, thanks for the IRC discussion. While not nice I think it makes sense as a build-fix. +1, but since I'm not a subject matter expert I'm holding back an official signed-off for this. > --- > drivers/net/dpaa2/dpaa2_rxtx.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/dpaa2/dpaa2_rxtx.c b/drivers/net/dpaa2/dpaa2_rxt= x.c > index ecd004f9fa..23e193f86c 100644 > --- a/drivers/net/dpaa2/dpaa2_rxtx.c > +++ b/drivers/net/dpaa2/dpaa2_rxtx.c > @@ -772,6 +772,9 @@ dpaa2_dev_rx(void *queue, struct rte_mbuf **bufs, uin= t16_t nb_pkts) > const struct qbman_fd *fd; > struct qbman_pull_desc pulldesc; > struct rte_eth_dev_data *eth_data =3D dpaa2_q->eth_data; > +#if defined(RTE_LIBRTE_IEEE1588) > + struct dpaa2_dev_priv *priv =3D eth_data->dev_private; > +#endif > > if (unlikely(!DPAA2_PER_LCORE_DPIO)) { > ret =3D dpaa2_affine_qbman_swp(); > -- > 2.34.1 > --=20 Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd