From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E347A034F for ; Tue, 8 Jun 2021 06:51:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9EF02410E7; Tue, 8 Jun 2021 06:51:10 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id 2AA11410E7 for ; Tue, 8 Jun 2021 06:51:09 +0200 (CEST) Received: from mail-qv1-f71.google.com ([209.85.219.71]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lqThk-0000mX-Sa for stable@dpdk.org; Tue, 08 Jun 2021 04:51:08 +0000 Received: by mail-qv1-f71.google.com with SMTP id gf13-20020a056214250db0290232483acc48so2743959qvb.13 for ; Mon, 07 Jun 2021 21:51:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ML2mozTz2CAz63WK2/u3tE3GwClc+dAq6MUBkf1YCeQ=; b=LgXSkXhQST1KAOUrFmQE5ZGKjD16CUc0scelTkrmpYDUkZdQ0M31qTjTHOqlSlHPYF mN27V25IOjyNGbVg5bqBw8bk6cYdLiygBHkFNyTxgmY7KQsJcShakmmvjehyEyikl9Lf dU2K0pJa0delGmD7VopI8vMaM9rzGndD8hrqR19y7DsY0FsKUk3yr/7wNyhuv0iUCDz+ jm9a32wvkKsCp9oxNfoPyKuZyli2JHq2ft8QkNK5/OuF2xV9qjj4yZ+uEkn93z3gnW6A GJJmjRqwPTYnZpiP8DI87FRNy3SJ1QR4QQ3AxzzJXpE/fsPKfNkdfpDis9Hrn9Oypb4A ATGQ== X-Gm-Message-State: AOAM5327ywv8LpiIXPeDhILyqH4BxLi0PW2z1jCNXbDybG2ckoBK2XLl WeYRk8rjqyW6NccirQj391DXuo6mgc/tuYJpWHm2eRbXujd5Z9zk/J34j2qvkW0UxQBOtb+uSwE I+UY1Exm0McpKlN//fPPqsEXR8PcB0FtKlJ9P02HQ X-Received: by 2002:a05:6214:10e9:: with SMTP id q9mr21683327qvt.45.1623127868050; Mon, 07 Jun 2021 21:51:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQ/ugxJKVvR6lqIfmaXe9JQlMwpGHi0O5rlk2v8BYz27PdEe8NbjRSg4yxyxB4nkAbOFH+RCz3o/mEm/23t/I= X-Received: by 2002:a05:6214:10e9:: with SMTP id q9mr21683322qvt.45.1623127867860; Mon, 07 Jun 2021 21:51:07 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Christian Ehrhardt Date: Tue, 8 Jun 2021 06:50:41 +0200 Message-ID: To: "Jiawei(Jonny) Wang" Cc: dpdk stable , Ori Kam Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] " app/testpmd: fix NVGRE encap configuration" incompatible with 19.11.x X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Fri, Jun 4, 2021 at 3:44 PM Jiawei(Jonny) Wang wrote: > > Hello Christian, > > > -----Original Message----- > > From: Christian Ehrhardt > > Sent: Friday, June 4, 2021 1:07 PM > > To: Jiawei(Jonny) Wang > > Cc: dpdk stable ; Ori Kam > > Subject: Re: " app/testpmd: fix NVGRE encap configuration" incompatible > > with 19.11.x > > > > On Thu, Jun 3, 2021 at 4:54 PM Jiawei(Jonny) Wang > > wrote: > > > > > > Hello Christian, > > > > > > I applied this patch on the 19.11.9-rc1, but not found this issue during > > compilation. > > > > > > Could you send me your code branch then I can try on my side? > > > > Hi, > > For me it fails when applied on top of the 19.11.x WIP branch. > > You can use that from > > https://github.com/cpaelzer/dpdk-stable-queue/commits/19.11 > > > > But as I said it only fails in some releases/configurations. > > That is why I have linked the failing error logs. > > For example on my Ubuntu 20.04 it builds just fine. > > > > Yes, I compared and found it's related with older gcc version. > I had sent the code patch. I've got the patch it applies and seems to work - thank you! It isn't critical enough to respin the release candidates though. If we hit a functional issue in testing that will force us to respin it will be in 19.11.9-rc3, otherwise it will be the first patch that gets queued for 19.11.10 > > > Code base: > > > commit 15d8f64d18a891a70d664d18eb918eee0705993e > > > Author: Christian Ehrhardt > > > Date: Wed Jun 2 16:33:26 2021 +0200 > > > > > > version: 19.11.9-rc1 > > > > > > Signed-off-by: Christian Ehrhardt > > > > > > > > > > > > #make O=x86_64-default-linux-gcc T=x86_64-native-linux-gcc config #sed > > > -ri 's,(RTE_MACHINE=).*,\1default,' x86_64-default-linux-gcc/.config > > > #sed -ri 's,(RTE_APP_TEST=).*,\1n,' x86_64-default-linux-gcc/.config > > > #sed -ri 's,(RTE_BUILD_SHARED_LIB=).*,\1y,' > > > x86_64-default-linux-gcc/.config #sed -ri 's,(RTE_NEXT_ABI=).*,\1n,' > > > x86_64-default-linux-gcc/.config #sed -ri 's,(LIBRTE_VHOST=).*,\1y,' > > > x86_64-default-linux-gcc/.config #sed -ri 's,(LIBRTE_VHOST=).*,\1y,' > > > x86_64-default-linux-gcc/.config #sed -ri 's,(RTE_KNI_KMOD=).*,\1y,' > > > x86_64-default-linux-gcc/.config #sed -ri > > > 's,(RTE_EAL_IGB_UIO=).*,\1y,' x86_64-default-linux-gcc/.config # #make > > > O=x86_64-default-linux-gcc -j3 EXTRA_CFLAGS=-Werror > > > > Yeah as I said it seems to only affect some releases/configs - I hope the logs > > help to find what is different between good/bad cases. > > > Yes, it's helpful, I had updated the code to make sure it works with older gcc version. > Thanks. > > > > ...... > > > > > > INSTALL-APP dpdk-test-crypto-perf > > > INSTALL-MAP dpdk-test-crypto-perf.map > > > CC test_perf_queue.o > > > CC test_perf_atq.o > > > CC test_pipeline_common.o > > > CC test_pipeline_queue.o > > > CC test_pipeline_atq.o > > > LD dpdk-test-eventdev > > > INSTALL-APP dpdk-test-eventdev > > > INSTALL-MAP dpdk-test-eventdev.map > > > Build complete [x86_64-default-linuxapp-gcc] > > > > > > Thanks. > > > B.R. > > > > > > Jonny > > > > > > > > > > -----Original Message----- > > > > From: Christian Ehrhardt > > > > Sent: Wednesday, June 2, 2021 9:25 PM > > > > To: Jiawei(Jonny) Wang > > > > Cc: dpdk stable ; Ori Kam > > > > Subject: " app/testpmd: fix NVGRE encap configuration" incompatible > > > > with 19.11.x > > > > > > > > Hi, > > > > this change was targeted for the stable releases > > > > > > > > commit 9b0da816bdec98c0d6c5d17ccdd337bdbafc3f75 > > > > Author: Jiawei Wang > > > > Date: Tue Mar 16 06:18:27 2021 +0200 > > > > > > > > app/testpmd: fix NVGRE encap configuration > > > > > > > > But when applied it causes: > > > > > > > > [ 263s] /home/abuild/rpmbuild/BUILD/dpdk- > > > > 1622611368.078834f40/app/test-pmd/cmdline_flow.c: > > > > In function 'parse_vc_action_nvgre_encap': > > > > [ 263s] /home/abuild/rpmbuild/BUILD/dpdk- > > > > 1622611368.078834f40/app/test-pmd/cmdline_flow.c:4254:3: > > > > error: missing initializer for field 'protocol' of 'struct > > > > rte_flow_item_nvgre' [- Werror=missing-field-initializers] > > > > [ 263s] .item_nvgre.protocol = RTE_BE16(RTE_ETHER_TYPE_TEB), > > > > [ 263s] ^ > > > > [ 263s] In file included from > > > > /home/abuild/rpmbuild/BUILD/dpdk-1622611368.078834f40/x86_64- > > > > default-linux-gcc/include/rte_eth_ctrl.h:11:0, > > > > [ 263s] from > > > > /home/abuild/rpmbuild/BUILD/dpdk-1622611368.078834f40/x86_64- > > > > default-linux-gcc/include/rte_ethdev.h:978, > > > > [ 263s] from > > > > /home/abuild/rpmbuild/BUILD/dpdk-1622611368.078834f40/app/test- > > > > pmd/cmdline_flow.c:18: > > > > [ 263s] /home/abuild/rpmbuild/BUILD/dpdk- > > > > 1622611368.078834f40/x86_64-default-linux- > > gcc/include/rte_flow.h:917:13: > > > > note: 'protocol' declared here > > > > [ 263s] rte_be16_t protocol; /**< Protocol type (0x6558). */ > > > > [ 263s] ^ > > > > > > > > This is failing not everywhere but in: > > > > - SLE_12_SP4/x86_64 > > > > - RHEL_7/x86_64 > > > > - openSUSE_Leap_42.3/x86_64 > > > > > > > > The type and the init code looks the same here and in the recent main > > branch. > > > > Neither do I see recent changes that would cause this. > > > > And the init just looks right to me, so I'm sure I'm overlooking something. > > > > > > > > So I wondered (if you consider this patch important for 19.11.x) if > > > > you could have a look and consider backporting it so that it works > > > > well (or as an alternative let me know that it won't be needed for > > > > 19.11.x) > > > > > > > > References/Logs: > > > > 19.11.8 working: https://paste.ubuntu.com/p/vvm4qCcmJT/ > > > > 19.11.9 fail RH7: https://paste.ubuntu.com/p/2wph5nfbCg/ > > > > 19.11.9 fail SLE12SP4: https://paste.ubuntu.com/p/nGHhkPJbR3/ > > > > 19.11.9 fail openSuse42.3: https://paste.ubuntu.com/p/43mMx3sY2n/ > > > > 19.11.9 witzh the patch dropped works: > > > > https://paste.ubuntu.com/p/JGZ44BhkC6/ > > > > > > > > > > > > -- > > > > Christian Ehrhardt > > > > Staff Engineer, Ubuntu Server > > > > Canonical Ltd > > > > > > > > -- > > Christian Ehrhardt > > Staff Engineer, Ubuntu Server > > Canonical Ltd -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd