From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCB4AA04A6 for ; Fri, 17 Dec 2021 18:57:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8C4B940040; Fri, 17 Dec 2021 18:57:53 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id B516540040 for ; Fri, 17 Dec 2021 18:57:52 +0100 (CET) Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 75F583F1FD for ; Fri, 17 Dec 2021 17:57:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1639763872; bh=KEZNsos4HxNjejCHWi7KJd3SlsY0uS1FqXiS3DzMJ4M=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=SQ/LROp8DKvvjSgl//De0xVSOiDZrHeL+VzeOWtkGfOd6XNSpcpIZQv7i/TBwWDEv FzossWmIhB8OKJ+XjPU37WAIZ6S24Gf4/L5qukC7IXyJh5UmdPcbDnjrfm5nZCdH2M RJza+dtCfmpBPg6adgbyDd2H6A/6oWuP2uiEVr5NAB/+8kKoHVzol3bkJwsAnrxq98 vAO7bVAoMQolVt1LN9swjCU5TMoJGKsdYvv9qHLFXkU2BOWujoLCW4hBTUSPTptzoY ao23UfrOI/LURTYMowg6NK9E47w4KdfEUi1qEepPtYr7MT8fXutoZ/KEqtc6ISPX6g 73rgiSaIEFzQw== Received: by mail-qt1-f199.google.com with SMTP id s6-20020a05622a018600b002b2d93b9c73so3225757qtw.9 for ; Fri, 17 Dec 2021 09:57:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KEZNsos4HxNjejCHWi7KJd3SlsY0uS1FqXiS3DzMJ4M=; b=V/8b/uXbuo5AhHaL8Vz3xEvoB5M3zgry4pGMB2Hf2mx0LrfJMfzCVccPdctSk82chz 5B9Ig8M6vt88wd35jnVRxqVE2oiUXvP1BdoY1cxStdTSBxqKO3yTUqhANtsGsiYcOqC5 wNvtOC2XcuQRevzrbqLNT9Bu1Lwd8ItN4rR5QLTWAeWiG/XTee1ZKlPkjuEXwDptt9/v s7C3xsoLn5OyQFlCGiATqG3pFpHcHrHVPWUd1gbweqJwNWwWYasx/2tWWVET+k0FM0wU h4Iyl1CRX805Kro2FqjDaBWla0eFE2+wcwu3KvdRj1Kp9x6At35LCZQpDTKSIl+wwf8f M5dQ== X-Gm-Message-State: AOAM531PgEQrkpVOfnakD5mYY3JfmrVetuF4J/sQRmJuMHUJrNunAA1b O5LUnR70AS5ct/k2OwKQasUO55v7OvUqnvoBZdsUUiwIKf/wD9shlParKgpHVp+dBdfa0k/4pAN 1cyWdu2VTmXIwyTIjSx6GYUxSO6pw6WydBNqpsc/d X-Received: by 2002:a37:9342:: with SMTP id v63mr2409177qkd.759.1639763871336; Fri, 17 Dec 2021 09:57:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJz2erM1hPz5ohU9ho5QLDvUl3OyNVMtmCdJYjX9JpNHo+7+Azkg88PoBgFCIa5HsBParWyeSNbv5Ioiz4MRvHU= X-Received: by 2002:a37:9342:: with SMTP id v63mr2409170qkd.759.1639763871146; Fri, 17 Dec 2021 09:57:51 -0800 (PST) MIME-Version: 1.0 References: <20211209144315.3424225-1-christian.ehrhardt@canonical.com> <83b12bda825d46ecb7a23b150997e90b@intel.com> <8b6f88e7214d481b86eaef093d438204@intel.com> In-Reply-To: <8b6f88e7214d481b86eaef093d438204@intel.com> From: Christian Ehrhardt Date: Fri, 17 Dec 2021 18:57:24 +0100 Message-ID: Subject: Re: 19.11.11 patches review and test To: "Richardson, Bruce" Cc: "stable@dpdk.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Fri, Dec 17, 2021 at 4:48 PM Richardson, Bruce wrote: > > > > -----Original Message----- > > From: Richardson, Bruce > > Sent: Friday, December 17, 2021 2:56 PM > > To: 'Christian Ehrhardt' > > Cc: stable@dpdk.org > > Subject: RE: 19.11.11 patches review and test > > > > Hi Christian, > > > > just tried compiling latest 19.11 branch in dpdk-stable tree (which is > > your 19.11.11-rc1 commit) on FreeBSD 13, and see the following error: > > > > [11/1452] Compiling C object > > lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o > > FAILED: lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o > > cc -Ilib/librte_eal.a.p -Ilib -I../lib -I. -I.. -Iconfig -I../config - > > Ilib/librte_eal/common/include -I../lib/librte_eal/common/include - > > I../lib/librte_eal/freebsd/eal/include -Ilib/librte_eal/common - > > I../lib/librte_eal/common -Ilib/librte_eal/common/include/arch/x86 - > > I../lib/librte_eal/common/include/arch/x86 -Ilib/librte_eal - > > I../lib/librte_eal -Ilib/librte_kvargs -I../lib/librte_kvargs -fcolor- > > diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O3 - > > include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat- > > nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes - > > Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare - > > Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member - > > Wno-missing-field-initializers -D_GNU_SOURCE -D__BSD_VISIBLE -fPIC - > > march=native -DRTE_LIBEAL_USE_GETENTROPY -DALLOW_EXPERIMENTAL_API -MD -MQ > > lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o -MF > > lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o.d -o > > lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o -c > > ../lib/librte_eal/common/eal_common_options.c > > ../lib/librte_eal/common/eal_common_options.c:1499:2: error: implicit > > declaration of function 'CPU_NAND' is invalid in C99 [-Werror,-Wimplicit- > > function-declaration] > > > > It looks to me that commit 9ed3385f "eal/freebsd: update CPU macro for > > FreeBSD 13" needs to be applied to 19.11 branch. > > > > Other errors on FreeBSD 13 have been reported too, I'm looking into those. > > Looks like 03bff90ccfd6 ("contigmem: update for FreeBSD 13") could do with being cherry-picked too for 19.11. > > With that done (2 patches cherry-picked, and one additional patch applied that I have just sent), I get a clean build on FBSD 13. They all look safe to me, applied all three now. I have started build tests... Not sure if I can tag -rc2 today, but if not today then still soon (many build time fixes from many people since -rc1). > Regards, > /Bruce -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd