From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: Haiyue Wang <haiyue.wang@intel.com>
Cc: stable@dpdk.org, yux.jiang@intel.com, qi.z.zhang@intel.com,
alialnu@nvidia.com, Wenzhuo Lu <wenzhuo.lu@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>
Subject: Re: [PATCH 19.11 v2 3/3] net/ixgbe: build failure with make and clang 13
Date: Wed, 15 Dec 2021 14:34:18 +0100 [thread overview]
Message-ID: <CAATJJ0L+eSXMoj29i0-A4k2WUeYsw1LHuaTJbBvbkqhB_u2V5Q@mail.gmail.com> (raw)
In-Reply-To: <20211215003544.371084-3-haiyue.wang@intel.com>
On Wed, Dec 15, 2021 at 2:08 AM Haiyue Wang <haiyue.wang@intel.com> wrote:
>
> Disable the -Wunused-but-set-variable option for clang to avoid
> compile warning.
Thanks,
this already is in the meson build btw.
And it is in the Makefile for some, but not all .c files.
I'm wondering as I'd have expected the existing:
drivers/net/ixgbe/Makefile:39:CFLAGS_ixgbe_common.o +=
-Wno-unused-but-set-variable
To avoid one of the two errors reported in bug 903.
Nevertheless I think adding those is
a) not totally new
b) only meant to make the older DPDK release more tolerant with new toolchains
c) already is globally enabled for ixgbe in the meson based build
(which is how it passed Ubuntu/Debian builds)
BTW (c) also is the reason we do not need to fix latest development branch.
There it has only meson and that does set it this way.
Therefore I think it is ok and I'll apply this patch - thank you.
> Bugzilla ID: 903
>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
> drivers/net/ixgbe/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile
> index 31523025b3..31a418a2c6 100644
> --- a/drivers/net/ixgbe/Makefile
> +++ b/drivers/net/ixgbe/Makefile
> @@ -29,6 +29,7 @@ else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
> #
> CFLAGS_BASE_DRIVER = -Wno-unused-parameter -Wno-unused-value
> CFLAGS_BASE_DRIVER += -Wno-strict-aliasing -Wno-format-extra-args
> +CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
>
> else
> #
> --
> 2.34.1
>
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
prev parent reply other threads:[~2021-12-15 13:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 0:35 [PATCH 19.11 v2 1/3] net/i40e: " Haiyue Wang
2021-12-15 0:35 ` [PATCH 19.11 v2 2/3] net/ice: " Haiyue Wang
2021-12-15 13:37 ` Christian Ehrhardt
2021-12-15 0:35 ` [PATCH 19.11 v2 3/3] net/ixgbe: " Haiyue Wang
2021-12-15 13:34 ` Christian Ehrhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAATJJ0L+eSXMoj29i0-A4k2WUeYsw1LHuaTJbBvbkqhB_u2V5Q@mail.gmail.com \
--to=christian.ehrhardt@canonical.com \
--cc=alialnu@nvidia.com \
--cc=haiyue.wang@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
--cc=yux.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).