From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E4F4A00C3 for ; Wed, 15 Dec 2021 14:34:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2948140041; Wed, 15 Dec 2021 14:34:50 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 587D540041 for ; Wed, 15 Dec 2021 14:34:49 +0100 (CET) Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 7C4AD3F1C0 for ; Wed, 15 Dec 2021 13:34:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1639575287; bh=7lnFYnwt905ZfBj1mNvo1bTRItqyLaSXuLi7YcnXScw=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=eIkbHiMmGlRsn7Sc1+yoPatDlGKqr14EeUKzgfspGFzSzW3IN6GvL+rwMskdUCm8W c/OSG8r435ihJik5Ja7qA0k02qnmmEvcy7ATYO8X4X9U5//IAoYvLOAkDXelrnzv1f Yrn+aSjfUItDCozvobAgKT4VCTsx9Pabu4sSpeDbAh25kU/7rRtwYBP6l4DaufJnxF wvAyXCPzZqsbx1eu4fDe8Pop3yDckOXKtEhC8jYGfbaXGvoNcGb8+yEzyLCQeZMXlS 39a0nek+ptR3U5xiumgDEEzRfj2/VaRQsAZIbxmZxfyTj3855QzjyJzuIPEEowwcz+ jYSXXh485MHBg== Received: by mail-qt1-f199.google.com with SMTP id d11-20020ac85acb000000b002c09d216560so142460qtd.14 for ; Wed, 15 Dec 2021 05:34:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7lnFYnwt905ZfBj1mNvo1bTRItqyLaSXuLi7YcnXScw=; b=DUDa9pLAUY9vP3THOLTjhSUMOYvrPK/dpX+Gi3XxIvfK1yCyLhTsOF5i5p6bgfMaEe cK2wwnkmgnjXpZg3F8NSasXDAXIcu3nbeUl7iddRR0mvzcXJv8rDeLJRcMFwKt4CLweb 5hR33f7JDFNost7AnsoMiMGzCRMtChdvhVjLxw41Xcdj3PBS+z9PVmH1glNadKpnw75k pvccoPRMbtFTsGX9yZMn5oQWDNGRftvbTEfQwh8kdJxhO76xoNKu3y8PfIOYLCS49IT3 hZxXfrvc9rm4/f5vhq/FeCx6eSeMSPq0ZOt3VQO8mQWg32cxFjTVnBz8+8rfLK0IwxUf njag== X-Gm-Message-State: AOAM530mSz89jcHF7uh80OYAaYXcFJOtIW559jYYpHSeouS6RRa7rtQn MVHRQ+BwJGZIOJjTdC7d8wUpW6/cZUM+yYZdX0eCL+7rFOQgOS7K1FFgT5IWFFUehGTTZLR+jZU CeQMlJW2H7+1rzQU02mEW+BbVkp4XLXXIHzc0hlNO X-Received: by 2002:ac8:5542:: with SMTP id o2mr11879460qtr.670.1639575285515; Wed, 15 Dec 2021 05:34:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJz08gdDQ+pmoi5aKLRAdqiS0DinKT3ZnmuIoi/sHzlIoO900C8TAuzkji050W6DUNs9dlLmv1YGddJZu34D1JU= X-Received: by 2002:ac8:5542:: with SMTP id o2mr11879364qtr.670.1639575284342; Wed, 15 Dec 2021 05:34:44 -0800 (PST) MIME-Version: 1.0 References: <20211215003544.371084-1-haiyue.wang@intel.com> <20211215003544.371084-3-haiyue.wang@intel.com> In-Reply-To: <20211215003544.371084-3-haiyue.wang@intel.com> From: Christian Ehrhardt Date: Wed, 15 Dec 2021 14:34:18 +0100 Message-ID: Subject: Re: [PATCH 19.11 v2 3/3] net/ixgbe: build failure with make and clang 13 To: Haiyue Wang Cc: stable@dpdk.org, yux.jiang@intel.com, qi.z.zhang@intel.com, alialnu@nvidia.com, Wenzhuo Lu , Konstantin Ananyev Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Dec 15, 2021 at 2:08 AM Haiyue Wang wrote: > > Disable the -Wunused-but-set-variable option for clang to avoid > compile warning. Thanks, this already is in the meson build btw. And it is in the Makefile for some, but not all .c files. I'm wondering as I'd have expected the existing: drivers/net/ixgbe/Makefile:39:CFLAGS_ixgbe_common.o += -Wno-unused-but-set-variable To avoid one of the two errors reported in bug 903. Nevertheless I think adding those is a) not totally new b) only meant to make the older DPDK release more tolerant with new toolchains c) already is globally enabled for ixgbe in the meson based build (which is how it passed Ubuntu/Debian builds) BTW (c) also is the reason we do not need to fix latest development branch. There it has only meson and that does set it this way. Therefore I think it is ok and I'll apply this patch - thank you. > Bugzilla ID: 903 > > Signed-off-by: Haiyue Wang > --- > drivers/net/ixgbe/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile > index 31523025b3..31a418a2c6 100644 > --- a/drivers/net/ixgbe/Makefile > +++ b/drivers/net/ixgbe/Makefile > @@ -29,6 +29,7 @@ else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y) > # > CFLAGS_BASE_DRIVER = -Wno-unused-parameter -Wno-unused-value > CFLAGS_BASE_DRIVER += -Wno-strict-aliasing -Wno-format-extra-args > +CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable > > else > # > -- > 2.34.1 > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd