* 19.11.11 patches review and test
@ 2021-12-09 14:43 christian.ehrhardt
2021-12-13 4:14 ` Kalesh Anakkur Purayil
` (2 more replies)
0 siblings, 3 replies; 33+ messages in thread
From: christian.ehrhardt @ 2021-12-09 14:43 UTC (permalink / raw)
To: stable
Cc: dev, Abhishek Marathe, Akhil Goyal, Ali Alnubani,
benjamin.walker, David Christensen, hariprasad.govindharajan,
Hemant Agrawal, Ian Stokes, Jerin Jacob, John McNamara,
Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi, Pei Zhang, pingx.yu,
qian.q.xu, Raslan Darawsheh, Thomas Monjalon, yuan.peng,
zhaoyan.chen
Hi all,
Here is a list of patches targeted for stable release 19.11.11.
The planned date for the final release is 7th January 2021.
Please help with testing and validation of your use cases and report
any issues/results with reply-all to this mail. For the final release
the fixes and reported validations will be added to the release notes.
A release candidate tarball can be found at:
https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1
These patches are located at branch 19.11 of dpdk-stable repo:
https://dpdk.org/browse/dpdk-stable/
Thanks.
Christian Ehrhardt <christian.ehrhardt@canonical.com>
---
Ajit Khaparde (3):
net/bnxt: fix Tx queue startup state
net/bnxt: fix memzone free for Tx and Rx rings
net/bnxt: fix tunnel port accounting
Alexander Bechikov (1):
mbuf: fix dump of dynamic fields and flags
Alexander Kozyrev (2):
net/mlx5: fix GENEVE and VXLAN-GPE flow item matching
net/mlx5: fix GRE flow item matching
Alvin Zhang (1):
net/i40e: fix Rx packet statistics
Aman Singh (1):
kni: fix build for SLES15-SP3
Anatoly Burakov (2):
vfio: fix FreeBSD clear group stub
vfio: fix FreeBSD documentation
Anoob Joseph (2):
test/crypto: skip plain text compare for null cipher
common/cpt: fix KASUMI input length
Arek Kusztal (2):
crypto/qat: fix status in RSA decryption
crypto/qat: fix uncleared cookies after operation
Ben Pfaff (1):
doc: fix numbers power of 2 in LPM6 guide
Bing Zhao (2):
net/mlx5: fix flow tables double release
net/mlx5: fix RETA update without stopping device
Bruce Richardson (3):
eal/freebsd: lock memory device to prevent conflicts
test/mem: fix memory autotests on FreeBSD
eal/freebsd: ignore in-memory option
Chengchang Tang (2):
net/bonding: fix dedicated queue mode in vector burst
net/bonding: fix RSS key length
Chengfeng Ye (1):
net/axgbe: fix unreleased lock in I2C transfer
Chengwen Feng (1):
kni: check error code of allmulticast mode switch
Cian Ferriter (1):
ring: fix Doxygen comment of internal function
Ciara Loftus (1):
net/af_xdp: disable secondary process support
Ciara Power (3):
crypto/openssl: fix CCM processing 0 length source
examples/fips_validation: remove unused allocation
test/crypto: fix unnecessary stats retrieval
Conor Walsh (8):
net/hinic/base: remove some unused variables
bus/fslmc: remove unused device count
event/sw: remove unused inflight events count
net/liquidio: remove unused counter
net/qede/base: remove unused message size
net/vmxnet3: fix build with clang 13
test/distributor: remove unused counter
examples/performance-thread: remove unused hits count
Dapeng Yu (1):
net/ice: save rule on switch filter creation
Dariusz Sosnowski (2):
net/mlx5: fix MPLS tunnel outer layer overwrite
doc: fix typo in coding style
David Christensen (3):
eal/ppc: ignore GCC 10 stringop-overflow warnings
config/ppc: ignore GCC 11 psabi warnings
test/atomic: fix 128-bit atomic test with many cores
David Hunt (1):
test/power: fix CPU frequency when turbo enabled
David Marchand (10):
net/virtio: avoid unneeded link interrupt configuration
net/virtio-user: fix Rx interrupts with multi-queue
bus/vmbus: fix leak on device scan
test/latency: fix loop boundary
eal/x86: fix some CPU extended features definitions
mbuf: enforce no option for dynamic fields and flags
doc: fix default mempool option in guides
eal/linux: fix uevent message parsing
test/red: fix typo in test description
examples/ntb: fix build dependency
Eli Britstein (4):
net: avoid cast-align warning in VLAN insert function
mbuf: avoid cast-align warning in data offset macro
eal/x86: avoid cast-align warning in memcpy functions
app/testpmd: fix packet burst spreading stats
Eugenio Pérez (1):
vhost: clean IOTLB cache on vring stop
Fan Zhang (1):
examples/fips_validation: fix device start
Feifei Wang (2):
drivers/net: fix typo in vector Rx comment
drivers/net: fix vector Rx comments
Ferruh Yigit (3):
net/softnic: fix useless address check
net/i40e: fix 32-bit build
ethdev: fix crash on owner delete
Gagandeep Singh (3):
common/dpaax/caamflib: fix IV for short MAC-I in SNOW3G
common/dpaax: fix physical address conversion
drivers/crypto: fix IPsec TTL decrement option
Gaoxiang Liu (1):
vhost: log socket path on adding connection
Georg Sauthoff (1):
net: fix aliasing in checksum computation
Gregory Etelson (6):
examples/multi_process: fix Rx packets distribution
net/mlx5: fix RSS expansion scheme for GRE header
app/testpmd: fix hexadecimal parser with odd length
net/mlx5: fix VXLAN-GPE next protocol translation
net/mlx5: fix GENEVE protocol type translation
net/mlx5: fix GRE protocol type translation
Haiyue Wang (1):
net/ice: fix memzone leak after device init failure
Hanumanth Reddy Pothula (1):
net/octeontx2: fix MTU when PTP is enabled
Harneet Singh (1):
examples/l3fwd-power: fix early shutdown
Harry van Haaren (1):
app/eventdev: fix terminal colour after control-c exit
Heinrich Kuhn (1):
net/nfp: fix minimum descriptor sizes
Honnappa Nagarahalli (1):
eal: reset lcore task callback and argument
Huisong Li (5):
net/hns3: fix input parameters of MAC functions
app/testpmd: retain all original dev conf when config DCB
ethdev: fix PCI device release in secondary process
net/hns3: simplify queue DMA address arithmetic
app/testpmd: remove unused header file
Hyong Youb Kim (2):
net/enic: fix filter mode detection
net/enic: avoid error message when no advanced filtering
Ivan Ilchenko (2):
net/virtio: fix mbuf count on Rx queue setup
ethdev: fix xstats by ID API documentation
Jerin Jacob (1):
examples/performance-thread: fix build with clang 12.0.1
Jiawei Wang (1):
net/mlx5: fix metadata and meter split shared tag
Jie Wang (2):
net/i40e: fix forward outer IPv6 VXLAN
app/testpmd: fix DCB in VT configuration
Jim Harris (2):
eal/linux: remove unused variable for socket memory
power: fix build with clang 13
Joyce Kong (2):
test/service: fix some comment
test/func_reentrancy: free memzones after test
Julien Meunier (2):
stack: fix reload head when pop fails
net/ixgbe: fix queue release
Junxiao Shi (1):
net/memif: fix chained mbuf determination
Kai Ji (1):
test/crypto: fix data lengths
Kalesh AP (5):
net/bnxt: fix ring group free
net/bnxt: fix double allocation of ring groups
net/bnxt: fix function driver register/unregister
net/bnxt: check FW capability for VLAN offloads
net/bnxt: fix VLAN indication in Rx mbuf
Kevin Traynor (2):
bitrate: fix registration to match API description
bitrate: fix calculation to match API description
Konstantin Ananyev (2):
test/bpf: fix undefined behavior with clang
test: fix ring PMD initialisation
Kumara Parameshwaran (1):
net/failsafe: fix secondary process probe
Lance Richardson (1):
net: fix checksum API documentation
Li Feng (1):
vhost: add sanity check on inflight last index
Long Li (1):
bus/vmbus: fix ring buffer mapping in secondary process
Maciej Szwed (1):
interrupt: fix request notifier interrupt processing
Maxime Coquelin (3):
app/testpmd: fix RSS key length
app/testpmd: fix RSS type display
net/mlx5: fix RSS RETA update
Michal Krawczyk (4):
net/ena: fix offload capabilities verification
net/ena: fix per-queue offload capabilities
net/ena: advertise scattered Rx capability
Revert "net/ena: trigger reset on Tx prepare failure"
Naga Harish K S V (2):
eventdev/eth_rx: fix WRR buffer overrun
eventdev/eth_tx: fix queue delete logic
Nithin Dabilpuram (2):
app/testpmd: fix check without outer checksum
app/testpmd: fix dump of Tx offload flags
Olivier Matz (1):
mem: fix dynamic hugepage mapping in container
Pablo de Lara (1):
efd: allow more CPU sockets in table creation
Przemyslaw Zegan (2):
app/crypto-perf: fix AAD template copy overrun
common/qat: fix queue pairs number
Qi Zhang (1):
net/ice/base: fix typo in comment
Qiming Chen (12):
net/ixgbe: fix Rx multicast statistics after reset
net/pcap: fix resource leakage on port probe
net/ixgbe: fix hash handle leak
net/ixgbe: fix queue resource leak
net/ixgbe: fix MAC resource leak
net/ixgbe: fix mbuf leak
net/i40e: fix mbuf leak
net/i40e: fix device startup resource release
net/iavf: fix mbuf leak
net/i40e/base: fix resource leakage
net/iavf: fix Rx queue buffer size alignment
common/iavf: fix ARQ resource leak
Rebecca Troy (1):
test/compress: fix buffer overflow
Robin Zhang (7):
net/i40e/base: fix PHY identifiers for 2.5G and 5G adapters
net/i40e/base: fix PF reset
net/i40e/base: fix update link data for X722
net/i40e/base: fix AOC media type
net/i40e/base: fix function name in comments
net/i40e/base: fix potentially uninitialized variables
net/i40e/base: fix using checksum before check
Ruifeng Wang (3):
examples/service_cores: fix lcore count check
net/i40e: fix risk in descriptor read in NEON Rx
net/i40e: fix risk in descriptor read in scalar Rx
Sean Morrissey (3):
remove repeated 'the' in the code
fix PMD wording
doc: capitalise PMD
Shijith Thotton (2):
test/event_crypto: fix event crypto metadata write
test/event: fix timer adapter creation test
Somnath Kotur (1):
net/bnxt: fix Rx next consumer index in mbuf alloc fail
Stephen Hemminger (4):
mbuf: fix typo in comment
bpf: allow self-xor operation
net/bnxt: fix firmware version query
fix spelling in comments and doxygen
Sunil Kumar Kori (1):
app/testpmd: fix access to DSCP table entries
Thomas Monjalon (2):
net/qede: fix minsize build
doc: remove repeated repeated words
Timothy Redaelli (1):
doc: strip build artefacts for examples file list
Tudor Cornea (3):
net/iavf: fix overflow in maximum packet length config
net/af_packet: fix ignoring full ring on Tx
net/ixgbe: fix port initialization if MTU config fails
Vanshika Shukla (1):
examples/ptpclient: fix delay request message
Viacheslav Ovsiienko (2):
app/testpmd: fix hex string parser in flow commands
doc: describe timestamp limitations for mlx5
Vladimir Medvedkin (3):
hash: fix Doxygen comment of Toeplitz file
lpm6: fix buffer overflow
rib: fix IPv6 depth mask
William Tu (1):
doc: fix emulated device names in e1000 guide
Xiaoyu Min (1):
net/mlx4: fix empty Ethernet spec with VLAN
Xuan Ding (1):
net/virtio: fix indirect descriptor reconnection
Xueming Li (2):
eal: fix device iterator when no bus is selected
net/mlx5: fix Altivec Rx
Yunjian Wang (1):
net/ice: fix memzone leak on queue re-configure
Yury Kylulin (1):
net/i40e: support 25G AOC/ACC cables
Zhihong Peng (1):
examples/performance-thread: fix build with ASan
Zhihong Wang (1):
app/testpmd: fix Tx retry in flowgen engine
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-09 14:43 19.11.11 patches review and test christian.ehrhardt
@ 2021-12-13 4:14 ` Kalesh Anakkur Purayil
2021-12-13 11:06 ` Ferruh Yigit
2021-12-14 7:14 ` Jiang, YuX
2021-12-14 13:51 ` Pei Zhang
2 siblings, 1 reply; 33+ messages in thread
From: Kalesh Anakkur Purayil @ 2021-12-13 4:14 UTC (permalink / raw)
To: Christian Ehrhardt
Cc: dpdk stable, dpdk-dev, Abhishek Marathe, Akhil Goyal,
Ali Alnubani, benjamin.walker, David Christensen,
Hariprasad Govindharajan, Hemant Agrawal, Ian Stokes,
Jerin Jacob, John McNamara, Ju-Hyoung Lee, Kevin Traynor,
Luca Boccassi, Pei Zhang, pingx.yu, qian.q.xu, Raslan Darawsheh,
Thomas Monjalon, yuan.peng, zhaoyan.chen
[-- Attachment #1: Type: text/plain, Size: 12887 bytes --]
Hi Christian,
We still see KNI build failure on SLES15 SP3 with dpdk-stable-19.11.11-rc1.
Is there a plan to address that on 19.11.11 LTS?
Regards,
Kalesh
On Thu, Dec 9, 2021 at 8:13 PM <christian.ehrhardt@canonical.com> wrote:
> Hi all,
>
> Here is a list of patches targeted for stable release 19.11.11.
>
> The planned date for the final release is 7th January 2021.
>
> Please help with testing and validation of your use cases and report
> any issues/results with reply-all to this mail. For the final release
> the fixes and reported validations will be added to the release notes.
>
> A release candidate tarball can be found at:
>
> https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1
>
> These patches are located at branch 19.11 of dpdk-stable repo:
> https://dpdk.org/browse/dpdk-stable/
>
> Thanks.
>
> Christian Ehrhardt <christian.ehrhardt@canonical.com>
>
> ---
> Ajit Khaparde (3):
> net/bnxt: fix Tx queue startup state
> net/bnxt: fix memzone free for Tx and Rx rings
> net/bnxt: fix tunnel port accounting
>
> Alexander Bechikov (1):
> mbuf: fix dump of dynamic fields and flags
>
> Alexander Kozyrev (2):
> net/mlx5: fix GENEVE and VXLAN-GPE flow item matching
> net/mlx5: fix GRE flow item matching
>
> Alvin Zhang (1):
> net/i40e: fix Rx packet statistics
>
> Aman Singh (1):
> kni: fix build for SLES15-SP3
>
> Anatoly Burakov (2):
> vfio: fix FreeBSD clear group stub
> vfio: fix FreeBSD documentation
>
> Anoob Joseph (2):
> test/crypto: skip plain text compare for null cipher
> common/cpt: fix KASUMI input length
>
> Arek Kusztal (2):
> crypto/qat: fix status in RSA decryption
> crypto/qat: fix uncleared cookies after operation
>
> Ben Pfaff (1):
> doc: fix numbers power of 2 in LPM6 guide
>
> Bing Zhao (2):
> net/mlx5: fix flow tables double release
> net/mlx5: fix RETA update without stopping device
>
> Bruce Richardson (3):
> eal/freebsd: lock memory device to prevent conflicts
> test/mem: fix memory autotests on FreeBSD
> eal/freebsd: ignore in-memory option
>
> Chengchang Tang (2):
> net/bonding: fix dedicated queue mode in vector burst
> net/bonding: fix RSS key length
>
> Chengfeng Ye (1):
> net/axgbe: fix unreleased lock in I2C transfer
>
> Chengwen Feng (1):
> kni: check error code of allmulticast mode switch
>
> Cian Ferriter (1):
> ring: fix Doxygen comment of internal function
>
> Ciara Loftus (1):
> net/af_xdp: disable secondary process support
>
> Ciara Power (3):
> crypto/openssl: fix CCM processing 0 length source
> examples/fips_validation: remove unused allocation
> test/crypto: fix unnecessary stats retrieval
>
> Conor Walsh (8):
> net/hinic/base: remove some unused variables
> bus/fslmc: remove unused device count
> event/sw: remove unused inflight events count
> net/liquidio: remove unused counter
> net/qede/base: remove unused message size
> net/vmxnet3: fix build with clang 13
> test/distributor: remove unused counter
> examples/performance-thread: remove unused hits count
>
> Dapeng Yu (1):
> net/ice: save rule on switch filter creation
>
> Dariusz Sosnowski (2):
> net/mlx5: fix MPLS tunnel outer layer overwrite
> doc: fix typo in coding style
>
> David Christensen (3):
> eal/ppc: ignore GCC 10 stringop-overflow warnings
> config/ppc: ignore GCC 11 psabi warnings
> test/atomic: fix 128-bit atomic test with many cores
>
> David Hunt (1):
> test/power: fix CPU frequency when turbo enabled
>
> David Marchand (10):
> net/virtio: avoid unneeded link interrupt configuration
> net/virtio-user: fix Rx interrupts with multi-queue
> bus/vmbus: fix leak on device scan
> test/latency: fix loop boundary
> eal/x86: fix some CPU extended features definitions
> mbuf: enforce no option for dynamic fields and flags
> doc: fix default mempool option in guides
> eal/linux: fix uevent message parsing
> test/red: fix typo in test description
> examples/ntb: fix build dependency
>
> Eli Britstein (4):
> net: avoid cast-align warning in VLAN insert function
> mbuf: avoid cast-align warning in data offset macro
> eal/x86: avoid cast-align warning in memcpy functions
> app/testpmd: fix packet burst spreading stats
>
> Eugenio Pérez (1):
> vhost: clean IOTLB cache on vring stop
>
> Fan Zhang (1):
> examples/fips_validation: fix device start
>
> Feifei Wang (2):
> drivers/net: fix typo in vector Rx comment
> drivers/net: fix vector Rx comments
>
> Ferruh Yigit (3):
> net/softnic: fix useless address check
> net/i40e: fix 32-bit build
> ethdev: fix crash on owner delete
>
> Gagandeep Singh (3):
> common/dpaax/caamflib: fix IV for short MAC-I in SNOW3G
> common/dpaax: fix physical address conversion
> drivers/crypto: fix IPsec TTL decrement option
>
> Gaoxiang Liu (1):
> vhost: log socket path on adding connection
>
> Georg Sauthoff (1):
> net: fix aliasing in checksum computation
>
> Gregory Etelson (6):
> examples/multi_process: fix Rx packets distribution
> net/mlx5: fix RSS expansion scheme for GRE header
> app/testpmd: fix hexadecimal parser with odd length
> net/mlx5: fix VXLAN-GPE next protocol translation
> net/mlx5: fix GENEVE protocol type translation
> net/mlx5: fix GRE protocol type translation
>
> Haiyue Wang (1):
> net/ice: fix memzone leak after device init failure
>
> Hanumanth Reddy Pothula (1):
> net/octeontx2: fix MTU when PTP is enabled
>
> Harneet Singh (1):
> examples/l3fwd-power: fix early shutdown
>
> Harry van Haaren (1):
> app/eventdev: fix terminal colour after control-c exit
>
> Heinrich Kuhn (1):
> net/nfp: fix minimum descriptor sizes
>
> Honnappa Nagarahalli (1):
> eal: reset lcore task callback and argument
>
> Huisong Li (5):
> net/hns3: fix input parameters of MAC functions
> app/testpmd: retain all original dev conf when config DCB
> ethdev: fix PCI device release in secondary process
> net/hns3: simplify queue DMA address arithmetic
> app/testpmd: remove unused header file
>
> Hyong Youb Kim (2):
> net/enic: fix filter mode detection
> net/enic: avoid error message when no advanced filtering
>
> Ivan Ilchenko (2):
> net/virtio: fix mbuf count on Rx queue setup
> ethdev: fix xstats by ID API documentation
>
> Jerin Jacob (1):
> examples/performance-thread: fix build with clang 12.0.1
>
> Jiawei Wang (1):
> net/mlx5: fix metadata and meter split shared tag
>
> Jie Wang (2):
> net/i40e: fix forward outer IPv6 VXLAN
> app/testpmd: fix DCB in VT configuration
>
> Jim Harris (2):
> eal/linux: remove unused variable for socket memory
> power: fix build with clang 13
>
> Joyce Kong (2):
> test/service: fix some comment
> test/func_reentrancy: free memzones after test
>
> Julien Meunier (2):
> stack: fix reload head when pop fails
> net/ixgbe: fix queue release
>
> Junxiao Shi (1):
> net/memif: fix chained mbuf determination
>
> Kai Ji (1):
> test/crypto: fix data lengths
>
> Kalesh AP (5):
> net/bnxt: fix ring group free
> net/bnxt: fix double allocation of ring groups
> net/bnxt: fix function driver register/unregister
> net/bnxt: check FW capability for VLAN offloads
> net/bnxt: fix VLAN indication in Rx mbuf
>
> Kevin Traynor (2):
> bitrate: fix registration to match API description
> bitrate: fix calculation to match API description
>
> Konstantin Ananyev (2):
> test/bpf: fix undefined behavior with clang
> test: fix ring PMD initialisation
>
> Kumara Parameshwaran (1):
> net/failsafe: fix secondary process probe
>
> Lance Richardson (1):
> net: fix checksum API documentation
>
> Li Feng (1):
> vhost: add sanity check on inflight last index
>
> Long Li (1):
> bus/vmbus: fix ring buffer mapping in secondary process
>
> Maciej Szwed (1):
> interrupt: fix request notifier interrupt processing
>
> Maxime Coquelin (3):
> app/testpmd: fix RSS key length
> app/testpmd: fix RSS type display
> net/mlx5: fix RSS RETA update
>
> Michal Krawczyk (4):
> net/ena: fix offload capabilities verification
> net/ena: fix per-queue offload capabilities
> net/ena: advertise scattered Rx capability
> Revert "net/ena: trigger reset on Tx prepare failure"
>
> Naga Harish K S V (2):
> eventdev/eth_rx: fix WRR buffer overrun
> eventdev/eth_tx: fix queue delete logic
>
> Nithin Dabilpuram (2):
> app/testpmd: fix check without outer checksum
> app/testpmd: fix dump of Tx offload flags
>
> Olivier Matz (1):
> mem: fix dynamic hugepage mapping in container
>
> Pablo de Lara (1):
> efd: allow more CPU sockets in table creation
>
> Przemyslaw Zegan (2):
> app/crypto-perf: fix AAD template copy overrun
> common/qat: fix queue pairs number
>
> Qi Zhang (1):
> net/ice/base: fix typo in comment
>
> Qiming Chen (12):
> net/ixgbe: fix Rx multicast statistics after reset
> net/pcap: fix resource leakage on port probe
> net/ixgbe: fix hash handle leak
> net/ixgbe: fix queue resource leak
> net/ixgbe: fix MAC resource leak
> net/ixgbe: fix mbuf leak
> net/i40e: fix mbuf leak
> net/i40e: fix device startup resource release
> net/iavf: fix mbuf leak
> net/i40e/base: fix resource leakage
> net/iavf: fix Rx queue buffer size alignment
> common/iavf: fix ARQ resource leak
>
> Rebecca Troy (1):
> test/compress: fix buffer overflow
>
> Robin Zhang (7):
> net/i40e/base: fix PHY identifiers for 2.5G and 5G adapters
> net/i40e/base: fix PF reset
> net/i40e/base: fix update link data for X722
> net/i40e/base: fix AOC media type
> net/i40e/base: fix function name in comments
> net/i40e/base: fix potentially uninitialized variables
> net/i40e/base: fix using checksum before check
>
> Ruifeng Wang (3):
> examples/service_cores: fix lcore count check
> net/i40e: fix risk in descriptor read in NEON Rx
> net/i40e: fix risk in descriptor read in scalar Rx
>
> Sean Morrissey (3):
> remove repeated 'the' in the code
> fix PMD wording
> doc: capitalise PMD
>
> Shijith Thotton (2):
> test/event_crypto: fix event crypto metadata write
> test/event: fix timer adapter creation test
>
> Somnath Kotur (1):
> net/bnxt: fix Rx next consumer index in mbuf alloc fail
>
> Stephen Hemminger (4):
> mbuf: fix typo in comment
> bpf: allow self-xor operation
> net/bnxt: fix firmware version query
> fix spelling in comments and doxygen
>
> Sunil Kumar Kori (1):
> app/testpmd: fix access to DSCP table entries
>
> Thomas Monjalon (2):
> net/qede: fix minsize build
> doc: remove repeated repeated words
>
> Timothy Redaelli (1):
> doc: strip build artefacts for examples file list
>
> Tudor Cornea (3):
> net/iavf: fix overflow in maximum packet length config
> net/af_packet: fix ignoring full ring on Tx
> net/ixgbe: fix port initialization if MTU config fails
>
> Vanshika Shukla (1):
> examples/ptpclient: fix delay request message
>
> Viacheslav Ovsiienko (2):
> app/testpmd: fix hex string parser in flow commands
> doc: describe timestamp limitations for mlx5
>
> Vladimir Medvedkin (3):
> hash: fix Doxygen comment of Toeplitz file
> lpm6: fix buffer overflow
> rib: fix IPv6 depth mask
>
> William Tu (1):
> doc: fix emulated device names in e1000 guide
>
> Xiaoyu Min (1):
> net/mlx4: fix empty Ethernet spec with VLAN
>
> Xuan Ding (1):
> net/virtio: fix indirect descriptor reconnection
>
> Xueming Li (2):
> eal: fix device iterator when no bus is selected
> net/mlx5: fix Altivec Rx
>
> Yunjian Wang (1):
> net/ice: fix memzone leak on queue re-configure
>
> Yury Kylulin (1):
> net/i40e: support 25G AOC/ACC cables
>
> Zhihong Peng (1):
> examples/performance-thread: fix build with ASan
>
> Zhihong Wang (1):
> app/testpmd: fix Tx retry in flowgen engine
>
--
Regards,
Kalesh A P
[-- Attachment #2: Type: text/html, Size: 15044 bytes --]
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-13 4:14 ` Kalesh Anakkur Purayil
@ 2021-12-13 11:06 ` Ferruh Yigit
2021-12-13 12:39 ` Christian Ehrhardt
0 siblings, 1 reply; 33+ messages in thread
From: Ferruh Yigit @ 2021-12-13 11:06 UTC (permalink / raw)
To: Kalesh Anakkur Purayil, Christian Ehrhardt
Cc: dpdk stable, dpdk-dev, Abhishek Marathe, Akhil Goyal,
Ali Alnubani, benjamin.walker, David Christensen,
Hariprasad Govindharajan, Hemant Agrawal, Ian Stokes,
Jerin Jacob, John McNamara, Ju-Hyoung Lee, Kevin Traynor,
Luca Boccassi, Pei Zhang, pingx.yu, qian.q.xu, Raslan Darawsheh,
Thomas Monjalon, yuan.peng, zhaoyan.chen
On 12/13/2021 4:14 AM, Kalesh Anakkur Purayil wrote:
> Hi Christian,
>
> We still see KNI build failure on SLES15 SP3 with dpdk-stable-19.11.11-rc1. Is there a plan to address that on 19.11.11 LTS?
>
Hi Kalesh,
I have sent a backport patch for 20.11, can you please check if it fixes
the build for the v19.11 too?
http://inbox.dpdk.org/stable/BYAPR11MB27110B5509D1C5B999BB3AA1FE709@BYAPR11MB2711.namprd11.prod.outlook.com/T/#m3a451169c23b73d9f421fa0d7cf8da8c9f9e496f
> Regards,
> Kalesh
>
> On Thu, Dec 9, 2021 at 8:13 PM <christian.ehrhardt@canonical.com <mailto:christian.ehrhardt@canonical.com>> wrote:
>
> Hi all,
>
> Here is a list of patches targeted for stable release 19.11.11.
>
> The planned date for the final release is 7th January 2021.
>
> Please help with testing and validation of your use cases and report
> any issues/results with reply-all to this mail. For the final release
> the fixes and reported validations will be added to the release notes.
>
> A release candidate tarball can be found at:
>
> https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1 <https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1>
>
> These patches are located at branch 19.11 of dpdk-stable repo:
> https://dpdk.org/browse/dpdk-stable/ <https://dpdk.org/browse/dpdk-stable/>
>
> Thanks.
>
> Christian Ehrhardt <christian.ehrhardt@canonical.com <mailto:christian.ehrhardt@canonical.com>>
>
> ---
> Ajit Khaparde (3):
> net/bnxt: fix Tx queue startup state
> net/bnxt: fix memzone free for Tx and Rx rings
> net/bnxt: fix tunnel port accounting
>
> Alexander Bechikov (1):
> mbuf: fix dump of dynamic fields and flags
>
> Alexander Kozyrev (2):
> net/mlx5: fix GENEVE and VXLAN-GPE flow item matching
> net/mlx5: fix GRE flow item matching
>
> Alvin Zhang (1):
> net/i40e: fix Rx packet statistics
>
> Aman Singh (1):
> kni: fix build for SLES15-SP3
>
> Anatoly Burakov (2):
> vfio: fix FreeBSD clear group stub
> vfio: fix FreeBSD documentation
>
> Anoob Joseph (2):
> test/crypto: skip plain text compare for null cipher
> common/cpt: fix KASUMI input length
>
> Arek Kusztal (2):
> crypto/qat: fix status in RSA decryption
> crypto/qat: fix uncleared cookies after operation
>
> Ben Pfaff (1):
> doc: fix numbers power of 2 in LPM6 guide
>
> Bing Zhao (2):
> net/mlx5: fix flow tables double release
> net/mlx5: fix RETA update without stopping device
>
> Bruce Richardson (3):
> eal/freebsd: lock memory device to prevent conflicts
> test/mem: fix memory autotests on FreeBSD
> eal/freebsd: ignore in-memory option
>
> Chengchang Tang (2):
> net/bonding: fix dedicated queue mode in vector burst
> net/bonding: fix RSS key length
>
> Chengfeng Ye (1):
> net/axgbe: fix unreleased lock in I2C transfer
>
> Chengwen Feng (1):
> kni: check error code of allmulticast mode switch
>
> Cian Ferriter (1):
> ring: fix Doxygen comment of internal function
>
> Ciara Loftus (1):
> net/af_xdp: disable secondary process support
>
> Ciara Power (3):
> crypto/openssl: fix CCM processing 0 length source
> examples/fips_validation: remove unused allocation
> test/crypto: fix unnecessary stats retrieval
>
> Conor Walsh (8):
> net/hinic/base: remove some unused variables
> bus/fslmc: remove unused device count
> event/sw: remove unused inflight events count
> net/liquidio: remove unused counter
> net/qede/base: remove unused message size
> net/vmxnet3: fix build with clang 13
> test/distributor: remove unused counter
> examples/performance-thread: remove unused hits count
>
> Dapeng Yu (1):
> net/ice: save rule on switch filter creation
>
> Dariusz Sosnowski (2):
> net/mlx5: fix MPLS tunnel outer layer overwrite
> doc: fix typo in coding style
>
> David Christensen (3):
> eal/ppc: ignore GCC 10 stringop-overflow warnings
> config/ppc: ignore GCC 11 psabi warnings
> test/atomic: fix 128-bit atomic test with many cores
>
> David Hunt (1):
> test/power: fix CPU frequency when turbo enabled
>
> David Marchand (10):
> net/virtio: avoid unneeded link interrupt configuration
> net/virtio-user: fix Rx interrupts with multi-queue
> bus/vmbus: fix leak on device scan
> test/latency: fix loop boundary
> eal/x86: fix some CPU extended features definitions
> mbuf: enforce no option for dynamic fields and flags
> doc: fix default mempool option in guides
> eal/linux: fix uevent message parsing
> test/red: fix typo in test description
> examples/ntb: fix build dependency
>
> Eli Britstein (4):
> net: avoid cast-align warning in VLAN insert function
> mbuf: avoid cast-align warning in data offset macro
> eal/x86: avoid cast-align warning in memcpy functions
> app/testpmd: fix packet burst spreading stats
>
> Eugenio Pérez (1):
> vhost: clean IOTLB cache on vring stop
>
> Fan Zhang (1):
> examples/fips_validation: fix device start
>
> Feifei Wang (2):
> drivers/net: fix typo in vector Rx comment
> drivers/net: fix vector Rx comments
>
> Ferruh Yigit (3):
> net/softnic: fix useless address check
> net/i40e: fix 32-bit build
> ethdev: fix crash on owner delete
>
> Gagandeep Singh (3):
> common/dpaax/caamflib: fix IV for short MAC-I in SNOW3G
> common/dpaax: fix physical address conversion
> drivers/crypto: fix IPsec TTL decrement option
>
> Gaoxiang Liu (1):
> vhost: log socket path on adding connection
>
> Georg Sauthoff (1):
> net: fix aliasing in checksum computation
>
> Gregory Etelson (6):
> examples/multi_process: fix Rx packets distribution
> net/mlx5: fix RSS expansion scheme for GRE header
> app/testpmd: fix hexadecimal parser with odd length
> net/mlx5: fix VXLAN-GPE next protocol translation
> net/mlx5: fix GENEVE protocol type translation
> net/mlx5: fix GRE protocol type translation
>
> Haiyue Wang (1):
> net/ice: fix memzone leak after device init failure
>
> Hanumanth Reddy Pothula (1):
> net/octeontx2: fix MTU when PTP is enabled
>
> Harneet Singh (1):
> examples/l3fwd-power: fix early shutdown
>
> Harry van Haaren (1):
> app/eventdev: fix terminal colour after control-c exit
>
> Heinrich Kuhn (1):
> net/nfp: fix minimum descriptor sizes
>
> Honnappa Nagarahalli (1):
> eal: reset lcore task callback and argument
>
> Huisong Li (5):
> net/hns3: fix input parameters of MAC functions
> app/testpmd: retain all original dev conf when config DCB
> ethdev: fix PCI device release in secondary process
> net/hns3: simplify queue DMA address arithmetic
> app/testpmd: remove unused header file
>
> Hyong Youb Kim (2):
> net/enic: fix filter mode detection
> net/enic: avoid error message when no advanced filtering
>
> Ivan Ilchenko (2):
> net/virtio: fix mbuf count on Rx queue setup
> ethdev: fix xstats by ID API documentation
>
> Jerin Jacob (1):
> examples/performance-thread: fix build with clang 12.0.1
>
> Jiawei Wang (1):
> net/mlx5: fix metadata and meter split shared tag
>
> Jie Wang (2):
> net/i40e: fix forward outer IPv6 VXLAN
> app/testpmd: fix DCB in VT configuration
>
> Jim Harris (2):
> eal/linux: remove unused variable for socket memory
> power: fix build with clang 13
>
> Joyce Kong (2):
> test/service: fix some comment
> test/func_reentrancy: free memzones after test
>
> Julien Meunier (2):
> stack: fix reload head when pop fails
> net/ixgbe: fix queue release
>
> Junxiao Shi (1):
> net/memif: fix chained mbuf determination
>
> Kai Ji (1):
> test/crypto: fix data lengths
>
> Kalesh AP (5):
> net/bnxt: fix ring group free
> net/bnxt: fix double allocation of ring groups
> net/bnxt: fix function driver register/unregister
> net/bnxt: check FW capability for VLAN offloads
> net/bnxt: fix VLAN indication in Rx mbuf
>
> Kevin Traynor (2):
> bitrate: fix registration to match API description
> bitrate: fix calculation to match API description
>
> Konstantin Ananyev (2):
> test/bpf: fix undefined behavior with clang
> test: fix ring PMD initialisation
>
> Kumara Parameshwaran (1):
> net/failsafe: fix secondary process probe
>
> Lance Richardson (1):
> net: fix checksum API documentation
>
> Li Feng (1):
> vhost: add sanity check on inflight last index
>
> Long Li (1):
> bus/vmbus: fix ring buffer mapping in secondary process
>
> Maciej Szwed (1):
> interrupt: fix request notifier interrupt processing
>
> Maxime Coquelin (3):
> app/testpmd: fix RSS key length
> app/testpmd: fix RSS type display
> net/mlx5: fix RSS RETA update
>
> Michal Krawczyk (4):
> net/ena: fix offload capabilities verification
> net/ena: fix per-queue offload capabilities
> net/ena: advertise scattered Rx capability
> Revert "net/ena: trigger reset on Tx prepare failure"
>
> Naga Harish K S V (2):
> eventdev/eth_rx: fix WRR buffer overrun
> eventdev/eth_tx: fix queue delete logic
>
> Nithin Dabilpuram (2):
> app/testpmd: fix check without outer checksum
> app/testpmd: fix dump of Tx offload flags
>
> Olivier Matz (1):
> mem: fix dynamic hugepage mapping in container
>
> Pablo de Lara (1):
> efd: allow more CPU sockets in table creation
>
> Przemyslaw Zegan (2):
> app/crypto-perf: fix AAD template copy overrun
> common/qat: fix queue pairs number
>
> Qi Zhang (1):
> net/ice/base: fix typo in comment
>
> Qiming Chen (12):
> net/ixgbe: fix Rx multicast statistics after reset
> net/pcap: fix resource leakage on port probe
> net/ixgbe: fix hash handle leak
> net/ixgbe: fix queue resource leak
> net/ixgbe: fix MAC resource leak
> net/ixgbe: fix mbuf leak
> net/i40e: fix mbuf leak
> net/i40e: fix device startup resource release
> net/iavf: fix mbuf leak
> net/i40e/base: fix resource leakage
> net/iavf: fix Rx queue buffer size alignment
> common/iavf: fix ARQ resource leak
>
> Rebecca Troy (1):
> test/compress: fix buffer overflow
>
> Robin Zhang (7):
> net/i40e/base: fix PHY identifiers for 2.5G and 5G adapters
> net/i40e/base: fix PF reset
> net/i40e/base: fix update link data for X722
> net/i40e/base: fix AOC media type
> net/i40e/base: fix function name in comments
> net/i40e/base: fix potentially uninitialized variables
> net/i40e/base: fix using checksum before check
>
> Ruifeng Wang (3):
> examples/service_cores: fix lcore count check
> net/i40e: fix risk in descriptor read in NEON Rx
> net/i40e: fix risk in descriptor read in scalar Rx
>
> Sean Morrissey (3):
> remove repeated 'the' in the code
> fix PMD wording
> doc: capitalise PMD
>
> Shijith Thotton (2):
> test/event_crypto: fix event crypto metadata write
> test/event: fix timer adapter creation test
>
> Somnath Kotur (1):
> net/bnxt: fix Rx next consumer index in mbuf alloc fail
>
> Stephen Hemminger (4):
> mbuf: fix typo in comment
> bpf: allow self-xor operation
> net/bnxt: fix firmware version query
> fix spelling in comments and doxygen
>
> Sunil Kumar Kori (1):
> app/testpmd: fix access to DSCP table entries
>
> Thomas Monjalon (2):
> net/qede: fix minsize build
> doc: remove repeated repeated words
>
> Timothy Redaelli (1):
> doc: strip build artefacts for examples file list
>
> Tudor Cornea (3):
> net/iavf: fix overflow in maximum packet length config
> net/af_packet: fix ignoring full ring on Tx
> net/ixgbe: fix port initialization if MTU config fails
>
> Vanshika Shukla (1):
> examples/ptpclient: fix delay request message
>
> Viacheslav Ovsiienko (2):
> app/testpmd: fix hex string parser in flow commands
> doc: describe timestamp limitations for mlx5
>
> Vladimir Medvedkin (3):
> hash: fix Doxygen comment of Toeplitz file
> lpm6: fix buffer overflow
> rib: fix IPv6 depth mask
>
> William Tu (1):
> doc: fix emulated device names in e1000 guide
>
> Xiaoyu Min (1):
> net/mlx4: fix empty Ethernet spec with VLAN
>
> Xuan Ding (1):
> net/virtio: fix indirect descriptor reconnection
>
> Xueming Li (2):
> eal: fix device iterator when no bus is selected
> net/mlx5: fix Altivec Rx
>
> Yunjian Wang (1):
> net/ice: fix memzone leak on queue re-configure
>
> Yury Kylulin (1):
> net/i40e: support 25G AOC/ACC cables
>
> Zhihong Peng (1):
> examples/performance-thread: fix build with ASan
>
> Zhihong Wang (1):
> app/testpmd: fix Tx retry in flowgen engine
>
>
>
> --
> Regards,
> Kalesh A P
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-13 11:06 ` Ferruh Yigit
@ 2021-12-13 12:39 ` Christian Ehrhardt
2021-12-13 12:58 ` Ferruh Yigit
0 siblings, 1 reply; 33+ messages in thread
From: Christian Ehrhardt @ 2021-12-13 12:39 UTC (permalink / raw)
To: Ferruh Yigit
Cc: Kalesh Anakkur Purayil, dpdk stable, dpdk-dev, Abhishek Marathe,
Akhil Goyal, Ali Alnubani, benjamin.walker, David Christensen,
Hariprasad Govindharajan, Hemant Agrawal, Ian Stokes,
Jerin Jacob, John McNamara, Ju-Hyoung Lee, Kevin Traynor,
Luca Boccassi, Pei Zhang, pingx.yu, qian.q.xu, Raslan Darawsheh,
Thomas Monjalon, yuan.peng, zhaoyan.chen
On Mon, Dec 13, 2021 at 12:06 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 12/13/2021 4:14 AM, Kalesh Anakkur Purayil wrote:
> > Hi Christian,
> >
> > We still see KNI build failure on SLES15 SP3 with dpdk-stable-19.11.11-rc1. Is there a plan to address that on 19.11.11 LTS?
> >
>
> Hi Kalesh,
>
> I have sent a backport patch for 20.11, can you please check if it fixes
> the build for the v19.11 too?
>
> http://inbox.dpdk.org/stable/BYAPR11MB27110B5509D1C5B999BB3AA1FE709@BYAPR11MB2711.namprd11.prod.outlook.com/T/#m3a451169c23b73d9f421fa0d7cf8da8c9f9e496f
This patch is already applied in 19.11.11 as [1], thereby at least
without backport adaptations it surely does not fix the problem.
Comparing the upstream, the 20.11 backport and the 19.11 kernel_dir
the difference is that 19.11 currently has it inside the check for
kernel_dir.
But both get initialized from ` get_option('kernel_dir')` so either
both or none would trigger and therefore it should be ok as-is.
I'm happy to consider a fix if someone looks deeper into it and let me
know what adaptations to try.
I can also test build SLES15SP3 (before this discussion I knew it was
"still broken").
[1]: https://github.com/cpaelzer/dpdk-stable-queue/commit/6c8f6b72f28c713a7017d0db9ce95b2377ce4366
> > Regards,
> > Kalesh
> >
> > On Thu, Dec 9, 2021 at 8:13 PM <christian.ehrhardt@canonical.com <mailto:christian.ehrhardt@canonical.com>> wrote:
> >
> > Hi all,
> >
> > Here is a list of patches targeted for stable release 19.11.11.
> >
> > The planned date for the final release is 7th January 2021.
> >
> > Please help with testing and validation of your use cases and report
> > any issues/results with reply-all to this mail. For the final release
> > the fixes and reported validations will be added to the release notes.
> >
> > A release candidate tarball can be found at:
> >
> > https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1 <https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1>
> >
> > These patches are located at branch 19.11 of dpdk-stable repo:
> > https://dpdk.org/browse/dpdk-stable/ <https://dpdk.org/browse/dpdk-stable/>
> >
> > Thanks.
> >
> > Christian Ehrhardt <christian.ehrhardt@canonical.com <mailto:christian.ehrhardt@canonical.com>>
> >
> > ---
> > Ajit Khaparde (3):
> > net/bnxt: fix Tx queue startup state
> > net/bnxt: fix memzone free for Tx and Rx rings
> > net/bnxt: fix tunnel port accounting
> >
> > Alexander Bechikov (1):
> > mbuf: fix dump of dynamic fields and flags
> >
> > Alexander Kozyrev (2):
> > net/mlx5: fix GENEVE and VXLAN-GPE flow item matching
> > net/mlx5: fix GRE flow item matching
> >
> > Alvin Zhang (1):
> > net/i40e: fix Rx packet statistics
> >
> > Aman Singh (1):
> > kni: fix build for SLES15-SP3
> >
> > Anatoly Burakov (2):
> > vfio: fix FreeBSD clear group stub
> > vfio: fix FreeBSD documentation
> >
> > Anoob Joseph (2):
> > test/crypto: skip plain text compare for null cipher
> > common/cpt: fix KASUMI input length
> >
> > Arek Kusztal (2):
> > crypto/qat: fix status in RSA decryption
> > crypto/qat: fix uncleared cookies after operation
> >
> > Ben Pfaff (1):
> > doc: fix numbers power of 2 in LPM6 guide
> >
> > Bing Zhao (2):
> > net/mlx5: fix flow tables double release
> > net/mlx5: fix RETA update without stopping device
> >
> > Bruce Richardson (3):
> > eal/freebsd: lock memory device to prevent conflicts
> > test/mem: fix memory autotests on FreeBSD
> > eal/freebsd: ignore in-memory option
> >
> > Chengchang Tang (2):
> > net/bonding: fix dedicated queue mode in vector burst
> > net/bonding: fix RSS key length
> >
> > Chengfeng Ye (1):
> > net/axgbe: fix unreleased lock in I2C transfer
> >
> > Chengwen Feng (1):
> > kni: check error code of allmulticast mode switch
> >
> > Cian Ferriter (1):
> > ring: fix Doxygen comment of internal function
> >
> > Ciara Loftus (1):
> > net/af_xdp: disable secondary process support
> >
> > Ciara Power (3):
> > crypto/openssl: fix CCM processing 0 length source
> > examples/fips_validation: remove unused allocation
> > test/crypto: fix unnecessary stats retrieval
> >
> > Conor Walsh (8):
> > net/hinic/base: remove some unused variables
> > bus/fslmc: remove unused device count
> > event/sw: remove unused inflight events count
> > net/liquidio: remove unused counter
> > net/qede/base: remove unused message size
> > net/vmxnet3: fix build with clang 13
> > test/distributor: remove unused counter
> > examples/performance-thread: remove unused hits count
> >
> > Dapeng Yu (1):
> > net/ice: save rule on switch filter creation
> >
> > Dariusz Sosnowski (2):
> > net/mlx5: fix MPLS tunnel outer layer overwrite
> > doc: fix typo in coding style
> >
> > David Christensen (3):
> > eal/ppc: ignore GCC 10 stringop-overflow warnings
> > config/ppc: ignore GCC 11 psabi warnings
> > test/atomic: fix 128-bit atomic test with many cores
> >
> > David Hunt (1):
> > test/power: fix CPU frequency when turbo enabled
> >
> > David Marchand (10):
> > net/virtio: avoid unneeded link interrupt configuration
> > net/virtio-user: fix Rx interrupts with multi-queue
> > bus/vmbus: fix leak on device scan
> > test/latency: fix loop boundary
> > eal/x86: fix some CPU extended features definitions
> > mbuf: enforce no option for dynamic fields and flags
> > doc: fix default mempool option in guides
> > eal/linux: fix uevent message parsing
> > test/red: fix typo in test description
> > examples/ntb: fix build dependency
> >
> > Eli Britstein (4):
> > net: avoid cast-align warning in VLAN insert function
> > mbuf: avoid cast-align warning in data offset macro
> > eal/x86: avoid cast-align warning in memcpy functions
> > app/testpmd: fix packet burst spreading stats
> >
> > Eugenio Pérez (1):
> > vhost: clean IOTLB cache on vring stop
> >
> > Fan Zhang (1):
> > examples/fips_validation: fix device start
> >
> > Feifei Wang (2):
> > drivers/net: fix typo in vector Rx comment
> > drivers/net: fix vector Rx comments
> >
> > Ferruh Yigit (3):
> > net/softnic: fix useless address check
> > net/i40e: fix 32-bit build
> > ethdev: fix crash on owner delete
> >
> > Gagandeep Singh (3):
> > common/dpaax/caamflib: fix IV for short MAC-I in SNOW3G
> > common/dpaax: fix physical address conversion
> > drivers/crypto: fix IPsec TTL decrement option
> >
> > Gaoxiang Liu (1):
> > vhost: log socket path on adding connection
> >
> > Georg Sauthoff (1):
> > net: fix aliasing in checksum computation
> >
> > Gregory Etelson (6):
> > examples/multi_process: fix Rx packets distribution
> > net/mlx5: fix RSS expansion scheme for GRE header
> > app/testpmd: fix hexadecimal parser with odd length
> > net/mlx5: fix VXLAN-GPE next protocol translation
> > net/mlx5: fix GENEVE protocol type translation
> > net/mlx5: fix GRE protocol type translation
> >
> > Haiyue Wang (1):
> > net/ice: fix memzone leak after device init failure
> >
> > Hanumanth Reddy Pothula (1):
> > net/octeontx2: fix MTU when PTP is enabled
> >
> > Harneet Singh (1):
> > examples/l3fwd-power: fix early shutdown
> >
> > Harry van Haaren (1):
> > app/eventdev: fix terminal colour after control-c exit
> >
> > Heinrich Kuhn (1):
> > net/nfp: fix minimum descriptor sizes
> >
> > Honnappa Nagarahalli (1):
> > eal: reset lcore task callback and argument
> >
> > Huisong Li (5):
> > net/hns3: fix input parameters of MAC functions
> > app/testpmd: retain all original dev conf when config DCB
> > ethdev: fix PCI device release in secondary process
> > net/hns3: simplify queue DMA address arithmetic
> > app/testpmd: remove unused header file
> >
> > Hyong Youb Kim (2):
> > net/enic: fix filter mode detection
> > net/enic: avoid error message when no advanced filtering
> >
> > Ivan Ilchenko (2):
> > net/virtio: fix mbuf count on Rx queue setup
> > ethdev: fix xstats by ID API documentation
> >
> > Jerin Jacob (1):
> > examples/performance-thread: fix build with clang 12.0.1
> >
> > Jiawei Wang (1):
> > net/mlx5: fix metadata and meter split shared tag
> >
> > Jie Wang (2):
> > net/i40e: fix forward outer IPv6 VXLAN
> > app/testpmd: fix DCB in VT configuration
> >
> > Jim Harris (2):
> > eal/linux: remove unused variable for socket memory
> > power: fix build with clang 13
> >
> > Joyce Kong (2):
> > test/service: fix some comment
> > test/func_reentrancy: free memzones after test
> >
> > Julien Meunier (2):
> > stack: fix reload head when pop fails
> > net/ixgbe: fix queue release
> >
> > Junxiao Shi (1):
> > net/memif: fix chained mbuf determination
> >
> > Kai Ji (1):
> > test/crypto: fix data lengths
> >
> > Kalesh AP (5):
> > net/bnxt: fix ring group free
> > net/bnxt: fix double allocation of ring groups
> > net/bnxt: fix function driver register/unregister
> > net/bnxt: check FW capability for VLAN offloads
> > net/bnxt: fix VLAN indication in Rx mbuf
> >
> > Kevin Traynor (2):
> > bitrate: fix registration to match API description
> > bitrate: fix calculation to match API description
> >
> > Konstantin Ananyev (2):
> > test/bpf: fix undefined behavior with clang
> > test: fix ring PMD initialisation
> >
> > Kumara Parameshwaran (1):
> > net/failsafe: fix secondary process probe
> >
> > Lance Richardson (1):
> > net: fix checksum API documentation
> >
> > Li Feng (1):
> > vhost: add sanity check on inflight last index
> >
> > Long Li (1):
> > bus/vmbus: fix ring buffer mapping in secondary process
> >
> > Maciej Szwed (1):
> > interrupt: fix request notifier interrupt processing
> >
> > Maxime Coquelin (3):
> > app/testpmd: fix RSS key length
> > app/testpmd: fix RSS type display
> > net/mlx5: fix RSS RETA update
> >
> > Michal Krawczyk (4):
> > net/ena: fix offload capabilities verification
> > net/ena: fix per-queue offload capabilities
> > net/ena: advertise scattered Rx capability
> > Revert "net/ena: trigger reset on Tx prepare failure"
> >
> > Naga Harish K S V (2):
> > eventdev/eth_rx: fix WRR buffer overrun
> > eventdev/eth_tx: fix queue delete logic
> >
> > Nithin Dabilpuram (2):
> > app/testpmd: fix check without outer checksum
> > app/testpmd: fix dump of Tx offload flags
> >
> > Olivier Matz (1):
> > mem: fix dynamic hugepage mapping in container
> >
> > Pablo de Lara (1):
> > efd: allow more CPU sockets in table creation
> >
> > Przemyslaw Zegan (2):
> > app/crypto-perf: fix AAD template copy overrun
> > common/qat: fix queue pairs number
> >
> > Qi Zhang (1):
> > net/ice/base: fix typo in comment
> >
> > Qiming Chen (12):
> > net/ixgbe: fix Rx multicast statistics after reset
> > net/pcap: fix resource leakage on port probe
> > net/ixgbe: fix hash handle leak
> > net/ixgbe: fix queue resource leak
> > net/ixgbe: fix MAC resource leak
> > net/ixgbe: fix mbuf leak
> > net/i40e: fix mbuf leak
> > net/i40e: fix device startup resource release
> > net/iavf: fix mbuf leak
> > net/i40e/base: fix resource leakage
> > net/iavf: fix Rx queue buffer size alignment
> > common/iavf: fix ARQ resource leak
> >
> > Rebecca Troy (1):
> > test/compress: fix buffer overflow
> >
> > Robin Zhang (7):
> > net/i40e/base: fix PHY identifiers for 2.5G and 5G adapters
> > net/i40e/base: fix PF reset
> > net/i40e/base: fix update link data for X722
> > net/i40e/base: fix AOC media type
> > net/i40e/base: fix function name in comments
> > net/i40e/base: fix potentially uninitialized variables
> > net/i40e/base: fix using checksum before check
> >
> > Ruifeng Wang (3):
> > examples/service_cores: fix lcore count check
> > net/i40e: fix risk in descriptor read in NEON Rx
> > net/i40e: fix risk in descriptor read in scalar Rx
> >
> > Sean Morrissey (3):
> > remove repeated 'the' in the code
> > fix PMD wording
> > doc: capitalise PMD
> >
> > Shijith Thotton (2):
> > test/event_crypto: fix event crypto metadata write
> > test/event: fix timer adapter creation test
> >
> > Somnath Kotur (1):
> > net/bnxt: fix Rx next consumer index in mbuf alloc fail
> >
> > Stephen Hemminger (4):
> > mbuf: fix typo in comment
> > bpf: allow self-xor operation
> > net/bnxt: fix firmware version query
> > fix spelling in comments and doxygen
> >
> > Sunil Kumar Kori (1):
> > app/testpmd: fix access to DSCP table entries
> >
> > Thomas Monjalon (2):
> > net/qede: fix minsize build
> > doc: remove repeated repeated words
> >
> > Timothy Redaelli (1):
> > doc: strip build artefacts for examples file list
> >
> > Tudor Cornea (3):
> > net/iavf: fix overflow in maximum packet length config
> > net/af_packet: fix ignoring full ring on Tx
> > net/ixgbe: fix port initialization if MTU config fails
> >
> > Vanshika Shukla (1):
> > examples/ptpclient: fix delay request message
> >
> > Viacheslav Ovsiienko (2):
> > app/testpmd: fix hex string parser in flow commands
> > doc: describe timestamp limitations for mlx5
> >
> > Vladimir Medvedkin (3):
> > hash: fix Doxygen comment of Toeplitz file
> > lpm6: fix buffer overflow
> > rib: fix IPv6 depth mask
> >
> > William Tu (1):
> > doc: fix emulated device names in e1000 guide
> >
> > Xiaoyu Min (1):
> > net/mlx4: fix empty Ethernet spec with VLAN
> >
> > Xuan Ding (1):
> > net/virtio: fix indirect descriptor reconnection
> >
> > Xueming Li (2):
> > eal: fix device iterator when no bus is selected
> > net/mlx5: fix Altivec Rx
> >
> > Yunjian Wang (1):
> > net/ice: fix memzone leak on queue re-configure
> >
> > Yury Kylulin (1):
> > net/i40e: support 25G AOC/ACC cables
> >
> > Zhihong Peng (1):
> > examples/performance-thread: fix build with ASan
> >
> > Zhihong Wang (1):
> > app/testpmd: fix Tx retry in flowgen engine
> >
> >
> >
> > --
> > Regards,
> > Kalesh A P
>
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-13 12:39 ` Christian Ehrhardt
@ 2021-12-13 12:58 ` Ferruh Yigit
2021-12-13 13:32 ` Christian Ehrhardt
0 siblings, 1 reply; 33+ messages in thread
From: Ferruh Yigit @ 2021-12-13 12:58 UTC (permalink / raw)
To: Christian Ehrhardt
Cc: Kalesh Anakkur Purayil, dpdk stable, dpdk-dev, Abhishek Marathe,
Akhil Goyal, Ali Alnubani, benjamin.walker, David Christensen,
Hariprasad Govindharajan, Hemant Agrawal, Ian Stokes,
Jerin Jacob, John McNamara, Ju-Hyoung Lee, Kevin Traynor,
Luca Boccassi, Pei Zhang, pingx.yu, qian.q.xu, Raslan Darawsheh,
Thomas Monjalon, yuan.peng, zhaoyan.chen
On 12/13/2021 12:39 PM, Christian Ehrhardt wrote:
> On Mon, Dec 13, 2021 at 12:06 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> On 12/13/2021 4:14 AM, Kalesh Anakkur Purayil wrote:
>>> Hi Christian,
>>>
>>> We still see KNI build failure on SLES15 SP3 with dpdk-stable-19.11.11-rc1. Is there a plan to address that on 19.11.11 LTS?
>>>
>>
>> Hi Kalesh,
>>
>> I have sent a backport patch for 20.11, can you please check if it fixes
>> the build for the v19.11 too?
>>
>> http://inbox.dpdk.org/stable/BYAPR11MB27110B5509D1C5B999BB3AA1FE709@BYAPR11MB2711.namprd11.prod.outlook.com/T/#m3a451169c23b73d9f421fa0d7cf8da8c9f9e496f
>
> This patch is already applied in 19.11.11 as [1], thereby at least
> without backport adaptations it surely does not fix the problem.
>
It is indeed.
@Kalesh, can you please share more details related to the build error?
> Comparing the upstream, the 20.11 backport and the 19.11 kernel_dir
> the difference is that 19.11 currently has it inside the check for
> kernel_dir.
> But both get initialized from ` get_option('kernel_dir')` so either
> both or none would trigger and therefore it should be ok as-is.
>
> I'm happy to consider a fix if someone looks deeper into it and let me
> know what adaptations to try.
> I can also test build SLES15SP3 (before this discussion I knew it was
> "still broken").
>
The above fix should fix the build for SLES15SP3, are you aware of any
build error after that patch?
> [1]: https://github.com/cpaelzer/dpdk-stable-queue/commit/6c8f6b72f28c713a7017d0db9ce95b2377ce4366
>
>>> Regards,
>>> Kalesh
>>>
>>> On Thu, Dec 9, 2021 at 8:13 PM <christian.ehrhardt@canonical.com <mailto:christian.ehrhardt@canonical.com>> wrote:
>>>
>>> Hi all,
>>>
>>> Here is a list of patches targeted for stable release 19.11.11.
>>>
>>> The planned date for the final release is 7th January 2021.
>>>
>>> Please help with testing and validation of your use cases and report
>>> any issues/results with reply-all to this mail. For the final release
>>> the fixes and reported validations will be added to the release notes.
>>>
>>> A release candidate tarball can be found at:
>>>
>>> https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1 <https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1>
>>>
>>> These patches are located at branch 19.11 of dpdk-stable repo:
>>> https://dpdk.org/browse/dpdk-stable/ <https://dpdk.org/browse/dpdk-stable/>
>>>
>>> Thanks.
>>>
>>> Christian Ehrhardt <christian.ehrhardt@canonical.com <mailto:christian.ehrhardt@canonical.com>>
>>>
>>> ---
>>> Ajit Khaparde (3):
>>> net/bnxt: fix Tx queue startup state
>>> net/bnxt: fix memzone free for Tx and Rx rings
>>> net/bnxt: fix tunnel port accounting
>>>
>>> Alexander Bechikov (1):
>>> mbuf: fix dump of dynamic fields and flags
>>>
>>> Alexander Kozyrev (2):
>>> net/mlx5: fix GENEVE and VXLAN-GPE flow item matching
>>> net/mlx5: fix GRE flow item matching
>>>
>>> Alvin Zhang (1):
>>> net/i40e: fix Rx packet statistics
>>>
>>> Aman Singh (1):
>>> kni: fix build for SLES15-SP3
>>>
>>> Anatoly Burakov (2):
>>> vfio: fix FreeBSD clear group stub
>>> vfio: fix FreeBSD documentation
>>>
>>> Anoob Joseph (2):
>>> test/crypto: skip plain text compare for null cipher
>>> common/cpt: fix KASUMI input length
>>>
>>> Arek Kusztal (2):
>>> crypto/qat: fix status in RSA decryption
>>> crypto/qat: fix uncleared cookies after operation
>>>
>>> Ben Pfaff (1):
>>> doc: fix numbers power of 2 in LPM6 guide
>>>
>>> Bing Zhao (2):
>>> net/mlx5: fix flow tables double release
>>> net/mlx5: fix RETA update without stopping device
>>>
>>> Bruce Richardson (3):
>>> eal/freebsd: lock memory device to prevent conflicts
>>> test/mem: fix memory autotests on FreeBSD
>>> eal/freebsd: ignore in-memory option
>>>
>>> Chengchang Tang (2):
>>> net/bonding: fix dedicated queue mode in vector burst
>>> net/bonding: fix RSS key length
>>>
>>> Chengfeng Ye (1):
>>> net/axgbe: fix unreleased lock in I2C transfer
>>>
>>> Chengwen Feng (1):
>>> kni: check error code of allmulticast mode switch
>>>
>>> Cian Ferriter (1):
>>> ring: fix Doxygen comment of internal function
>>>
>>> Ciara Loftus (1):
>>> net/af_xdp: disable secondary process support
>>>
>>> Ciara Power (3):
>>> crypto/openssl: fix CCM processing 0 length source
>>> examples/fips_validation: remove unused allocation
>>> test/crypto: fix unnecessary stats retrieval
>>>
>>> Conor Walsh (8):
>>> net/hinic/base: remove some unused variables
>>> bus/fslmc: remove unused device count
>>> event/sw: remove unused inflight events count
>>> net/liquidio: remove unused counter
>>> net/qede/base: remove unused message size
>>> net/vmxnet3: fix build with clang 13
>>> test/distributor: remove unused counter
>>> examples/performance-thread: remove unused hits count
>>>
>>> Dapeng Yu (1):
>>> net/ice: save rule on switch filter creation
>>>
>>> Dariusz Sosnowski (2):
>>> net/mlx5: fix MPLS tunnel outer layer overwrite
>>> doc: fix typo in coding style
>>>
>>> David Christensen (3):
>>> eal/ppc: ignore GCC 10 stringop-overflow warnings
>>> config/ppc: ignore GCC 11 psabi warnings
>>> test/atomic: fix 128-bit atomic test with many cores
>>>
>>> David Hunt (1):
>>> test/power: fix CPU frequency when turbo enabled
>>>
>>> David Marchand (10):
>>> net/virtio: avoid unneeded link interrupt configuration
>>> net/virtio-user: fix Rx interrupts with multi-queue
>>> bus/vmbus: fix leak on device scan
>>> test/latency: fix loop boundary
>>> eal/x86: fix some CPU extended features definitions
>>> mbuf: enforce no option for dynamic fields and flags
>>> doc: fix default mempool option in guides
>>> eal/linux: fix uevent message parsing
>>> test/red: fix typo in test description
>>> examples/ntb: fix build dependency
>>>
>>> Eli Britstein (4):
>>> net: avoid cast-align warning in VLAN insert function
>>> mbuf: avoid cast-align warning in data offset macro
>>> eal/x86: avoid cast-align warning in memcpy functions
>>> app/testpmd: fix packet burst spreading stats
>>>
>>> Eugenio Pérez (1):
>>> vhost: clean IOTLB cache on vring stop
>>>
>>> Fan Zhang (1):
>>> examples/fips_validation: fix device start
>>>
>>> Feifei Wang (2):
>>> drivers/net: fix typo in vector Rx comment
>>> drivers/net: fix vector Rx comments
>>>
>>> Ferruh Yigit (3):
>>> net/softnic: fix useless address check
>>> net/i40e: fix 32-bit build
>>> ethdev: fix crash on owner delete
>>>
>>> Gagandeep Singh (3):
>>> common/dpaax/caamflib: fix IV for short MAC-I in SNOW3G
>>> common/dpaax: fix physical address conversion
>>> drivers/crypto: fix IPsec TTL decrement option
>>>
>>> Gaoxiang Liu (1):
>>> vhost: log socket path on adding connection
>>>
>>> Georg Sauthoff (1):
>>> net: fix aliasing in checksum computation
>>>
>>> Gregory Etelson (6):
>>> examples/multi_process: fix Rx packets distribution
>>> net/mlx5: fix RSS expansion scheme for GRE header
>>> app/testpmd: fix hexadecimal parser with odd length
>>> net/mlx5: fix VXLAN-GPE next protocol translation
>>> net/mlx5: fix GENEVE protocol type translation
>>> net/mlx5: fix GRE protocol type translation
>>>
>>> Haiyue Wang (1):
>>> net/ice: fix memzone leak after device init failure
>>>
>>> Hanumanth Reddy Pothula (1):
>>> net/octeontx2: fix MTU when PTP is enabled
>>>
>>> Harneet Singh (1):
>>> examples/l3fwd-power: fix early shutdown
>>>
>>> Harry van Haaren (1):
>>> app/eventdev: fix terminal colour after control-c exit
>>>
>>> Heinrich Kuhn (1):
>>> net/nfp: fix minimum descriptor sizes
>>>
>>> Honnappa Nagarahalli (1):
>>> eal: reset lcore task callback and argument
>>>
>>> Huisong Li (5):
>>> net/hns3: fix input parameters of MAC functions
>>> app/testpmd: retain all original dev conf when config DCB
>>> ethdev: fix PCI device release in secondary process
>>> net/hns3: simplify queue DMA address arithmetic
>>> app/testpmd: remove unused header file
>>>
>>> Hyong Youb Kim (2):
>>> net/enic: fix filter mode detection
>>> net/enic: avoid error message when no advanced filtering
>>>
>>> Ivan Ilchenko (2):
>>> net/virtio: fix mbuf count on Rx queue setup
>>> ethdev: fix xstats by ID API documentation
>>>
>>> Jerin Jacob (1):
>>> examples/performance-thread: fix build with clang 12.0.1
>>>
>>> Jiawei Wang (1):
>>> net/mlx5: fix metadata and meter split shared tag
>>>
>>> Jie Wang (2):
>>> net/i40e: fix forward outer IPv6 VXLAN
>>> app/testpmd: fix DCB in VT configuration
>>>
>>> Jim Harris (2):
>>> eal/linux: remove unused variable for socket memory
>>> power: fix build with clang 13
>>>
>>> Joyce Kong (2):
>>> test/service: fix some comment
>>> test/func_reentrancy: free memzones after test
>>>
>>> Julien Meunier (2):
>>> stack: fix reload head when pop fails
>>> net/ixgbe: fix queue release
>>>
>>> Junxiao Shi (1):
>>> net/memif: fix chained mbuf determination
>>>
>>> Kai Ji (1):
>>> test/crypto: fix data lengths
>>>
>>> Kalesh AP (5):
>>> net/bnxt: fix ring group free
>>> net/bnxt: fix double allocation of ring groups
>>> net/bnxt: fix function driver register/unregister
>>> net/bnxt: check FW capability for VLAN offloads
>>> net/bnxt: fix VLAN indication in Rx mbuf
>>>
>>> Kevin Traynor (2):
>>> bitrate: fix registration to match API description
>>> bitrate: fix calculation to match API description
>>>
>>> Konstantin Ananyev (2):
>>> test/bpf: fix undefined behavior with clang
>>> test: fix ring PMD initialisation
>>>
>>> Kumara Parameshwaran (1):
>>> net/failsafe: fix secondary process probe
>>>
>>> Lance Richardson (1):
>>> net: fix checksum API documentation
>>>
>>> Li Feng (1):
>>> vhost: add sanity check on inflight last index
>>>
>>> Long Li (1):
>>> bus/vmbus: fix ring buffer mapping in secondary process
>>>
>>> Maciej Szwed (1):
>>> interrupt: fix request notifier interrupt processing
>>>
>>> Maxime Coquelin (3):
>>> app/testpmd: fix RSS key length
>>> app/testpmd: fix RSS type display
>>> net/mlx5: fix RSS RETA update
>>>
>>> Michal Krawczyk (4):
>>> net/ena: fix offload capabilities verification
>>> net/ena: fix per-queue offload capabilities
>>> net/ena: advertise scattered Rx capability
>>> Revert "net/ena: trigger reset on Tx prepare failure"
>>>
>>> Naga Harish K S V (2):
>>> eventdev/eth_rx: fix WRR buffer overrun
>>> eventdev/eth_tx: fix queue delete logic
>>>
>>> Nithin Dabilpuram (2):
>>> app/testpmd: fix check without outer checksum
>>> app/testpmd: fix dump of Tx offload flags
>>>
>>> Olivier Matz (1):
>>> mem: fix dynamic hugepage mapping in container
>>>
>>> Pablo de Lara (1):
>>> efd: allow more CPU sockets in table creation
>>>
>>> Przemyslaw Zegan (2):
>>> app/crypto-perf: fix AAD template copy overrun
>>> common/qat: fix queue pairs number
>>>
>>> Qi Zhang (1):
>>> net/ice/base: fix typo in comment
>>>
>>> Qiming Chen (12):
>>> net/ixgbe: fix Rx multicast statistics after reset
>>> net/pcap: fix resource leakage on port probe
>>> net/ixgbe: fix hash handle leak
>>> net/ixgbe: fix queue resource leak
>>> net/ixgbe: fix MAC resource leak
>>> net/ixgbe: fix mbuf leak
>>> net/i40e: fix mbuf leak
>>> net/i40e: fix device startup resource release
>>> net/iavf: fix mbuf leak
>>> net/i40e/base: fix resource leakage
>>> net/iavf: fix Rx queue buffer size alignment
>>> common/iavf: fix ARQ resource leak
>>>
>>> Rebecca Troy (1):
>>> test/compress: fix buffer overflow
>>>
>>> Robin Zhang (7):
>>> net/i40e/base: fix PHY identifiers for 2.5G and 5G adapters
>>> net/i40e/base: fix PF reset
>>> net/i40e/base: fix update link data for X722
>>> net/i40e/base: fix AOC media type
>>> net/i40e/base: fix function name in comments
>>> net/i40e/base: fix potentially uninitialized variables
>>> net/i40e/base: fix using checksum before check
>>>
>>> Ruifeng Wang (3):
>>> examples/service_cores: fix lcore count check
>>> net/i40e: fix risk in descriptor read in NEON Rx
>>> net/i40e: fix risk in descriptor read in scalar Rx
>>>
>>> Sean Morrissey (3):
>>> remove repeated 'the' in the code
>>> fix PMD wording
>>> doc: capitalise PMD
>>>
>>> Shijith Thotton (2):
>>> test/event_crypto: fix event crypto metadata write
>>> test/event: fix timer adapter creation test
>>>
>>> Somnath Kotur (1):
>>> net/bnxt: fix Rx next consumer index in mbuf alloc fail
>>>
>>> Stephen Hemminger (4):
>>> mbuf: fix typo in comment
>>> bpf: allow self-xor operation
>>> net/bnxt: fix firmware version query
>>> fix spelling in comments and doxygen
>>>
>>> Sunil Kumar Kori (1):
>>> app/testpmd: fix access to DSCP table entries
>>>
>>> Thomas Monjalon (2):
>>> net/qede: fix minsize build
>>> doc: remove repeated repeated words
>>>
>>> Timothy Redaelli (1):
>>> doc: strip build artefacts for examples file list
>>>
>>> Tudor Cornea (3):
>>> net/iavf: fix overflow in maximum packet length config
>>> net/af_packet: fix ignoring full ring on Tx
>>> net/ixgbe: fix port initialization if MTU config fails
>>>
>>> Vanshika Shukla (1):
>>> examples/ptpclient: fix delay request message
>>>
>>> Viacheslav Ovsiienko (2):
>>> app/testpmd: fix hex string parser in flow commands
>>> doc: describe timestamp limitations for mlx5
>>>
>>> Vladimir Medvedkin (3):
>>> hash: fix Doxygen comment of Toeplitz file
>>> lpm6: fix buffer overflow
>>> rib: fix IPv6 depth mask
>>>
>>> William Tu (1):
>>> doc: fix emulated device names in e1000 guide
>>>
>>> Xiaoyu Min (1):
>>> net/mlx4: fix empty Ethernet spec with VLAN
>>>
>>> Xuan Ding (1):
>>> net/virtio: fix indirect descriptor reconnection
>>>
>>> Xueming Li (2):
>>> eal: fix device iterator when no bus is selected
>>> net/mlx5: fix Altivec Rx
>>>
>>> Yunjian Wang (1):
>>> net/ice: fix memzone leak on queue re-configure
>>>
>>> Yury Kylulin (1):
>>> net/i40e: support 25G AOC/ACC cables
>>>
>>> Zhihong Peng (1):
>>> examples/performance-thread: fix build with ASan
>>>
>>> Zhihong Wang (1):
>>> app/testpmd: fix Tx retry in flowgen engine
>>>
>>>
>>>
>>> --
>>> Regards,
>>> Kalesh A P
>>
>
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-13 12:58 ` Ferruh Yigit
@ 2021-12-13 13:32 ` Christian Ehrhardt
2021-12-13 13:49 ` Kalesh Anakkur Purayil
0 siblings, 1 reply; 33+ messages in thread
From: Christian Ehrhardt @ 2021-12-13 13:32 UTC (permalink / raw)
To: Ferruh Yigit
Cc: Kalesh Anakkur Purayil, dpdk stable, dpdk-dev, Abhishek Marathe,
Akhil Goyal, Ali Alnubani, benjamin.walker, David Christensen,
Hariprasad Govindharajan, Hemant Agrawal, Ian Stokes,
Jerin Jacob, John McNamara, Ju-Hyoung Lee, Kevin Traynor,
Luca Boccassi, Pei Zhang, pingx.yu, qian.q.xu, Raslan Darawsheh,
Thomas Monjalon, yuan.peng, zhaoyan.chen
On Mon, Dec 13, 2021 at 1:59 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 12/13/2021 12:39 PM, Christian Ehrhardt wrote:
> > On Mon, Dec 13, 2021 at 12:06 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >>
> >> On 12/13/2021 4:14 AM, Kalesh Anakkur Purayil wrote:
> >>> Hi Christian,
> >>>
> >>> We still see KNI build failure on SLES15 SP3 with dpdk-stable-19.11.11-rc1. Is there a plan to address that on 19.11.11 LTS?
> >>>
> >>
> >> Hi Kalesh,
> >>
> >> I have sent a backport patch for 20.11, can you please check if it fixes
> >> the build for the v19.11 too?
> >>
> >> http://inbox.dpdk.org/stable/BYAPR11MB27110B5509D1C5B999BB3AA1FE709@BYAPR11MB2711.namprd11.prod.outlook.com/T/#m3a451169c23b73d9f421fa0d7cf8da8c9f9e496f
> >
> > This patch is already applied in 19.11.11 as [1], thereby at least
> > without backport adaptations it surely does not fix the problem.
> >
>
> It is indeed.
>
> @Kalesh, can you please share more details related to the build error?
>
>
> > Comparing the upstream, the 20.11 backport and the 19.11 kernel_dir
> > the difference is that 19.11 currently has it inside the check for
> > kernel_dir.
> > But both get initialized from ` get_option('kernel_dir')` so either
> > both or none would trigger and therefore it should be ok as-is.
> >
> > I'm happy to consider a fix if someone looks deeper into it and let me
> > know what adaptations to try.
> > I can also test build SLES15SP3 (before this discussion I knew it was
> > "still broken").
> >
>
> The above fix should fix the build for SLES15SP3, are you aware of any
> build error after that patch?
As I said my SLES15SP3 test build kept failing [1] and it looked like
the very same issue as before.
[ 351s] CC
/home/abuild/rpmbuild/BUILD/dpdk-1638972763.ee4ce5a57/x86_64-default-linux-gcc/build/kernel/linux/igb_uio/igb_uio.mod.o
[ 351s] /home/abuild/rpmbuild/BUILD/dpdk-1638972763.ee4ce5a57/x86_64-default-linux-gcc/build/kernel/linux/kni/kni_net.c:791:20:
error: initialization from incompatible pointer type
[-Werror=incompatible-pointer-types]
[ 351s] .ndo_tx_timeout = kni_net_tx_timeout,
[ 351s] ^~~~~~~~~~~~~~~~~~
[1]: https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/SLE_15/x86_64
> > [1]: https://github.com/cpaelzer/dpdk-stable-queue/commit/6c8f6b72f28c713a7017d0db9ce95b2377ce4366
> >
> >>> Regards,
> >>> Kalesh
> >>>
> >>> On Thu, Dec 9, 2021 at 8:13 PM <christian.ehrhardt@canonical.com <mailto:christian.ehrhardt@canonical.com>> wrote:
> >>>
> >>> Hi all,
> >>>
> >>> Here is a list of patches targeted for stable release 19.11.11.
> >>>
> >>> The planned date for the final release is 7th January 2021.
> >>>
> >>> Please help with testing and validation of your use cases and report
> >>> any issues/results with reply-all to this mail. For the final release
> >>> the fixes and reported validations will be added to the release notes.
> >>>
> >>> A release candidate tarball can be found at:
> >>>
> >>> https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1 <https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1>
> >>>
> >>> These patches are located at branch 19.11 of dpdk-stable repo:
> >>> https://dpdk.org/browse/dpdk-stable/ <https://dpdk.org/browse/dpdk-stable/>
> >>>
> >>> Thanks.
> >>>
> >>> Christian Ehrhardt <christian.ehrhardt@canonical.com <mailto:christian.ehrhardt@canonical.com>>
> >>>
> >>> ---
> >>> Ajit Khaparde (3):
> >>> net/bnxt: fix Tx queue startup state
> >>> net/bnxt: fix memzone free for Tx and Rx rings
> >>> net/bnxt: fix tunnel port accounting
> >>>
> >>> Alexander Bechikov (1):
> >>> mbuf: fix dump of dynamic fields and flags
> >>>
> >>> Alexander Kozyrev (2):
> >>> net/mlx5: fix GENEVE and VXLAN-GPE flow item matching
> >>> net/mlx5: fix GRE flow item matching
> >>>
> >>> Alvin Zhang (1):
> >>> net/i40e: fix Rx packet statistics
> >>>
> >>> Aman Singh (1):
> >>> kni: fix build for SLES15-SP3
> >>>
> >>> Anatoly Burakov (2):
> >>> vfio: fix FreeBSD clear group stub
> >>> vfio: fix FreeBSD documentation
> >>>
> >>> Anoob Joseph (2):
> >>> test/crypto: skip plain text compare for null cipher
> >>> common/cpt: fix KASUMI input length
> >>>
> >>> Arek Kusztal (2):
> >>> crypto/qat: fix status in RSA decryption
> >>> crypto/qat: fix uncleared cookies after operation
> >>>
> >>> Ben Pfaff (1):
> >>> doc: fix numbers power of 2 in LPM6 guide
> >>>
> >>> Bing Zhao (2):
> >>> net/mlx5: fix flow tables double release
> >>> net/mlx5: fix RETA update without stopping device
> >>>
> >>> Bruce Richardson (3):
> >>> eal/freebsd: lock memory device to prevent conflicts
> >>> test/mem: fix memory autotests on FreeBSD
> >>> eal/freebsd: ignore in-memory option
> >>>
> >>> Chengchang Tang (2):
> >>> net/bonding: fix dedicated queue mode in vector burst
> >>> net/bonding: fix RSS key length
> >>>
> >>> Chengfeng Ye (1):
> >>> net/axgbe: fix unreleased lock in I2C transfer
> >>>
> >>> Chengwen Feng (1):
> >>> kni: check error code of allmulticast mode switch
> >>>
> >>> Cian Ferriter (1):
> >>> ring: fix Doxygen comment of internal function
> >>>
> >>> Ciara Loftus (1):
> >>> net/af_xdp: disable secondary process support
> >>>
> >>> Ciara Power (3):
> >>> crypto/openssl: fix CCM processing 0 length source
> >>> examples/fips_validation: remove unused allocation
> >>> test/crypto: fix unnecessary stats retrieval
> >>>
> >>> Conor Walsh (8):
> >>> net/hinic/base: remove some unused variables
> >>> bus/fslmc: remove unused device count
> >>> event/sw: remove unused inflight events count
> >>> net/liquidio: remove unused counter
> >>> net/qede/base: remove unused message size
> >>> net/vmxnet3: fix build with clang 13
> >>> test/distributor: remove unused counter
> >>> examples/performance-thread: remove unused hits count
> >>>
> >>> Dapeng Yu (1):
> >>> net/ice: save rule on switch filter creation
> >>>
> >>> Dariusz Sosnowski (2):
> >>> net/mlx5: fix MPLS tunnel outer layer overwrite
> >>> doc: fix typo in coding style
> >>>
> >>> David Christensen (3):
> >>> eal/ppc: ignore GCC 10 stringop-overflow warnings
> >>> config/ppc: ignore GCC 11 psabi warnings
> >>> test/atomic: fix 128-bit atomic test with many cores
> >>>
> >>> David Hunt (1):
> >>> test/power: fix CPU frequency when turbo enabled
> >>>
> >>> David Marchand (10):
> >>> net/virtio: avoid unneeded link interrupt configuration
> >>> net/virtio-user: fix Rx interrupts with multi-queue
> >>> bus/vmbus: fix leak on device scan
> >>> test/latency: fix loop boundary
> >>> eal/x86: fix some CPU extended features definitions
> >>> mbuf: enforce no option for dynamic fields and flags
> >>> doc: fix default mempool option in guides
> >>> eal/linux: fix uevent message parsing
> >>> test/red: fix typo in test description
> >>> examples/ntb: fix build dependency
> >>>
> >>> Eli Britstein (4):
> >>> net: avoid cast-align warning in VLAN insert function
> >>> mbuf: avoid cast-align warning in data offset macro
> >>> eal/x86: avoid cast-align warning in memcpy functions
> >>> app/testpmd: fix packet burst spreading stats
> >>>
> >>> Eugenio Pérez (1):
> >>> vhost: clean IOTLB cache on vring stop
> >>>
> >>> Fan Zhang (1):
> >>> examples/fips_validation: fix device start
> >>>
> >>> Feifei Wang (2):
> >>> drivers/net: fix typo in vector Rx comment
> >>> drivers/net: fix vector Rx comments
> >>>
> >>> Ferruh Yigit (3):
> >>> net/softnic: fix useless address check
> >>> net/i40e: fix 32-bit build
> >>> ethdev: fix crash on owner delete
> >>>
> >>> Gagandeep Singh (3):
> >>> common/dpaax/caamflib: fix IV for short MAC-I in SNOW3G
> >>> common/dpaax: fix physical address conversion
> >>> drivers/crypto: fix IPsec TTL decrement option
> >>>
> >>> Gaoxiang Liu (1):
> >>> vhost: log socket path on adding connection
> >>>
> >>> Georg Sauthoff (1):
> >>> net: fix aliasing in checksum computation
> >>>
> >>> Gregory Etelson (6):
> >>> examples/multi_process: fix Rx packets distribution
> >>> net/mlx5: fix RSS expansion scheme for GRE header
> >>> app/testpmd: fix hexadecimal parser with odd length
> >>> net/mlx5: fix VXLAN-GPE next protocol translation
> >>> net/mlx5: fix GENEVE protocol type translation
> >>> net/mlx5: fix GRE protocol type translation
> >>>
> >>> Haiyue Wang (1):
> >>> net/ice: fix memzone leak after device init failure
> >>>
> >>> Hanumanth Reddy Pothula (1):
> >>> net/octeontx2: fix MTU when PTP is enabled
> >>>
> >>> Harneet Singh (1):
> >>> examples/l3fwd-power: fix early shutdown
> >>>
> >>> Harry van Haaren (1):
> >>> app/eventdev: fix terminal colour after control-c exit
> >>>
> >>> Heinrich Kuhn (1):
> >>> net/nfp: fix minimum descriptor sizes
> >>>
> >>> Honnappa Nagarahalli (1):
> >>> eal: reset lcore task callback and argument
> >>>
> >>> Huisong Li (5):
> >>> net/hns3: fix input parameters of MAC functions
> >>> app/testpmd: retain all original dev conf when config DCB
> >>> ethdev: fix PCI device release in secondary process
> >>> net/hns3: simplify queue DMA address arithmetic
> >>> app/testpmd: remove unused header file
> >>>
> >>> Hyong Youb Kim (2):
> >>> net/enic: fix filter mode detection
> >>> net/enic: avoid error message when no advanced filtering
> >>>
> >>> Ivan Ilchenko (2):
> >>> net/virtio: fix mbuf count on Rx queue setup
> >>> ethdev: fix xstats by ID API documentation
> >>>
> >>> Jerin Jacob (1):
> >>> examples/performance-thread: fix build with clang 12.0.1
> >>>
> >>> Jiawei Wang (1):
> >>> net/mlx5: fix metadata and meter split shared tag
> >>>
> >>> Jie Wang (2):
> >>> net/i40e: fix forward outer IPv6 VXLAN
> >>> app/testpmd: fix DCB in VT configuration
> >>>
> >>> Jim Harris (2):
> >>> eal/linux: remove unused variable for socket memory
> >>> power: fix build with clang 13
> >>>
> >>> Joyce Kong (2):
> >>> test/service: fix some comment
> >>> test/func_reentrancy: free memzones after test
> >>>
> >>> Julien Meunier (2):
> >>> stack: fix reload head when pop fails
> >>> net/ixgbe: fix queue release
> >>>
> >>> Junxiao Shi (1):
> >>> net/memif: fix chained mbuf determination
> >>>
> >>> Kai Ji (1):
> >>> test/crypto: fix data lengths
> >>>
> >>> Kalesh AP (5):
> >>> net/bnxt: fix ring group free
> >>> net/bnxt: fix double allocation of ring groups
> >>> net/bnxt: fix function driver register/unregister
> >>> net/bnxt: check FW capability for VLAN offloads
> >>> net/bnxt: fix VLAN indication in Rx mbuf
> >>>
> >>> Kevin Traynor (2):
> >>> bitrate: fix registration to match API description
> >>> bitrate: fix calculation to match API description
> >>>
> >>> Konstantin Ananyev (2):
> >>> test/bpf: fix undefined behavior with clang
> >>> test: fix ring PMD initialisation
> >>>
> >>> Kumara Parameshwaran (1):
> >>> net/failsafe: fix secondary process probe
> >>>
> >>> Lance Richardson (1):
> >>> net: fix checksum API documentation
> >>>
> >>> Li Feng (1):
> >>> vhost: add sanity check on inflight last index
> >>>
> >>> Long Li (1):
> >>> bus/vmbus: fix ring buffer mapping in secondary process
> >>>
> >>> Maciej Szwed (1):
> >>> interrupt: fix request notifier interrupt processing
> >>>
> >>> Maxime Coquelin (3):
> >>> app/testpmd: fix RSS key length
> >>> app/testpmd: fix RSS type display
> >>> net/mlx5: fix RSS RETA update
> >>>
> >>> Michal Krawczyk (4):
> >>> net/ena: fix offload capabilities verification
> >>> net/ena: fix per-queue offload capabilities
> >>> net/ena: advertise scattered Rx capability
> >>> Revert "net/ena: trigger reset on Tx prepare failure"
> >>>
> >>> Naga Harish K S V (2):
> >>> eventdev/eth_rx: fix WRR buffer overrun
> >>> eventdev/eth_tx: fix queue delete logic
> >>>
> >>> Nithin Dabilpuram (2):
> >>> app/testpmd: fix check without outer checksum
> >>> app/testpmd: fix dump of Tx offload flags
> >>>
> >>> Olivier Matz (1):
> >>> mem: fix dynamic hugepage mapping in container
> >>>
> >>> Pablo de Lara (1):
> >>> efd: allow more CPU sockets in table creation
> >>>
> >>> Przemyslaw Zegan (2):
> >>> app/crypto-perf: fix AAD template copy overrun
> >>> common/qat: fix queue pairs number
> >>>
> >>> Qi Zhang (1):
> >>> net/ice/base: fix typo in comment
> >>>
> >>> Qiming Chen (12):
> >>> net/ixgbe: fix Rx multicast statistics after reset
> >>> net/pcap: fix resource leakage on port probe
> >>> net/ixgbe: fix hash handle leak
> >>> net/ixgbe: fix queue resource leak
> >>> net/ixgbe: fix MAC resource leak
> >>> net/ixgbe: fix mbuf leak
> >>> net/i40e: fix mbuf leak
> >>> net/i40e: fix device startup resource release
> >>> net/iavf: fix mbuf leak
> >>> net/i40e/base: fix resource leakage
> >>> net/iavf: fix Rx queue buffer size alignment
> >>> common/iavf: fix ARQ resource leak
> >>>
> >>> Rebecca Troy (1):
> >>> test/compress: fix buffer overflow
> >>>
> >>> Robin Zhang (7):
> >>> net/i40e/base: fix PHY identifiers for 2.5G and 5G adapters
> >>> net/i40e/base: fix PF reset
> >>> net/i40e/base: fix update link data for X722
> >>> net/i40e/base: fix AOC media type
> >>> net/i40e/base: fix function name in comments
> >>> net/i40e/base: fix potentially uninitialized variables
> >>> net/i40e/base: fix using checksum before check
> >>>
> >>> Ruifeng Wang (3):
> >>> examples/service_cores: fix lcore count check
> >>> net/i40e: fix risk in descriptor read in NEON Rx
> >>> net/i40e: fix risk in descriptor read in scalar Rx
> >>>
> >>> Sean Morrissey (3):
> >>> remove repeated 'the' in the code
> >>> fix PMD wording
> >>> doc: capitalise PMD
> >>>
> >>> Shijith Thotton (2):
> >>> test/event_crypto: fix event crypto metadata write
> >>> test/event: fix timer adapter creation test
> >>>
> >>> Somnath Kotur (1):
> >>> net/bnxt: fix Rx next consumer index in mbuf alloc fail
> >>>
> >>> Stephen Hemminger (4):
> >>> mbuf: fix typo in comment
> >>> bpf: allow self-xor operation
> >>> net/bnxt: fix firmware version query
> >>> fix spelling in comments and doxygen
> >>>
> >>> Sunil Kumar Kori (1):
> >>> app/testpmd: fix access to DSCP table entries
> >>>
> >>> Thomas Monjalon (2):
> >>> net/qede: fix minsize build
> >>> doc: remove repeated repeated words
> >>>
> >>> Timothy Redaelli (1):
> >>> doc: strip build artefacts for examples file list
> >>>
> >>> Tudor Cornea (3):
> >>> net/iavf: fix overflow in maximum packet length config
> >>> net/af_packet: fix ignoring full ring on Tx
> >>> net/ixgbe: fix port initialization if MTU config fails
> >>>
> >>> Vanshika Shukla (1):
> >>> examples/ptpclient: fix delay request message
> >>>
> >>> Viacheslav Ovsiienko (2):
> >>> app/testpmd: fix hex string parser in flow commands
> >>> doc: describe timestamp limitations for mlx5
> >>>
> >>> Vladimir Medvedkin (3):
> >>> hash: fix Doxygen comment of Toeplitz file
> >>> lpm6: fix buffer overflow
> >>> rib: fix IPv6 depth mask
> >>>
> >>> William Tu (1):
> >>> doc: fix emulated device names in e1000 guide
> >>>
> >>> Xiaoyu Min (1):
> >>> net/mlx4: fix empty Ethernet spec with VLAN
> >>>
> >>> Xuan Ding (1):
> >>> net/virtio: fix indirect descriptor reconnection
> >>>
> >>> Xueming Li (2):
> >>> eal: fix device iterator when no bus is selected
> >>> net/mlx5: fix Altivec Rx
> >>>
> >>> Yunjian Wang (1):
> >>> net/ice: fix memzone leak on queue re-configure
> >>>
> >>> Yury Kylulin (1):
> >>> net/i40e: support 25G AOC/ACC cables
> >>>
> >>> Zhihong Peng (1):
> >>> examples/performance-thread: fix build with ASan
> >>>
> >>> Zhihong Wang (1):
> >>> app/testpmd: fix Tx retry in flowgen engine
> >>>
> >>>
> >>>
> >>> --
> >>> Regards,
> >>> Kalesh A P
> >>
> >
> >
>
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-13 13:32 ` Christian Ehrhardt
@ 2021-12-13 13:49 ` Kalesh Anakkur Purayil
2021-12-13 14:07 ` Ferruh Yigit
0 siblings, 1 reply; 33+ messages in thread
From: Kalesh Anakkur Purayil @ 2021-12-13 13:49 UTC (permalink / raw)
To: Christian Ehrhardt
Cc: Abhishek Marathe, Akhil Goyal, Ali Alnubani, David Christensen,
Ferruh Yigit, Hariprasad Govindharajan, Hemant Agrawal,
Ian Stokes, Jerin Jacob, John McNamara, Ju-Hyoung Lee,
Kevin Traynor, Luca Boccassi, Pei Zhang, Raslan Darawsheh,
Thomas Monjalon, benjamin.walker, dpdk stable, dpdk-dev,
pingx.yu, qian.q.xu, yuan.peng, zhaoyan.chen
[-- Attachment #1.1: Type: text/plain, Size: 20123 bytes --]
Hi Christian/Ferruh,
On Mon, 13 Dec 2021 at 7:03 PM, Christian Ehrhardt <
christian.ehrhardt@canonical.com> wrote:
> On Mon, Dec 13, 2021 at 1:59 PM Ferruh Yigit <ferruh.yigit@intel.com>
> wrote:
> >
> > On 12/13/2021 12:39 PM, Christian Ehrhardt wrote:
> > > On Mon, Dec 13, 2021 at 12:06 PM Ferruh Yigit <ferruh.yigit@intel.com>
> wrote:
> > >>
> > >> On 12/13/2021 4:14 AM, Kalesh Anakkur Purayil wrote:
> > >>> Hi Christian,
> > >>>
> > >>> We still see KNI build failure on SLES15 SP3 with
> dpdk-stable-19.11.11-rc1. Is there a plan to address that on 19.11.11 LTS?
> > >>>
> > >>
> > >> Hi Kalesh,
> > >>
> > >> I have sent a backport patch for 20.11, can you please check if it
> fixes
> > >> the build for the v19.11 too?
> > >>
> > >>
> http://inbox.dpdk.org/stable/BYAPR11MB27110B5509D1C5B999BB3AA1FE709@BYAPR11MB2711.namprd11.prod.outlook.com/T/#m3a451169c23b73d9f421fa0d7cf8da8c9f9e496f
> > >
> > > This patch is already applied in 19.11.11 as [1], thereby at least
> > > without backport adaptations it surely does not fix the problem.
> > >
> >
> > It is indeed.
> >
> > @Kalesh, can you please share more details related to the build error?
> >
> >
> > > Comparing the upstream, the 20.11 backport and the 19.11 kernel_dir
> > > the difference is that 19.11 currently has it inside the check for
> > > kernel_dir.
> > > But both get initialized from ` get_option('kernel_dir')` so either
> > > both or none would trigger and therefore it should be ok as-is.
> > >
> > > I'm happy to consider a fix if someone looks deeper into it and let me
> > > know what adaptations to try.
> > > I can also test build SLES15SP3 (before this discussion I knew it was
> > > "still broken").
> > >
> >
> > The above fix should fix the build for SLES15SP3, are you aware of any
> > build error after that patch?
>
> As I said my SLES15SP3 test build kept failing [1] and it looked like
> the very same issue as before.
>
> [ 351s] CC
>
> /home/abuild/rpmbuild/BUILD/dpdk-1638972763.ee4ce5a57/x86_64-default-linux-gcc/build/kernel/linux/igb_uio/igb_uio.mod.o
> [ 351s]
> /home/abuild/rpmbuild/BUILD/dpdk-1638972763.ee4ce5a57/x86_64-default-linux-gcc/build/kernel/linux/kni/kni_net.c:791:20:
> error: initialization from incompatible pointer type
> [-Werror=incompatible-pointer-types]
> [ 351s] .ndo_tx_timeout = kni_net_tx_timeout,
> [ 351s] ^~~~~~~~~~~~~~~~~~
>
> [1]:
> https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/SLE_15/x86_64
[Kalesh] Yes, i am seeing the same error. I used make command to build
dpdk, not meson.
The back ported commit you mentioned takes care of meson build only I think.
Regards,
Kalesh
>
> <https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/SLE_15/x86_64>
>
> > > [1]:
> https://github.com/cpaelzer/dpdk-stable-queue/commit/6c8f6b72f28c713a7017d0db9ce95b2377ce4366
> > >
> > >>> Regards,
> > >>> Kalesh
> > >>>
> > >>> On Thu, Dec 9, 2021 at 8:13 PM <christian.ehrhardt@canonical.com
> <mailto:christian.ehrhardt@canonical.com>> wrote:
> > >>>
> > >>> Hi all,
> > >>>
> > >>> Here is a list of patches targeted for stable release 19.11.11.
> > >>>
> > >>> The planned date for the final release is 7th January 2021.
> > >>>
> > >>> Please help with testing and validation of your use cases and
> report
> > >>> any issues/results with reply-all to this mail. For the final
> release
> > >>> the fixes and reported validations will be added to the release
> notes.
> > >>>
> > >>> A release candidate tarball can be found at:
> > >>>
> > >>> https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1 <
> https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1>
> > >>>
> > >>> These patches are located at branch 19.11 of dpdk-stable repo:
> > >>> https://dpdk.org/browse/dpdk-stable/ <
> https://dpdk.org/browse/dpdk-stable/>
> > >>>
> > >>> Thanks.
> > >>>
> > >>> Christian Ehrhardt <christian.ehrhardt@canonical.com <mailto:
> christian.ehrhardt@canonical.com>>
> > >>>
> > >>> ---
> > >>> Ajit Khaparde (3):
> > >>> net/bnxt: fix Tx queue startup state
> > >>> net/bnxt: fix memzone free for Tx and Rx rings
> > >>> net/bnxt: fix tunnel port accounting
> > >>>
> > >>> Alexander Bechikov (1):
> > >>> mbuf: fix dump of dynamic fields and flags
> > >>>
> > >>> Alexander Kozyrev (2):
> > >>> net/mlx5: fix GENEVE and VXLAN-GPE flow item matching
> > >>> net/mlx5: fix GRE flow item matching
> > >>>
> > >>> Alvin Zhang (1):
> > >>> net/i40e: fix Rx packet statistics
> > >>>
> > >>> Aman Singh (1):
> > >>> kni: fix build for SLES15-SP3
> > >>>
> > >>> Anatoly Burakov (2):
> > >>> vfio: fix FreeBSD clear group stub
> > >>> vfio: fix FreeBSD documentation
> > >>>
> > >>> Anoob Joseph (2):
> > >>> test/crypto: skip plain text compare for null cipher
> > >>> common/cpt: fix KASUMI input length
> > >>>
> > >>> Arek Kusztal (2):
> > >>> crypto/qat: fix status in RSA decryption
> > >>> crypto/qat: fix uncleared cookies after operation
> > >>>
> > >>> Ben Pfaff (1):
> > >>> doc: fix numbers power of 2 in LPM6 guide
> > >>>
> > >>> Bing Zhao (2):
> > >>> net/mlx5: fix flow tables double release
> > >>> net/mlx5: fix RETA update without stopping device
> > >>>
> > >>> Bruce Richardson (3):
> > >>> eal/freebsd: lock memory device to prevent conflicts
> > >>> test/mem: fix memory autotests on FreeBSD
> > >>> eal/freebsd: ignore in-memory option
> > >>>
> > >>> Chengchang Tang (2):
> > >>> net/bonding: fix dedicated queue mode in vector burst
> > >>> net/bonding: fix RSS key length
> > >>>
> > >>> Chengfeng Ye (1):
> > >>> net/axgbe: fix unreleased lock in I2C transfer
> > >>>
> > >>> Chengwen Feng (1):
> > >>> kni: check error code of allmulticast mode switch
> > >>>
> > >>> Cian Ferriter (1):
> > >>> ring: fix Doxygen comment of internal function
> > >>>
> > >>> Ciara Loftus (1):
> > >>> net/af_xdp: disable secondary process support
> > >>>
> > >>> Ciara Power (3):
> > >>> crypto/openssl: fix CCM processing 0 length source
> > >>> examples/fips_validation: remove unused allocation
> > >>> test/crypto: fix unnecessary stats retrieval
> > >>>
> > >>> Conor Walsh (8):
> > >>> net/hinic/base: remove some unused variables
> > >>> bus/fslmc: remove unused device count
> > >>> event/sw: remove unused inflight events count
> > >>> net/liquidio: remove unused counter
> > >>> net/qede/base: remove unused message size
> > >>> net/vmxnet3: fix build with clang 13
> > >>> test/distributor: remove unused counter
> > >>> examples/performance-thread: remove unused hits count
> > >>>
> > >>> Dapeng Yu (1):
> > >>> net/ice: save rule on switch filter creation
> > >>>
> > >>> Dariusz Sosnowski (2):
> > >>> net/mlx5: fix MPLS tunnel outer layer overwrite
> > >>> doc: fix typo in coding style
> > >>>
> > >>> David Christensen (3):
> > >>> eal/ppc: ignore GCC 10 stringop-overflow warnings
> > >>> config/ppc: ignore GCC 11 psabi warnings
> > >>> test/atomic: fix 128-bit atomic test with many cores
> > >>>
> > >>> David Hunt (1):
> > >>> test/power: fix CPU frequency when turbo enabled
> > >>>
> > >>> David Marchand (10):
> > >>> net/virtio: avoid unneeded link interrupt configuration
> > >>> net/virtio-user: fix Rx interrupts with multi-queue
> > >>> bus/vmbus: fix leak on device scan
> > >>> test/latency: fix loop boundary
> > >>> eal/x86: fix some CPU extended features definitions
> > >>> mbuf: enforce no option for dynamic fields and flags
> > >>> doc: fix default mempool option in guides
> > >>> eal/linux: fix uevent message parsing
> > >>> test/red: fix typo in test description
> > >>> examples/ntb: fix build dependency
> > >>>
> > >>> Eli Britstein (4):
> > >>> net: avoid cast-align warning in VLAN insert function
> > >>> mbuf: avoid cast-align warning in data offset macro
> > >>> eal/x86: avoid cast-align warning in memcpy functions
> > >>> app/testpmd: fix packet burst spreading stats
> > >>>
> > >>> Eugenio Pérez (1):
> > >>> vhost: clean IOTLB cache on vring stop
> > >>>
> > >>> Fan Zhang (1):
> > >>> examples/fips_validation: fix device start
> > >>>
> > >>> Feifei Wang (2):
> > >>> drivers/net: fix typo in vector Rx comment
> > >>> drivers/net: fix vector Rx comments
> > >>>
> > >>> Ferruh Yigit (3):
> > >>> net/softnic: fix useless address check
> > >>> net/i40e: fix 32-bit build
> > >>> ethdev: fix crash on owner delete
> > >>>
> > >>> Gagandeep Singh (3):
> > >>> common/dpaax/caamflib: fix IV for short MAC-I in SNOW3G
> > >>> common/dpaax: fix physical address conversion
> > >>> drivers/crypto: fix IPsec TTL decrement option
> > >>>
> > >>> Gaoxiang Liu (1):
> > >>> vhost: log socket path on adding connection
> > >>>
> > >>> Georg Sauthoff (1):
> > >>> net: fix aliasing in checksum computation
> > >>>
> > >>> Gregory Etelson (6):
> > >>> examples/multi_process: fix Rx packets distribution
> > >>> net/mlx5: fix RSS expansion scheme for GRE header
> > >>> app/testpmd: fix hexadecimal parser with odd length
> > >>> net/mlx5: fix VXLAN-GPE next protocol translation
> > >>> net/mlx5: fix GENEVE protocol type translation
> > >>> net/mlx5: fix GRE protocol type translation
> > >>>
> > >>> Haiyue Wang (1):
> > >>> net/ice: fix memzone leak after device init failure
> > >>>
> > >>> Hanumanth Reddy Pothula (1):
> > >>> net/octeontx2: fix MTU when PTP is enabled
> > >>>
> > >>> Harneet Singh (1):
> > >>> examples/l3fwd-power: fix early shutdown
> > >>>
> > >>> Harry van Haaren (1):
> > >>> app/eventdev: fix terminal colour after control-c exit
> > >>>
> > >>> Heinrich Kuhn (1):
> > >>> net/nfp: fix minimum descriptor sizes
> > >>>
> > >>> Honnappa Nagarahalli (1):
> > >>> eal: reset lcore task callback and argument
> > >>>
> > >>> Huisong Li (5):
> > >>> net/hns3: fix input parameters of MAC functions
> > >>> app/testpmd: retain all original dev conf when config DCB
> > >>> ethdev: fix PCI device release in secondary process
> > >>> net/hns3: simplify queue DMA address arithmetic
> > >>> app/testpmd: remove unused header file
> > >>>
> > >>> Hyong Youb Kim (2):
> > >>> net/enic: fix filter mode detection
> > >>> net/enic: avoid error message when no advanced filtering
> > >>>
> > >>> Ivan Ilchenko (2):
> > >>> net/virtio: fix mbuf count on Rx queue setup
> > >>> ethdev: fix xstats by ID API documentation
> > >>>
> > >>> Jerin Jacob (1):
> > >>> examples/performance-thread: fix build with clang 12.0.1
> > >>>
> > >>> Jiawei Wang (1):
> > >>> net/mlx5: fix metadata and meter split shared tag
> > >>>
> > >>> Jie Wang (2):
> > >>> net/i40e: fix forward outer IPv6 VXLAN
> > >>> app/testpmd: fix DCB in VT configuration
> > >>>
> > >>> Jim Harris (2):
> > >>> eal/linux: remove unused variable for socket memory
> > >>> power: fix build with clang 13
> > >>>
> > >>> Joyce Kong (2):
> > >>> test/service: fix some comment
> > >>> test/func_reentrancy: free memzones after test
> > >>>
> > >>> Julien Meunier (2):
> > >>> stack: fix reload head when pop fails
> > >>> net/ixgbe: fix queue release
> > >>>
> > >>> Junxiao Shi (1):
> > >>> net/memif: fix chained mbuf determination
> > >>>
> > >>> Kai Ji (1):
> > >>> test/crypto: fix data lengths
> > >>>
> > >>> Kalesh AP (5):
> > >>> net/bnxt: fix ring group free
> > >>> net/bnxt: fix double allocation of ring groups
> > >>> net/bnxt: fix function driver register/unregister
> > >>> net/bnxt: check FW capability for VLAN offloads
> > >>> net/bnxt: fix VLAN indication in Rx mbuf
> > >>>
> > >>> Kevin Traynor (2):
> > >>> bitrate: fix registration to match API description
> > >>> bitrate: fix calculation to match API description
> > >>>
> > >>> Konstantin Ananyev (2):
> > >>> test/bpf: fix undefined behavior with clang
> > >>> test: fix ring PMD initialisation
> > >>>
> > >>> Kumara Parameshwaran (1):
> > >>> net/failsafe: fix secondary process probe
> > >>>
> > >>> Lance Richardson (1):
> > >>> net: fix checksum API documentation
> > >>>
> > >>> Li Feng (1):
> > >>> vhost: add sanity check on inflight last index
> > >>>
> > >>> Long Li (1):
> > >>> bus/vmbus: fix ring buffer mapping in secondary process
> > >>>
> > >>> Maciej Szwed (1):
> > >>> interrupt: fix request notifier interrupt processing
> > >>>
> > >>> Maxime Coquelin (3):
> > >>> app/testpmd: fix RSS key length
> > >>> app/testpmd: fix RSS type display
> > >>> net/mlx5: fix RSS RETA update
> > >>>
> > >>> Michal Krawczyk (4):
> > >>> net/ena: fix offload capabilities verification
> > >>> net/ena: fix per-queue offload capabilities
> > >>> net/ena: advertise scattered Rx capability
> > >>> Revert "net/ena: trigger reset on Tx prepare failure"
> > >>>
> > >>> Naga Harish K S V (2):
> > >>> eventdev/eth_rx: fix WRR buffer overrun
> > >>> eventdev/eth_tx: fix queue delete logic
> > >>>
> > >>> Nithin Dabilpuram (2):
> > >>> app/testpmd: fix check without outer checksum
> > >>> app/testpmd: fix dump of Tx offload flags
> > >>>
> > >>> Olivier Matz (1):
> > >>> mem: fix dynamic hugepage mapping in container
> > >>>
> > >>> Pablo de Lara (1):
> > >>> efd: allow more CPU sockets in table creation
> > >>>
> > >>> Przemyslaw Zegan (2):
> > >>> app/crypto-perf: fix AAD template copy overrun
> > >>> common/qat: fix queue pairs number
> > >>>
> > >>> Qi Zhang (1):
> > >>> net/ice/base: fix typo in comment
> > >>>
> > >>> Qiming Chen (12):
> > >>> net/ixgbe: fix Rx multicast statistics after reset
> > >>> net/pcap: fix resource leakage on port probe
> > >>> net/ixgbe: fix hash handle leak
> > >>> net/ixgbe: fix queue resource leak
> > >>> net/ixgbe: fix MAC resource leak
> > >>> net/ixgbe: fix mbuf leak
> > >>> net/i40e: fix mbuf leak
> > >>> net/i40e: fix device startup resource release
> > >>> net/iavf: fix mbuf leak
> > >>> net/i40e/base: fix resource leakage
> > >>> net/iavf: fix Rx queue buffer size alignment
> > >>> common/iavf: fix ARQ resource leak
> > >>>
> > >>> Rebecca Troy (1):
> > >>> test/compress: fix buffer overflow
> > >>>
> > >>> Robin Zhang (7):
> > >>> net/i40e/base: fix PHY identifiers for 2.5G and 5G
> adapters
> > >>> net/i40e/base: fix PF reset
> > >>> net/i40e/base: fix update link data for X722
> > >>> net/i40e/base: fix AOC media type
> > >>> net/i40e/base: fix function name in comments
> > >>> net/i40e/base: fix potentially uninitialized variables
> > >>> net/i40e/base: fix using checksum before check
> > >>>
> > >>> Ruifeng Wang (3):
> > >>> examples/service_cores: fix lcore count check
> > >>> net/i40e: fix risk in descriptor read in NEON Rx
> > >>> net/i40e: fix risk in descriptor read in scalar Rx
> > >>>
> > >>> Sean Morrissey (3):
> > >>> remove repeated 'the' in the code
> > >>> fix PMD wording
> > >>> doc: capitalise PMD
> > >>>
> > >>> Shijith Thotton (2):
> > >>> test/event_crypto: fix event crypto metadata write
> > >>> test/event: fix timer adapter creation test
> > >>>
> > >>> Somnath Kotur (1):
> > >>> net/bnxt: fix Rx next consumer index in mbuf alloc fail
> > >>>
> > >>> Stephen Hemminger (4):
> > >>> mbuf: fix typo in comment
> > >>> bpf: allow self-xor operation
> > >>> net/bnxt: fix firmware version query
> > >>> fix spelling in comments and doxygen
> > >>>
> > >>> Sunil Kumar Kori (1):
> > >>> app/testpmd: fix access to DSCP table entries
> > >>>
> > >>> Thomas Monjalon (2):
> > >>> net/qede: fix minsize build
> > >>> doc: remove repeated repeated words
> > >>>
> > >>> Timothy Redaelli (1):
> > >>> doc: strip build artefacts for examples file list
> > >>>
> > >>> Tudor Cornea (3):
> > >>> net/iavf: fix overflow in maximum packet length config
> > >>> net/af_packet: fix ignoring full ring on Tx
> > >>> net/ixgbe: fix port initialization if MTU config fails
> > >>>
> > >>> Vanshika Shukla (1):
> > >>> examples/ptpclient: fix delay request message
> > >>>
> > >>> Viacheslav Ovsiienko (2):
> > >>> app/testpmd: fix hex string parser in flow commands
> > >>> doc: describe timestamp limitations for mlx5
> > >>>
> > >>> Vladimir Medvedkin (3):
> > >>> hash: fix Doxygen comment of Toeplitz file
> > >>> lpm6: fix buffer overflow
> > >>> rib: fix IPv6 depth mask
> > >>>
> > >>> William Tu (1):
> > >>> doc: fix emulated device names in e1000 guide
> > >>>
> > >>> Xiaoyu Min (1):
> > >>> net/mlx4: fix empty Ethernet spec with VLAN
> > >>>
> > >>> Xuan Ding (1):
> > >>> net/virtio: fix indirect descriptor reconnection
> > >>>
> > >>> Xueming Li (2):
> > >>> eal: fix device iterator when no bus is selected
> > >>> net/mlx5: fix Altivec Rx
> > >>>
> > >>> Yunjian Wang (1):
> > >>> net/ice: fix memzone leak on queue re-configure
> > >>>
> > >>> Yury Kylulin (1):
> > >>> net/i40e: support 25G AOC/ACC cables
> > >>>
> > >>> Zhihong Peng (1):
> > >>> examples/performance-thread: fix build with ASan
> > >>>
> > >>> Zhihong Wang (1):
> > >>> app/testpmd: fix Tx retry in flowgen engine
> > >>>
> > >>>
> > >>>
> > >>> --
> > >>> Regards,
> > >>> Kalesh A P
> > >>
> > >
> > >
> >
>
>
> --
> Christian Ehrhardt
> Staff Engineer, Ubuntu Server
> Canonical Ltd
>
--
Regards,
Kalesh A P
[-- Attachment #1.2: Type: text/html, Size: 29703 bytes --]
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4239 bytes --]
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-13 13:49 ` Kalesh Anakkur Purayil
@ 2021-12-13 14:07 ` Ferruh Yigit
2021-12-14 5:49 ` Kalesh Anakkur Purayil
0 siblings, 1 reply; 33+ messages in thread
From: Ferruh Yigit @ 2021-12-13 14:07 UTC (permalink / raw)
To: Kalesh Anakkur Purayil, Christian Ehrhardt
Cc: Abhishek Marathe, Akhil Goyal, Ali Alnubani, David Christensen,
Hariprasad Govindharajan, Hemant Agrawal, Ian Stokes,
Jerin Jacob, John McNamara, Ju-Hyoung Lee, Kevin Traynor,
Luca Boccassi, Pei Zhang, Raslan Darawsheh, Thomas Monjalon,
benjamin.walker, dpdk stable, dpdk-dev, pingx.yu, qian.q.xu,
yuan.peng, zhaoyan.chen
On 12/13/2021 1:49 PM, Kalesh Anakkur Purayil wrote:
> Hi Christian/Ferruh,
>
> On Mon, 13 Dec 2021 at 7:03 PM, Christian Ehrhardt <christian.ehrhardt@canonical.com <mailto:christian.ehrhardt@canonical.com>> wrote:
>
> On Mon, Dec 13, 2021 at 1:59 PM Ferruh Yigit <ferruh.yigit@intel.com <mailto:ferruh.yigit@intel.com>> wrote:
> >
> > On 12/13/2021 12:39 PM, Christian Ehrhardt wrote:
> > > On Mon, Dec 13, 2021 at 12:06 PM Ferruh Yigit <ferruh.yigit@intel.com <mailto:ferruh.yigit@intel.com>> wrote:
> > >>
> > >> On 12/13/2021 4:14 AM, Kalesh Anakkur Purayil wrote:
> > >>> Hi Christian,
> > >>>
> > >>> We still see KNI build failure on SLES15 SP3 with dpdk-stable-19.11.11-rc1. Is there a plan to address that on 19.11.11 LTS?
> > >>>
> > >>
> > >> Hi Kalesh,
> > >>
> > >> I have sent a backport patch for 20.11, can you please check if it fixes
> > >> the build for the v19.11 too?
> > >>
> > >> http://inbox.dpdk.org/stable/BYAPR11MB27110B5509D1C5B999BB3AA1FE709@BYAPR11MB2711.namprd11.prod.outlook.com/T/#m3a451169c23b73d9f421fa0d7cf8da8c9f9e496f <http://inbox.dpdk.org/stable/BYAPR11MB27110B5509D1C5B999BB3AA1FE709@BYAPR11MB2711.namprd11.prod.outlook.com/T/#m3a451169c23b73d9f421fa0d7cf8da8c9f9e496f>
> > >
> > > This patch is already applied in 19.11.11 as [1], thereby at least
> > > without backport adaptations it surely does not fix the problem.
> > >
> >
> > It is indeed.
> >
> > @Kalesh, can you please share more details related to the build error?
> >
> >
> > > Comparing the upstream, the 20.11 backport and the 19.11 kernel_dir
> > > the difference is that 19.11 currently has it inside the check for
> > > kernel_dir.
> > > But both get initialized from ` get_option('kernel_dir')` so either
> > > both or none would trigger and therefore it should be ok as-is.
> > >
> > > I'm happy to consider a fix if someone looks deeper into it and let me
> > > know what adaptations to try.
> > > I can also test build SLES15SP3 (before this discussion I knew it was
> > > "still broken").
> > >
> >
> > The above fix should fix the build for SLES15SP3, are you aware of any
> > build error after that patch?
>
> As I said my SLES15SP3 test build kept failing [1] and it looked like
> the very same issue as before.
>
> [ 351s] CC
> /home/abuild/rpmbuild/BUILD/dpdk-1638972763.ee4ce5a57/x86_64-default-linux-gcc/build/kernel/linux/igb_uio/igb_uio.mod.o
> [ 351s] /home/abuild/rpmbuild/BUILD/dpdk-1638972763.ee4ce5a57/x86_64-default-linux-gcc/build/kernel/linux/kni/kni_net.c:791:20:
> error: initialization from incompatible pointer type
> [-Werror=incompatible-pointer-types]
> [ 351s] .ndo_tx_timeout = kni_net_tx_timeout,
> [ 351s] ^~~~~~~~~~~~~~~~~~
>
> [1]: https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/SLE_15/x86_64 <https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/SLE_15/x86_64>
>
> [Kalesh] Yes, i am seeing the same error. I used make command to build dpdk, not meson.
> The back ported commit you mentioned takes care of meson build only I think.
>
I see, make build is failing, and yes the fix is only for the meson.
I will check the make build and will send a fix for it.
> Regards,
> Kalesh
>
> <https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/SLE_15/x86_64>
>
> > > [1]: https://github.com/cpaelzer/dpdk-stable-queue/commit/6c8f6b72f28c713a7017d0db9ce95b2377ce4366 <https://github.com/cpaelzer/dpdk-stable-queue/commit/6c8f6b72f28c713a7017d0db9ce95b2377ce4366>
> > >
> > >>> Regards,
> > >>> Kalesh
> > >>>
> > >>> On Thu, Dec 9, 2021 at 8:13 PM <christian.ehrhardt@canonical.com <mailto:christian.ehrhardt@canonical.com> <mailto:christian.ehrhardt@canonical.com <mailto:christian.ehrhardt@canonical.com>>> wrote:
> > >>>
> > >>> Hi all,
> > >>>
> > >>> Here is a list of patches targeted for stable release 19.11.11.
> > >>>
> > >>> The planned date for the final release is 7th January 2021.
> > >>>
> > >>> Please help with testing and validation of your use cases and report
> > >>> any issues/results with reply-all to this mail. For the final release
> > >>> the fixes and reported validations will be added to the release notes.
> > >>>
> > >>> A release candidate tarball can be found at:
> > >>>
> > >>> https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1 <https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1> <https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1 <https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1>>
> > >>>
> > >>> These patches are located at branch 19.11 of dpdk-stable repo:
> > >>> https://dpdk.org/browse/dpdk-stable/ <https://dpdk.org/browse/dpdk-stable/> <https://dpdk.org/browse/dpdk-stable/ <https://dpdk.org/browse/dpdk-stable/>>
> > >>>
> > >>> Thanks.
> > >>>
> > >>> Christian Ehrhardt <christian.ehrhardt@canonical.com <mailto:christian.ehrhardt@canonical.com> <mailto:christian.ehrhardt@canonical.com <mailto:christian.ehrhardt@canonical.com>>>
> > >>>
> > >>> ---
> > >>> Ajit Khaparde (3):
> > >>> net/bnxt: fix Tx queue startup state
> > >>> net/bnxt: fix memzone free for Tx and Rx rings
> > >>> net/bnxt: fix tunnel port accounting
> > >>>
> > >>> Alexander Bechikov (1):
> > >>> mbuf: fix dump of dynamic fields and flags
> > >>>
> > >>> Alexander Kozyrev (2):
> > >>> net/mlx5: fix GENEVE and VXLAN-GPE flow item matching
> > >>> net/mlx5: fix GRE flow item matching
> > >>>
> > >>> Alvin Zhang (1):
> > >>> net/i40e: fix Rx packet statistics
> > >>>
> > >>> Aman Singh (1):
> > >>> kni: fix build for SLES15-SP3
> > >>>
> > >>> Anatoly Burakov (2):
> > >>> vfio: fix FreeBSD clear group stub
> > >>> vfio: fix FreeBSD documentation
> > >>>
> > >>> Anoob Joseph (2):
> > >>> test/crypto: skip plain text compare for null cipher
> > >>> common/cpt: fix KASUMI input length
> > >>>
> > >>> Arek Kusztal (2):
> > >>> crypto/qat: fix status in RSA decryption
> > >>> crypto/qat: fix uncleared cookies after operation
> > >>>
> > >>> Ben Pfaff (1):
> > >>> doc: fix numbers power of 2 in LPM6 guide
> > >>>
> > >>> Bing Zhao (2):
> > >>> net/mlx5: fix flow tables double release
> > >>> net/mlx5: fix RETA update without stopping device
> > >>>
> > >>> Bruce Richardson (3):
> > >>> eal/freebsd: lock memory device to prevent conflicts
> > >>> test/mem: fix memory autotests on FreeBSD
> > >>> eal/freebsd: ignore in-memory option
> > >>>
> > >>> Chengchang Tang (2):
> > >>> net/bonding: fix dedicated queue mode in vector burst
> > >>> net/bonding: fix RSS key length
> > >>>
> > >>> Chengfeng Ye (1):
> > >>> net/axgbe: fix unreleased lock in I2C transfer
> > >>>
> > >>> Chengwen Feng (1):
> > >>> kni: check error code of allmulticast mode switch
> > >>>
> > >>> Cian Ferriter (1):
> > >>> ring: fix Doxygen comment of internal function
> > >>>
> > >>> Ciara Loftus (1):
> > >>> net/af_xdp: disable secondary process support
> > >>>
> > >>> Ciara Power (3):
> > >>> crypto/openssl: fix CCM processing 0 length source
> > >>> examples/fips_validation: remove unused allocation
> > >>> test/crypto: fix unnecessary stats retrieval
> > >>>
> > >>> Conor Walsh (8):
> > >>> net/hinic/base: remove some unused variables
> > >>> bus/fslmc: remove unused device count
> > >>> event/sw: remove unused inflight events count
> > >>> net/liquidio: remove unused counter
> > >>> net/qede/base: remove unused message size
> > >>> net/vmxnet3: fix build with clang 13
> > >>> test/distributor: remove unused counter
> > >>> examples/performance-thread: remove unused hits count
> > >>>
> > >>> Dapeng Yu (1):
> > >>> net/ice: save rule on switch filter creation
> > >>>
> > >>> Dariusz Sosnowski (2):
> > >>> net/mlx5: fix MPLS tunnel outer layer overwrite
> > >>> doc: fix typo in coding style
> > >>>
> > >>> David Christensen (3):
> > >>> eal/ppc: ignore GCC 10 stringop-overflow warnings
> > >>> config/ppc: ignore GCC 11 psabi warnings
> > >>> test/atomic: fix 128-bit atomic test with many cores
> > >>>
> > >>> David Hunt (1):
> > >>> test/power: fix CPU frequency when turbo enabled
> > >>>
> > >>> David Marchand (10):
> > >>> net/virtio: avoid unneeded link interrupt configuration
> > >>> net/virtio-user: fix Rx interrupts with multi-queue
> > >>> bus/vmbus: fix leak on device scan
> > >>> test/latency: fix loop boundary
> > >>> eal/x86: fix some CPU extended features definitions
> > >>> mbuf: enforce no option for dynamic fields and flags
> > >>> doc: fix default mempool option in guides
> > >>> eal/linux: fix uevent message parsing
> > >>> test/red: fix typo in test description
> > >>> examples/ntb: fix build dependency
> > >>>
> > >>> Eli Britstein (4):
> > >>> net: avoid cast-align warning in VLAN insert function
> > >>> mbuf: avoid cast-align warning in data offset macro
> > >>> eal/x86: avoid cast-align warning in memcpy functions
> > >>> app/testpmd: fix packet burst spreading stats
> > >>>
> > >>> Eugenio Pérez (1):
> > >>> vhost: clean IOTLB cache on vring stop
> > >>>
> > >>> Fan Zhang (1):
> > >>> examples/fips_validation: fix device start
> > >>>
> > >>> Feifei Wang (2):
> > >>> drivers/net: fix typo in vector Rx comment
> > >>> drivers/net: fix vector Rx comments
> > >>>
> > >>> Ferruh Yigit (3):
> > >>> net/softnic: fix useless address check
> > >>> net/i40e: fix 32-bit build
> > >>> ethdev: fix crash on owner delete
> > >>>
> > >>> Gagandeep Singh (3):
> > >>> common/dpaax/caamflib: fix IV for short MAC-I in SNOW3G
> > >>> common/dpaax: fix physical address conversion
> > >>> drivers/crypto: fix IPsec TTL decrement option
> > >>>
> > >>> Gaoxiang Liu (1):
> > >>> vhost: log socket path on adding connection
> > >>>
> > >>> Georg Sauthoff (1):
> > >>> net: fix aliasing in checksum computation
> > >>>
> > >>> Gregory Etelson (6):
> > >>> examples/multi_process: fix Rx packets distribution
> > >>> net/mlx5: fix RSS expansion scheme for GRE header
> > >>> app/testpmd: fix hexadecimal parser with odd length
> > >>> net/mlx5: fix VXLAN-GPE next protocol translation
> > >>> net/mlx5: fix GENEVE protocol type translation
> > >>> net/mlx5: fix GRE protocol type translation
> > >>>
> > >>> Haiyue Wang (1):
> > >>> net/ice: fix memzone leak after device init failure
> > >>>
> > >>> Hanumanth Reddy Pothula (1):
> > >>> net/octeontx2: fix MTU when PTP is enabled
> > >>>
> > >>> Harneet Singh (1):
> > >>> examples/l3fwd-power: fix early shutdown
> > >>>
> > >>> Harry van Haaren (1):
> > >>> app/eventdev: fix terminal colour after control-c exit
> > >>>
> > >>> Heinrich Kuhn (1):
> > >>> net/nfp: fix minimum descriptor sizes
> > >>>
> > >>> Honnappa Nagarahalli (1):
> > >>> eal: reset lcore task callback and argument
> > >>>
> > >>> Huisong Li (5):
> > >>> net/hns3: fix input parameters of MAC functions
> > >>> app/testpmd: retain all original dev conf when config DCB
> > >>> ethdev: fix PCI device release in secondary process
> > >>> net/hns3: simplify queue DMA address arithmetic
> > >>> app/testpmd: remove unused header file
> > >>>
> > >>> Hyong Youb Kim (2):
> > >>> net/enic: fix filter mode detection
> > >>> net/enic: avoid error message when no advanced filtering
> > >>>
> > >>> Ivan Ilchenko (2):
> > >>> net/virtio: fix mbuf count on Rx queue setup
> > >>> ethdev: fix xstats by ID API documentation
> > >>>
> > >>> Jerin Jacob (1):
> > >>> examples/performance-thread: fix build with clang 12.0.1
> > >>>
> > >>> Jiawei Wang (1):
> > >>> net/mlx5: fix metadata and meter split shared tag
> > >>>
> > >>> Jie Wang (2):
> > >>> net/i40e: fix forward outer IPv6 VXLAN
> > >>> app/testpmd: fix DCB in VT configuration
> > >>>
> > >>> Jim Harris (2):
> > >>> eal/linux: remove unused variable for socket memory
> > >>> power: fix build with clang 13
> > >>>
> > >>> Joyce Kong (2):
> > >>> test/service: fix some comment
> > >>> test/func_reentrancy: free memzones after test
> > >>>
> > >>> Julien Meunier (2):
> > >>> stack: fix reload head when pop fails
> > >>> net/ixgbe: fix queue release
> > >>>
> > >>> Junxiao Shi (1):
> > >>> net/memif: fix chained mbuf determination
> > >>>
> > >>> Kai Ji (1):
> > >>> test/crypto: fix data lengths
> > >>>
> > >>> Kalesh AP (5):
> > >>> net/bnxt: fix ring group free
> > >>> net/bnxt: fix double allocation of ring groups
> > >>> net/bnxt: fix function driver register/unregister
> > >>> net/bnxt: check FW capability for VLAN offloads
> > >>> net/bnxt: fix VLAN indication in Rx mbuf
> > >>>
> > >>> Kevin Traynor (2):
> > >>> bitrate: fix registration to match API description
> > >>> bitrate: fix calculation to match API description
> > >>>
> > >>> Konstantin Ananyev (2):
> > >>> test/bpf: fix undefined behavior with clang
> > >>> test: fix ring PMD initialisation
> > >>>
> > >>> Kumara Parameshwaran (1):
> > >>> net/failsafe: fix secondary process probe
> > >>>
> > >>> Lance Richardson (1):
> > >>> net: fix checksum API documentation
> > >>>
> > >>> Li Feng (1):
> > >>> vhost: add sanity check on inflight last index
> > >>>
> > >>> Long Li (1):
> > >>> bus/vmbus: fix ring buffer mapping in secondary process
> > >>>
> > >>> Maciej Szwed (1):
> > >>> interrupt: fix request notifier interrupt processing
> > >>>
> > >>> Maxime Coquelin (3):
> > >>> app/testpmd: fix RSS key length
> > >>> app/testpmd: fix RSS type display
> > >>> net/mlx5: fix RSS RETA update
> > >>>
> > >>> Michal Krawczyk (4):
> > >>> net/ena: fix offload capabilities verification
> > >>> net/ena: fix per-queue offload capabilities
> > >>> net/ena: advertise scattered Rx capability
> > >>> Revert "net/ena: trigger reset on Tx prepare failure"
> > >>>
> > >>> Naga Harish K S V (2):
> > >>> eventdev/eth_rx: fix WRR buffer overrun
> > >>> eventdev/eth_tx: fix queue delete logic
> > >>>
> > >>> Nithin Dabilpuram (2):
> > >>> app/testpmd: fix check without outer checksum
> > >>> app/testpmd: fix dump of Tx offload flags
> > >>>
> > >>> Olivier Matz (1):
> > >>> mem: fix dynamic hugepage mapping in container
> > >>>
> > >>> Pablo de Lara (1):
> > >>> efd: allow more CPU sockets in table creation
> > >>>
> > >>> Przemyslaw Zegan (2):
> > >>> app/crypto-perf: fix AAD template copy overrun
> > >>> common/qat: fix queue pairs number
> > >>>
> > >>> Qi Zhang (1):
> > >>> net/ice/base: fix typo in comment
> > >>>
> > >>> Qiming Chen (12):
> > >>> net/ixgbe: fix Rx multicast statistics after reset
> > >>> net/pcap: fix resource leakage on port probe
> > >>> net/ixgbe: fix hash handle leak
> > >>> net/ixgbe: fix queue resource leak
> > >>> net/ixgbe: fix MAC resource leak
> > >>> net/ixgbe: fix mbuf leak
> > >>> net/i40e: fix mbuf leak
> > >>> net/i40e: fix device startup resource release
> > >>> net/iavf: fix mbuf leak
> > >>> net/i40e/base: fix resource leakage
> > >>> net/iavf: fix Rx queue buffer size alignment
> > >>> common/iavf: fix ARQ resource leak
> > >>>
> > >>> Rebecca Troy (1):
> > >>> test/compress: fix buffer overflow
> > >>>
> > >>> Robin Zhang (7):
> > >>> net/i40e/base: fix PHY identifiers for 2.5G and 5G adapters
> > >>> net/i40e/base: fix PF reset
> > >>> net/i40e/base: fix update link data for X722
> > >>> net/i40e/base: fix AOC media type
> > >>> net/i40e/base: fix function name in comments
> > >>> net/i40e/base: fix potentially uninitialized variables
> > >>> net/i40e/base: fix using checksum before check
> > >>>
> > >>> Ruifeng Wang (3):
> > >>> examples/service_cores: fix lcore count check
> > >>> net/i40e: fix risk in descriptor read in NEON Rx
> > >>> net/i40e: fix risk in descriptor read in scalar Rx
> > >>>
> > >>> Sean Morrissey (3):
> > >>> remove repeated 'the' in the code
> > >>> fix PMD wording
> > >>> doc: capitalise PMD
> > >>>
> > >>> Shijith Thotton (2):
> > >>> test/event_crypto: fix event crypto metadata write
> > >>> test/event: fix timer adapter creation test
> > >>>
> > >>> Somnath Kotur (1):
> > >>> net/bnxt: fix Rx next consumer index in mbuf alloc fail
> > >>>
> > >>> Stephen Hemminger (4):
> > >>> mbuf: fix typo in comment
> > >>> bpf: allow self-xor operation
> > >>> net/bnxt: fix firmware version query
> > >>> fix spelling in comments and doxygen
> > >>>
> > >>> Sunil Kumar Kori (1):
> > >>> app/testpmd: fix access to DSCP table entries
> > >>>
> > >>> Thomas Monjalon (2):
> > >>> net/qede: fix minsize build
> > >>> doc: remove repeated repeated words
> > >>>
> > >>> Timothy Redaelli (1):
> > >>> doc: strip build artefacts for examples file list
> > >>>
> > >>> Tudor Cornea (3):
> > >>> net/iavf: fix overflow in maximum packet length config
> > >>> net/af_packet: fix ignoring full ring on Tx
> > >>> net/ixgbe: fix port initialization if MTU config fails
> > >>>
> > >>> Vanshika Shukla (1):
> > >>> examples/ptpclient: fix delay request message
> > >>>
> > >>> Viacheslav Ovsiienko (2):
> > >>> app/testpmd: fix hex string parser in flow commands
> > >>> doc: describe timestamp limitations for mlx5
> > >>>
> > >>> Vladimir Medvedkin (3):
> > >>> hash: fix Doxygen comment of Toeplitz file
> > >>> lpm6: fix buffer overflow
> > >>> rib: fix IPv6 depth mask
> > >>>
> > >>> William Tu (1):
> > >>> doc: fix emulated device names in e1000 guide
> > >>>
> > >>> Xiaoyu Min (1):
> > >>> net/mlx4: fix empty Ethernet spec with VLAN
> > >>>
> > >>> Xuan Ding (1):
> > >>> net/virtio: fix indirect descriptor reconnection
> > >>>
> > >>> Xueming Li (2):
> > >>> eal: fix device iterator when no bus is selected
> > >>> net/mlx5: fix Altivec Rx
> > >>>
> > >>> Yunjian Wang (1):
> > >>> net/ice: fix memzone leak on queue re-configure
> > >>>
> > >>> Yury Kylulin (1):
> > >>> net/i40e: support 25G AOC/ACC cables
> > >>>
> > >>> Zhihong Peng (1):
> > >>> examples/performance-thread: fix build with ASan
> > >>>
> > >>> Zhihong Wang (1):
> > >>> app/testpmd: fix Tx retry in flowgen engine
> > >>>
> > >>>
> > >>>
> > >>> --
> > >>> Regards,
> > >>> Kalesh A P
> > >>
> > >
> > >
> >
>
>
> --
> Christian Ehrhardt
> Staff Engineer, Ubuntu Server
> Canonical Ltd
>
> --
> Regards,
> Kalesh A P
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-13 14:07 ` Ferruh Yigit
@ 2021-12-14 5:49 ` Kalesh Anakkur Purayil
2021-12-14 7:44 ` Christian Ehrhardt
0 siblings, 1 reply; 33+ messages in thread
From: Kalesh Anakkur Purayil @ 2021-12-14 5:49 UTC (permalink / raw)
To: Ferruh Yigit
Cc: Christian Ehrhardt, Abhishek Marathe, Akhil Goyal, Ali Alnubani,
David Christensen, Hariprasad Govindharajan, Hemant Agrawal,
Ian Stokes, Jerin Jacob, John McNamara, Ju-Hyoung Lee,
Kevin Traynor, Luca Boccassi, Pei Zhang, Raslan Darawsheh,
Thomas Monjalon, benjamin.walker, dpdk stable, dpdk-dev,
pingx.yu, qian.q.xu, yuan.peng, zhaoyan.chen
[-- Attachment #1: Type: text/plain, Size: 25606 bytes --]
On Mon, Dec 13, 2021 at 7:42 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 12/13/2021 1:49 PM, Kalesh Anakkur Purayil wrote:
> > Hi Christian/Ferruh,
> >
> > On Mon, 13 Dec 2021 at 7:03 PM, Christian Ehrhardt <
> christian.ehrhardt@canonical.com <mailto:christian.ehrhardt@canonical.com>>
> wrote:
> >
> > On Mon, Dec 13, 2021 at 1:59 PM Ferruh Yigit <ferruh.yigit@intel.com
> <mailto:ferruh.yigit@intel.com>> wrote:
> > >
> > > On 12/13/2021 12:39 PM, Christian Ehrhardt wrote:
> > > > On Mon, Dec 13, 2021 at 12:06 PM Ferruh Yigit <
> ferruh.yigit@intel.com <mailto:ferruh.yigit@intel.com>> wrote:
> > > >>
> > > >> On 12/13/2021 4:14 AM, Kalesh Anakkur Purayil wrote:
> > > >>> Hi Christian,
> > > >>>
> > > >>> We still see KNI build failure on SLES15 SP3 with
> dpdk-stable-19.11.11-rc1. Is there a plan to address that on 19.11.11 LTS?
> > > >>>
> > > >>
> > > >> Hi Kalesh,
> > > >>
> > > >> I have sent a backport patch for 20.11, can you please check
> if it fixes
> > > >> the build for the v19.11 too?
> > > >>
> > > >>
> http://inbox.dpdk.org/stable/BYAPR11MB27110B5509D1C5B999BB3AA1FE709@BYAPR11MB2711.namprd11.prod.outlook.com/T/#m3a451169c23b73d9f421fa0d7cf8da8c9f9e496f
> <
> http://inbox.dpdk.org/stable/BYAPR11MB27110B5509D1C5B999BB3AA1FE709@BYAPR11MB2711.namprd11.prod.outlook.com/T/#m3a451169c23b73d9f421fa0d7cf8da8c9f9e496f
> >
> > > >
> > > > This patch is already applied in 19.11.11 as [1], thereby at
> least
> > > > without backport adaptations it surely does not fix the problem.
> > > >
> > >
> > > It is indeed.
> > >
> > > @Kalesh, can you please share more details related to the build
> error?
> > >
> > >
> > > > Comparing the upstream, the 20.11 backport and the 19.11
> kernel_dir
> > > > the difference is that 19.11 currently has it inside the check
> for
> > > > kernel_dir.
> > > > But both get initialized from ` get_option('kernel_dir')` so
> either
> > > > both or none would trigger and therefore it should be ok as-is.
> > > >
> > > > I'm happy to consider a fix if someone looks deeper into it and
> let me
> > > > know what adaptations to try.
> > > > I can also test build SLES15SP3 (before this discussion I knew
> it was
> > > > "still broken").
> > > >
> > >
> > > The above fix should fix the build for SLES15SP3, are you aware
> of any
> > > build error after that patch?
> >
> > As I said my SLES15SP3 test build kept failing [1] and it looked like
> > the very same issue as before.
> >
> > [ 351s] CC
> >
> /home/abuild/rpmbuild/BUILD/dpdk-1638972763.ee4ce5a57/x86_64-default-linux-gcc/build/kernel/linux/igb_uio/igb_uio.mod.o
> > [ 351s]
> /home/abuild/rpmbuild/BUILD/dpdk-1638972763.ee4ce5a57/x86_64-default-linux-gcc/build/kernel/linux/kni/kni_net.c:791:20:
> > error: initialization from incompatible pointer type
> > [-Werror=incompatible-pointer-types]
> > [ 351s] .ndo_tx_timeout = kni_net_tx_timeout,
> > [ 351s] ^~~~~~~~~~~~~~~~~~
> >
> > [1]:
> https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/SLE_15/x86_64
> <
> https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/SLE_15/x86_64
> >
> >
> > [Kalesh] Yes, i am seeing the same error. I used make command to build
> dpdk, not meson.
> > The back ported commit you mentioned takes care of meson build only I
> think.
> >
>
> I see, make build is failing, and yes the fix is only for the meson.
> I will check the make build and will send a fix for it.
>
[Kalesh]: looks like the below changes fixes the issue. I tried only on
SLES15 SP3 and not on other SLES flavors.
diff --git a/kernel/linux/kni/Makefile b/kernel/linux/kni/Makefile
index 595bac2..bf0efab 100644
--- a/kernel/linux/kni/Makefile
+++ b/kernel/linux/kni/Makefile
@@ -16,6 +16,16 @@ MODULE_CFLAGS += -I$(RTE_OUTPUT)/include
MODULE_CFLAGS += -include $(RTE_OUTPUT)/include/rte_config.h
MODULE_CFLAGS += -Wall -Werror
+#
+# Use explicit 'source' folder for header path. In SUSE 'source' is not
linked to 'build' folder.
+#
+ifdef CONFIG_SUSE_KERNEL
+ KSRC = /lib/modules/$(shell uname -r)/source
+ ifneq ($(shell grep -A 1 "ndo_tx_timeout"
$(KSRC)/include/linux/netdevice.h | grep -o txqueue),)
+ MODULE_CFLAGS += -DHAVE_TX_TIMEOUT_TXQUEUE
+ endif
+endif
+
-include /etc/lsb-release
ifeq ($(DISTRIB_ID),Ubuntu)
Regards,
Kalesh
>
> > Regards,
> > Kalesh
> >
> > <
> https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/SLE_15/x86_64
> >
> >
> > > > [1]:
> https://github.com/cpaelzer/dpdk-stable-queue/commit/6c8f6b72f28c713a7017d0db9ce95b2377ce4366
> <
> https://github.com/cpaelzer/dpdk-stable-queue/commit/6c8f6b72f28c713a7017d0db9ce95b2377ce4366
> >
> > > >
> > > >>> Regards,
> > > >>> Kalesh
> > > >>>
> > > >>> On Thu, Dec 9, 2021 at 8:13 PM <
> christian.ehrhardt@canonical.com <mailto:christian.ehrhardt@canonical.com>
> <mailto:christian.ehrhardt@canonical.com <mailto:
> christian.ehrhardt@canonical.com>>> wrote:
> > > >>>
> > > >>> Hi all,
> > > >>>
> > > >>> Here is a list of patches targeted for stable release
> 19.11.11.
> > > >>>
> > > >>> The planned date for the final release is 7th January
> 2021.
> > > >>>
> > > >>> Please help with testing and validation of your use
> cases and report
> > > >>> any issues/results with reply-all to this mail. For the
> final release
> > > >>> the fixes and reported validations will be added to the
> release notes.
> > > >>>
> > > >>> A release candidate tarball can be found at:
> > > >>>
> > > >>> https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1 <
> https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1> <
> https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1 <
> https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1>>
> > > >>>
> > > >>> These patches are located at branch 19.11 of dpdk-stable
> repo:
> > > >>> https://dpdk.org/browse/dpdk-stable/ <
> https://dpdk.org/browse/dpdk-stable/> <
> https://dpdk.org/browse/dpdk-stable/ <https://dpdk.org/browse/dpdk-stable/
> >>
> > > >>>
> > > >>> Thanks.
> > > >>>
> > > >>> Christian Ehrhardt <christian.ehrhardt@canonical.com
> <mailto:christian.ehrhardt@canonical.com> <mailto:
> christian.ehrhardt@canonical.com <mailto:christian.ehrhardt@canonical.com
> >>>
> > > >>>
> > > >>> ---
> > > >>> Ajit Khaparde (3):
> > > >>> net/bnxt: fix Tx queue startup state
> > > >>> net/bnxt: fix memzone free for Tx and Rx rings
> > > >>> net/bnxt: fix tunnel port accounting
> > > >>>
> > > >>> Alexander Bechikov (1):
> > > >>> mbuf: fix dump of dynamic fields and flags
> > > >>>
> > > >>> Alexander Kozyrev (2):
> > > >>> net/mlx5: fix GENEVE and VXLAN-GPE flow item
> matching
> > > >>> net/mlx5: fix GRE flow item matching
> > > >>>
> > > >>> Alvin Zhang (1):
> > > >>> net/i40e: fix Rx packet statistics
> > > >>>
> > > >>> Aman Singh (1):
> > > >>> kni: fix build for SLES15-SP3
> > > >>>
> > > >>> Anatoly Burakov (2):
> > > >>> vfio: fix FreeBSD clear group stub
> > > >>> vfio: fix FreeBSD documentation
> > > >>>
> > > >>> Anoob Joseph (2):
> > > >>> test/crypto: skip plain text compare for null
> cipher
> > > >>> common/cpt: fix KASUMI input length
> > > >>>
> > > >>> Arek Kusztal (2):
> > > >>> crypto/qat: fix status in RSA decryption
> > > >>> crypto/qat: fix uncleared cookies after operation
> > > >>>
> > > >>> Ben Pfaff (1):
> > > >>> doc: fix numbers power of 2 in LPM6 guide
> > > >>>
> > > >>> Bing Zhao (2):
> > > >>> net/mlx5: fix flow tables double release
> > > >>> net/mlx5: fix RETA update without stopping device
> > > >>>
> > > >>> Bruce Richardson (3):
> > > >>> eal/freebsd: lock memory device to prevent
> conflicts
> > > >>> test/mem: fix memory autotests on FreeBSD
> > > >>> eal/freebsd: ignore in-memory option
> > > >>>
> > > >>> Chengchang Tang (2):
> > > >>> net/bonding: fix dedicated queue mode in vector
> burst
> > > >>> net/bonding: fix RSS key length
> > > >>>
> > > >>> Chengfeng Ye (1):
> > > >>> net/axgbe: fix unreleased lock in I2C transfer
> > > >>>
> > > >>> Chengwen Feng (1):
> > > >>> kni: check error code of allmulticast mode switch
> > > >>>
> > > >>> Cian Ferriter (1):
> > > >>> ring: fix Doxygen comment of internal function
> > > >>>
> > > >>> Ciara Loftus (1):
> > > >>> net/af_xdp: disable secondary process support
> > > >>>
> > > >>> Ciara Power (3):
> > > >>> crypto/openssl: fix CCM processing 0 length source
> > > >>> examples/fips_validation: remove unused allocation
> > > >>> test/crypto: fix unnecessary stats retrieval
> > > >>>
> > > >>> Conor Walsh (8):
> > > >>> net/hinic/base: remove some unused variables
> > > >>> bus/fslmc: remove unused device count
> > > >>> event/sw: remove unused inflight events count
> > > >>> net/liquidio: remove unused counter
> > > >>> net/qede/base: remove unused message size
> > > >>> net/vmxnet3: fix build with clang 13
> > > >>> test/distributor: remove unused counter
> > > >>> examples/performance-thread: remove unused hits
> count
> > > >>>
> > > >>> Dapeng Yu (1):
> > > >>> net/ice: save rule on switch filter creation
> > > >>>
> > > >>> Dariusz Sosnowski (2):
> > > >>> net/mlx5: fix MPLS tunnel outer layer overwrite
> > > >>> doc: fix typo in coding style
> > > >>>
> > > >>> David Christensen (3):
> > > >>> eal/ppc: ignore GCC 10 stringop-overflow warnings
> > > >>> config/ppc: ignore GCC 11 psabi warnings
> > > >>> test/atomic: fix 128-bit atomic test with many
> cores
> > > >>>
> > > >>> David Hunt (1):
> > > >>> test/power: fix CPU frequency when turbo enabled
> > > >>>
> > > >>> David Marchand (10):
> > > >>> net/virtio: avoid unneeded link interrupt
> configuration
> > > >>> net/virtio-user: fix Rx interrupts with
> multi-queue
> > > >>> bus/vmbus: fix leak on device scan
> > > >>> test/latency: fix loop boundary
> > > >>> eal/x86: fix some CPU extended features
> definitions
> > > >>> mbuf: enforce no option for dynamic fields and
> flags
> > > >>> doc: fix default mempool option in guides
> > > >>> eal/linux: fix uevent message parsing
> > > >>> test/red: fix typo in test description
> > > >>> examples/ntb: fix build dependency
> > > >>>
> > > >>> Eli Britstein (4):
> > > >>> net: avoid cast-align warning in VLAN insert
> function
> > > >>> mbuf: avoid cast-align warning in data offset
> macro
> > > >>> eal/x86: avoid cast-align warning in memcpy
> functions
> > > >>> app/testpmd: fix packet burst spreading stats
> > > >>>
> > > >>> Eugenio Pérez (1):
> > > >>> vhost: clean IOTLB cache on vring stop
> > > >>>
> > > >>> Fan Zhang (1):
> > > >>> examples/fips_validation: fix device start
> > > >>>
> > > >>> Feifei Wang (2):
> > > >>> drivers/net: fix typo in vector Rx comment
> > > >>> drivers/net: fix vector Rx comments
> > > >>>
> > > >>> Ferruh Yigit (3):
> > > >>> net/softnic: fix useless address check
> > > >>> net/i40e: fix 32-bit build
> > > >>> ethdev: fix crash on owner delete
> > > >>>
> > > >>> Gagandeep Singh (3):
> > > >>> common/dpaax/caamflib: fix IV for short MAC-I in
> SNOW3G
> > > >>> common/dpaax: fix physical address conversion
> > > >>> drivers/crypto: fix IPsec TTL decrement option
> > > >>>
> > > >>> Gaoxiang Liu (1):
> > > >>> vhost: log socket path on adding connection
> > > >>>
> > > >>> Georg Sauthoff (1):
> > > >>> net: fix aliasing in checksum computation
> > > >>>
> > > >>> Gregory Etelson (6):
> > > >>> examples/multi_process: fix Rx packets
> distribution
> > > >>> net/mlx5: fix RSS expansion scheme for GRE header
> > > >>> app/testpmd: fix hexadecimal parser with odd
> length
> > > >>> net/mlx5: fix VXLAN-GPE next protocol translation
> > > >>> net/mlx5: fix GENEVE protocol type translation
> > > >>> net/mlx5: fix GRE protocol type translation
> > > >>>
> > > >>> Haiyue Wang (1):
> > > >>> net/ice: fix memzone leak after device init
> failure
> > > >>>
> > > >>> Hanumanth Reddy Pothula (1):
> > > >>> net/octeontx2: fix MTU when PTP is enabled
> > > >>>
> > > >>> Harneet Singh (1):
> > > >>> examples/l3fwd-power: fix early shutdown
> > > >>>
> > > >>> Harry van Haaren (1):
> > > >>> app/eventdev: fix terminal colour after control-c
> exit
> > > >>>
> > > >>> Heinrich Kuhn (1):
> > > >>> net/nfp: fix minimum descriptor sizes
> > > >>>
> > > >>> Honnappa Nagarahalli (1):
> > > >>> eal: reset lcore task callback and argument
> > > >>>
> > > >>> Huisong Li (5):
> > > >>> net/hns3: fix input parameters of MAC functions
> > > >>> app/testpmd: retain all original dev conf when
> config DCB
> > > >>> ethdev: fix PCI device release in secondary
> process
> > > >>> net/hns3: simplify queue DMA address arithmetic
> > > >>> app/testpmd: remove unused header file
> > > >>>
> > > >>> Hyong Youb Kim (2):
> > > >>> net/enic: fix filter mode detection
> > > >>> net/enic: avoid error message when no advanced
> filtering
> > > >>>
> > > >>> Ivan Ilchenko (2):
> > > >>> net/virtio: fix mbuf count on Rx queue setup
> > > >>> ethdev: fix xstats by ID API documentation
> > > >>>
> > > >>> Jerin Jacob (1):
> > > >>> examples/performance-thread: fix build with clang
> 12.0.1
> > > >>>
> > > >>> Jiawei Wang (1):
> > > >>> net/mlx5: fix metadata and meter split shared tag
> > > >>>
> > > >>> Jie Wang (2):
> > > >>> net/i40e: fix forward outer IPv6 VXLAN
> > > >>> app/testpmd: fix DCB in VT configuration
> > > >>>
> > > >>> Jim Harris (2):
> > > >>> eal/linux: remove unused variable for socket
> memory
> > > >>> power: fix build with clang 13
> > > >>>
> > > >>> Joyce Kong (2):
> > > >>> test/service: fix some comment
> > > >>> test/func_reentrancy: free memzones after test
> > > >>>
> > > >>> Julien Meunier (2):
> > > >>> stack: fix reload head when pop fails
> > > >>> net/ixgbe: fix queue release
> > > >>>
> > > >>> Junxiao Shi (1):
> > > >>> net/memif: fix chained mbuf determination
> > > >>>
> > > >>> Kai Ji (1):
> > > >>> test/crypto: fix data lengths
> > > >>>
> > > >>> Kalesh AP (5):
> > > >>> net/bnxt: fix ring group free
> > > >>> net/bnxt: fix double allocation of ring groups
> > > >>> net/bnxt: fix function driver register/unregister
> > > >>> net/bnxt: check FW capability for VLAN offloads
> > > >>> net/bnxt: fix VLAN indication in Rx mbuf
> > > >>>
> > > >>> Kevin Traynor (2):
> > > >>> bitrate: fix registration to match API description
> > > >>> bitrate: fix calculation to match API description
> > > >>>
> > > >>> Konstantin Ananyev (2):
> > > >>> test/bpf: fix undefined behavior with clang
> > > >>> test: fix ring PMD initialisation
> > > >>>
> > > >>> Kumara Parameshwaran (1):
> > > >>> net/failsafe: fix secondary process probe
> > > >>>
> > > >>> Lance Richardson (1):
> > > >>> net: fix checksum API documentation
> > > >>>
> > > >>> Li Feng (1):
> > > >>> vhost: add sanity check on inflight last index
> > > >>>
> > > >>> Long Li (1):
> > > >>> bus/vmbus: fix ring buffer mapping in secondary
> process
> > > >>>
> > > >>> Maciej Szwed (1):
> > > >>> interrupt: fix request notifier interrupt
> processing
> > > >>>
> > > >>> Maxime Coquelin (3):
> > > >>> app/testpmd: fix RSS key length
> > > >>> app/testpmd: fix RSS type display
> > > >>> net/mlx5: fix RSS RETA update
> > > >>>
> > > >>> Michal Krawczyk (4):
> > > >>> net/ena: fix offload capabilities verification
> > > >>> net/ena: fix per-queue offload capabilities
> > > >>> net/ena: advertise scattered Rx capability
> > > >>> Revert "net/ena: trigger reset on Tx prepare
> failure"
> > > >>>
> > > >>> Naga Harish K S V (2):
> > > >>> eventdev/eth_rx: fix WRR buffer overrun
> > > >>> eventdev/eth_tx: fix queue delete logic
> > > >>>
> > > >>> Nithin Dabilpuram (2):
> > > >>> app/testpmd: fix check without outer checksum
> > > >>> app/testpmd: fix dump of Tx offload flags
> > > >>>
> > > >>> Olivier Matz (1):
> > > >>> mem: fix dynamic hugepage mapping in container
> > > >>>
> > > >>> Pablo de Lara (1):
> > > >>> efd: allow more CPU sockets in table creation
> > > >>>
> > > >>> Przemyslaw Zegan (2):
> > > >>> app/crypto-perf: fix AAD template copy overrun
> > > >>> common/qat: fix queue pairs number
> > > >>>
> > > >>> Qi Zhang (1):
> > > >>> net/ice/base: fix typo in comment
> > > >>>
> > > >>> Qiming Chen (12):
> > > >>> net/ixgbe: fix Rx multicast statistics after reset
> > > >>> net/pcap: fix resource leakage on port probe
> > > >>> net/ixgbe: fix hash handle leak
> > > >>> net/ixgbe: fix queue resource leak
> > > >>> net/ixgbe: fix MAC resource leak
> > > >>> net/ixgbe: fix mbuf leak
> > > >>> net/i40e: fix mbuf leak
> > > >>> net/i40e: fix device startup resource release
> > > >>> net/iavf: fix mbuf leak
> > > >>> net/i40e/base: fix resource leakage
> > > >>> net/iavf: fix Rx queue buffer size alignment
> > > >>> common/iavf: fix ARQ resource leak
> > > >>>
> > > >>> Rebecca Troy (1):
> > > >>> test/compress: fix buffer overflow
> > > >>>
> > > >>> Robin Zhang (7):
> > > >>> net/i40e/base: fix PHY identifiers for 2.5G and
> 5G adapters
> > > >>> net/i40e/base: fix PF reset
> > > >>> net/i40e/base: fix update link data for X722
> > > >>> net/i40e/base: fix AOC media type
> > > >>> net/i40e/base: fix function name in comments
> > > >>> net/i40e/base: fix potentially uninitialized
> variables
> > > >>> net/i40e/base: fix using checksum before check
> > > >>>
> > > >>> Ruifeng Wang (3):
> > > >>> examples/service_cores: fix lcore count check
> > > >>> net/i40e: fix risk in descriptor read in NEON Rx
> > > >>> net/i40e: fix risk in descriptor read in scalar Rx
> > > >>>
> > > >>> Sean Morrissey (3):
> > > >>> remove repeated 'the' in the code
> > > >>> fix PMD wording
> > > >>> doc: capitalise PMD
> > > >>>
> > > >>> Shijith Thotton (2):
> > > >>> test/event_crypto: fix event crypto metadata write
> > > >>> test/event: fix timer adapter creation test
> > > >>>
> > > >>> Somnath Kotur (1):
> > > >>> net/bnxt: fix Rx next consumer index in mbuf
> alloc fail
> > > >>>
> > > >>> Stephen Hemminger (4):
> > > >>> mbuf: fix typo in comment
> > > >>> bpf: allow self-xor operation
> > > >>> net/bnxt: fix firmware version query
> > > >>> fix spelling in comments and doxygen
> > > >>>
> > > >>> Sunil Kumar Kori (1):
> > > >>> app/testpmd: fix access to DSCP table entries
> > > >>>
> > > >>> Thomas Monjalon (2):
> > > >>> net/qede: fix minsize build
> > > >>> doc: remove repeated repeated words
> > > >>>
> > > >>> Timothy Redaelli (1):
> > > >>> doc: strip build artefacts for examples file list
> > > >>>
> > > >>> Tudor Cornea (3):
> > > >>> net/iavf: fix overflow in maximum packet length
> config
> > > >>> net/af_packet: fix ignoring full ring on Tx
> > > >>> net/ixgbe: fix port initialization if MTU config
> fails
> > > >>>
> > > >>> Vanshika Shukla (1):
> > > >>> examples/ptpclient: fix delay request message
> > > >>>
> > > >>> Viacheslav Ovsiienko (2):
> > > >>> app/testpmd: fix hex string parser in flow
> commands
> > > >>> doc: describe timestamp limitations for mlx5
> > > >>>
> > > >>> Vladimir Medvedkin (3):
> > > >>> hash: fix Doxygen comment of Toeplitz file
> > > >>> lpm6: fix buffer overflow
> > > >>> rib: fix IPv6 depth mask
> > > >>>
> > > >>> William Tu (1):
> > > >>> doc: fix emulated device names in e1000 guide
> > > >>>
> > > >>> Xiaoyu Min (1):
> > > >>> net/mlx4: fix empty Ethernet spec with VLAN
> > > >>>
> > > >>> Xuan Ding (1):
> > > >>> net/virtio: fix indirect descriptor reconnection
> > > >>>
> > > >>> Xueming Li (2):
> > > >>> eal: fix device iterator when no bus is selected
> > > >>> net/mlx5: fix Altivec Rx
> > > >>>
> > > >>> Yunjian Wang (1):
> > > >>> net/ice: fix memzone leak on queue re-configure
> > > >>>
> > > >>> Yury Kylulin (1):
> > > >>> net/i40e: support 25G AOC/ACC cables
> > > >>>
> > > >>> Zhihong Peng (1):
> > > >>> examples/performance-thread: fix build with ASan
> > > >>>
> > > >>> Zhihong Wang (1):
> > > >>> app/testpmd: fix Tx retry in flowgen engine
> > > >>>
> > > >>>
> > > >>>
> > > >>> --
> > > >>> Regards,
> > > >>> Kalesh A P
> > > >>
> > > >
> > > >
> > >
> >
> >
> > --
> > Christian Ehrhardt
> > Staff Engineer, Ubuntu Server
> > Canonical Ltd
> >
> > --
> > Regards,
> > Kalesh A P
>
>
--
Regards,
Kalesh A P
[-- Attachment #2: Type: text/html, Size: 39549 bytes --]
^ permalink raw reply [flat|nested] 33+ messages in thread
* RE: 19.11.11 patches review and test
2021-12-09 14:43 19.11.11 patches review and test christian.ehrhardt
2021-12-13 4:14 ` Kalesh Anakkur Purayil
@ 2021-12-14 7:14 ` Jiang, YuX
2021-12-14 7:45 ` Christian Ehrhardt
2021-12-15 11:04 ` Jiang, YuX
2021-12-14 13:51 ` Pei Zhang
2 siblings, 2 replies; 33+ messages in thread
From: Jiang, YuX @ 2021-12-14 7:14 UTC (permalink / raw)
To: christian.ehrhardt, stable
Cc: dev, Abhishek Marathe, Akhil Goyal, Ali Alnubani, Walker,
Benjamin, David Christensen, Govindharajan, Hariprasad,
Hemant Agrawal, Stokes, Ian, Jerin Jacob, Mcnamara, John,
Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi, Pei Zhang, pingx.yu,
Xu, Qian Q, Raslan Darawsheh, Thomas Monjalon, Peng, Yuan, Chen,
Zhaoyan
> -----Original Message-----
> From: christian.ehrhardt@canonical.com <christian.ehrhardt@canonical.com>
> Sent: Thursday, December 9, 2021 10:43 PM
> To: stable@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@nvidia.com>;
> Walker, Benjamin <benjamin.walker@intel.com>; David Christensen
> <drc@linux.vnet.ibm.com>; Govindharajan, Hariprasad
> <hariprasad.govindharajan@intel.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin
> Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>;
> Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
> <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> <pezhang@redhat.com>; pingx.yu@intel.com; Xu, Qian Q
> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>; Thomas
> Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>;
> Chen, Zhaoyan <zhaoyan.chen@intel.com>
> Subject: 19.11.11 patches review and test
>
> Hi all,
>
> Here is a list of patches targeted for stable release 19.11.11.
>
> The planned date for the final release is 7th January 2021.
>
> Please help with testing and validation of your use cases and report any
> issues/results with reply-all to this mail. For the final release the fixes and
> reported validations will be added to the release notes.
>
> A release candidate tarball can be found at:
>
> https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1
>
> These patches are located at branch 19.11 of dpdk-stable repo:
> https://dpdk.org/browse/dpdk-stable/
>
> Thanks.
>
> Christian Ehrhardt <christian.ehrhardt@canonical.com>
>
> ---
Hi Christian,
We find many build issues on LTS19.11. But all of them have no fix yet.
https://bugs.dpdk.org/show_bug.cgi?id=744 DPDK core dev UNCO --- [dpdk-19.11.9-rc3] make build failed on Fedora34 with GCC11 and build failed on Fedora35 with gcc11.2.1&clang13.0.0
https://bugs.dpdk.org/show_bug.cgi?id=747 DPDK core dev UNCO --- [dpdk-19.11.9-rc3] Meson build failed with ICC-19.1.1
https://bugs.dpdk.org/show_bug.cgi?id=900 DPDK ethdev dev UNCO --- [19.11.11-rc1] net/nfp build failure with clang 13
https://bugs.dpdk.org/show_bug.cgi?id=901 DPDK ethdev dev UNCO --- [19.11.11-rc1] net/i40e build failure with make and clang 13
https://bugs.dpdk.org/show_bug.cgi?id=902 DPDK ethdev dev UNCO --- [19.11.11-rc1] net/ice build failure with make and clang 13
https://bugs.dpdk.org/show_bug.cgi?id=903 DPDK ethdev dev UNCO --- [19.11.11-rc1] net/ixgbe build failure with make and clang 13
https://bugs.dpdk.org/show_bug.cgi?id=904 DPDK meson dev UNCO --- [dpdk-19.11.11] Meson build has some failures on Fedora35 with clang 13.0.0
https://bugs.dpdk.org/show_bug.cgi?id=905 DPDK meson dev UNCO --- [dpdk-19.11.11-rc1]Meson&Makefile build failed on Freebsd13 with gcc10.3.0&clang11.0.1
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-14 5:49 ` Kalesh Anakkur Purayil
@ 2021-12-14 7:44 ` Christian Ehrhardt
2021-12-14 10:13 ` Ferruh Yigit
0 siblings, 1 reply; 33+ messages in thread
From: Christian Ehrhardt @ 2021-12-14 7:44 UTC (permalink / raw)
To: Kalesh Anakkur Purayil
Cc: Ferruh Yigit, Abhishek Marathe, Akhil Goyal, Ali Alnubani,
David Christensen, Hariprasad Govindharajan, Hemant Agrawal,
Ian Stokes, Jerin Jacob, John McNamara, Ju-Hyoung Lee,
Kevin Traynor, Luca Boccassi, Pei Zhang, Raslan Darawsheh,
Thomas Monjalon, benjamin.walker, dpdk stable, dpdk-dev,
pingx.yu, qian.q.xu, yuan.peng, zhaoyan.chen
On Tue, Dec 14, 2021 at 6:49 AM Kalesh Anakkur Purayil
<kalesh-anakkur.purayil@broadcom.com> wrote:
[snip]
>> > [Kalesh] Yes, i am seeing the same error. I used make command to build dpdk, not meson.
>> > The back ported commit you mentioned takes care of meson build only I think.
>> >
>>
>> I see, make build is failing, and yes the fix is only for the meson.
>> I will check the make build and will send a fix for it.
>
> [Kalesh]: looks like the below changes fixes the issue. I tried only on SLES15 SP3 and not on other SLES flavors.
>
> diff --git a/kernel/linux/kni/Makefile b/kernel/linux/kni/Makefile
> index 595bac2..bf0efab 100644
> --- a/kernel/linux/kni/Makefile
> +++ b/kernel/linux/kni/Makefile
> @@ -16,6 +16,16 @@ MODULE_CFLAGS += -I$(RTE_OUTPUT)/include
> MODULE_CFLAGS += -include $(RTE_OUTPUT)/include/rte_config.h
> MODULE_CFLAGS += -Wall -Werror
>
> +#
> +# Use explicit 'source' folder for header path. In SUSE 'source' is not linked to 'build' folder.
> +#
> +ifdef CONFIG_SUSE_KERNEL
> + KSRC = /lib/modules/$(shell uname -r)/source
> + ifneq ($(shell grep -A 1 "ndo_tx_timeout" $(KSRC)/include/linux/netdevice.h | grep -o txqueue),)
> + MODULE_CFLAGS += -DHAVE_TX_TIMEOUT_TXQUEUE
> + endif
> +endif
Back in the day we tried various "is Suse and kernel version x.y"
approaches, but they failed as there was no clear version throughout
all of the Suse streams (leap, tumbleweed, sles) that worked well for
all.
This change here follows the upstream approach of "just check if it is there".
I've applied this to 19.11 and did test builds across various distributions:
1. no non-suse build changed
2. suse builds stayed as-is or improved
Formerly failing:
openSUSE_Factory_ARM aarch64
SLE_15 x86_64 -> now working
openSUSE_Leap_15.3 x86_64 -> now working
openSUSE_Tumbleweed x86_64 -> still failing
Formerly working:
SLE_12_SP4 x86_64 ppc64le -> still fine
openSUSE_Factory_ARM armv7l -> still fine
openSUSE_Leap_15.2 x86_64 -> still fine
Past fixes always "inverted" the result, by fixing some but breaking others.
This new patch works in "not breaking any formerly working build" but
at the same time fixing a few builds.
Therefore -> applied & thanks!
I'll likely tag -rc2 before the end of the week.
The good thing is that (so far) we have:
1. a non functional change
2. a change fixing clang-13 builds (TBH only one of many needed clang13 issues)
3. a change fixing sles15SP3 builds
Due to those, no current ongoing tests will have to be restarted.
Whoever was able to build, can continue the current tests.
Whoever was blocked by SLES15SP3 or clang-13 had no tests other than a
failing build and can work with -rc2 then.
I'll explain the same in the mail about -rc2.
> -include /etc/lsb-release
>
> ifeq ($(DISTRIB_ID),Ubuntu)
>
> Regards,
> Kalesh
[snip]
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-14 7:14 ` Jiang, YuX
@ 2021-12-14 7:45 ` Christian Ehrhardt
2021-12-14 8:05 ` Christian Ehrhardt
2021-12-15 11:04 ` Jiang, YuX
1 sibling, 1 reply; 33+ messages in thread
From: Christian Ehrhardt @ 2021-12-14 7:45 UTC (permalink / raw)
To: Jiang, YuX
Cc: stable, dev, Abhishek Marathe, Akhil Goyal, Ali Alnubani, Walker,
Benjamin, David Christensen, Govindharajan, Hariprasad,
Hemant Agrawal, Stokes, Ian, Jerin Jacob, Mcnamara, John,
Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi, Pei Zhang, pingx.yu,
Xu, Qian Q, Raslan Darawsheh, Thomas Monjalon, Peng, Yuan, Chen,
Zhaoyan
On Tue, Dec 14, 2021 at 8:14 AM Jiang, YuX <yux.jiang@intel.com> wrote:
>
> > -----Original Message-----
> > From: christian.ehrhardt@canonical.com <christian.ehrhardt@canonical.com>
> > Sent: Thursday, December 9, 2021 10:43 PM
> > To: stable@dpdk.org
> > Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> > Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@nvidia.com>;
> > Walker, Benjamin <benjamin.walker@intel.com>; David Christensen
> > <drc@linux.vnet.ibm.com>; Govindharajan, Hariprasad
> > <hariprasad.govindharajan@intel.com>; Hemant Agrawal
> > <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin
> > Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>;
> > Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
> > <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> > <pezhang@redhat.com>; pingx.yu@intel.com; Xu, Qian Q
> > <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>; Thomas
> > Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>;
> > Chen, Zhaoyan <zhaoyan.chen@intel.com>
> > Subject: 19.11.11 patches review and test
> >
> > Hi all,
> >
> > Here is a list of patches targeted for stable release 19.11.11.
> >
> > The planned date for the final release is 7th January 2021.
> >
> > Please help with testing and validation of your use cases and report any
> > issues/results with reply-all to this mail. For the final release the fixes and
> > reported validations will be added to the release notes.
> >
> > A release candidate tarball can be found at:
> >
> > https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1
> >
> > These patches are located at branch 19.11 of dpdk-stable repo:
> > https://dpdk.org/browse/dpdk-stable/
> >
> > Thanks.
> >
> > Christian Ehrhardt <christian.ehrhardt@canonical.com>
> >
> > ---
> Hi Christian,
>
> We find many build issues on LTS19.11. But all of them have no fix yet.
Hi,
thanks for the overview - that will be useful to extend the list of
known-issues eventually.
I agree with all of those reports, and some of them are older already,
not new to the current iteration.
But they all fall into the same category as some former build issues
we have seen.
As the 19.11 series gets older it fails to build in very new
compilers/distros for the new toolchains there being more strict.
I'm happy to backport patches for those, but as always we will only
block new LTS releases if we break build(environments) that formerly
worked.
> https://bugs.dpdk.org/show_bug.cgi?id=744 DPDK core dev UNCO --- [dpdk-19.11.9-rc3] make build failed on Fedora34 with GCC11 and build failed on Fedora35 with gcc11.2.1&clang13.0.0
> https://bugs.dpdk.org/show_bug.cgi?id=747 DPDK core dev UNCO --- [dpdk-19.11.9-rc3] Meson build failed with ICC-19.1.1
> https://bugs.dpdk.org/show_bug.cgi?id=900 DPDK ethdev dev UNCO --- [19.11.11-rc1] net/nfp build failure with clang 13
^^ this one has (900) a fix which I already picked and will be in -rc2
> https://bugs.dpdk.org/show_bug.cgi?id=901 DPDK ethdev dev UNCO --- [19.11.11-rc1] net/i40e build failure with make and clang 13
> https://bugs.dpdk.org/show_bug.cgi?id=902 DPDK ethdev dev UNCO --- [19.11.11-rc1] net/ice build failure with make and clang 13
> https://bugs.dpdk.org/show_bug.cgi?id=903 DPDK ethdev dev UNCO --- [19.11.11-rc1] net/ixgbe build failure with make and clang 13
> https://bugs.dpdk.org/show_bug.cgi?id=904 DPDK meson dev UNCO --- [dpdk-19.11.11] Meson build has some failures on Fedora35 with clang 13.0.0
> https://bugs.dpdk.org/show_bug.cgi?id=905 DPDK meson dev UNCO --- [dpdk-19.11.11-rc1]Meson&Makefile build failed on Freebsd13 with gcc10.3.0&clang11.0.1
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-14 7:45 ` Christian Ehrhardt
@ 2021-12-14 8:05 ` Christian Ehrhardt
0 siblings, 0 replies; 33+ messages in thread
From: Christian Ehrhardt @ 2021-12-14 8:05 UTC (permalink / raw)
To: Jiang, YuX
Cc: stable, dev, Abhishek Marathe, Akhil Goyal, Ali Alnubani, Walker,
Benjamin, David Christensen, Govindharajan, Hariprasad,
Hemant Agrawal, Stokes, Ian, Jerin Jacob, Mcnamara, John,
Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi, Pei Zhang, pingx.yu,
Xu, Qian Q, Raslan Darawsheh, Thomas Monjalon, Peng, Yuan, Chen,
Zhaoyan
On Tue, Dec 14, 2021 at 8:45 AM Christian Ehrhardt
<christian.ehrhardt@canonical.com> wrote:
>
> On Tue, Dec 14, 2021 at 8:14 AM Jiang, YuX <yux.jiang@intel.com> wrote:
> >
> > > -----Original Message-----
> > > From: christian.ehrhardt@canonical.com <christian.ehrhardt@canonical.com>
> > > Sent: Thursday, December 9, 2021 10:43 PM
> > > To: stable@dpdk.org
> > > Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> > > Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@nvidia.com>;
> > > Walker, Benjamin <benjamin.walker@intel.com>; David Christensen
> > > <drc@linux.vnet.ibm.com>; Govindharajan, Hariprasad
> > > <hariprasad.govindharajan@intel.com>; Hemant Agrawal
> > > <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin
> > > Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>;
> > > Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
> > > <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> > > <pezhang@redhat.com>; pingx.yu@intel.com; Xu, Qian Q
> > > <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>; Thomas
> > > Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>;
> > > Chen, Zhaoyan <zhaoyan.chen@intel.com>
> > > Subject: 19.11.11 patches review and test
> > >
> > > Hi all,
> > >
> > > Here is a list of patches targeted for stable release 19.11.11.
> > >
> > > The planned date for the final release is 7th January 2021.
> > >
> > > Please help with testing and validation of your use cases and report any
> > > issues/results with reply-all to this mail. For the final release the fixes and
> > > reported validations will be added to the release notes.
> > >
> > > A release candidate tarball can be found at:
> > >
> > > https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1
> > >
> > > These patches are located at branch 19.11 of dpdk-stable repo:
> > > https://dpdk.org/browse/dpdk-stable/
> > >
> > > Thanks.
> > >
> > > Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > >
> > > ---
> > Hi Christian,
> >
> > We find many build issues on LTS19.11. But all of them have no fix yet.
>
> Hi,
> thanks for the overview - that will be useful to extend the list of
> known-issues eventually.
>
> I agree with all of those reports, and some of them are older already,
> not new to the current iteration.
> But they all fall into the same category as some former build issues
> we have seen.
> As the 19.11 series gets older it fails to build in very new
> compilers/distros for the new toolchains there being more strict.
> I'm happy to backport patches for those, but as always we will only
> block new LTS releases if we break build(environments) that formerly
> worked.
Oh and I wanted to state that I tried to start an activity to get
those resolved back when the first of those came up in summer.
=> http://mails.dpdk.org/archives/dev/2021-July/214998.html
But the activity on that was ... zero :-/
So I pick the fixes that get provided, but as mentioned above - will
not block the LTS unless we break formerly working builds.
> > https://bugs.dpdk.org/show_bug.cgi?id=744 DPDK core dev UNCO --- [dpdk-19.11.9-rc3] make build failed on Fedora34 with GCC11 and build failed on Fedora35 with gcc11.2.1&clang13.0.0
> > https://bugs.dpdk.org/show_bug.cgi?id=747 DPDK core dev UNCO --- [dpdk-19.11.9-rc3] Meson build failed with ICC-19.1.1
> > https://bugs.dpdk.org/show_bug.cgi?id=900 DPDK ethdev dev UNCO --- [19.11.11-rc1] net/nfp build failure with clang 13
>
> ^^ this one has (900) a fix which I already picked and will be in -rc2
>
> > https://bugs.dpdk.org/show_bug.cgi?id=901 DPDK ethdev dev UNCO --- [19.11.11-rc1] net/i40e build failure with make and clang 13
> > https://bugs.dpdk.org/show_bug.cgi?id=902 DPDK ethdev dev UNCO --- [19.11.11-rc1] net/ice build failure with make and clang 13
> > https://bugs.dpdk.org/show_bug.cgi?id=903 DPDK ethdev dev UNCO --- [19.11.11-rc1] net/ixgbe build failure with make and clang 13
> > https://bugs.dpdk.org/show_bug.cgi?id=904 DPDK meson dev UNCO --- [dpdk-19.11.11] Meson build has some failures on Fedora35 with clang 13.0.0
> > https://bugs.dpdk.org/show_bug.cgi?id=905 DPDK meson dev UNCO --- [dpdk-19.11.11-rc1]Meson&Makefile build failed on Freebsd13 with gcc10.3.0&clang11.0.1
>
> --
> Christian Ehrhardt
> Staff Engineer, Ubuntu Server
> Canonical Ltd
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-14 7:44 ` Christian Ehrhardt
@ 2021-12-14 10:13 ` Ferruh Yigit
2021-12-14 11:39 ` Christian Ehrhardt
0 siblings, 1 reply; 33+ messages in thread
From: Ferruh Yigit @ 2021-12-14 10:13 UTC (permalink / raw)
To: Christian Ehrhardt, Kalesh Anakkur Purayil
Cc: Abhishek Marathe, Akhil Goyal, Ali Alnubani, David Christensen,
Hariprasad Govindharajan, Hemant Agrawal, Ian Stokes,
Jerin Jacob, John McNamara, Ju-Hyoung Lee, Kevin Traynor,
Luca Boccassi, Pei Zhang, Raslan Darawsheh, Thomas Monjalon,
benjamin.walker, dpdk stable, dpdk-dev, pingx.yu, qian.q.xu,
yuan.peng, zhaoyan.chen
On 12/14/2021 7:44 AM, Christian Ehrhardt wrote:
> On Tue, Dec 14, 2021 at 6:49 AM Kalesh Anakkur Purayil
> <kalesh-anakkur.purayil@broadcom.com> wrote:
>
> [snip]
>
>>>> [Kalesh] Yes, i am seeing the same error. I used make command to build dpdk, not meson.
>>>> The back ported commit you mentioned takes care of meson build only I think.
>>>>
>>>
>>> I see, make build is failing, and yes the fix is only for the meson.
>>> I will check the make build and will send a fix for it.
>>
>> [Kalesh]: looks like the below changes fixes the issue. I tried only on SLES15 SP3 and not on other SLES flavors.
>>
>> diff --git a/kernel/linux/kni/Makefile b/kernel/linux/kni/Makefile
>> index 595bac2..bf0efab 100644
>> --- a/kernel/linux/kni/Makefile
>> +++ b/kernel/linux/kni/Makefile
>> @@ -16,6 +16,16 @@ MODULE_CFLAGS += -I$(RTE_OUTPUT)/include
>> MODULE_CFLAGS += -include $(RTE_OUTPUT)/include/rte_config.h
>> MODULE_CFLAGS += -Wall -Werror
>>
>> +#
>> +# Use explicit 'source' folder for header path. In SUSE 'source' is not linked to 'build' folder.
>> +#
>> +ifdef CONFIG_SUSE_KERNEL
>> + KSRC = /lib/modules/$(shell uname -r)/source
>> + ifneq ($(shell grep -A 1 "ndo_tx_timeout" $(KSRC)/include/linux/netdevice.h | grep -o txqueue),)
>> + MODULE_CFLAGS += -DHAVE_TX_TIMEOUT_TXQUEUE
>> + endif
>> +endif
>
> Back in the day we tried various "is Suse and kernel version x.y"
> approaches, but they failed as there was no clear version throughout
> all of the Suse streams (leap, tumbleweed, sles) that worked well for
> all.
> This change here follows the upstream approach of "just check if it is there".
>
> I've applied this to 19.11 and did test builds across various distributions:
> 1. no non-suse build changed
> 2. suse builds stayed as-is or improved
> Formerly failing:
> openSUSE_Factory_ARM aarch64
> SLE_15 x86_64 -> now working
> openSUSE_Leap_15.3 x86_64 -> now working
> openSUSE_Tumbleweed x86_64 -> still failing
> Formerly working:
> SLE_12_SP4 x86_64 ppc64le -> still fine
> openSUSE_Factory_ARM armv7l -> still fine
> openSUSE_Leap_15.2 x86_64 -> still fine
>
Thanks Kalesh for the fix, and thanks Christian for testing.
I was expecting this approach will fix all builds, after patch only
'openSUSE_Tumbleweed' is failing, right? I will check it.
And I think you need the fix as a patch anyway, @Kalesh are you
planning to send the patch?
> Past fixes always "inverted" the result, by fixing some but breaking others.
> This new patch works in "not breaking any formerly working build" but
> at the same time fixing a few builds.
> Therefore -> applied & thanks!
>
> I'll likely tag -rc2 before the end of the week.
> The good thing is that (so far) we have:
> 1. a non functional change
> 2. a change fixing clang-13 builds (TBH only one of many needed clang13 issues)
> 3. a change fixing sles15SP3 builds
>
> Due to those, no current ongoing tests will have to be restarted.
> Whoever was able to build, can continue the current tests.
> Whoever was blocked by SLES15SP3 or clang-13 had no tests other than a
> failing build and can work with -rc2 then.
> I'll explain the same in the mail about -rc2.
>
>> -include /etc/lsb-release
>>
>> ifeq ($(DISTRIB_ID),Ubuntu)
>>
>> Regards,
>> Kalesh
>
> [snip]
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-14 10:13 ` Ferruh Yigit
@ 2021-12-14 11:39 ` Christian Ehrhardt
2021-12-14 12:08 ` Ferruh Yigit
2021-12-14 13:10 ` Ferruh Yigit
0 siblings, 2 replies; 33+ messages in thread
From: Christian Ehrhardt @ 2021-12-14 11:39 UTC (permalink / raw)
To: Ferruh Yigit
Cc: Kalesh Anakkur Purayil, Abhishek Marathe, Akhil Goyal,
Ali Alnubani, David Christensen, Hariprasad Govindharajan,
Hemant Agrawal, Ian Stokes, Jerin Jacob, John McNamara,
Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi, Pei Zhang,
Raslan Darawsheh, Thomas Monjalon, benjamin.walker, dpdk stable,
dpdk-dev, pingx.yu, qian.q.xu, yuan.peng, zhaoyan.chen
On Tue, Dec 14, 2021 at 11:13 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 12/14/2021 7:44 AM, Christian Ehrhardt wrote:
> > On Tue, Dec 14, 2021 at 6:49 AM Kalesh Anakkur Purayil
> > <kalesh-anakkur.purayil@broadcom.com> wrote:
> >
> > [snip]
> >
> >>>> [Kalesh] Yes, i am seeing the same error. I used make command to build dpdk, not meson.
> >>>> The back ported commit you mentioned takes care of meson build only I think.
> >>>>
> >>>
> >>> I see, make build is failing, and yes the fix is only for the meson.
> >>> I will check the make build and will send a fix for it.
> >>
> >> [Kalesh]: looks like the below changes fixes the issue. I tried only on SLES15 SP3 and not on other SLES flavors.
> >>
> >> diff --git a/kernel/linux/kni/Makefile b/kernel/linux/kni/Makefile
> >> index 595bac2..bf0efab 100644
> >> --- a/kernel/linux/kni/Makefile
> >> +++ b/kernel/linux/kni/Makefile
> >> @@ -16,6 +16,16 @@ MODULE_CFLAGS += -I$(RTE_OUTPUT)/include
> >> MODULE_CFLAGS += -include $(RTE_OUTPUT)/include/rte_config.h
> >> MODULE_CFLAGS += -Wall -Werror
> >>
> >> +#
> >> +# Use explicit 'source' folder for header path. In SUSE 'source' is not linked to 'build' folder.
> >> +#
> >> +ifdef CONFIG_SUSE_KERNEL
> >> + KSRC = /lib/modules/$(shell uname -r)/source
> >> + ifneq ($(shell grep -A 1 "ndo_tx_timeout" $(KSRC)/include/linux/netdevice.h | grep -o txqueue),)
> >> + MODULE_CFLAGS += -DHAVE_TX_TIMEOUT_TXQUEUE
> >> + endif
> >> +endif
> >
> > Back in the day we tried various "is Suse and kernel version x.y"
> > approaches, but they failed as there was no clear version throughout
> > all of the Suse streams (leap, tumbleweed, sles) that worked well for
> > all.
> > This change here follows the upstream approach of "just check if it is there".
> >
> > I've applied this to 19.11 and did test builds across various distributions:
> > 1. no non-suse build changed
> > 2. suse builds stayed as-is or improved
> > Formerly failing:
> > openSUSE_Factory_ARM aarch64
> > SLE_15 x86_64 -> now working
> > openSUSE_Leap_15.3 x86_64 -> now working
> > openSUSE_Tumbleweed x86_64 -> still failing
> > Formerly working:
> > SLE_12_SP4 x86_64 ppc64le -> still fine
> > openSUSE_Factory_ARM armv7l -> still fine
> > openSUSE_Leap_15.2 x86_64 -> still fine
> >
>
> Thanks Kalesh for the fix, and thanks Christian for testing.
>
> I was expecting this approach will fix all builds, after patch only
> 'openSUSE_Tumbleweed' is failing, right? I will check it.
As just discussed on IRC, yes and the log for that is at
https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/openSUSE_Tumbleweed/x86_64
It also is affected by an issue around -Werror=implicit-fallthrough,
so even with KNI fixed it likely is going to fail.
> And I think you need the fix as a patch anyway, @Kalesh are you
> planning to send the patch?
I don't need it, as I have already grabbed and preliminary added it:
https://github.com/cpaelzer/dpdk-stable-queue/commit/d43fa3e198c08a3a76d70f4565b31ad3ab5f29c4
But surely, once/If you come up with a full patch that also includes
tumbleweed I can replace it with yours.
> > Past fixes always "inverted" the result, by fixing some but breaking others.
> > This new patch works in "not breaking any formerly working build" but
> > at the same time fixing a few builds.
> > Therefore -> applied & thanks!
> >
> > I'll likely tag -rc2 before the end of the week.
> > The good thing is that (so far) we have:
> > 1. a non functional change
> > 2. a change fixing clang-13 builds (TBH only one of many needed clang13 issues)
> > 3. a change fixing sles15SP3 builds
> >
> > Due to those, no current ongoing tests will have to be restarted.
> > Whoever was able to build, can continue the current tests.
> > Whoever was blocked by SLES15SP3 or clang-13 had no tests other than a
> > failing build and can work with -rc2 then.
> > I'll explain the same in the mail about -rc2.
> >
> >> -include /etc/lsb-release
> >>
> >> ifeq ($(DISTRIB_ID),Ubuntu)
> >>
> >> Regards,
> >> Kalesh
> >
> > [snip]
> >
>
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-14 11:39 ` Christian Ehrhardt
@ 2021-12-14 12:08 ` Ferruh Yigit
2021-12-14 13:57 ` Christian Ehrhardt
2021-12-14 13:10 ` Ferruh Yigit
1 sibling, 1 reply; 33+ messages in thread
From: Ferruh Yigit @ 2021-12-14 12:08 UTC (permalink / raw)
To: Christian Ehrhardt, Luca Boccassi, Kevin Traynor, Xueming(Steven) Li
Cc: Kalesh Anakkur Purayil, Abhishek Marathe, Akhil Goyal,
Ali Alnubani, David Christensen, Hariprasad Govindharajan,
Hemant Agrawal, Ian Stokes, Jerin Jacob, John McNamara,
Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi, Pei Zhang,
Raslan Darawsheh, Thomas Monjalon, benjamin.walker, dpdk stable,
dpdk-dev, pingx.yu, qian.q.xu, yuan.peng, zhaoyan.chen
On 12/14/2021 11:39 AM, Christian Ehrhardt wrote:
> On Tue, Dec 14, 2021 at 11:13 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> On 12/14/2021 7:44 AM, Christian Ehrhardt wrote:
>>> On Tue, Dec 14, 2021 at 6:49 AM Kalesh Anakkur Purayil
>>> <kalesh-anakkur.purayil@broadcom.com> wrote:
>>>
>>> [snip]
>>>
>>>>>> [Kalesh] Yes, i am seeing the same error. I used make command to build dpdk, not meson.
>>>>>> The back ported commit you mentioned takes care of meson build only I think.
>>>>>>
>>>>>
>>>>> I see, make build is failing, and yes the fix is only for the meson.
>>>>> I will check the make build and will send a fix for it.
>>>>
>>>> [Kalesh]: looks like the below changes fixes the issue. I tried only on SLES15 SP3 and not on other SLES flavors.
>>>>
>>>> diff --git a/kernel/linux/kni/Makefile b/kernel/linux/kni/Makefile
>>>> index 595bac2..bf0efab 100644
>>>> --- a/kernel/linux/kni/Makefile
>>>> +++ b/kernel/linux/kni/Makefile
>>>> @@ -16,6 +16,16 @@ MODULE_CFLAGS += -I$(RTE_OUTPUT)/include
>>>> MODULE_CFLAGS += -include $(RTE_OUTPUT)/include/rte_config.h
>>>> MODULE_CFLAGS += -Wall -Werror
>>>>
>>>> +#
>>>> +# Use explicit 'source' folder for header path. In SUSE 'source' is not linked to 'build' folder.
>>>> +#
>>>> +ifdef CONFIG_SUSE_KERNEL
>>>> + KSRC = /lib/modules/$(shell uname -r)/source
>>>> + ifneq ($(shell grep -A 1 "ndo_tx_timeout" $(KSRC)/include/linux/netdevice.h | grep -o txqueue),)
>>>> + MODULE_CFLAGS += -DHAVE_TX_TIMEOUT_TXQUEUE
>>>> + endif
>>>> +endif
>>>
>>> Back in the day we tried various "is Suse and kernel version x.y"
>>> approaches, but they failed as there was no clear version throughout
>>> all of the Suse streams (leap, tumbleweed, sles) that worked well for
>>> all.
>>> This change here follows the upstream approach of "just check if it is there".
>>>
>>> I've applied this to 19.11 and did test builds across various distributions:
>>> 1. no non-suse build changed
>>> 2. suse builds stayed as-is or improved
>>> Formerly failing:
>>> openSUSE_Factory_ARM aarch64
>>> SLE_15 x86_64 -> now working
>>> openSUSE_Leap_15.3 x86_64 -> now working
>>> openSUSE_Tumbleweed x86_64 -> still failing
>>> Formerly working:
>>> SLE_12_SP4 x86_64 ppc64le -> still fine
>>> openSUSE_Factory_ARM armv7l -> still fine
>>> openSUSE_Leap_15.2 x86_64 -> still fine
>>>
>>
>> Thanks Kalesh for the fix, and thanks Christian for testing.
>>
>> I was expecting this approach will fix all builds, after patch only
>> 'openSUSE_Tumbleweed' is failing, right? I will check it.
>
> As just discussed on IRC, yes and the log for that is at
> https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/openSUSE_Tumbleweed/x86_64
>
> It also is affected by an issue around -Werror=implicit-fallthrough,
> so even with KNI fixed it likely is going to fail.
>
>> And I think you need the fix as a patch anyway, @Kalesh are you
>> planning to send the patch?
>
> I don't need it, as I have already grabbed and preliminary added it:
> https://github.com/cpaelzer/dpdk-stable-queue/commit/d43fa3e198c08a3a76d70f4565b31ad3ab5f29c4
>
I was thinking any commit in the LTS *must* come from either upstream
commit or a backport patch in the stable mail list.
Isn't it very hard to back trace merging diffs from emails,
are you OK with that?
> But surely, once/If you come up with a full patch that also includes
> tumbleweed I can replace it with yours.
>
>>> Past fixes always "inverted" the result, by fixing some but breaking others.
>>> This new patch works in "not breaking any formerly working build" but
>>> at the same time fixing a few builds.
>>> Therefore -> applied & thanks!
>>>
>>> I'll likely tag -rc2 before the end of the week.
>>> The good thing is that (so far) we have:
>>> 1. a non functional change
>>> 2. a change fixing clang-13 builds (TBH only one of many needed clang13 issues)
>>> 3. a change fixing sles15SP3 builds
>>>
>>> Due to those, no current ongoing tests will have to be restarted.
>>> Whoever was able to build, can continue the current tests.
>>> Whoever was blocked by SLES15SP3 or clang-13 had no tests other than a
>>> failing build and can work with -rc2 then.
>>> I'll explain the same in the mail about -rc2.
>>>
>>>> -include /etc/lsb-release
>>>>
>>>> ifeq ($(DISTRIB_ID),Ubuntu)
>>>>
>>>> Regards,
>>>> Kalesh
>>>
>>> [snip]
>>>
>>
>
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-14 11:39 ` Christian Ehrhardt
2021-12-14 12:08 ` Ferruh Yigit
@ 2021-12-14 13:10 ` Ferruh Yigit
2021-12-14 13:58 ` Christian Ehrhardt
1 sibling, 1 reply; 33+ messages in thread
From: Ferruh Yigit @ 2021-12-14 13:10 UTC (permalink / raw)
To: Christian Ehrhardt
Cc: Kalesh Anakkur Purayil, Abhishek Marathe, Akhil Goyal,
Ali Alnubani, David Christensen, Hariprasad Govindharajan,
Hemant Agrawal, Ian Stokes, Jerin Jacob, John McNamara,
Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi, Pei Zhang,
Raslan Darawsheh, Thomas Monjalon, benjamin.walker, dpdk stable,
dpdk-dev, pingx.yu, qian.q.xu, yuan.peng, zhaoyan.chen
On 12/14/2021 11:39 AM, Christian Ehrhardt wrote:
> On Tue, Dec 14, 2021 at 11:13 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> On 12/14/2021 7:44 AM, Christian Ehrhardt wrote:
>>> On Tue, Dec 14, 2021 at 6:49 AM Kalesh Anakkur Purayil
>>> <kalesh-anakkur.purayil@broadcom.com> wrote:
>>>
>>> [snip]
>>>
>>>>>> [Kalesh] Yes, i am seeing the same error. I used make command to build dpdk, not meson.
>>>>>> The back ported commit you mentioned takes care of meson build only I think.
>>>>>>
>>>>>
>>>>> I see, make build is failing, and yes the fix is only for the meson.
>>>>> I will check the make build and will send a fix for it.
>>>>
>>>> [Kalesh]: looks like the below changes fixes the issue. I tried only on SLES15 SP3 and not on other SLES flavors.
>>>>
>>>> diff --git a/kernel/linux/kni/Makefile b/kernel/linux/kni/Makefile
>>>> index 595bac2..bf0efab 100644
>>>> --- a/kernel/linux/kni/Makefile
>>>> +++ b/kernel/linux/kni/Makefile
>>>> @@ -16,6 +16,16 @@ MODULE_CFLAGS += -I$(RTE_OUTPUT)/include
>>>> MODULE_CFLAGS += -include $(RTE_OUTPUT)/include/rte_config.h
>>>> MODULE_CFLAGS += -Wall -Werror
>>>>
>>>> +#
>>>> +# Use explicit 'source' folder for header path. In SUSE 'source' is not linked to 'build' folder.
>>>> +#
>>>> +ifdef CONFIG_SUSE_KERNEL
>>>> + KSRC = /lib/modules/$(shell uname -r)/source
>>>> + ifneq ($(shell grep -A 1 "ndo_tx_timeout" $(KSRC)/include/linux/netdevice.h | grep -o txqueue),)
>>>> + MODULE_CFLAGS += -DHAVE_TX_TIMEOUT_TXQUEUE
>>>> + endif
>>>> +endif
>>>
>>> Back in the day we tried various "is Suse and kernel version x.y"
>>> approaches, but they failed as there was no clear version throughout
>>> all of the Suse streams (leap, tumbleweed, sles) that worked well for
>>> all.
>>> This change here follows the upstream approach of "just check if it is there".
>>>
>>> I've applied this to 19.11 and did test builds across various distributions:
>>> 1. no non-suse build changed
>>> 2. suse builds stayed as-is or improved
>>> Formerly failing:
>>> openSUSE_Factory_ARM aarch64
>>> SLE_15 x86_64 -> now working
>>> openSUSE_Leap_15.3 x86_64 -> now working
>>> openSUSE_Tumbleweed x86_64 -> still failing
>>> Formerly working:
>>> SLE_12_SP4 x86_64 ppc64le -> still fine
>>> openSUSE_Factory_ARM armv7l -> still fine
>>> openSUSE_Leap_15.2 x86_64 -> still fine
>>>
>>
>> Thanks Kalesh for the fix, and thanks Christian for testing.
>>
>> I was expecting this approach will fix all builds, after patch only
>> 'openSUSE_Tumbleweed' is failing, right? I will check it.
>
> As just discussed on IRC, yes and the log for that is at
> https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/openSUSE_Tumbleweed/x86_64
>
> It also is affected by an issue around -Werror=implicit-fallthrough,
> so even with KNI fixed it likely is going to fail.
>
>> And I think you need the fix as a patch anyway, @Kalesh are you
>> planning to send the patch?
>
> I don't need it, as I have already grabbed and preliminary added it:
> https://github.com/cpaelzer/dpdk-stable-queue/commit/d43fa3e198c08a3a76d70f4565b31ad3ab5f29c4
>
> But surely, once/If you come up with a full patch that also includes
> tumbleweed I can replace it with yours.
>
'tumbleweed' error is odd, it complains about macro being redefined,
not sure why only in this platform we are getting an error.
Macro is only defined in one place, but indeed header file included
multiple times, one direct and one indirect, so macro defined multiple
times but without value, so it should be OK and it is OK for other
platforms, it is defined as:
#define HAVE_TX_TIMEOUT_TXQUEUE
Another option is that macro is defined in some other header file,
although I think that is very unlikely, can you please test with
below change to rule out that option:
diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h
index 664785674ff1..71846419f437 100644
--- a/kernel/linux/kni/compat.h
+++ b/kernel/linux/kni/compat.h
@@ -135,7 +135,7 @@
(defined(RHEL_RELEASE_CODE) && \
RHEL_RELEASE_VERSION(8, 3) <= RHEL_RELEASE_CODE) || \
(defined(CONFIG_SUSE_KERNEL) && defined(HAVE_ARG_TX_QUEUE))
-#define HAVE_TX_TIMEOUT_TXQUEUE
+#define RTE_HAVE_TX_TIMEOUT_TXQUEUE
#endif
#if KERNEL_VERSION(5, 9, 0) > LINUX_VERSION_CODE
diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c
index c8bad5f197ca..7397de4659b2 100644
--- a/kernel/linux/kni/kni_net.c
+++ b/kernel/linux/kni/kni_net.c
@@ -623,7 +623,7 @@ kni_net_rx(struct kni_dev *kni)
/*
* Deal with a transmit timeout.
*/
-#ifdef HAVE_TX_TIMEOUT_TXQUEUE
+#ifdef RTE_HAVE_TX_TIMEOUT_TXQUEUE
static void
kni_net_tx_timeout(struct net_device *dev, unsigned int txqueue)
#else
>>> Past fixes always "inverted" the result, by fixing some but breaking others.
>>> This new patch works in "not breaking any formerly working build" but
>>> at the same time fixing a few builds.
>>> Therefore -> applied & thanks!
>>>
>>> I'll likely tag -rc2 before the end of the week.
>>> The good thing is that (so far) we have:
>>> 1. a non functional change
>>> 2. a change fixing clang-13 builds (TBH only one of many needed clang13 issues)
>>> 3. a change fixing sles15SP3 builds
>>>
>>> Due to those, no current ongoing tests will have to be restarted.
>>> Whoever was able to build, can continue the current tests.
>>> Whoever was blocked by SLES15SP3 or clang-13 had no tests other than a
>>> failing build and can work with -rc2 then.
>>> I'll explain the same in the mail about -rc2.
>>>
>>>> -include /etc/lsb-release
>>>>
>>>> ifeq ($(DISTRIB_ID),Ubuntu)
>>>>
>>>> Regards,
>>>> Kalesh
>>>
>>> [snip]
>>>
>>
>
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-09 14:43 19.11.11 patches review and test christian.ehrhardt
2021-12-13 4:14 ` Kalesh Anakkur Purayil
2021-12-14 7:14 ` Jiang, YuX
@ 2021-12-14 13:51 ` Pei Zhang
2021-12-14 13:52 ` Christian Ehrhardt
2 siblings, 1 reply; 33+ messages in thread
From: Pei Zhang @ 2021-12-14 13:51 UTC (permalink / raw)
To: ehrhardt, christian
Cc: stable, dev, Abhishek Marathe, Akhil Goyal, Ali Alnubani,
benjamin.walker, David Christensen, hariprasad.govindharajan,
Hemant Agrawal, Ian Stokes, Jerin Jacob, John McNamara,
Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi, pingx.yu, xu, qian,
Raslan Darawsheh, Thomas Monjalon, yuan.peng, Chen, Zhaoyan,
Chao Yang, Maxime Coquelin, David Marchand
[-- Attachment #1: Type: text/plain, Size: 14365 bytes --]
Hello Christian,
The testing with dpdk 19.11.11-rc1 from Red Hat looks good. We tested below
17 scenarios and all got PASS on RHEL8:
(1)Guest with device assignment(PF) throughput testing(1G hugepage size):
PASS
(2)Guest with device assignment(PF) throughput testing(2M hugepage size) :
PASS
(3)Guest with device assignment(VF) throughput testing: PASS
(4)PVP (host dpdk testpmd as vswitch) 1Q: throughput testing: PASS
(5)PVP vhost-user 2Q throughput testing: PASS
(6)PVP vhost-user 1Q - cross numa node throughput testing: PASS
(7)Guest with vhost-user 2Q throughput testing: PASS
(8)vhost-user reconnect with dpdk-client, qemu-server: qemu reconnect: PASS
(9)vhost-user reconnect with dpdk-client, qemu-server: ovs reconnect: PASS
(10)PVP 1Q live migration testing: PASS
(11)PVP 1Q cross numa node live migration testing: PASS
(12)Guest with ovs+dpdk+vhost-user 1Q live migration testing: PASS
(13)Guest with ovs+dpdk+vhost-user 1Q live migration testing (2M): PASS
(14)Guest with ovs+dpdk+vhost-user 2Q live migration testing: PASS
(15)Guest with ovs+dpdk+vhost-user 4Q live migration testing: PASS
(16)Host PF + DPDK testing: PASS
(17)Host VF + DPDK testing: PASS
Versions:
kernel 4.18
qemu 6.1
dpdk: git://dpdk.org/dpdk-stable
branch: remotes/origin/19.11
# git log -1
commit 928100dd6d30e733be411380fdb78c68a061936c (HEAD, tag: v19.11.11-rc1,
origin/19.11)
Author: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Date: Thu Dec 9 15:33:57 2021 +0100
version: 19.11.11-rc1
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
NICs: X540-AT2 NIC(ixgbe, 10G)
Best regards,
Pei
On Thu, Dec 9, 2021 at 10:43 PM <christian.ehrhardt@canonical.com> wrote:
> Hi all,
>
> Here is a list of patches targeted for stable release 19.11.11.
>
> The planned date for the final release is 7th January 2021.
>
> Please help with testing and validation of your use cases and report
> any issues/results with reply-all to this mail. For the final release
> the fixes and reported validations will be added to the release notes.
>
> A release candidate tarball can be found at:
>
> https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1
>
> These patches are located at branch 19.11 of dpdk-stable repo:
> https://dpdk.org/browse/dpdk-stable/
>
> Thanks.
>
> Christian Ehrhardt <christian.ehrhardt@canonical.com>
>
> ---
> Ajit Khaparde (3):
> net/bnxt: fix Tx queue startup state
> net/bnxt: fix memzone free for Tx and Rx rings
> net/bnxt: fix tunnel port accounting
>
> Alexander Bechikov (1):
> mbuf: fix dump of dynamic fields and flags
>
> Alexander Kozyrev (2):
> net/mlx5: fix GENEVE and VXLAN-GPE flow item matching
> net/mlx5: fix GRE flow item matching
>
> Alvin Zhang (1):
> net/i40e: fix Rx packet statistics
>
> Aman Singh (1):
> kni: fix build for SLES15-SP3
>
> Anatoly Burakov (2):
> vfio: fix FreeBSD clear group stub
> vfio: fix FreeBSD documentation
>
> Anoob Joseph (2):
> test/crypto: skip plain text compare for null cipher
> common/cpt: fix KASUMI input length
>
> Arek Kusztal (2):
> crypto/qat: fix status in RSA decryption
> crypto/qat: fix uncleared cookies after operation
>
> Ben Pfaff (1):
> doc: fix numbers power of 2 in LPM6 guide
>
> Bing Zhao (2):
> net/mlx5: fix flow tables double release
> net/mlx5: fix RETA update without stopping device
>
> Bruce Richardson (3):
> eal/freebsd: lock memory device to prevent conflicts
> test/mem: fix memory autotests on FreeBSD
> eal/freebsd: ignore in-memory option
>
> Chengchang Tang (2):
> net/bonding: fix dedicated queue mode in vector burst
> net/bonding: fix RSS key length
>
> Chengfeng Ye (1):
> net/axgbe: fix unreleased lock in I2C transfer
>
> Chengwen Feng (1):
> kni: check error code of allmulticast mode switch
>
> Cian Ferriter (1):
> ring: fix Doxygen comment of internal function
>
> Ciara Loftus (1):
> net/af_xdp: disable secondary process support
>
> Ciara Power (3):
> crypto/openssl: fix CCM processing 0 length source
> examples/fips_validation: remove unused allocation
> test/crypto: fix unnecessary stats retrieval
>
> Conor Walsh (8):
> net/hinic/base: remove some unused variables
> bus/fslmc: remove unused device count
> event/sw: remove unused inflight events count
> net/liquidio: remove unused counter
> net/qede/base: remove unused message size
> net/vmxnet3: fix build with clang 13
> test/distributor: remove unused counter
> examples/performance-thread: remove unused hits count
>
> Dapeng Yu (1):
> net/ice: save rule on switch filter creation
>
> Dariusz Sosnowski (2):
> net/mlx5: fix MPLS tunnel outer layer overwrite
> doc: fix typo in coding style
>
> David Christensen (3):
> eal/ppc: ignore GCC 10 stringop-overflow warnings
> config/ppc: ignore GCC 11 psabi warnings
> test/atomic: fix 128-bit atomic test with many cores
>
> David Hunt (1):
> test/power: fix CPU frequency when turbo enabled
>
> David Marchand (10):
> net/virtio: avoid unneeded link interrupt configuration
> net/virtio-user: fix Rx interrupts with multi-queue
> bus/vmbus: fix leak on device scan
> test/latency: fix loop boundary
> eal/x86: fix some CPU extended features definitions
> mbuf: enforce no option for dynamic fields and flags
> doc: fix default mempool option in guides
> eal/linux: fix uevent message parsing
> test/red: fix typo in test description
> examples/ntb: fix build dependency
>
> Eli Britstein (4):
> net: avoid cast-align warning in VLAN insert function
> mbuf: avoid cast-align warning in data offset macro
> eal/x86: avoid cast-align warning in memcpy functions
> app/testpmd: fix packet burst spreading stats
>
> Eugenio Pérez (1):
> vhost: clean IOTLB cache on vring stop
>
> Fan Zhang (1):
> examples/fips_validation: fix device start
>
> Feifei Wang (2):
> drivers/net: fix typo in vector Rx comment
> drivers/net: fix vector Rx comments
>
> Ferruh Yigit (3):
> net/softnic: fix useless address check
> net/i40e: fix 32-bit build
> ethdev: fix crash on owner delete
>
> Gagandeep Singh (3):
> common/dpaax/caamflib: fix IV for short MAC-I in SNOW3G
> common/dpaax: fix physical address conversion
> drivers/crypto: fix IPsec TTL decrement option
>
> Gaoxiang Liu (1):
> vhost: log socket path on adding connection
>
> Georg Sauthoff (1):
> net: fix aliasing in checksum computation
>
> Gregory Etelson (6):
> examples/multi_process: fix Rx packets distribution
> net/mlx5: fix RSS expansion scheme for GRE header
> app/testpmd: fix hexadecimal parser with odd length
> net/mlx5: fix VXLAN-GPE next protocol translation
> net/mlx5: fix GENEVE protocol type translation
> net/mlx5: fix GRE protocol type translation
>
> Haiyue Wang (1):
> net/ice: fix memzone leak after device init failure
>
> Hanumanth Reddy Pothula (1):
> net/octeontx2: fix MTU when PTP is enabled
>
> Harneet Singh (1):
> examples/l3fwd-power: fix early shutdown
>
> Harry van Haaren (1):
> app/eventdev: fix terminal colour after control-c exit
>
> Heinrich Kuhn (1):
> net/nfp: fix minimum descriptor sizes
>
> Honnappa Nagarahalli (1):
> eal: reset lcore task callback and argument
>
> Huisong Li (5):
> net/hns3: fix input parameters of MAC functions
> app/testpmd: retain all original dev conf when config DCB
> ethdev: fix PCI device release in secondary process
> net/hns3: simplify queue DMA address arithmetic
> app/testpmd: remove unused header file
>
> Hyong Youb Kim (2):
> net/enic: fix filter mode detection
> net/enic: avoid error message when no advanced filtering
>
> Ivan Ilchenko (2):
> net/virtio: fix mbuf count on Rx queue setup
> ethdev: fix xstats by ID API documentation
>
> Jerin Jacob (1):
> examples/performance-thread: fix build with clang 12.0.1
>
> Jiawei Wang (1):
> net/mlx5: fix metadata and meter split shared tag
>
> Jie Wang (2):
> net/i40e: fix forward outer IPv6 VXLAN
> app/testpmd: fix DCB in VT configuration
>
> Jim Harris (2):
> eal/linux: remove unused variable for socket memory
> power: fix build with clang 13
>
> Joyce Kong (2):
> test/service: fix some comment
> test/func_reentrancy: free memzones after test
>
> Julien Meunier (2):
> stack: fix reload head when pop fails
> net/ixgbe: fix queue release
>
> Junxiao Shi (1):
> net/memif: fix chained mbuf determination
>
> Kai Ji (1):
> test/crypto: fix data lengths
>
> Kalesh AP (5):
> net/bnxt: fix ring group free
> net/bnxt: fix double allocation of ring groups
> net/bnxt: fix function driver register/unregister
> net/bnxt: check FW capability for VLAN offloads
> net/bnxt: fix VLAN indication in Rx mbuf
>
> Kevin Traynor (2):
> bitrate: fix registration to match API description
> bitrate: fix calculation to match API description
>
> Konstantin Ananyev (2):
> test/bpf: fix undefined behavior with clang
> test: fix ring PMD initialisation
>
> Kumara Parameshwaran (1):
> net/failsafe: fix secondary process probe
>
> Lance Richardson (1):
> net: fix checksum API documentation
>
> Li Feng (1):
> vhost: add sanity check on inflight last index
>
> Long Li (1):
> bus/vmbus: fix ring buffer mapping in secondary process
>
> Maciej Szwed (1):
> interrupt: fix request notifier interrupt processing
>
> Maxime Coquelin (3):
> app/testpmd: fix RSS key length
> app/testpmd: fix RSS type display
> net/mlx5: fix RSS RETA update
>
> Michal Krawczyk (4):
> net/ena: fix offload capabilities verification
> net/ena: fix per-queue offload capabilities
> net/ena: advertise scattered Rx capability
> Revert "net/ena: trigger reset on Tx prepare failure"
>
> Naga Harish K S V (2):
> eventdev/eth_rx: fix WRR buffer overrun
> eventdev/eth_tx: fix queue delete logic
>
> Nithin Dabilpuram (2):
> app/testpmd: fix check without outer checksum
> app/testpmd: fix dump of Tx offload flags
>
> Olivier Matz (1):
> mem: fix dynamic hugepage mapping in container
>
> Pablo de Lara (1):
> efd: allow more CPU sockets in table creation
>
> Przemyslaw Zegan (2):
> app/crypto-perf: fix AAD template copy overrun
> common/qat: fix queue pairs number
>
> Qi Zhang (1):
> net/ice/base: fix typo in comment
>
> Qiming Chen (12):
> net/ixgbe: fix Rx multicast statistics after reset
> net/pcap: fix resource leakage on port probe
> net/ixgbe: fix hash handle leak
> net/ixgbe: fix queue resource leak
> net/ixgbe: fix MAC resource leak
> net/ixgbe: fix mbuf leak
> net/i40e: fix mbuf leak
> net/i40e: fix device startup resource release
> net/iavf: fix mbuf leak
> net/i40e/base: fix resource leakage
> net/iavf: fix Rx queue buffer size alignment
> common/iavf: fix ARQ resource leak
>
> Rebecca Troy (1):
> test/compress: fix buffer overflow
>
> Robin Zhang (7):
> net/i40e/base: fix PHY identifiers for 2.5G and 5G adapters
> net/i40e/base: fix PF reset
> net/i40e/base: fix update link data for X722
> net/i40e/base: fix AOC media type
> net/i40e/base: fix function name in comments
> net/i40e/base: fix potentially uninitialized variables
> net/i40e/base: fix using checksum before check
>
> Ruifeng Wang (3):
> examples/service_cores: fix lcore count check
> net/i40e: fix risk in descriptor read in NEON Rx
> net/i40e: fix risk in descriptor read in scalar Rx
>
> Sean Morrissey (3):
> remove repeated 'the' in the code
> fix PMD wording
> doc: capitalise PMD
>
> Shijith Thotton (2):
> test/event_crypto: fix event crypto metadata write
> test/event: fix timer adapter creation test
>
> Somnath Kotur (1):
> net/bnxt: fix Rx next consumer index in mbuf alloc fail
>
> Stephen Hemminger (4):
> mbuf: fix typo in comment
> bpf: allow self-xor operation
> net/bnxt: fix firmware version query
> fix spelling in comments and doxygen
>
> Sunil Kumar Kori (1):
> app/testpmd: fix access to DSCP table entries
>
> Thomas Monjalon (2):
> net/qede: fix minsize build
> doc: remove repeated repeated words
>
> Timothy Redaelli (1):
> doc: strip build artefacts for examples file list
>
> Tudor Cornea (3):
> net/iavf: fix overflow in maximum packet length config
> net/af_packet: fix ignoring full ring on Tx
> net/ixgbe: fix port initialization if MTU config fails
>
> Vanshika Shukla (1):
> examples/ptpclient: fix delay request message
>
> Viacheslav Ovsiienko (2):
> app/testpmd: fix hex string parser in flow commands
> doc: describe timestamp limitations for mlx5
>
> Vladimir Medvedkin (3):
> hash: fix Doxygen comment of Toeplitz file
> lpm6: fix buffer overflow
> rib: fix IPv6 depth mask
>
> William Tu (1):
> doc: fix emulated device names in e1000 guide
>
> Xiaoyu Min (1):
> net/mlx4: fix empty Ethernet spec with VLAN
>
> Xuan Ding (1):
> net/virtio: fix indirect descriptor reconnection
>
> Xueming Li (2):
> eal: fix device iterator when no bus is selected
> net/mlx5: fix Altivec Rx
>
> Yunjian Wang (1):
> net/ice: fix memzone leak on queue re-configure
>
> Yury Kylulin (1):
> net/i40e: support 25G AOC/ACC cables
>
> Zhihong Peng (1):
> examples/performance-thread: fix build with ASan
>
> Zhihong Wang (1):
> app/testpmd: fix Tx retry in flowgen engine
>
>
[-- Attachment #2: Type: text/html, Size: 17388 bytes --]
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-14 13:51 ` Pei Zhang
@ 2021-12-14 13:52 ` Christian Ehrhardt
0 siblings, 0 replies; 33+ messages in thread
From: Christian Ehrhardt @ 2021-12-14 13:52 UTC (permalink / raw)
To: Pei Zhang
Cc: stable, dev, Abhishek Marathe, Akhil Goyal, Ali Alnubani,
benjamin.walker, David Christensen, hariprasad.govindharajan,
Hemant Agrawal, Ian Stokes, Jerin Jacob, John McNamara,
Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi, pingx.yu, xu, qian,
Raslan Darawsheh, Thomas Monjalon, yuan.peng, Chen, Zhaoyan,
Chao Yang, Maxime Coquelin, David Marchand
[-- Attachment #1: Type: text/plain, Size: 15004 bytes --]
On Tue, Dec 14, 2021 at 2:51 PM Pei Zhang <pezhang@redhat.com> wrote:
> Hello Christian,
>
> The testing with dpdk 19.11.11-rc1 from Red Hat looks good. We tested
> below 17 scenarios and all got PASS on RHEL8:
>
Thank you!
> (1)Guest with device assignment(PF) throughput testing(1G hugepage size):
> PASS
> (2)Guest with device assignment(PF) throughput testing(2M hugepage size) :
> PASS
> (3)Guest with device assignment(VF) throughput testing: PASS
> (4)PVP (host dpdk testpmd as vswitch) 1Q: throughput testing: PASS
> (5)PVP vhost-user 2Q throughput testing: PASS
> (6)PVP vhost-user 1Q - cross numa node throughput testing: PASS
> (7)Guest with vhost-user 2Q throughput testing: PASS
> (8)vhost-user reconnect with dpdk-client, qemu-server: qemu reconnect: PASS
> (9)vhost-user reconnect with dpdk-client, qemu-server: ovs reconnect: PASS
> (10)PVP 1Q live migration testing: PASS
> (11)PVP 1Q cross numa node live migration testing: PASS
> (12)Guest with ovs+dpdk+vhost-user 1Q live migration testing: PASS
> (13)Guest with ovs+dpdk+vhost-user 1Q live migration testing (2M): PASS
> (14)Guest with ovs+dpdk+vhost-user 2Q live migration testing: PASS
> (15)Guest with ovs+dpdk+vhost-user 4Q live migration testing: PASS
> (16)Host PF + DPDK testing: PASS
> (17)Host VF + DPDK testing: PASS
>
> Versions:
> kernel 4.18
> qemu 6.1
>
> dpdk: git://dpdk.org/dpdk-stable
> branch: remotes/origin/19.11
> # git log -1
> commit 928100dd6d30e733be411380fdb78c68a061936c (HEAD, tag: v19.11.11-rc1,
> origin/19.11)
> Author: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> Date: Thu Dec 9 15:33:57 2021 +0100
>
> version: 19.11.11-rc1
>
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
>
>
> NICs: X540-AT2 NIC(ixgbe, 10G)
>
> Best regards,
>
> Pei
>
> On Thu, Dec 9, 2021 at 10:43 PM <christian.ehrhardt@canonical.com> wrote:
>
>> Hi all,
>>
>> Here is a list of patches targeted for stable release 19.11.11.
>>
>> The planned date for the final release is 7th January 2021.
>>
>> Please help with testing and validation of your use cases and report
>> any issues/results with reply-all to this mail. For the final release
>> the fixes and reported validations will be added to the release notes.
>>
>> A release candidate tarball can be found at:
>>
>> https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1
>>
>> These patches are located at branch 19.11 of dpdk-stable repo:
>> https://dpdk.org/browse/dpdk-stable/
>>
>> Thanks.
>>
>> Christian Ehrhardt <christian.ehrhardt@canonical.com>
>>
>> ---
>> Ajit Khaparde (3):
>> net/bnxt: fix Tx queue startup state
>> net/bnxt: fix memzone free for Tx and Rx rings
>> net/bnxt: fix tunnel port accounting
>>
>> Alexander Bechikov (1):
>> mbuf: fix dump of dynamic fields and flags
>>
>> Alexander Kozyrev (2):
>> net/mlx5: fix GENEVE and VXLAN-GPE flow item matching
>> net/mlx5: fix GRE flow item matching
>>
>> Alvin Zhang (1):
>> net/i40e: fix Rx packet statistics
>>
>> Aman Singh (1):
>> kni: fix build for SLES15-SP3
>>
>> Anatoly Burakov (2):
>> vfio: fix FreeBSD clear group stub
>> vfio: fix FreeBSD documentation
>>
>> Anoob Joseph (2):
>> test/crypto: skip plain text compare for null cipher
>> common/cpt: fix KASUMI input length
>>
>> Arek Kusztal (2):
>> crypto/qat: fix status in RSA decryption
>> crypto/qat: fix uncleared cookies after operation
>>
>> Ben Pfaff (1):
>> doc: fix numbers power of 2 in LPM6 guide
>>
>> Bing Zhao (2):
>> net/mlx5: fix flow tables double release
>> net/mlx5: fix RETA update without stopping device
>>
>> Bruce Richardson (3):
>> eal/freebsd: lock memory device to prevent conflicts
>> test/mem: fix memory autotests on FreeBSD
>> eal/freebsd: ignore in-memory option
>>
>> Chengchang Tang (2):
>> net/bonding: fix dedicated queue mode in vector burst
>> net/bonding: fix RSS key length
>>
>> Chengfeng Ye (1):
>> net/axgbe: fix unreleased lock in I2C transfer
>>
>> Chengwen Feng (1):
>> kni: check error code of allmulticast mode switch
>>
>> Cian Ferriter (1):
>> ring: fix Doxygen comment of internal function
>>
>> Ciara Loftus (1):
>> net/af_xdp: disable secondary process support
>>
>> Ciara Power (3):
>> crypto/openssl: fix CCM processing 0 length source
>> examples/fips_validation: remove unused allocation
>> test/crypto: fix unnecessary stats retrieval
>>
>> Conor Walsh (8):
>> net/hinic/base: remove some unused variables
>> bus/fslmc: remove unused device count
>> event/sw: remove unused inflight events count
>> net/liquidio: remove unused counter
>> net/qede/base: remove unused message size
>> net/vmxnet3: fix build with clang 13
>> test/distributor: remove unused counter
>> examples/performance-thread: remove unused hits count
>>
>> Dapeng Yu (1):
>> net/ice: save rule on switch filter creation
>>
>> Dariusz Sosnowski (2):
>> net/mlx5: fix MPLS tunnel outer layer overwrite
>> doc: fix typo in coding style
>>
>> David Christensen (3):
>> eal/ppc: ignore GCC 10 stringop-overflow warnings
>> config/ppc: ignore GCC 11 psabi warnings
>> test/atomic: fix 128-bit atomic test with many cores
>>
>> David Hunt (1):
>> test/power: fix CPU frequency when turbo enabled
>>
>> David Marchand (10):
>> net/virtio: avoid unneeded link interrupt configuration
>> net/virtio-user: fix Rx interrupts with multi-queue
>> bus/vmbus: fix leak on device scan
>> test/latency: fix loop boundary
>> eal/x86: fix some CPU extended features definitions
>> mbuf: enforce no option for dynamic fields and flags
>> doc: fix default mempool option in guides
>> eal/linux: fix uevent message parsing
>> test/red: fix typo in test description
>> examples/ntb: fix build dependency
>>
>> Eli Britstein (4):
>> net: avoid cast-align warning in VLAN insert function
>> mbuf: avoid cast-align warning in data offset macro
>> eal/x86: avoid cast-align warning in memcpy functions
>> app/testpmd: fix packet burst spreading stats
>>
>> Eugenio Pérez (1):
>> vhost: clean IOTLB cache on vring stop
>>
>> Fan Zhang (1):
>> examples/fips_validation: fix device start
>>
>> Feifei Wang (2):
>> drivers/net: fix typo in vector Rx comment
>> drivers/net: fix vector Rx comments
>>
>> Ferruh Yigit (3):
>> net/softnic: fix useless address check
>> net/i40e: fix 32-bit build
>> ethdev: fix crash on owner delete
>>
>> Gagandeep Singh (3):
>> common/dpaax/caamflib: fix IV for short MAC-I in SNOW3G
>> common/dpaax: fix physical address conversion
>> drivers/crypto: fix IPsec TTL decrement option
>>
>> Gaoxiang Liu (1):
>> vhost: log socket path on adding connection
>>
>> Georg Sauthoff (1):
>> net: fix aliasing in checksum computation
>>
>> Gregory Etelson (6):
>> examples/multi_process: fix Rx packets distribution
>> net/mlx5: fix RSS expansion scheme for GRE header
>> app/testpmd: fix hexadecimal parser with odd length
>> net/mlx5: fix VXLAN-GPE next protocol translation
>> net/mlx5: fix GENEVE protocol type translation
>> net/mlx5: fix GRE protocol type translation
>>
>> Haiyue Wang (1):
>> net/ice: fix memzone leak after device init failure
>>
>> Hanumanth Reddy Pothula (1):
>> net/octeontx2: fix MTU when PTP is enabled
>>
>> Harneet Singh (1):
>> examples/l3fwd-power: fix early shutdown
>>
>> Harry van Haaren (1):
>> app/eventdev: fix terminal colour after control-c exit
>>
>> Heinrich Kuhn (1):
>> net/nfp: fix minimum descriptor sizes
>>
>> Honnappa Nagarahalli (1):
>> eal: reset lcore task callback and argument
>>
>> Huisong Li (5):
>> net/hns3: fix input parameters of MAC functions
>> app/testpmd: retain all original dev conf when config DCB
>> ethdev: fix PCI device release in secondary process
>> net/hns3: simplify queue DMA address arithmetic
>> app/testpmd: remove unused header file
>>
>> Hyong Youb Kim (2):
>> net/enic: fix filter mode detection
>> net/enic: avoid error message when no advanced filtering
>>
>> Ivan Ilchenko (2):
>> net/virtio: fix mbuf count on Rx queue setup
>> ethdev: fix xstats by ID API documentation
>>
>> Jerin Jacob (1):
>> examples/performance-thread: fix build with clang 12.0.1
>>
>> Jiawei Wang (1):
>> net/mlx5: fix metadata and meter split shared tag
>>
>> Jie Wang (2):
>> net/i40e: fix forward outer IPv6 VXLAN
>> app/testpmd: fix DCB in VT configuration
>>
>> Jim Harris (2):
>> eal/linux: remove unused variable for socket memory
>> power: fix build with clang 13
>>
>> Joyce Kong (2):
>> test/service: fix some comment
>> test/func_reentrancy: free memzones after test
>>
>> Julien Meunier (2):
>> stack: fix reload head when pop fails
>> net/ixgbe: fix queue release
>>
>> Junxiao Shi (1):
>> net/memif: fix chained mbuf determination
>>
>> Kai Ji (1):
>> test/crypto: fix data lengths
>>
>> Kalesh AP (5):
>> net/bnxt: fix ring group free
>> net/bnxt: fix double allocation of ring groups
>> net/bnxt: fix function driver register/unregister
>> net/bnxt: check FW capability for VLAN offloads
>> net/bnxt: fix VLAN indication in Rx mbuf
>>
>> Kevin Traynor (2):
>> bitrate: fix registration to match API description
>> bitrate: fix calculation to match API description
>>
>> Konstantin Ananyev (2):
>> test/bpf: fix undefined behavior with clang
>> test: fix ring PMD initialisation
>>
>> Kumara Parameshwaran (1):
>> net/failsafe: fix secondary process probe
>>
>> Lance Richardson (1):
>> net: fix checksum API documentation
>>
>> Li Feng (1):
>> vhost: add sanity check on inflight last index
>>
>> Long Li (1):
>> bus/vmbus: fix ring buffer mapping in secondary process
>>
>> Maciej Szwed (1):
>> interrupt: fix request notifier interrupt processing
>>
>> Maxime Coquelin (3):
>> app/testpmd: fix RSS key length
>> app/testpmd: fix RSS type display
>> net/mlx5: fix RSS RETA update
>>
>> Michal Krawczyk (4):
>> net/ena: fix offload capabilities verification
>> net/ena: fix per-queue offload capabilities
>> net/ena: advertise scattered Rx capability
>> Revert "net/ena: trigger reset on Tx prepare failure"
>>
>> Naga Harish K S V (2):
>> eventdev/eth_rx: fix WRR buffer overrun
>> eventdev/eth_tx: fix queue delete logic
>>
>> Nithin Dabilpuram (2):
>> app/testpmd: fix check without outer checksum
>> app/testpmd: fix dump of Tx offload flags
>>
>> Olivier Matz (1):
>> mem: fix dynamic hugepage mapping in container
>>
>> Pablo de Lara (1):
>> efd: allow more CPU sockets in table creation
>>
>> Przemyslaw Zegan (2):
>> app/crypto-perf: fix AAD template copy overrun
>> common/qat: fix queue pairs number
>>
>> Qi Zhang (1):
>> net/ice/base: fix typo in comment
>>
>> Qiming Chen (12):
>> net/ixgbe: fix Rx multicast statistics after reset
>> net/pcap: fix resource leakage on port probe
>> net/ixgbe: fix hash handle leak
>> net/ixgbe: fix queue resource leak
>> net/ixgbe: fix MAC resource leak
>> net/ixgbe: fix mbuf leak
>> net/i40e: fix mbuf leak
>> net/i40e: fix device startup resource release
>> net/iavf: fix mbuf leak
>> net/i40e/base: fix resource leakage
>> net/iavf: fix Rx queue buffer size alignment
>> common/iavf: fix ARQ resource leak
>>
>> Rebecca Troy (1):
>> test/compress: fix buffer overflow
>>
>> Robin Zhang (7):
>> net/i40e/base: fix PHY identifiers for 2.5G and 5G adapters
>> net/i40e/base: fix PF reset
>> net/i40e/base: fix update link data for X722
>> net/i40e/base: fix AOC media type
>> net/i40e/base: fix function name in comments
>> net/i40e/base: fix potentially uninitialized variables
>> net/i40e/base: fix using checksum before check
>>
>> Ruifeng Wang (3):
>> examples/service_cores: fix lcore count check
>> net/i40e: fix risk in descriptor read in NEON Rx
>> net/i40e: fix risk in descriptor read in scalar Rx
>>
>> Sean Morrissey (3):
>> remove repeated 'the' in the code
>> fix PMD wording
>> doc: capitalise PMD
>>
>> Shijith Thotton (2):
>> test/event_crypto: fix event crypto metadata write
>> test/event: fix timer adapter creation test
>>
>> Somnath Kotur (1):
>> net/bnxt: fix Rx next consumer index in mbuf alloc fail
>>
>> Stephen Hemminger (4):
>> mbuf: fix typo in comment
>> bpf: allow self-xor operation
>> net/bnxt: fix firmware version query
>> fix spelling in comments and doxygen
>>
>> Sunil Kumar Kori (1):
>> app/testpmd: fix access to DSCP table entries
>>
>> Thomas Monjalon (2):
>> net/qede: fix minsize build
>> doc: remove repeated repeated words
>>
>> Timothy Redaelli (1):
>> doc: strip build artefacts for examples file list
>>
>> Tudor Cornea (3):
>> net/iavf: fix overflow in maximum packet length config
>> net/af_packet: fix ignoring full ring on Tx
>> net/ixgbe: fix port initialization if MTU config fails
>>
>> Vanshika Shukla (1):
>> examples/ptpclient: fix delay request message
>>
>> Viacheslav Ovsiienko (2):
>> app/testpmd: fix hex string parser in flow commands
>> doc: describe timestamp limitations for mlx5
>>
>> Vladimir Medvedkin (3):
>> hash: fix Doxygen comment of Toeplitz file
>> lpm6: fix buffer overflow
>> rib: fix IPv6 depth mask
>>
>> William Tu (1):
>> doc: fix emulated device names in e1000 guide
>>
>> Xiaoyu Min (1):
>> net/mlx4: fix empty Ethernet spec with VLAN
>>
>> Xuan Ding (1):
>> net/virtio: fix indirect descriptor reconnection
>>
>> Xueming Li (2):
>> eal: fix device iterator when no bus is selected
>> net/mlx5: fix Altivec Rx
>>
>> Yunjian Wang (1):
>> net/ice: fix memzone leak on queue re-configure
>>
>> Yury Kylulin (1):
>> net/i40e: support 25G AOC/ACC cables
>>
>> Zhihong Peng (1):
>> examples/performance-thread: fix build with ASan
>>
>> Zhihong Wang (1):
>> app/testpmd: fix Tx retry in flowgen engine
>>
>>
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
[-- Attachment #2: Type: text/html, Size: 18173 bytes --]
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-14 12:08 ` Ferruh Yigit
@ 2021-12-14 13:57 ` Christian Ehrhardt
0 siblings, 0 replies; 33+ messages in thread
From: Christian Ehrhardt @ 2021-12-14 13:57 UTC (permalink / raw)
To: Ferruh Yigit
Cc: Luca Boccassi, Kevin Traynor, Xueming(Steven) Li,
Kalesh Anakkur Purayil, Abhishek Marathe, Akhil Goyal,
Ali Alnubani, David Christensen, Hariprasad Govindharajan,
Hemant Agrawal, Ian Stokes, Jerin Jacob, John McNamara,
Ju-Hyoung Lee, Pei Zhang, Raslan Darawsheh, Thomas Monjalon,
benjamin.walker, dpdk stable, dpdk-dev, pingx.yu, qian.q.xu,
yuan.peng, zhaoyan.chen
On Tue, Dec 14, 2021 at 1:08 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 12/14/2021 11:39 AM, Christian Ehrhardt wrote:
> > On Tue, Dec 14, 2021 at 11:13 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >>
> >> On 12/14/2021 7:44 AM, Christian Ehrhardt wrote:
> >>> On Tue, Dec 14, 2021 at 6:49 AM Kalesh Anakkur Purayil
> >>> <kalesh-anakkur.purayil@broadcom.com> wrote:
> >>>
> >>> [snip]
> >>>
> >>>>>> [Kalesh] Yes, i am seeing the same error. I used make command to build dpdk, not meson.
> >>>>>> The back ported commit you mentioned takes care of meson build only I think.
> >>>>>>
> >>>>>
> >>>>> I see, make build is failing, and yes the fix is only for the meson.
> >>>>> I will check the make build and will send a fix for it.
> >>>>
> >>>> [Kalesh]: looks like the below changes fixes the issue. I tried only on SLES15 SP3 and not on other SLES flavors.
> >>>>
> >>>> diff --git a/kernel/linux/kni/Makefile b/kernel/linux/kni/Makefile
> >>>> index 595bac2..bf0efab 100644
> >>>> --- a/kernel/linux/kni/Makefile
> >>>> +++ b/kernel/linux/kni/Makefile
> >>>> @@ -16,6 +16,16 @@ MODULE_CFLAGS += -I$(RTE_OUTPUT)/include
> >>>> MODULE_CFLAGS += -include $(RTE_OUTPUT)/include/rte_config.h
> >>>> MODULE_CFLAGS += -Wall -Werror
> >>>>
> >>>> +#
> >>>> +# Use explicit 'source' folder for header path. In SUSE 'source' is not linked to 'build' folder.
> >>>> +#
> >>>> +ifdef CONFIG_SUSE_KERNEL
> >>>> + KSRC = /lib/modules/$(shell uname -r)/source
> >>>> + ifneq ($(shell grep -A 1 "ndo_tx_timeout" $(KSRC)/include/linux/netdevice.h | grep -o txqueue),)
> >>>> + MODULE_CFLAGS += -DHAVE_TX_TIMEOUT_TXQUEUE
> >>>> + endif
> >>>> +endif
> >>>
> >>> Back in the day we tried various "is Suse and kernel version x.y"
> >>> approaches, but they failed as there was no clear version throughout
> >>> all of the Suse streams (leap, tumbleweed, sles) that worked well for
> >>> all.
> >>> This change here follows the upstream approach of "just check if it is there".
> >>>
> >>> I've applied this to 19.11 and did test builds across various distributions:
> >>> 1. no non-suse build changed
> >>> 2. suse builds stayed as-is or improved
> >>> Formerly failing:
> >>> openSUSE_Factory_ARM aarch64
> >>> SLE_15 x86_64 -> now working
> >>> openSUSE_Leap_15.3 x86_64 -> now working
> >>> openSUSE_Tumbleweed x86_64 -> still failing
> >>> Formerly working:
> >>> SLE_12_SP4 x86_64 ppc64le -> still fine
> >>> openSUSE_Factory_ARM armv7l -> still fine
> >>> openSUSE_Leap_15.2 x86_64 -> still fine
> >>>
> >>
> >> Thanks Kalesh for the fix, and thanks Christian for testing.
> >>
> >> I was expecting this approach will fix all builds, after patch only
> >> 'openSUSE_Tumbleweed' is failing, right? I will check it.
> >
> > As just discussed on IRC, yes and the log for that is at
> > https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/openSUSE_Tumbleweed/x86_64
> >
> > It also is affected by an issue around -Werror=implicit-fallthrough,
> > so even with KNI fixed it likely is going to fail.
> >
> >> And I think you need the fix as a patch anyway, @Kalesh are you
> >> planning to send the patch?
> >
> > I don't need it, as I have already grabbed and preliminary added it:
> > https://github.com/cpaelzer/dpdk-stable-queue/commit/d43fa3e198c08a3a76d70f4565b31ad3ab5f29c4
> >
>
> I was thinking any commit in the LTS *must* come from either upstream
> commit or a backport patch in the stable mail list.
To be clear, yes we want transparency where things come from, but in
this case we had all of that.
It is an extension (by Kalesh) of a backport (by me) of c28e2165e that
was correctly sent to stable@dpdk.org
> Isn't it very hard to back trace merging diffs from emails,
> are you OK with that?
Only for the very special case it is here, not for random diff
snippets thrown in any thread.
The rule of thumb should still be "submit with prefix [Patch 19.11] to
stable@dpdk.org"
> > But surely, once/If you come up with a full patch that also includes
> > tumbleweed I can replace it with yours.
> >
> >>> Past fixes always "inverted" the result, by fixing some but breaking others.
> >>> This new patch works in "not breaking any formerly working build" but
> >>> at the same time fixing a few builds.
> >>> Therefore -> applied & thanks!
> >>>
> >>> I'll likely tag -rc2 before the end of the week.
> >>> The good thing is that (so far) we have:
> >>> 1. a non functional change
> >>> 2. a change fixing clang-13 builds (TBH only one of many needed clang13 issues)
> >>> 3. a change fixing sles15SP3 builds
> >>>
> >>> Due to those, no current ongoing tests will have to be restarted.
> >>> Whoever was able to build, can continue the current tests.
> >>> Whoever was blocked by SLES15SP3 or clang-13 had no tests other than a
> >>> failing build and can work with -rc2 then.
> >>> I'll explain the same in the mail about -rc2.
> >>>
> >>>> -include /etc/lsb-release
> >>>>
> >>>> ifeq ($(DISTRIB_ID),Ubuntu)
> >>>>
> >>>> Regards,
> >>>> Kalesh
> >>>
> >>> [snip]
> >>>
> >>
> >
> >
>
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-14 13:10 ` Ferruh Yigit
@ 2021-12-14 13:58 ` Christian Ehrhardt
2021-12-14 14:46 ` Christian Ehrhardt
0 siblings, 1 reply; 33+ messages in thread
From: Christian Ehrhardt @ 2021-12-14 13:58 UTC (permalink / raw)
To: Ferruh Yigit
Cc: Kalesh Anakkur Purayil, Abhishek Marathe, Akhil Goyal,
Ali Alnubani, David Christensen, Hariprasad Govindharajan,
Hemant Agrawal, Ian Stokes, Jerin Jacob, John McNamara,
Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi, Pei Zhang,
Raslan Darawsheh, Thomas Monjalon, benjamin.walker, dpdk stable,
dpdk-dev, pingx.yu, qian.q.xu, yuan.peng, zhaoyan.chen
On Tue, Dec 14, 2021 at 2:10 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 12/14/2021 11:39 AM, Christian Ehrhardt wrote:
> > On Tue, Dec 14, 2021 at 11:13 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >>
> >> On 12/14/2021 7:44 AM, Christian Ehrhardt wrote:
> >>> On Tue, Dec 14, 2021 at 6:49 AM Kalesh Anakkur Purayil
> >>> <kalesh-anakkur.purayil@broadcom.com> wrote:
> >>>
> >>> [snip]
> >>>
> >>>>>> [Kalesh] Yes, i am seeing the same error. I used make command to build dpdk, not meson.
> >>>>>> The back ported commit you mentioned takes care of meson build only I think.
> >>>>>>
> >>>>>
> >>>>> I see, make build is failing, and yes the fix is only for the meson.
> >>>>> I will check the make build and will send a fix for it.
> >>>>
> >>>> [Kalesh]: looks like the below changes fixes the issue. I tried only on SLES15 SP3 and not on other SLES flavors.
> >>>>
> >>>> diff --git a/kernel/linux/kni/Makefile b/kernel/linux/kni/Makefile
> >>>> index 595bac2..bf0efab 100644
> >>>> --- a/kernel/linux/kni/Makefile
> >>>> +++ b/kernel/linux/kni/Makefile
> >>>> @@ -16,6 +16,16 @@ MODULE_CFLAGS += -I$(RTE_OUTPUT)/include
> >>>> MODULE_CFLAGS += -include $(RTE_OUTPUT)/include/rte_config.h
> >>>> MODULE_CFLAGS += -Wall -Werror
> >>>>
> >>>> +#
> >>>> +# Use explicit 'source' folder for header path. In SUSE 'source' is not linked to 'build' folder.
> >>>> +#
> >>>> +ifdef CONFIG_SUSE_KERNEL
> >>>> + KSRC = /lib/modules/$(shell uname -r)/source
> >>>> + ifneq ($(shell grep -A 1 "ndo_tx_timeout" $(KSRC)/include/linux/netdevice.h | grep -o txqueue),)
> >>>> + MODULE_CFLAGS += -DHAVE_TX_TIMEOUT_TXQUEUE
> >>>> + endif
> >>>> +endif
> >>>
> >>> Back in the day we tried various "is Suse and kernel version x.y"
> >>> approaches, but they failed as there was no clear version throughout
> >>> all of the Suse streams (leap, tumbleweed, sles) that worked well for
> >>> all.
> >>> This change here follows the upstream approach of "just check if it is there".
> >>>
> >>> I've applied this to 19.11 and did test builds across various distributions:
> >>> 1. no non-suse build changed
> >>> 2. suse builds stayed as-is or improved
> >>> Formerly failing:
> >>> openSUSE_Factory_ARM aarch64
> >>> SLE_15 x86_64 -> now working
> >>> openSUSE_Leap_15.3 x86_64 -> now working
> >>> openSUSE_Tumbleweed x86_64 -> still failing
> >>> Formerly working:
> >>> SLE_12_SP4 x86_64 ppc64le -> still fine
> >>> openSUSE_Factory_ARM armv7l -> still fine
> >>> openSUSE_Leap_15.2 x86_64 -> still fine
> >>>
> >>
> >> Thanks Kalesh for the fix, and thanks Christian for testing.
> >>
> >> I was expecting this approach will fix all builds, after patch only
> >> 'openSUSE_Tumbleweed' is failing, right? I will check it.
> >
> > As just discussed on IRC, yes and the log for that is at
> > https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/openSUSE_Tumbleweed/x86_64
> >
> > It also is affected by an issue around -Werror=implicit-fallthrough,
> > so even with KNI fixed it likely is going to fail.
> >
> >> And I think you need the fix as a patch anyway, @Kalesh are you
> >> planning to send the patch?
> >
> > I don't need it, as I have already grabbed and preliminary added it:
> > https://github.com/cpaelzer/dpdk-stable-queue/commit/d43fa3e198c08a3a76d70f4565b31ad3ab5f29c4
> >
> > But surely, once/If you come up with a full patch that also includes
> > tumbleweed I can replace it with yours.
> >
>
> 'tumbleweed' error is odd, it complains about macro being redefined,
> not sure why only in this platform we are getting an error.
>
> Macro is only defined in one place, but indeed header file included
> multiple times, one direct and one indirect, so macro defined multiple
> times but without value, so it should be OK and it is OK for other
> platforms, it is defined as:
> #define HAVE_TX_TIMEOUT_TXQUEUE
>
> Another option is that macro is defined in some other header file,
> although I think that is very unlikely, can you please test with
> below change to rule out that option:
I'm testing that and will let you know in a bit ...
> diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h
> index 664785674ff1..71846419f437 100644
> --- a/kernel/linux/kni/compat.h
> +++ b/kernel/linux/kni/compat.h
> @@ -135,7 +135,7 @@
> (defined(RHEL_RELEASE_CODE) && \
> RHEL_RELEASE_VERSION(8, 3) <= RHEL_RELEASE_CODE) || \
> (defined(CONFIG_SUSE_KERNEL) && defined(HAVE_ARG_TX_QUEUE))
> -#define HAVE_TX_TIMEOUT_TXQUEUE
> +#define RTE_HAVE_TX_TIMEOUT_TXQUEUE
> #endif
>
> #if KERNEL_VERSION(5, 9, 0) > LINUX_VERSION_CODE
> diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c
> index c8bad5f197ca..7397de4659b2 100644
> --- a/kernel/linux/kni/kni_net.c
> +++ b/kernel/linux/kni/kni_net.c
> @@ -623,7 +623,7 @@ kni_net_rx(struct kni_dev *kni)
> /*
> * Deal with a transmit timeout.
> */
> -#ifdef HAVE_TX_TIMEOUT_TXQUEUE
> +#ifdef RTE_HAVE_TX_TIMEOUT_TXQUEUE
> static void
> kni_net_tx_timeout(struct net_device *dev, unsigned int txqueue)
> #else
>
>
> >>> Past fixes always "inverted" the result, by fixing some but breaking others.
> >>> This new patch works in "not breaking any formerly working build" but
> >>> at the same time fixing a few builds.
> >>> Therefore -> applied & thanks!
> >>>
> >>> I'll likely tag -rc2 before the end of the week.
> >>> The good thing is that (so far) we have:
> >>> 1. a non functional change
> >>> 2. a change fixing clang-13 builds (TBH only one of many needed clang13 issues)
> >>> 3. a change fixing sles15SP3 builds
> >>>
> >>> Due to those, no current ongoing tests will have to be restarted.
> >>> Whoever was able to build, can continue the current tests.
> >>> Whoever was blocked by SLES15SP3 or clang-13 had no tests other than a
> >>> failing build and can work with -rc2 then.
> >>> I'll explain the same in the mail about -rc2.
> >>>
> >>>> -include /etc/lsb-release
> >>>>
> >>>> ifeq ($(DISTRIB_ID),Ubuntu)
> >>>>
> >>>> Regards,
> >>>> Kalesh
> >>>
> >>> [snip]
> >>>
> >>
> >
> >
>
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-14 13:58 ` Christian Ehrhardt
@ 2021-12-14 14:46 ` Christian Ehrhardt
2021-12-14 14:52 ` Ferruh Yigit
0 siblings, 1 reply; 33+ messages in thread
From: Christian Ehrhardt @ 2021-12-14 14:46 UTC (permalink / raw)
To: Ferruh Yigit
Cc: Kalesh Anakkur Purayil, Abhishek Marathe, Akhil Goyal,
Ali Alnubani, David Christensen, Hariprasad Govindharajan,
Hemant Agrawal, Ian Stokes, Jerin Jacob, John McNamara,
Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi, Pei Zhang,
Raslan Darawsheh, Thomas Monjalon, benjamin.walker, dpdk stable,
dpdk-dev, pingx.yu, qian.q.xu, yuan.peng, zhaoyan.chen
On Tue, Dec 14, 2021 at 2:58 PM Christian Ehrhardt
<christian.ehrhardt@canonical.com> wrote:
>
> On Tue, Dec 14, 2021 at 2:10 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >
> > On 12/14/2021 11:39 AM, Christian Ehrhardt wrote:
> > > On Tue, Dec 14, 2021 at 11:13 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> > >>
> > >> On 12/14/2021 7:44 AM, Christian Ehrhardt wrote:
> > >>> On Tue, Dec 14, 2021 at 6:49 AM Kalesh Anakkur Purayil
> > >>> <kalesh-anakkur.purayil@broadcom.com> wrote:
> > >>>
> > >>> [snip]
> > >>>
> > >>>>>> [Kalesh] Yes, i am seeing the same error. I used make command to build dpdk, not meson.
> > >>>>>> The back ported commit you mentioned takes care of meson build only I think.
> > >>>>>>
> > >>>>>
> > >>>>> I see, make build is failing, and yes the fix is only for the meson.
> > >>>>> I will check the make build and will send a fix for it.
> > >>>>
> > >>>> [Kalesh]: looks like the below changes fixes the issue. I tried only on SLES15 SP3 and not on other SLES flavors.
> > >>>>
> > >>>> diff --git a/kernel/linux/kni/Makefile b/kernel/linux/kni/Makefile
> > >>>> index 595bac2..bf0efab 100644
> > >>>> --- a/kernel/linux/kni/Makefile
> > >>>> +++ b/kernel/linux/kni/Makefile
> > >>>> @@ -16,6 +16,16 @@ MODULE_CFLAGS += -I$(RTE_OUTPUT)/include
> > >>>> MODULE_CFLAGS += -include $(RTE_OUTPUT)/include/rte_config.h
> > >>>> MODULE_CFLAGS += -Wall -Werror
> > >>>>
> > >>>> +#
> > >>>> +# Use explicit 'source' folder for header path. In SUSE 'source' is not linked to 'build' folder.
> > >>>> +#
> > >>>> +ifdef CONFIG_SUSE_KERNEL
> > >>>> + KSRC = /lib/modules/$(shell uname -r)/source
> > >>>> + ifneq ($(shell grep -A 1 "ndo_tx_timeout" $(KSRC)/include/linux/netdevice.h | grep -o txqueue),)
> > >>>> + MODULE_CFLAGS += -DHAVE_TX_TIMEOUT_TXQUEUE
> > >>>> + endif
> > >>>> +endif
> > >>>
> > >>> Back in the day we tried various "is Suse and kernel version x.y"
> > >>> approaches, but they failed as there was no clear version throughout
> > >>> all of the Suse streams (leap, tumbleweed, sles) that worked well for
> > >>> all.
> > >>> This change here follows the upstream approach of "just check if it is there".
> > >>>
> > >>> I've applied this to 19.11 and did test builds across various distributions:
> > >>> 1. no non-suse build changed
> > >>> 2. suse builds stayed as-is or improved
> > >>> Formerly failing:
> > >>> openSUSE_Factory_ARM aarch64
> > >>> SLE_15 x86_64 -> now working
> > >>> openSUSE_Leap_15.3 x86_64 -> now working
> > >>> openSUSE_Tumbleweed x86_64 -> still failing
> > >>> Formerly working:
> > >>> SLE_12_SP4 x86_64 ppc64le -> still fine
> > >>> openSUSE_Factory_ARM armv7l -> still fine
> > >>> openSUSE_Leap_15.2 x86_64 -> still fine
> > >>>
> > >>
> > >> Thanks Kalesh for the fix, and thanks Christian for testing.
> > >>
> > >> I was expecting this approach will fix all builds, after patch only
> > >> 'openSUSE_Tumbleweed' is failing, right? I will check it.
> > >
> > > As just discussed on IRC, yes and the log for that is at
> > > https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/openSUSE_Tumbleweed/x86_64
> > >
> > > It also is affected by an issue around -Werror=implicit-fallthrough,
> > > so even with KNI fixed it likely is going to fail.
> > >
> > >> And I think you need the fix as a patch anyway, @Kalesh are you
> > >> planning to send the patch?
> > >
> > > I don't need it, as I have already grabbed and preliminary added it:
> > > https://github.com/cpaelzer/dpdk-stable-queue/commit/d43fa3e198c08a3a76d70f4565b31ad3ab5f29c4
> > >
> > > But surely, once/If you come up with a full patch that also includes
> > > tumbleweed I can replace it with yours.
> > >
> >
> > 'tumbleweed' error is odd, it complains about macro being redefined,
> > not sure why only in this platform we are getting an error.
> >
> > Macro is only defined in one place, but indeed header file included
> > multiple times, one direct and one indirect, so macro defined multiple
> > times but without value, so it should be OK and it is OK for other
> > platforms, it is defined as:
> > #define HAVE_TX_TIMEOUT_TXQUEUE
> >
> > Another option is that macro is defined in some other header file,
> > although I think that is very unlikely, can you please test with
> > below change to rule out that option:
>
> I'm testing that and will let you know in a bit ...
Hi Ferruh,
with your change the build now works.
So indeed the symbol might have been defined elsewhere.
https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/openSUSE_Tumbleweed/x86_64
It still fails later with the "-Werror=implicit-fallthrough=" but that
is a different problem
=> https://bugs.dpdk.org/show_bug.cgi?id=907
Ferruh - are you ok if I merge your suggestion with the backport I got
from Kalesh?
> > diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h
> > index 664785674ff1..71846419f437 100644
> > --- a/kernel/linux/kni/compat.h
> > +++ b/kernel/linux/kni/compat.h
> > @@ -135,7 +135,7 @@
> > (defined(RHEL_RELEASE_CODE) && \
> > RHEL_RELEASE_VERSION(8, 3) <= RHEL_RELEASE_CODE) || \
> > (defined(CONFIG_SUSE_KERNEL) && defined(HAVE_ARG_TX_QUEUE))
> > -#define HAVE_TX_TIMEOUT_TXQUEUE
> > +#define RTE_HAVE_TX_TIMEOUT_TXQUEUE
> > #endif
> >
> > #if KERNEL_VERSION(5, 9, 0) > LINUX_VERSION_CODE
> > diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c
> > index c8bad5f197ca..7397de4659b2 100644
> > --- a/kernel/linux/kni/kni_net.c
> > +++ b/kernel/linux/kni/kni_net.c
> > @@ -623,7 +623,7 @@ kni_net_rx(struct kni_dev *kni)
> > /*
> > * Deal with a transmit timeout.
> > */
> > -#ifdef HAVE_TX_TIMEOUT_TXQUEUE
> > +#ifdef RTE_HAVE_TX_TIMEOUT_TXQUEUE
> > static void
> > kni_net_tx_timeout(struct net_device *dev, unsigned int txqueue)
> > #else
> >
> >
> > >>> Past fixes always "inverted" the result, by fixing some but breaking others.
> > >>> This new patch works in "not breaking any formerly working build" but
> > >>> at the same time fixing a few builds.
> > >>> Therefore -> applied & thanks!
> > >>>
> > >>> I'll likely tag -rc2 before the end of the week.
> > >>> The good thing is that (so far) we have:
> > >>> 1. a non functional change
> > >>> 2. a change fixing clang-13 builds (TBH only one of many needed clang13 issues)
> > >>> 3. a change fixing sles15SP3 builds
> > >>>
> > >>> Due to those, no current ongoing tests will have to be restarted.
> > >>> Whoever was able to build, can continue the current tests.
> > >>> Whoever was blocked by SLES15SP3 or clang-13 had no tests other than a
> > >>> failing build and can work with -rc2 then.
> > >>> I'll explain the same in the mail about -rc2.
> > >>>
> > >>>> -include /etc/lsb-release
> > >>>>
> > >>>> ifeq ($(DISTRIB_ID),Ubuntu)
> > >>>>
> > >>>> Regards,
> > >>>> Kalesh
> > >>>
> > >>> [snip]
> > >>>
> > >>
> > >
> > >
> >
>
>
> --
> Christian Ehrhardt
> Staff Engineer, Ubuntu Server
> Canonical Ltd
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-14 14:46 ` Christian Ehrhardt
@ 2021-12-14 14:52 ` Ferruh Yigit
2021-12-15 13:17 ` Christian Ehrhardt
0 siblings, 1 reply; 33+ messages in thread
From: Ferruh Yigit @ 2021-12-14 14:52 UTC (permalink / raw)
To: Christian Ehrhardt
Cc: Kalesh Anakkur Purayil, Abhishek Marathe, Akhil Goyal,
Ali Alnubani, David Christensen, Hariprasad Govindharajan,
Hemant Agrawal, Ian Stokes, Jerin Jacob, John McNamara,
Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi, Pei Zhang,
Raslan Darawsheh, Thomas Monjalon, benjamin.walker, dpdk stable,
dpdk-dev, pingx.yu, qian.q.xu, yuan.peng, zhaoyan.chen
On 12/14/2021 2:46 PM, Christian Ehrhardt wrote:
> On Tue, Dec 14, 2021 at 2:58 PM Christian Ehrhardt
> <christian.ehrhardt@canonical.com> wrote:
>>
>> On Tue, Dec 14, 2021 at 2:10 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>>
>>> On 12/14/2021 11:39 AM, Christian Ehrhardt wrote:
>>>> On Tue, Dec 14, 2021 at 11:13 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>>>>
>>>>> On 12/14/2021 7:44 AM, Christian Ehrhardt wrote:
>>>>>> On Tue, Dec 14, 2021 at 6:49 AM Kalesh Anakkur Purayil
>>>>>> <kalesh-anakkur.purayil@broadcom.com> wrote:
>>>>>>
>>>>>> [snip]
>>>>>>
>>>>>>>>> [Kalesh] Yes, i am seeing the same error. I used make command to build dpdk, not meson.
>>>>>>>>> The back ported commit you mentioned takes care of meson build only I think.
>>>>>>>>>
>>>>>>>>
>>>>>>>> I see, make build is failing, and yes the fix is only for the meson.
>>>>>>>> I will check the make build and will send a fix for it.
>>>>>>>
>>>>>>> [Kalesh]: looks like the below changes fixes the issue. I tried only on SLES15 SP3 and not on other SLES flavors.
>>>>>>>
>>>>>>> diff --git a/kernel/linux/kni/Makefile b/kernel/linux/kni/Makefile
>>>>>>> index 595bac2..bf0efab 100644
>>>>>>> --- a/kernel/linux/kni/Makefile
>>>>>>> +++ b/kernel/linux/kni/Makefile
>>>>>>> @@ -16,6 +16,16 @@ MODULE_CFLAGS += -I$(RTE_OUTPUT)/include
>>>>>>> MODULE_CFLAGS += -include $(RTE_OUTPUT)/include/rte_config.h
>>>>>>> MODULE_CFLAGS += -Wall -Werror
>>>>>>>
>>>>>>> +#
>>>>>>> +# Use explicit 'source' folder for header path. In SUSE 'source' is not linked to 'build' folder.
>>>>>>> +#
>>>>>>> +ifdef CONFIG_SUSE_KERNEL
>>>>>>> + KSRC = /lib/modules/$(shell uname -r)/source
>>>>>>> + ifneq ($(shell grep -A 1 "ndo_tx_timeout" $(KSRC)/include/linux/netdevice.h | grep -o txqueue),)
>>>>>>> + MODULE_CFLAGS += -DHAVE_TX_TIMEOUT_TXQUEUE
>>>>>>> + endif
>>>>>>> +endif
>>>>>>
>>>>>> Back in the day we tried various "is Suse and kernel version x.y"
>>>>>> approaches, but they failed as there was no clear version throughout
>>>>>> all of the Suse streams (leap, tumbleweed, sles) that worked well for
>>>>>> all.
>>>>>> This change here follows the upstream approach of "just check if it is there".
>>>>>>
>>>>>> I've applied this to 19.11 and did test builds across various distributions:
>>>>>> 1. no non-suse build changed
>>>>>> 2. suse builds stayed as-is or improved
>>>>>> Formerly failing:
>>>>>> openSUSE_Factory_ARM aarch64
>>>>>> SLE_15 x86_64 -> now working
>>>>>> openSUSE_Leap_15.3 x86_64 -> now working
>>>>>> openSUSE_Tumbleweed x86_64 -> still failing
>>>>>> Formerly working:
>>>>>> SLE_12_SP4 x86_64 ppc64le -> still fine
>>>>>> openSUSE_Factory_ARM armv7l -> still fine
>>>>>> openSUSE_Leap_15.2 x86_64 -> still fine
>>>>>>
>>>>>
>>>>> Thanks Kalesh for the fix, and thanks Christian for testing.
>>>>>
>>>>> I was expecting this approach will fix all builds, after patch only
>>>>> 'openSUSE_Tumbleweed' is failing, right? I will check it.
>>>>
>>>> As just discussed on IRC, yes and the log for that is at
>>>> https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/openSUSE_Tumbleweed/x86_64
>>>>
>>>> It also is affected by an issue around -Werror=implicit-fallthrough,
>>>> so even with KNI fixed it likely is going to fail.
>>>>
>>>>> And I think you need the fix as a patch anyway, @Kalesh are you
>>>>> planning to send the patch?
>>>>
>>>> I don't need it, as I have already grabbed and preliminary added it:
>>>> https://github.com/cpaelzer/dpdk-stable-queue/commit/d43fa3e198c08a3a76d70f4565b31ad3ab5f29c4
>>>>
>>>> But surely, once/If you come up with a full patch that also includes
>>>> tumbleweed I can replace it with yours.
>>>>
>>>
>>> 'tumbleweed' error is odd, it complains about macro being redefined,
>>> not sure why only in this platform we are getting an error.
>>>
>>> Macro is only defined in one place, but indeed header file included
>>> multiple times, one direct and one indirect, so macro defined multiple
>>> times but without value, so it should be OK and it is OK for other
>>> platforms, it is defined as:
>>> #define HAVE_TX_TIMEOUT_TXQUEUE
>>>
>>> Another option is that macro is defined in some other header file,
>>> although I think that is very unlikely, can you please test with
>>> below change to rule out that option:
>>
>> I'm testing that and will let you know in a bit ...
>
> Hi Ferruh,
> with your change the build now works.
> So indeed the symbol might have been defined elsewhere.
>
Interesting, this is self note to prefix 'RTE_' future macros.
> https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/openSUSE_Tumbleweed/x86_64
>
> It still fails later with the "-Werror=implicit-fallthrough=" but that
> is a different problem
> => https://bugs.dpdk.org/show_bug.cgi?id=907
>
Yep, this is igb_uio error, I assigned the bug to myself and will look at it.
> Ferruh - are you ok if I merge your suggestion with the backport I got
> from Kalesh?
>
Sure.
But would you mind sending the final patch to the stable mail list as record?
Or I can do the same if you prefer?
>>> diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h
>>> index 664785674ff1..71846419f437 100644
>>> --- a/kernel/linux/kni/compat.h
>>> +++ b/kernel/linux/kni/compat.h
>>> @@ -135,7 +135,7 @@
>>> (defined(RHEL_RELEASE_CODE) && \
>>> RHEL_RELEASE_VERSION(8, 3) <= RHEL_RELEASE_CODE) || \
>>> (defined(CONFIG_SUSE_KERNEL) && defined(HAVE_ARG_TX_QUEUE))
>>> -#define HAVE_TX_TIMEOUT_TXQUEUE
>>> +#define RTE_HAVE_TX_TIMEOUT_TXQUEUE
>>> #endif
>>>
>>> #if KERNEL_VERSION(5, 9, 0) > LINUX_VERSION_CODE
>>> diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c
>>> index c8bad5f197ca..7397de4659b2 100644
>>> --- a/kernel/linux/kni/kni_net.c
>>> +++ b/kernel/linux/kni/kni_net.c
>>> @@ -623,7 +623,7 @@ kni_net_rx(struct kni_dev *kni)
>>> /*
>>> * Deal with a transmit timeout.
>>> */
>>> -#ifdef HAVE_TX_TIMEOUT_TXQUEUE
>>> +#ifdef RTE_HAVE_TX_TIMEOUT_TXQUEUE
>>> static void
>>> kni_net_tx_timeout(struct net_device *dev, unsigned int txqueue)
>>> #else
>>>
>>>
>>>>>> Past fixes always "inverted" the result, by fixing some but breaking others.
>>>>>> This new patch works in "not breaking any formerly working build" but
>>>>>> at the same time fixing a few builds.
>>>>>> Therefore -> applied & thanks!
>>>>>>
>>>>>> I'll likely tag -rc2 before the end of the week.
>>>>>> The good thing is that (so far) we have:
>>>>>> 1. a non functional change
>>>>>> 2. a change fixing clang-13 builds (TBH only one of many needed clang13 issues)
>>>>>> 3. a change fixing sles15SP3 builds
>>>>>>
>>>>>> Due to those, no current ongoing tests will have to be restarted.
>>>>>> Whoever was able to build, can continue the current tests.
>>>>>> Whoever was blocked by SLES15SP3 or clang-13 had no tests other than a
>>>>>> failing build and can work with -rc2 then.
>>>>>> I'll explain the same in the mail about -rc2.
>>>>>>
>>>>>>> -include /etc/lsb-release
>>>>>>>
>>>>>>> ifeq ($(DISTRIB_ID),Ubuntu)
>>>>>>>
>>>>>>> Regards,
>>>>>>> Kalesh
>>>>>>
>>>>>> [snip]
>>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>>
>> --
>> Christian Ehrhardt
>> Staff Engineer, Ubuntu Server
>> Canonical Ltd
>
>
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* RE: 19.11.11 patches review and test
2021-12-14 7:14 ` Jiang, YuX
2021-12-14 7:45 ` Christian Ehrhardt
@ 2021-12-15 11:04 ` Jiang, YuX
2021-12-15 13:16 ` Christian Ehrhardt
2021-12-17 7:05 ` Jiang, YuX
1 sibling, 2 replies; 33+ messages in thread
From: Jiang, YuX @ 2021-12-15 11:04 UTC (permalink / raw)
To: Jiang, YuX, christian.ehrhardt, stable
Cc: dev, Abhishek Marathe, Akhil Goyal, Ali Alnubani, Walker,
Benjamin, David Christensen, Govindharajan, Hariprasad,
Hemant Agrawal, Stokes, Ian, Jerin Jacob, Mcnamara, John,
Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi, Pei Zhang, pingx.yu,
Xu, Qian Q, Raslan Darawsheh, Thomas Monjalon, Peng, Yuan, Chen,
Zhaoyan
> -----Original Message-----
> From: Jiang, YuX <yux.jiang@intel.com>
> Sent: Tuesday, December 14, 2021 3:14 PM
> To: christian.ehrhardt@canonical.com; stable@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@nvidia.com>;
> Walker, Benjamin <benjamin.walker@intel.com>; David Christensen
> <drc@linux.vnet.ibm.com>; Govindharajan, Hariprasad
> <hariprasad.govindharajan@intel.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin
> Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>;
> Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
> <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> <pezhang@redhat.com>; pingx.yu@intel.com; Xu, Qian Q
> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>; Thomas
> Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>;
> Chen, Zhaoyan <zhaoyan.chen@intel.com>
> Subject: RE: 19.11.11 patches review and test
>
> > -----Original Message-----
> > From: christian.ehrhardt@canonical.com
> > <christian.ehrhardt@canonical.com>
> > Sent: Thursday, December 9, 2021 10:43 PM
> > To: stable@dpdk.org
> > Cc: dev@dpdk.org; Abhishek Marathe
> <Abhishek.Marathe@microsoft.com>;
> > Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@nvidia.com>;
> > Walker, Benjamin <benjamin.walker@intel.com>; David Christensen
> > <drc@linux.vnet.ibm.com>; Govindharajan, Hariprasad
> > <hariprasad.govindharajan@intel.com>; Hemant Agrawal
> > <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin
> > Jacob <jerinj@marvell.com>; Mcnamara, John
> <john.mcnamara@intel.com>;
> > Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
> > <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> > <pezhang@redhat.com>; pingx.yu@intel.com; Xu, Qian Q
> > <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>; Thomas
> > Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>;
> > Chen, Zhaoyan <zhaoyan.chen@intel.com>
> > Subject: 19.11.11 patches review and test
> >
> > Hi all,
> >
> > Here is a list of patches targeted for stable release 19.11.11.
> >
> > The planned date for the final release is 7th January 2021.
> >
> > Please help with testing and validation of your use cases and report
> > any issues/results with reply-all to this mail. For the final release
> > the fixes and reported validations will be added to the release notes.
> >
> > A release candidate tarball can be found at:
> >
> > https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1
> >
> > These patches are located at branch 19.11 of dpdk-stable repo:
> > https://dpdk.org/browse/dpdk-stable/
> >
> > Thanks.
> >
> > Christian Ehrhardt <christian.ehrhardt@canonical.com>
> >
> > ---
> Hi Christian,
>
> We find many build issues on LTS19.11. But all of them have no fix yet.
> https://bugs.dpdk.org/show_bug.cgi?id=744 DPDK core dev UNCO
> --- [dpdk-19.11.9-rc3] make build failed on Fedora34 with GCC11
> and build failed on Fedora35 with gcc11.2.1&clang13.0.0
> https://bugs.dpdk.org/show_bug.cgi?id=747 DPDK core dev UNCO
> --- [dpdk-19.11.9-rc3] Meson build failed with ICC-19.1.1
> https://bugs.dpdk.org/show_bug.cgi?id=900 DPDK ethdev dev UNCO
> --- [19.11.11-rc1] net/nfp build failure with clang 13
> https://bugs.dpdk.org/show_bug.cgi?id=901 DPDK ethdev dev UNCO
> --- [19.11.11-rc1] net/i40e build failure with make and clang 13
> https://bugs.dpdk.org/show_bug.cgi?id=902 DPDK ethdev dev UNCO
> --- [19.11.11-rc1] net/ice build failure with make and clang 13
> https://bugs.dpdk.org/show_bug.cgi?id=903 DPDK ethdev dev UNCO
> --- [19.11.11-rc1] net/ixgbe build failure with make and clang 13
> https://bugs.dpdk.org/show_bug.cgi?id=904 DPDK meson dev UNCO
> --- [dpdk-19.11.11] Meson build has some failures on Fedora35
> with clang 13.0.0
> https://bugs.dpdk.org/show_bug.cgi?id=905 DPDK meson dev UNCO
> --- [dpdk-19.11.11-rc1]Meson&Makefile build failed on
> Freebsd13 with gcc10.3.0&clang11.0.1
Update the test status for Intel part. Till now dpdk19.11.11-rc1 test is almost finished.
Totally find three bugs for Build test from Intel.
# Basic Intel(R) NIC testing
* Build: cover the build test combination with latest GCC/Clang/ICC version and the popular OS revision such as Ubuntu20.04, Fedora34, RHEL8.4, etc.
- All test done.
- Tree bugs are found.
https://bugs.dpdk.org/show_bug.cgi?id=904
https://bugs.dpdk.org/show_bug.cgi?id=905
dpdk-19.11.11-rc]KNI build failed used makefile on OpenSuse15.3 with gcc7.5.0&clang11.0.1, has fix.
* PF(i40e, ixgbe): test scenarios including RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
- All test done. No new issue is found.
* VF(i40e, ixgbe): test scenarios including VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
- All test done. No new issue is found.
* PF/VF(ice): test scenarios including Switch features/Package Management/Flow Director/Advanced Tx, etc.
- All test done. No new issue is found.
* Intel NIC single core/NIC performance: test scenarios including PF/VF single core performance test etc.
- All test done. No big performance drop.
* IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - QAT&SW/FIB library, etc.
- All passed.
# Basic cryptodev and virtio testing
* Virtio: both function and performance test are covered. Such as PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing, etc.
- All test done. No new issue is found.
* Cryptodev:
* Function test: test scenarios including Cryptodev API testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/ etc.
- All test done.
* Performance test: test scenarios including Thoughput Performance /Cryptodev Latency, etc.
- All test done.
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-15 11:04 ` Jiang, YuX
@ 2021-12-15 13:16 ` Christian Ehrhardt
2021-12-17 7:05 ` Jiang, YuX
1 sibling, 0 replies; 33+ messages in thread
From: Christian Ehrhardt @ 2021-12-15 13:16 UTC (permalink / raw)
To: Jiang, YuX
Cc: stable, dev, Abhishek Marathe, Akhil Goyal, Ali Alnubani, Walker,
Benjamin, David Christensen, Govindharajan, Hariprasad,
Hemant Agrawal, Stokes, Ian, Jerin Jacob, Mcnamara, John,
Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi, Pei Zhang, pingx.yu,
Xu, Qian Q, Raslan Darawsheh, Thomas Monjalon, Peng, Yuan, Chen,
Zhaoyan
On Wed, Dec 15, 2021 at 12:04 PM Jiang, YuX <yux.jiang@intel.com> wrote:
>
> > -----Original Message-----
> > From: Jiang, YuX <yux.jiang@intel.com>
> > Sent: Tuesday, December 14, 2021 3:14 PM
> > To: christian.ehrhardt@canonical.com; stable@dpdk.org
> > Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> > Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@nvidia.com>;
> > Walker, Benjamin <benjamin.walker@intel.com>; David Christensen
> > <drc@linux.vnet.ibm.com>; Govindharajan, Hariprasad
> > <hariprasad.govindharajan@intel.com>; Hemant Agrawal
> > <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin
> > Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>;
> > Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
> > <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> > <pezhang@redhat.com>; pingx.yu@intel.com; Xu, Qian Q
> > <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>; Thomas
> > Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>;
> > Chen, Zhaoyan <zhaoyan.chen@intel.com>
> > Subject: RE: 19.11.11 patches review and test
> >
> > > -----Original Message-----
> > > From: christian.ehrhardt@canonical.com
> > > <christian.ehrhardt@canonical.com>
> > > Sent: Thursday, December 9, 2021 10:43 PM
> > > To: stable@dpdk.org
> > > Cc: dev@dpdk.org; Abhishek Marathe
> > <Abhishek.Marathe@microsoft.com>;
> > > Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@nvidia.com>;
> > > Walker, Benjamin <benjamin.walker@intel.com>; David Christensen
> > > <drc@linux.vnet.ibm.com>; Govindharajan, Hariprasad
> > > <hariprasad.govindharajan@intel.com>; Hemant Agrawal
> > > <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin
> > > Jacob <jerinj@marvell.com>; Mcnamara, John
> > <john.mcnamara@intel.com>;
> > > Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
> > > <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> > > <pezhang@redhat.com>; pingx.yu@intel.com; Xu, Qian Q
> > > <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>; Thomas
> > > Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>;
> > > Chen, Zhaoyan <zhaoyan.chen@intel.com>
> > > Subject: 19.11.11 patches review and test
> > >
> > > Hi all,
> > >
> > > Here is a list of patches targeted for stable release 19.11.11.
> > >
> > > The planned date for the final release is 7th January 2021.
> > >
> > > Please help with testing and validation of your use cases and report
> > > any issues/results with reply-all to this mail. For the final release
> > > the fixes and reported validations will be added to the release notes.
> > >
> > > A release candidate tarball can be found at:
> > >
> > > https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1
> > >
> > > These patches are located at branch 19.11 of dpdk-stable repo:
> > > https://dpdk.org/browse/dpdk-stable/
> > >
> > > Thanks.
> > >
> > > Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > >
> > > ---
> > Hi Christian,
> >
> > We find many build issues on LTS19.11. But all of them have no fix yet.
> > https://bugs.dpdk.org/show_bug.cgi?id=744 DPDK core dev UNCO
> > --- [dpdk-19.11.9-rc3] make build failed on Fedora34 with GCC11
> > and build failed on Fedora35 with gcc11.2.1&clang13.0.0
> > https://bugs.dpdk.org/show_bug.cgi?id=747 DPDK core dev UNCO
> > --- [dpdk-19.11.9-rc3] Meson build failed with ICC-19.1.1
> > https://bugs.dpdk.org/show_bug.cgi?id=900 DPDK ethdev dev UNCO
> > --- [19.11.11-rc1] net/nfp build failure with clang 13
> > https://bugs.dpdk.org/show_bug.cgi?id=901 DPDK ethdev dev UNCO
> > --- [19.11.11-rc1] net/i40e build failure with make and clang 13
> > https://bugs.dpdk.org/show_bug.cgi?id=902 DPDK ethdev dev UNCO
> > --- [19.11.11-rc1] net/ice build failure with make and clang 13
> > https://bugs.dpdk.org/show_bug.cgi?id=903 DPDK ethdev dev UNCO
> > --- [19.11.11-rc1] net/ixgbe build failure with make and clang 13
> > https://bugs.dpdk.org/show_bug.cgi?id=904 DPDK meson dev UNCO
> > --- [dpdk-19.11.11] Meson build has some failures on Fedora35
> > with clang 13.0.0
> > https://bugs.dpdk.org/show_bug.cgi?id=905 DPDK meson dev UNCO
> > --- [dpdk-19.11.11-rc1]Meson&Makefile build failed on
> > Freebsd13 with gcc10.3.0&clang11.0.1
>
> Update the test status for Intel part. Till now dpdk19.11.11-rc1 test is almost finished.
Thank you,
the new bugs are all with new toolchains.
An effort to fix those is ongoing right now.
So far it seems no other issues got identified by you or anyone else.
\o/
> Totally find three bugs for Build test from Intel.
> # Basic Intel(R) NIC testing
> * Build: cover the build test combination with latest GCC/Clang/ICC version and the popular OS revision such as Ubuntu20.04, Fedora34, RHEL8.4, etc.
> - All test done.
> - Tree bugs are found.
> https://bugs.dpdk.org/show_bug.cgi?id=904
> https://bugs.dpdk.org/show_bug.cgi?id=905
> dpdk-19.11.11-rc]KNI build failed used makefile on OpenSuse15.3 with gcc7.5.0&clang11.0.1, has fix.
> * PF(i40e, ixgbe): test scenarios including RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> - All test done. No new issue is found.
> * VF(i40e, ixgbe): test scenarios including VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> - All test done. No new issue is found.
> * PF/VF(ice): test scenarios including Switch features/Package Management/Flow Director/Advanced Tx, etc.
> - All test done. No new issue is found.
> * Intel NIC single core/NIC performance: test scenarios including PF/VF single core performance test etc.
> - All test done. No big performance drop.
> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - QAT&SW/FIB library, etc.
> - All passed.
> # Basic cryptodev and virtio testing
> * Virtio: both function and performance test are covered. Such as PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing, etc.
> - All test done. No new issue is found.
> * Cryptodev:
> * Function test: test scenarios including Cryptodev API testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/ etc.
> - All test done.
> * Performance test: test scenarios including Thoughput Performance /Cryptodev Latency, etc.
> - All test done.
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-14 14:52 ` Ferruh Yigit
@ 2021-12-15 13:17 ` Christian Ehrhardt
2021-12-15 14:44 ` Ferruh Yigit
0 siblings, 1 reply; 33+ messages in thread
From: Christian Ehrhardt @ 2021-12-15 13:17 UTC (permalink / raw)
To: Ferruh Yigit
Cc: Kalesh Anakkur Purayil, Abhishek Marathe, Akhil Goyal,
Ali Alnubani, David Christensen, Hariprasad Govindharajan,
Hemant Agrawal, Ian Stokes, Jerin Jacob, John McNamara,
Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi, Pei Zhang,
Raslan Darawsheh, Thomas Monjalon, benjamin.walker, dpdk stable,
dpdk-dev, pingx.yu, qian.q.xu, yuan.peng, zhaoyan.chen
On Tue, Dec 14, 2021 at 3:52 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 12/14/2021 2:46 PM, Christian Ehrhardt wrote:
> > On Tue, Dec 14, 2021 at 2:58 PM Christian Ehrhardt
> > <christian.ehrhardt@canonical.com> wrote:
> >>
> >> On Tue, Dec 14, 2021 at 2:10 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >>>
> >>> On 12/14/2021 11:39 AM, Christian Ehrhardt wrote:
> >>>> On Tue, Dec 14, 2021 at 11:13 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >>>>>
> >>>>> On 12/14/2021 7:44 AM, Christian Ehrhardt wrote:
> >>>>>> On Tue, Dec 14, 2021 at 6:49 AM Kalesh Anakkur Purayil
> >>>>>> <kalesh-anakkur.purayil@broadcom.com> wrote:
> >>>>>>
> >>>>>> [snip]
> >>>>>>
> >>>>>>>>> [Kalesh] Yes, i am seeing the same error. I used make command to build dpdk, not meson.
> >>>>>>>>> The back ported commit you mentioned takes care of meson build only I think.
> >>>>>>>>>
> >>>>>>>>
> >>>>>>>> I see, make build is failing, and yes the fix is only for the meson.
> >>>>>>>> I will check the make build and will send a fix for it.
> >>>>>>>
> >>>>>>> [Kalesh]: looks like the below changes fixes the issue. I tried only on SLES15 SP3 and not on other SLES flavors.
> >>>>>>>
> >>>>>>> diff --git a/kernel/linux/kni/Makefile b/kernel/linux/kni/Makefile
> >>>>>>> index 595bac2..bf0efab 100644
> >>>>>>> --- a/kernel/linux/kni/Makefile
> >>>>>>> +++ b/kernel/linux/kni/Makefile
> >>>>>>> @@ -16,6 +16,16 @@ MODULE_CFLAGS += -I$(RTE_OUTPUT)/include
> >>>>>>> MODULE_CFLAGS += -include $(RTE_OUTPUT)/include/rte_config.h
> >>>>>>> MODULE_CFLAGS += -Wall -Werror
> >>>>>>>
> >>>>>>> +#
> >>>>>>> +# Use explicit 'source' folder for header path. In SUSE 'source' is not linked to 'build' folder.
> >>>>>>> +#
> >>>>>>> +ifdef CONFIG_SUSE_KERNEL
> >>>>>>> + KSRC = /lib/modules/$(shell uname -r)/source
> >>>>>>> + ifneq ($(shell grep -A 1 "ndo_tx_timeout" $(KSRC)/include/linux/netdevice.h | grep -o txqueue),)
> >>>>>>> + MODULE_CFLAGS += -DHAVE_TX_TIMEOUT_TXQUEUE
> >>>>>>> + endif
> >>>>>>> +endif
> >>>>>>
> >>>>>> Back in the day we tried various "is Suse and kernel version x.y"
> >>>>>> approaches, but they failed as there was no clear version throughout
> >>>>>> all of the Suse streams (leap, tumbleweed, sles) that worked well for
> >>>>>> all.
> >>>>>> This change here follows the upstream approach of "just check if it is there".
> >>>>>>
> >>>>>> I've applied this to 19.11 and did test builds across various distributions:
> >>>>>> 1. no non-suse build changed
> >>>>>> 2. suse builds stayed as-is or improved
> >>>>>> Formerly failing:
> >>>>>> openSUSE_Factory_ARM aarch64
> >>>>>> SLE_15 x86_64 -> now working
> >>>>>> openSUSE_Leap_15.3 x86_64 -> now working
> >>>>>> openSUSE_Tumbleweed x86_64 -> still failing
> >>>>>> Formerly working:
> >>>>>> SLE_12_SP4 x86_64 ppc64le -> still fine
> >>>>>> openSUSE_Factory_ARM armv7l -> still fine
> >>>>>> openSUSE_Leap_15.2 x86_64 -> still fine
> >>>>>>
> >>>>>
> >>>>> Thanks Kalesh for the fix, and thanks Christian for testing.
> >>>>>
> >>>>> I was expecting this approach will fix all builds, after patch only
> >>>>> 'openSUSE_Tumbleweed' is failing, right? I will check it.
> >>>>
> >>>> As just discussed on IRC, yes and the log for that is at
> >>>> https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/openSUSE_Tumbleweed/x86_64
> >>>>
> >>>> It also is affected by an issue around -Werror=implicit-fallthrough,
> >>>> so even with KNI fixed it likely is going to fail.
> >>>>
> >>>>> And I think you need the fix as a patch anyway, @Kalesh are you
> >>>>> planning to send the patch?
> >>>>
> >>>> I don't need it, as I have already grabbed and preliminary added it:
> >>>> https://github.com/cpaelzer/dpdk-stable-queue/commit/d43fa3e198c08a3a76d70f4565b31ad3ab5f29c4
> >>>>
> >>>> But surely, once/If you come up with a full patch that also includes
> >>>> tumbleweed I can replace it with yours.
> >>>>
> >>>
> >>> 'tumbleweed' error is odd, it complains about macro being redefined,
> >>> not sure why only in this platform we are getting an error.
> >>>
> >>> Macro is only defined in one place, but indeed header file included
> >>> multiple times, one direct and one indirect, so macro defined multiple
> >>> times but without value, so it should be OK and it is OK for other
> >>> platforms, it is defined as:
> >>> #define HAVE_TX_TIMEOUT_TXQUEUE
> >>>
> >>> Another option is that macro is defined in some other header file,
> >>> although I think that is very unlikely, can you please test with
> >>> below change to rule out that option:
> >>
> >> I'm testing that and will let you know in a bit ...
> >
> > Hi Ferruh,
> > with your change the build now works.
> > So indeed the symbol might have been defined elsewhere.
> >
>
> Interesting, this is self note to prefix 'RTE_' future macros.
While generally an interesting Idea I do not know what I saw yesterday.
I have rebuilt it three times today and must say that other than I
said before - it does not work with RTE_*.
Actually even worse than before, with RTE_.. even opensuse_leap15.3
and SLES15 fail again :-/
> > https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/openSUSE_Tumbleweed/x86_64
> >
> > It still fails later with the "-Werror=implicit-fallthrough=" but that
> > is a different problem
> > => https://bugs.dpdk.org/show_bug.cgi?id=907
> >
>
> Yep, this is igb_uio error, I assigned the bug to myself and will look at it.
>
> > Ferruh - are you ok if I merge your suggestion with the backport I got
> > from Kalesh?
> >
>
> Sure.
> But would you mind sending the final patch to the stable mail list as record?
> Or I can do the same if you prefer?
>
> >>> diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h
> >>> index 664785674ff1..71846419f437 100644
> >>> --- a/kernel/linux/kni/compat.h
> >>> +++ b/kernel/linux/kni/compat.h
> >>> @@ -135,7 +135,7 @@
> >>> (defined(RHEL_RELEASE_CODE) && \
> >>> RHEL_RELEASE_VERSION(8, 3) <= RHEL_RELEASE_CODE) || \
> >>> (defined(CONFIG_SUSE_KERNEL) && defined(HAVE_ARG_TX_QUEUE))
> >>> -#define HAVE_TX_TIMEOUT_TXQUEUE
> >>> +#define RTE_HAVE_TX_TIMEOUT_TXQUEUE
> >>> #endif
> >>>
> >>> #if KERNEL_VERSION(5, 9, 0) > LINUX_VERSION_CODE
> >>> diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c
> >>> index c8bad5f197ca..7397de4659b2 100644
> >>> --- a/kernel/linux/kni/kni_net.c
> >>> +++ b/kernel/linux/kni/kni_net.c
> >>> @@ -623,7 +623,7 @@ kni_net_rx(struct kni_dev *kni)
> >>> /*
> >>> * Deal with a transmit timeout.
> >>> */
> >>> -#ifdef HAVE_TX_TIMEOUT_TXQUEUE
> >>> +#ifdef RTE_HAVE_TX_TIMEOUT_TXQUEUE
> >>> static void
> >>> kni_net_tx_timeout(struct net_device *dev, unsigned int txqueue)
> >>> #else
> >>>
> >>>
> >>>>>> Past fixes always "inverted" the result, by fixing some but breaking others.
> >>>>>> This new patch works in "not breaking any formerly working build" but
> >>>>>> at the same time fixing a few builds.
> >>>>>> Therefore -> applied & thanks!
> >>>>>>
> >>>>>> I'll likely tag -rc2 before the end of the week.
> >>>>>> The good thing is that (so far) we have:
> >>>>>> 1. a non functional change
> >>>>>> 2. a change fixing clang-13 builds (TBH only one of many needed clang13 issues)
> >>>>>> 3. a change fixing sles15SP3 builds
> >>>>>>
> >>>>>> Due to those, no current ongoing tests will have to be restarted.
> >>>>>> Whoever was able to build, can continue the current tests.
> >>>>>> Whoever was blocked by SLES15SP3 or clang-13 had no tests other than a
> >>>>>> failing build and can work with -rc2 then.
> >>>>>> I'll explain the same in the mail about -rc2.
> >>>>>>
> >>>>>>> -include /etc/lsb-release
> >>>>>>>
> >>>>>>> ifeq ($(DISTRIB_ID),Ubuntu)
> >>>>>>>
> >>>>>>> Regards,
> >>>>>>> Kalesh
> >>>>>>
> >>>>>> [snip]
> >>>>>>
> >>>>>
> >>>>
> >>>>
> >>>
> >>
> >>
> >> --
> >> Christian Ehrhardt
> >> Staff Engineer, Ubuntu Server
> >> Canonical Ltd
> >
> >
> >
>
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-15 13:17 ` Christian Ehrhardt
@ 2021-12-15 14:44 ` Ferruh Yigit
2021-12-16 7:21 ` Christian Ehrhardt
0 siblings, 1 reply; 33+ messages in thread
From: Ferruh Yigit @ 2021-12-15 14:44 UTC (permalink / raw)
To: Christian Ehrhardt
Cc: Kalesh Anakkur Purayil, Abhishek Marathe, Akhil Goyal,
Ali Alnubani, David Christensen, Hariprasad Govindharajan,
Hemant Agrawal, Ian Stokes, Jerin Jacob, John McNamara,
Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi, Pei Zhang,
Raslan Darawsheh, Thomas Monjalon, benjamin.walker, dpdk stable,
dpdk-dev, pingx.yu, qian.q.xu, yuan.peng, zhaoyan.chen
On 12/15/2021 1:17 PM, Christian Ehrhardt wrote:
> On Tue, Dec 14, 2021 at 3:52 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> On 12/14/2021 2:46 PM, Christian Ehrhardt wrote:
>>> On Tue, Dec 14, 2021 at 2:58 PM Christian Ehrhardt
>>> <christian.ehrhardt@canonical.com> wrote:
>>>>
>>>> On Tue, Dec 14, 2021 at 2:10 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>>>>
>>>>> On 12/14/2021 11:39 AM, Christian Ehrhardt wrote:
>>>>>> On Tue, Dec 14, 2021 at 11:13 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>>>>>>
>>>>>>> On 12/14/2021 7:44 AM, Christian Ehrhardt wrote:
>>>>>>>> On Tue, Dec 14, 2021 at 6:49 AM Kalesh Anakkur Purayil
>>>>>>>> <kalesh-anakkur.purayil@broadcom.com> wrote:
>>>>>>>>
>>>>>>>> [snip]
>>>>>>>>
>>>>>>>>>>> [Kalesh] Yes, i am seeing the same error. I used make command to build dpdk, not meson.
>>>>>>>>>>> The back ported commit you mentioned takes care of meson build only I think.
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> I see, make build is failing, and yes the fix is only for the meson.
>>>>>>>>>> I will check the make build and will send a fix for it.
>>>>>>>>>
>>>>>>>>> [Kalesh]: looks like the below changes fixes the issue. I tried only on SLES15 SP3 and not on other SLES flavors.
>>>>>>>>>
>>>>>>>>> diff --git a/kernel/linux/kni/Makefile b/kernel/linux/kni/Makefile
>>>>>>>>> index 595bac2..bf0efab 100644
>>>>>>>>> --- a/kernel/linux/kni/Makefile
>>>>>>>>> +++ b/kernel/linux/kni/Makefile
>>>>>>>>> @@ -16,6 +16,16 @@ MODULE_CFLAGS += -I$(RTE_OUTPUT)/include
>>>>>>>>> MODULE_CFLAGS += -include $(RTE_OUTPUT)/include/rte_config.h
>>>>>>>>> MODULE_CFLAGS += -Wall -Werror
>>>>>>>>>
>>>>>>>>> +#
>>>>>>>>> +# Use explicit 'source' folder for header path. In SUSE 'source' is not linked to 'build' folder.
>>>>>>>>> +#
>>>>>>>>> +ifdef CONFIG_SUSE_KERNEL
>>>>>>>>> + KSRC = /lib/modules/$(shell uname -r)/source
>>>>>>>>> + ifneq ($(shell grep -A 1 "ndo_tx_timeout" $(KSRC)/include/linux/netdevice.h | grep -o txqueue),)
>>>>>>>>> + MODULE_CFLAGS += -DHAVE_TX_TIMEOUT_TXQUEUE
>>>>>>>>> + endif
>>>>>>>>> +endif
>>>>>>>>
>>>>>>>> Back in the day we tried various "is Suse and kernel version x.y"
>>>>>>>> approaches, but they failed as there was no clear version throughout
>>>>>>>> all of the Suse streams (leap, tumbleweed, sles) that worked well for
>>>>>>>> all.
>>>>>>>> This change here follows the upstream approach of "just check if it is there".
>>>>>>>>
>>>>>>>> I've applied this to 19.11 and did test builds across various distributions:
>>>>>>>> 1. no non-suse build changed
>>>>>>>> 2. suse builds stayed as-is or improved
>>>>>>>> Formerly failing:
>>>>>>>> openSUSE_Factory_ARM aarch64
>>>>>>>> SLE_15 x86_64 -> now working
>>>>>>>> openSUSE_Leap_15.3 x86_64 -> now working
>>>>>>>> openSUSE_Tumbleweed x86_64 -> still failing
>>>>>>>> Formerly working:
>>>>>>>> SLE_12_SP4 x86_64 ppc64le -> still fine
>>>>>>>> openSUSE_Factory_ARM armv7l -> still fine
>>>>>>>> openSUSE_Leap_15.2 x86_64 -> still fine
>>>>>>>>
>>>>>>>
>>>>>>> Thanks Kalesh for the fix, and thanks Christian for testing.
>>>>>>>
>>>>>>> I was expecting this approach will fix all builds, after patch only
>>>>>>> 'openSUSE_Tumbleweed' is failing, right? I will check it.
>>>>>>
>>>>>> As just discussed on IRC, yes and the log for that is at
>>>>>> https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/openSUSE_Tumbleweed/x86_64
>>>>>>
>>>>>> It also is affected by an issue around -Werror=implicit-fallthrough,
>>>>>> so even with KNI fixed it likely is going to fail.
>>>>>>
>>>>>>> And I think you need the fix as a patch anyway, @Kalesh are you
>>>>>>> planning to send the patch?
>>>>>>
>>>>>> I don't need it, as I have already grabbed and preliminary added it:
>>>>>> https://github.com/cpaelzer/dpdk-stable-queue/commit/d43fa3e198c08a3a76d70f4565b31ad3ab5f29c4
>>>>>>
>>>>>> But surely, once/If you come up with a full patch that also includes
>>>>>> tumbleweed I can replace it with yours.
>>>>>>
>>>>>
>>>>> 'tumbleweed' error is odd, it complains about macro being redefined,
>>>>> not sure why only in this platform we are getting an error.
>>>>>
>>>>> Macro is only defined in one place, but indeed header file included
>>>>> multiple times, one direct and one indirect, so macro defined multiple
>>>>> times but without value, so it should be OK and it is OK for other
>>>>> platforms, it is defined as:
>>>>> #define HAVE_TX_TIMEOUT_TXQUEUE
>>>>>
>>>>> Another option is that macro is defined in some other header file,
>>>>> although I think that is very unlikely, can you please test with
>>>>> below change to rule out that option:
>>>>
>>>> I'm testing that and will let you know in a bit ...
>>>
>>> Hi Ferruh,
>>> with your change the build now works.
>>> So indeed the symbol might have been defined elsewhere.
>>>
>>
>> Interesting, this is self note to prefix 'RTE_' future macros.
>
> While generally an interesting Idea I do not know what I saw yesterday.
> I have rebuilt it three times today and must say that other than I
> said before - it does not work with RTE_*.
>
This was more expected result :)
Is there a way to debug that environment?
> Actually even worse than before, with RTE_.. even opensuse_leap15.3
> and SLES15 fail again :-/
>
>>> https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/openSUSE_Tumbleweed/x86_64
>>>
>>> It still fails later with the "-Werror=implicit-fallthrough=" but that
>>> is a different problem
>>> => https://bugs.dpdk.org/show_bug.cgi?id=907
>>>
>>
>> Yep, this is igb_uio error, I assigned the bug to myself and will look at it.
>>
>>> Ferruh - are you ok if I merge your suggestion with the backport I got
>>> from Kalesh?
>>>
>>
>> Sure.
>> But would you mind sending the final patch to the stable mail list as record?
>> Or I can do the same if you prefer?
>>
>>>>> diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h
>>>>> index 664785674ff1..71846419f437 100644
>>>>> --- a/kernel/linux/kni/compat.h
>>>>> +++ b/kernel/linux/kni/compat.h
>>>>> @@ -135,7 +135,7 @@
>>>>> (defined(RHEL_RELEASE_CODE) && \
>>>>> RHEL_RELEASE_VERSION(8, 3) <= RHEL_RELEASE_CODE) || \
>>>>> (defined(CONFIG_SUSE_KERNEL) && defined(HAVE_ARG_TX_QUEUE))
>>>>> -#define HAVE_TX_TIMEOUT_TXQUEUE
>>>>> +#define RTE_HAVE_TX_TIMEOUT_TXQUEUE
>>>>> #endif
>>>>>
>>>>> #if KERNEL_VERSION(5, 9, 0) > LINUX_VERSION_CODE
>>>>> diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c
>>>>> index c8bad5f197ca..7397de4659b2 100644
>>>>> --- a/kernel/linux/kni/kni_net.c
>>>>> +++ b/kernel/linux/kni/kni_net.c
>>>>> @@ -623,7 +623,7 @@ kni_net_rx(struct kni_dev *kni)
>>>>> /*
>>>>> * Deal with a transmit timeout.
>>>>> */
>>>>> -#ifdef HAVE_TX_TIMEOUT_TXQUEUE
>>>>> +#ifdef RTE_HAVE_TX_TIMEOUT_TXQUEUE
>>>>> static void
>>>>> kni_net_tx_timeout(struct net_device *dev, unsigned int txqueue)
>>>>> #else
>>>>>
>>>>>
>>>>>>>> Past fixes always "inverted" the result, by fixing some but breaking others.
>>>>>>>> This new patch works in "not breaking any formerly working build" but
>>>>>>>> at the same time fixing a few builds.
>>>>>>>> Therefore -> applied & thanks!
>>>>>>>>
>>>>>>>> I'll likely tag -rc2 before the end of the week.
>>>>>>>> The good thing is that (so far) we have:
>>>>>>>> 1. a non functional change
>>>>>>>> 2. a change fixing clang-13 builds (TBH only one of many needed clang13 issues)
>>>>>>>> 3. a change fixing sles15SP3 builds
>>>>>>>>
>>>>>>>> Due to those, no current ongoing tests will have to be restarted.
>>>>>>>> Whoever was able to build, can continue the current tests.
>>>>>>>> Whoever was blocked by SLES15SP3 or clang-13 had no tests other than a
>>>>>>>> failing build and can work with -rc2 then.
>>>>>>>> I'll explain the same in the mail about -rc2.
>>>>>>>>
>>>>>>>>> -include /etc/lsb-release
>>>>>>>>>
>>>>>>>>> ifeq ($(DISTRIB_ID),Ubuntu)
>>>>>>>>>
>>>>>>>>> Regards,
>>>>>>>>> Kalesh
>>>>>>>>
>>>>>>>> [snip]
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Christian Ehrhardt
>>>> Staff Engineer, Ubuntu Server
>>>> Canonical Ltd
>>>
>>>
>>>
>>
>
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-15 14:44 ` Ferruh Yigit
@ 2021-12-16 7:21 ` Christian Ehrhardt
0 siblings, 0 replies; 33+ messages in thread
From: Christian Ehrhardt @ 2021-12-16 7:21 UTC (permalink / raw)
To: Ferruh Yigit
Cc: Kalesh Anakkur Purayil, Abhishek Marathe, Akhil Goyal,
Ali Alnubani, David Christensen, Hemant Agrawal, Ian Stokes,
Jerin Jacob, John McNamara, Ju-Hyoung Lee, Kevin Traynor,
Luca Boccassi, Pei Zhang, Raslan Darawsheh, Thomas Monjalon,
benjamin.walker, dpdk stable, dpdk-dev, pingx.yu, qian.q.xu,
yuan.peng, zhaoyan.chen
On Wed, Dec 15, 2021 at 3:44 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 12/15/2021 1:17 PM, Christian Ehrhardt wrote:
> > On Tue, Dec 14, 2021 at 3:52 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >>
> >> On 12/14/2021 2:46 PM, Christian Ehrhardt wrote:
> >>> On Tue, Dec 14, 2021 at 2:58 PM Christian Ehrhardt
> >>> <christian.ehrhardt@canonical.com> wrote:
> >>>>
> >>>> On Tue, Dec 14, 2021 at 2:10 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >>>>>
> >>>>> On 12/14/2021 11:39 AM, Christian Ehrhardt wrote:
> >>>>>> On Tue, Dec 14, 2021 at 11:13 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >>>>>>>
> >>>>>>> On 12/14/2021 7:44 AM, Christian Ehrhardt wrote:
> >>>>>>>> On Tue, Dec 14, 2021 at 6:49 AM Kalesh Anakkur Purayil
> >>>>>>>> <kalesh-anakkur.purayil@broadcom.com> wrote:
> >>>>>>>>
> >>>>>>>> [snip]
> >>>>>>>>
> >>>>>>>>>>> [Kalesh] Yes, i am seeing the same error. I used make command to build dpdk, not meson.
> >>>>>>>>>>> The back ported commit you mentioned takes care of meson build only I think.
> >>>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> I see, make build is failing, and yes the fix is only for the meson.
> >>>>>>>>>> I will check the make build and will send a fix for it.
> >>>>>>>>>
> >>>>>>>>> [Kalesh]: looks like the below changes fixes the issue. I tried only on SLES15 SP3 and not on other SLES flavors.
> >>>>>>>>>
> >>>>>>>>> diff --git a/kernel/linux/kni/Makefile b/kernel/linux/kni/Makefile
> >>>>>>>>> index 595bac2..bf0efab 100644
> >>>>>>>>> --- a/kernel/linux/kni/Makefile
> >>>>>>>>> +++ b/kernel/linux/kni/Makefile
> >>>>>>>>> @@ -16,6 +16,16 @@ MODULE_CFLAGS += -I$(RTE_OUTPUT)/include
> >>>>>>>>> MODULE_CFLAGS += -include $(RTE_OUTPUT)/include/rte_config.h
> >>>>>>>>> MODULE_CFLAGS += -Wall -Werror
> >>>>>>>>>
> >>>>>>>>> +#
> >>>>>>>>> +# Use explicit 'source' folder for header path. In SUSE 'source' is not linked to 'build' folder.
> >>>>>>>>> +#
> >>>>>>>>> +ifdef CONFIG_SUSE_KERNEL
> >>>>>>>>> + KSRC = /lib/modules/$(shell uname -r)/source
> >>>>>>>>> + ifneq ($(shell grep -A 1 "ndo_tx_timeout" $(KSRC)/include/linux/netdevice.h | grep -o txqueue),)
> >>>>>>>>> + MODULE_CFLAGS += -DHAVE_TX_TIMEOUT_TXQUEUE
> >>>>>>>>> + endif
> >>>>>>>>> +endif
> >>>>>>>>
> >>>>>>>> Back in the day we tried various "is Suse and kernel version x.y"
> >>>>>>>> approaches, but they failed as there was no clear version throughout
> >>>>>>>> all of the Suse streams (leap, tumbleweed, sles) that worked well for
> >>>>>>>> all.
> >>>>>>>> This change here follows the upstream approach of "just check if it is there".
> >>>>>>>>
> >>>>>>>> I've applied this to 19.11 and did test builds across various distributions:
> >>>>>>>> 1. no non-suse build changed
> >>>>>>>> 2. suse builds stayed as-is or improved
> >>>>>>>> Formerly failing:
> >>>>>>>> openSUSE_Factory_ARM aarch64
> >>>>>>>> SLE_15 x86_64 -> now working
> >>>>>>>> openSUSE_Leap_15.3 x86_64 -> now working
> >>>>>>>> openSUSE_Tumbleweed x86_64 -> still failing
> >>>>>>>> Formerly working:
> >>>>>>>> SLE_12_SP4 x86_64 ppc64le -> still fine
> >>>>>>>> openSUSE_Factory_ARM armv7l -> still fine
> >>>>>>>> openSUSE_Leap_15.2 x86_64 -> still fine
> >>>>>>>>
> >>>>>>>
> >>>>>>> Thanks Kalesh for the fix, and thanks Christian for testing.
> >>>>>>>
> >>>>>>> I was expecting this approach will fix all builds, after patch only
> >>>>>>> 'openSUSE_Tumbleweed' is failing, right? I will check it.
> >>>>>>
> >>>>>> As just discussed on IRC, yes and the log for that is at
> >>>>>> https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/openSUSE_Tumbleweed/x86_64
> >>>>>>
> >>>>>> It also is affected by an issue around -Werror=implicit-fallthrough,
> >>>>>> so even with KNI fixed it likely is going to fail.
> >>>>>>
> >>>>>>> And I think you need the fix as a patch anyway, @Kalesh are you
> >>>>>>> planning to send the patch?
> >>>>>>
> >>>>>> I don't need it, as I have already grabbed and preliminary added it:
> >>>>>> https://github.com/cpaelzer/dpdk-stable-queue/commit/d43fa3e198c08a3a76d70f4565b31ad3ab5f29c4
> >>>>>>
> >>>>>> But surely, once/If you come up with a full patch that also includes
> >>>>>> tumbleweed I can replace it with yours.
> >>>>>>
> >>>>>
> >>>>> 'tumbleweed' error is odd, it complains about macro being redefined,
> >>>>> not sure why only in this platform we are getting an error.
> >>>>>
> >>>>> Macro is only defined in one place, but indeed header file included
> >>>>> multiple times, one direct and one indirect, so macro defined multiple
> >>>>> times but without value, so it should be OK and it is OK for other
> >>>>> platforms, it is defined as:
> >>>>> #define HAVE_TX_TIMEOUT_TXQUEUE
> >>>>>
> >>>>> Another option is that macro is defined in some other header file,
> >>>>> although I think that is very unlikely, can you please test with
> >>>>> below change to rule out that option:
> >>>>
> >>>> I'm testing that and will let you know in a bit ...
> >>>
> >>> Hi Ferruh,
> >>> with your change the build now works.
> >>> So indeed the symbol might have been defined elsewhere.
> >>>
> >>
> >> Interesting, this is self note to prefix 'RTE_' future macros.
> >
> > While generally an interesting Idea I do not know what I saw yesterday.
> > I have rebuilt it three times today and must say that other than I
> > said before - it does not work with RTE_*.
> >
>
> This was more expected result :)
>
> Is there a way to debug that environment?
Not that I'd know of.
Get a local VM of the same would be my way :-/
@Luca - you came up with this CI platform for the LTS builds, do you
know of a way to debug in-place?
> > Actually even worse than before, with RTE_.. even opensuse_leap15.3
> > and SLES15 fail again :-/
> >
> >>> https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/openSUSE_Tumbleweed/x86_64
> >>>
> >>> It still fails later with the "-Werror=implicit-fallthrough=" but that
> >>> is a different problem
> >>> => https://bugs.dpdk.org/show_bug.cgi?id=907
> >>>
> >>
> >> Yep, this is igb_uio error, I assigned the bug to myself and will look at it.
> >>
> >>> Ferruh - are you ok if I merge your suggestion with the backport I got
> >>> from Kalesh?
> >>>
> >>
> >> Sure.
> >> But would you mind sending the final patch to the stable mail list as record?
> >> Or I can do the same if you prefer?
> >>
> >>>>> diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h
> >>>>> index 664785674ff1..71846419f437 100644
> >>>>> --- a/kernel/linux/kni/compat.h
> >>>>> +++ b/kernel/linux/kni/compat.h
> >>>>> @@ -135,7 +135,7 @@
> >>>>> (defined(RHEL_RELEASE_CODE) && \
> >>>>> RHEL_RELEASE_VERSION(8, 3) <= RHEL_RELEASE_CODE) || \
> >>>>> (defined(CONFIG_SUSE_KERNEL) && defined(HAVE_ARG_TX_QUEUE))
> >>>>> -#define HAVE_TX_TIMEOUT_TXQUEUE
> >>>>> +#define RTE_HAVE_TX_TIMEOUT_TXQUEUE
> >>>>> #endif
> >>>>>
> >>>>> #if KERNEL_VERSION(5, 9, 0) > LINUX_VERSION_CODE
> >>>>> diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c
> >>>>> index c8bad5f197ca..7397de4659b2 100644
> >>>>> --- a/kernel/linux/kni/kni_net.c
> >>>>> +++ b/kernel/linux/kni/kni_net.c
> >>>>> @@ -623,7 +623,7 @@ kni_net_rx(struct kni_dev *kni)
> >>>>> /*
> >>>>> * Deal with a transmit timeout.
> >>>>> */
> >>>>> -#ifdef HAVE_TX_TIMEOUT_TXQUEUE
> >>>>> +#ifdef RTE_HAVE_TX_TIMEOUT_TXQUEUE
> >>>>> static void
> >>>>> kni_net_tx_timeout(struct net_device *dev, unsigned int txqueue)
> >>>>> #else
> >>>>>
> >>>>>
> >>>>>>>> Past fixes always "inverted" the result, by fixing some but breaking others.
> >>>>>>>> This new patch works in "not breaking any formerly working build" but
> >>>>>>>> at the same time fixing a few builds.
> >>>>>>>> Therefore -> applied & thanks!
> >>>>>>>>
> >>>>>>>> I'll likely tag -rc2 before the end of the week.
> >>>>>>>> The good thing is that (so far) we have:
> >>>>>>>> 1. a non functional change
> >>>>>>>> 2. a change fixing clang-13 builds (TBH only one of many needed clang13 issues)
> >>>>>>>> 3. a change fixing sles15SP3 builds
> >>>>>>>>
> >>>>>>>> Due to those, no current ongoing tests will have to be restarted.
> >>>>>>>> Whoever was able to build, can continue the current tests.
> >>>>>>>> Whoever was blocked by SLES15SP3 or clang-13 had no tests other than a
> >>>>>>>> failing build and can work with -rc2 then.
> >>>>>>>> I'll explain the same in the mail about -rc2.
> >>>>>>>>
> >>>>>>>>> -include /etc/lsb-release
> >>>>>>>>>
> >>>>>>>>> ifeq ($(DISTRIB_ID),Ubuntu)
> >>>>>>>>>
> >>>>>>>>> Regards,
> >>>>>>>>> Kalesh
> >>>>>>>>
> >>>>>>>> [snip]
> >>>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>>
> >>>>>
> >>>>
> >>>>
> >>>> --
> >>>> Christian Ehrhardt
> >>>> Staff Engineer, Ubuntu Server
> >>>> Canonical Ltd
> >>>
> >>>
> >>>
> >>
> >
> >
>
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 33+ messages in thread
* RE: 19.11.11 patches review and test
2021-12-15 11:04 ` Jiang, YuX
2021-12-15 13:16 ` Christian Ehrhardt
@ 2021-12-17 7:05 ` Jiang, YuX
2021-12-17 7:47 ` Christian Ehrhardt
1 sibling, 1 reply; 33+ messages in thread
From: Jiang, YuX @ 2021-12-17 7:05 UTC (permalink / raw)
To: christian.ehrhardt, stable
Cc: dev, Abhishek Marathe, Akhil Goyal, Ali Alnubani, Walker,
Benjamin, David Christensen, Govindharajan, Hariprasad,
Hemant Agrawal, Stokes, Ian, Jerin Jacob, Mcnamara, John,
Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi, Pei Zhang, pingx.yu,
Xu, Qian Q, Raslan Darawsheh, Thomas Monjalon, Peng, Yuan, Chen,
Zhaoyan
> -----Original Message-----
> From: Jiang, YuX
> Sent: Wednesday, December 15, 2021 7:04 PM
> To: Jiang, YuX <yux.jiang@intel.com>; christian.ehrhardt@canonical.com;
> stable@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@nvidia.com>;
> Walker, Benjamin <benjamin.walker@intel.com>; David Christensen
> <drc@linux.vnet.ibm.com>; Govindharajan, Hariprasad
> <hariprasad.govindharajan@intel.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin
> Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>;
> Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
> <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> <pezhang@redhat.com>; pingx.yu@intel.com; Xu, Qian Q
> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>; Thomas
> Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>;
> Chen, Zhaoyan <zhaoyan.chen@intel.com>
> Subject: RE: 19.11.11 patches review and test
>
> > -----Original Message-----
> > From: Jiang, YuX <yux.jiang@intel.com>
> > Sent: Tuesday, December 14, 2021 3:14 PM
> > To: christian.ehrhardt@canonical.com; stable@dpdk.org
> > Cc: dev@dpdk.org; Abhishek Marathe
> <Abhishek.Marathe@microsoft.com>;
> > Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@nvidia.com>;
> > Walker, Benjamin <benjamin.walker@intel.com>; David Christensen
> > <drc@linux.vnet.ibm.com>; Govindharajan, Hariprasad
> > <hariprasad.govindharajan@intel.com>; Hemant Agrawal
> > <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin
> > Jacob <jerinj@marvell.com>; Mcnamara, John
> <john.mcnamara@intel.com>;
> > Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
> > <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> > <pezhang@redhat.com>; pingx.yu@intel.com; Xu, Qian Q
> > <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>; Thomas
> > Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>;
> > Chen, Zhaoyan <zhaoyan.chen@intel.com>
> > Subject: RE: 19.11.11 patches review and test
> >
> > > -----Original Message-----
> > > From: christian.ehrhardt@canonical.com
> > > <christian.ehrhardt@canonical.com>
> > > Sent: Thursday, December 9, 2021 10:43 PM
> > > To: stable@dpdk.org
> > > Cc: dev@dpdk.org; Abhishek Marathe
> > <Abhishek.Marathe@microsoft.com>;
> > > Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani
> > > <alialnu@nvidia.com>; Walker, Benjamin <benjamin.walker@intel.com>;
> > > David Christensen <drc@linux.vnet.ibm.com>; Govindharajan,
> > > Hariprasad <hariprasad.govindharajan@intel.com>; Hemant Agrawal
> > > <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin
> > > Jacob <jerinj@marvell.com>; Mcnamara, John
> > <john.mcnamara@intel.com>;
> > > Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
> > > <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> > > <pezhang@redhat.com>; pingx.yu@intel.com; Xu, Qian Q
> > > <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>;
> Thomas
> > > Monjalon <thomas@monjalon.net>; Peng, Yuan
> <yuan.peng@intel.com>;
> > > Chen, Zhaoyan <zhaoyan.chen@intel.com>
> > > Subject: 19.11.11 patches review and test
> > >
> > > Hi all,
> > >
> > > Here is a list of patches targeted for stable release 19.11.11.
> > >
> > > The planned date for the final release is 7th January 2021.
> > >
> > > Please help with testing and validation of your use cases and report
> > > any issues/results with reply-all to this mail. For the final
> > > release the fixes and reported validations will be added to the release
> notes.
> > >
> > > A release candidate tarball can be found at:
> > >
> > > https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1
> > >
> > > These patches are located at branch 19.11 of dpdk-stable repo:
> > > https://dpdk.org/browse/dpdk-stable/
> > >
> > > Thanks.
> > >
> > > Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > >
> > > ---
> > Hi Christian,
> >
> > We find many build issues on LTS19.11. But all of them have no fix yet.
> > https://bugs.dpdk.org/show_bug.cgi?id=744 DPDK core dev UNCO
> > --- [dpdk-19.11.9-rc3] make build failed on Fedora34 with GCC11
> > and build failed on Fedora35 with gcc11.2.1&clang13.0.0
> > https://bugs.dpdk.org/show_bug.cgi?id=747 DPDK core dev UNCO
> > --- [dpdk-19.11.9-rc3] Meson build failed with ICC-19.1.1
> > https://bugs.dpdk.org/show_bug.cgi?id=900 DPDK ethdev dev UNCO
> > --- [19.11.11-rc1] net/nfp build failure with clang 13
> > https://bugs.dpdk.org/show_bug.cgi?id=901 DPDK ethdev dev UNCO
> > --- [19.11.11-rc1] net/i40e build failure with make and clang 13
> > https://bugs.dpdk.org/show_bug.cgi?id=902 DPDK ethdev dev UNCO
> > --- [19.11.11-rc1] net/ice build failure with make and clang 13
> > https://bugs.dpdk.org/show_bug.cgi?id=903 DPDK ethdev dev UNCO
> > --- [19.11.11-rc1] net/ixgbe build failure with make and clang 13
> > https://bugs.dpdk.org/show_bug.cgi?id=904 DPDK meson dev UNCO
> > --- [dpdk-19.11.11] Meson build has some failures on Fedora35
> > with clang 13.0.0
> > https://bugs.dpdk.org/show_bug.cgi?id=905 DPDK meson dev UNCO
> > --- [dpdk-19.11.11-rc1]Meson&Makefile build failed on
> > Freebsd13 with gcc10.3.0&clang11.0.1
>
> Update the test status for Intel part. Till now dpdk19.11.11-rc1 test is almost
> finished.
> Totally find three bugs for Build test from Intel.
> # Basic Intel(R) NIC testing
> * Build: cover the build test combination with latest GCC/Clang/ICC version
> and the popular OS revision such as Ubuntu20.04, Fedora34, RHEL8.4, etc.
> - All test done.
> - Tree bugs are found.
> https://bugs.dpdk.org/show_bug.cgi?id=904
> https://bugs.dpdk.org/show_bug.cgi?id=905
> dpdk-19.11.11-rc]KNI build failed used makefile on OpenSuse15.3 with
> gcc7.5.0&clang11.0.1, has fix.
> * PF(i40e, ixgbe): test scenarios including
> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> - All test done. No new issue is found.
> * VF(i40e, ixgbe): test scenarios including VF-
> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
>
> - All test done. No new issue is found.
> * PF/VF(ice): test scenarios including Switch features/Package
> Management/Flow Director/Advanced Tx, etc.
> - All test done. No new issue is found.
> * Intel NIC single core/NIC performance: test scenarios including PF/VF single
> core performance test etc.
> - All test done. No big performance drop.
> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test -
> QAT&SW/FIB library, etc.
> - All passed.
> # Basic cryptodev and virtio testing
> * Virtio: both function and performance test are covered. Such as
> PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing,
> etc.
> - All test done. No new issue is found.
> * Cryptodev:
> * Function test: test scenarios including Cryptodev API testing/CompressDev
> ISA-L/QAT/ZLIB PMD Testing/ etc.
> - All test done.
> * Performance test: test scenarios including Thoughput Performance
> /Cryptodev Latency, etc.
> - All test done.
Verify bugs: 901/902/903
https://bugs.dpdk.org/show_bug.cgi?id=901 [19.11.11-rc1] net/i40e build failure with make and clang 13
https://bugs.dpdk.org/show_bug.cgi?id=902 [19.11.11-rc1] net/ice build failure with make and clang 13
https://bugs.dpdk.org/show_bug.cgi?id=903 [19.11.11-rc1] net/ixgbe build failure with make and clang 13
Verified patchset https://github.com/cpaelzer/dpdk-stable-queue/commits/19.11/
Commit:
net/ixgbe: build failure with make and clang 13
acd0a2d2d net/ice: build failure with make and clang 13
cc089e955 net/i40e: build failure with make and clang 13
Tested with clang version 13.0.0 (Fedora 13.0.0~rc1-1.fc35) on baseline 19.11.11-rc1,
No ice/i40e/ixgbe error.
Find two new bugs:
https://bugs.dpdk.org/show_bug.cgi?id=911 [19.11.11-rc1] linux/igb_uio/igb_uio build failure with make and clang 13
https://bugs.dpdk.org/show_bug.cgi?id=912 [19.11.11-rc1] net/qede build failure with make and clang 13
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-17 7:05 ` Jiang, YuX
@ 2021-12-17 7:47 ` Christian Ehrhardt
2021-12-17 14:55 ` Richardson, Bruce
0 siblings, 1 reply; 33+ messages in thread
From: Christian Ehrhardt @ 2021-12-17 7:47 UTC (permalink / raw)
To: Jiang, YuX
Cc: stable, dev, Abhishek Marathe, Akhil Goyal, Ali Alnubani, Walker,
Benjamin, David Christensen, Govindharajan, Hariprasad,
Hemant Agrawal, Stokes, Ian, Jerin Jacob, Mcnamara, John,
Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi, Pei Zhang, pingx.yu,
Xu, Qian Q, Raslan Darawsheh, Thomas Monjalon, Peng, Yuan, Chen,
Zhaoyan
On Fri, Dec 17, 2021 at 8:06 AM Jiang, YuX <yux.jiang@intel.com> wrote:
>
> > -----Original Message-----
> > From: Jiang, YuX
> > Sent: Wednesday, December 15, 2021 7:04 PM
> > To: Jiang, YuX <yux.jiang@intel.com>; christian.ehrhardt@canonical.com;
> > stable@dpdk.org
> > Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> > Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@nvidia.com>;
> > Walker, Benjamin <benjamin.walker@intel.com>; David Christensen
> > <drc@linux.vnet.ibm.com>; Govindharajan, Hariprasad
> > <hariprasad.govindharajan@intel.com>; Hemant Agrawal
> > <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin
> > Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>;
> > Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
> > <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> > <pezhang@redhat.com>; pingx.yu@intel.com; Xu, Qian Q
> > <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>; Thomas
> > Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>;
> > Chen, Zhaoyan <zhaoyan.chen@intel.com>
> > Subject: RE: 19.11.11 patches review and test
> >
> > > -----Original Message-----
> > > From: Jiang, YuX <yux.jiang@intel.com>
> > > Sent: Tuesday, December 14, 2021 3:14 PM
> > > To: christian.ehrhardt@canonical.com; stable@dpdk.org
> > > Cc: dev@dpdk.org; Abhishek Marathe
> > <Abhishek.Marathe@microsoft.com>;
> > > Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@nvidia.com>;
> > > Walker, Benjamin <benjamin.walker@intel.com>; David Christensen
> > > <drc@linux.vnet.ibm.com>; Govindharajan, Hariprasad
> > > <hariprasad.govindharajan@intel.com>; Hemant Agrawal
> > > <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin
> > > Jacob <jerinj@marvell.com>; Mcnamara, John
> > <john.mcnamara@intel.com>;
> > > Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
> > > <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> > > <pezhang@redhat.com>; pingx.yu@intel.com; Xu, Qian Q
> > > <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>; Thomas
> > > Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>;
> > > Chen, Zhaoyan <zhaoyan.chen@intel.com>
> > > Subject: RE: 19.11.11 patches review and test
> > >
> > > > -----Original Message-----
> > > > From: christian.ehrhardt@canonical.com
> > > > <christian.ehrhardt@canonical.com>
> > > > Sent: Thursday, December 9, 2021 10:43 PM
> > > > To: stable@dpdk.org
> > > > Cc: dev@dpdk.org; Abhishek Marathe
> > > <Abhishek.Marathe@microsoft.com>;
> > > > Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani
> > > > <alialnu@nvidia.com>; Walker, Benjamin <benjamin.walker@intel.com>;
> > > > David Christensen <drc@linux.vnet.ibm.com>; Govindharajan,
> > > > Hariprasad <hariprasad.govindharajan@intel.com>; Hemant Agrawal
> > > > <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin
> > > > Jacob <jerinj@marvell.com>; Mcnamara, John
> > > <john.mcnamara@intel.com>;
> > > > Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
> > > > <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> > > > <pezhang@redhat.com>; pingx.yu@intel.com; Xu, Qian Q
> > > > <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>;
> > Thomas
> > > > Monjalon <thomas@monjalon.net>; Peng, Yuan
> > <yuan.peng@intel.com>;
> > > > Chen, Zhaoyan <zhaoyan.chen@intel.com>
> > > > Subject: 19.11.11 patches review and test
> > > >
> > > > Hi all,
> > > >
> > > > Here is a list of patches targeted for stable release 19.11.11.
> > > >
> > > > The planned date for the final release is 7th January 2021.
> > > >
> > > > Please help with testing and validation of your use cases and report
> > > > any issues/results with reply-all to this mail. For the final
> > > > release the fixes and reported validations will be added to the release
> > notes.
> > > >
> > > > A release candidate tarball can be found at:
> > > >
> > > > https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1
> > > >
> > > > These patches are located at branch 19.11 of dpdk-stable repo:
> > > > https://dpdk.org/browse/dpdk-stable/
> > > >
> > > > Thanks.
> > > >
> > > > Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > > >
> > > > ---
> > > Hi Christian,
> > >
> > > We find many build issues on LTS19.11. But all of them have no fix yet.
> > > https://bugs.dpdk.org/show_bug.cgi?id=744 DPDK core dev UNCO
> > > --- [dpdk-19.11.9-rc3] make build failed on Fedora34 with GCC11
> > > and build failed on Fedora35 with gcc11.2.1&clang13.0.0
> > > https://bugs.dpdk.org/show_bug.cgi?id=747 DPDK core dev UNCO
> > > --- [dpdk-19.11.9-rc3] Meson build failed with ICC-19.1.1
> > > https://bugs.dpdk.org/show_bug.cgi?id=900 DPDK ethdev dev UNCO
> > > --- [19.11.11-rc1] net/nfp build failure with clang 13
> > > https://bugs.dpdk.org/show_bug.cgi?id=901 DPDK ethdev dev UNCO
> > > --- [19.11.11-rc1] net/i40e build failure with make and clang 13
> > > https://bugs.dpdk.org/show_bug.cgi?id=902 DPDK ethdev dev UNCO
> > > --- [19.11.11-rc1] net/ice build failure with make and clang 13
> > > https://bugs.dpdk.org/show_bug.cgi?id=903 DPDK ethdev dev UNCO
> > > --- [19.11.11-rc1] net/ixgbe build failure with make and clang 13
> > > https://bugs.dpdk.org/show_bug.cgi?id=904 DPDK meson dev UNCO
> > > --- [dpdk-19.11.11] Meson build has some failures on Fedora35
> > > with clang 13.0.0
> > > https://bugs.dpdk.org/show_bug.cgi?id=905 DPDK meson dev UNCO
> > > --- [dpdk-19.11.11-rc1]Meson&Makefile build failed on
> > > Freebsd13 with gcc10.3.0&clang11.0.1
> >
> > Update the test status for Intel part. Till now dpdk19.11.11-rc1 test is almost
> > finished.
> > Totally find three bugs for Build test from Intel.
> > # Basic Intel(R) NIC testing
> > * Build: cover the build test combination with latest GCC/Clang/ICC version
> > and the popular OS revision such as Ubuntu20.04, Fedora34, RHEL8.4, etc.
> > - All test done.
> > - Tree bugs are found.
> > https://bugs.dpdk.org/show_bug.cgi?id=904
> > https://bugs.dpdk.org/show_bug.cgi?id=905
> > dpdk-19.11.11-rc]KNI build failed used makefile on OpenSuse15.3 with
> > gcc7.5.0&clang11.0.1, has fix.
> > * PF(i40e, ixgbe): test scenarios including
> > RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> > - All test done. No new issue is found.
> > * VF(i40e, ixgbe): test scenarios including VF-
> > RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> >
> > - All test done. No new issue is found.
> > * PF/VF(ice): test scenarios including Switch features/Package
> > Management/Flow Director/Advanced Tx, etc.
> > - All test done. No new issue is found.
> > * Intel NIC single core/NIC performance: test scenarios including PF/VF single
> > core performance test etc.
> > - All test done. No big performance drop.
> > * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test -
> > QAT&SW/FIB library, etc.
> > - All passed.
> > # Basic cryptodev and virtio testing
> > * Virtio: both function and performance test are covered. Such as
> > PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing,
> > etc.
> > - All test done. No new issue is found.
> > * Cryptodev:
> > * Function test: test scenarios including Cryptodev API testing/CompressDev
> > ISA-L/QAT/ZLIB PMD Testing/ etc.
> > - All test done.
> > * Performance test: test scenarios including Thoughput Performance
> > /Cryptodev Latency, etc.
> > - All test done.
> Verify bugs: 901/902/903
> https://bugs.dpdk.org/show_bug.cgi?id=901 [19.11.11-rc1] net/i40e build failure with make and clang 13
> https://bugs.dpdk.org/show_bug.cgi?id=902 [19.11.11-rc1] net/ice build failure with make and clang 13
> https://bugs.dpdk.org/show_bug.cgi?id=903 [19.11.11-rc1] net/ixgbe build failure with make and clang 13
Thank you, they also work well in all my tests so far.
> Verified patchset https://github.com/cpaelzer/dpdk-stable-queue/commits/19.11/
> Commit:
> net/ixgbe: build failure with make and clang 13
> acd0a2d2d net/ice: build failure with make and clang 13
> cc089e955 net/i40e: build failure with make and clang 13
>
> Tested with clang version 13.0.0 (Fedora 13.0.0~rc1-1.fc35) on baseline 19.11.11-rc1,
> No ice/i40e/ixgbe error.
> Find two new bugs:
> https://bugs.dpdk.org/show_bug.cgi?id=911 [19.11.11-rc1] linux/igb_uio/igb_uio build failure with make and clang 13
> https://bugs.dpdk.org/show_bug.cgi?id=912 [19.11.11-rc1] net/qede build failure with make and clang 13
Thanks for finding and filing these.
911 is a dup of 907, but 912 seems legit.
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 33+ messages in thread
* RE: 19.11.11 patches review and test
2021-12-17 7:47 ` Christian Ehrhardt
@ 2021-12-17 14:55 ` Richardson, Bruce
2021-12-17 15:48 ` Richardson, Bruce
0 siblings, 1 reply; 33+ messages in thread
From: Richardson, Bruce @ 2021-12-17 14:55 UTC (permalink / raw)
To: Christian Ehrhardt; +Cc: stable
Hi Christian,
just tried compiling latest 19.11 branch in dpdk-stable tree (which is your 19.11.11-rc1 commit) on FreeBSD 13, and see the following error:
[11/1452] Compiling C object lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o
FAILED: lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o
cc -Ilib/librte_eal.a.p -Ilib -I../lib -I. -I.. -Iconfig -I../config -Ilib/librte_eal/common/include -I../lib/librte_eal/common/include -I../lib/librte_eal/freebsd/eal/include -Ilib/librte_eal/common -I../lib/librte_eal/common -Ilib/librte_eal/common/include/arch/x86 -I../lib/librte_eal/common/include/arch/x86 -Ilib/librte_eal -I../lib/librte_eal -Ilib/librte_kvargs -I../lib/librte_kvargs -fcolor-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O3 -include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-missing-field-initializers -D_GNU_SOURCE -D__BSD_VISIBLE -fPIC -march=native -DRTE_LIBEAL_USE_GETENTROPY -DALLOW_EXPERIMENTAL_API -MD -MQ lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o -MF lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o.d -o lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o -c ../lib/librte_eal/common/eal_common_options.c
../lib/librte_eal/common/eal_common_options.c:1499:2: error: implicit declaration of function 'CPU_NAND' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
It looks to me that commit 9ed3385f "eal/freebsd: update CPU macro for FreeBSD 13" needs to be applied to 19.11 branch.
Other errors on FreeBSD 13 have been reported too, I'm looking into those.
Thanks,
/Bruce
^ permalink raw reply [flat|nested] 33+ messages in thread
* RE: 19.11.11 patches review and test
2021-12-17 14:55 ` Richardson, Bruce
@ 2021-12-17 15:48 ` Richardson, Bruce
2021-12-17 17:57 ` Christian Ehrhardt
0 siblings, 1 reply; 33+ messages in thread
From: Richardson, Bruce @ 2021-12-17 15:48 UTC (permalink / raw)
To: Christian Ehrhardt; +Cc: stable
> -----Original Message-----
> From: Richardson, Bruce
> Sent: Friday, December 17, 2021 2:56 PM
> To: 'Christian Ehrhardt' <christian.ehrhardt@canonical.com>
> Cc: stable@dpdk.org
> Subject: RE: 19.11.11 patches review and test
>
> Hi Christian,
>
> just tried compiling latest 19.11 branch in dpdk-stable tree (which is
> your 19.11.11-rc1 commit) on FreeBSD 13, and see the following error:
>
> [11/1452] Compiling C object
> lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o
> FAILED: lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o
> cc -Ilib/librte_eal.a.p -Ilib -I../lib -I. -I.. -Iconfig -I../config -
> Ilib/librte_eal/common/include -I../lib/librte_eal/common/include -
> I../lib/librte_eal/freebsd/eal/include -Ilib/librte_eal/common -
> I../lib/librte_eal/common -Ilib/librte_eal/common/include/arch/x86 -
> I../lib/librte_eal/common/include/arch/x86 -Ilib/librte_eal -
> I../lib/librte_eal -Ilib/librte_kvargs -I../lib/librte_kvargs -fcolor-
> diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O3 -
> include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-
> nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -
> Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -
> Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -
> Wno-missing-field-initializers -D_GNU_SOURCE -D__BSD_VISIBLE -fPIC -
> march=native -DRTE_LIBEAL_USE_GETENTROPY -DALLOW_EXPERIMENTAL_API -MD -MQ
> lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o -MF
> lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o.d -o
> lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o -c
> ../lib/librte_eal/common/eal_common_options.c
> ../lib/librte_eal/common/eal_common_options.c:1499:2: error: implicit
> declaration of function 'CPU_NAND' is invalid in C99 [-Werror,-Wimplicit-
> function-declaration]
>
> It looks to me that commit 9ed3385f "eal/freebsd: update CPU macro for
> FreeBSD 13" needs to be applied to 19.11 branch.
>
> Other errors on FreeBSD 13 have been reported too, I'm looking into those.
Looks like 03bff90ccfd6 ("contigmem: update for FreeBSD 13") could do with being cherry-picked too for 19.11.
With that done (2 patches cherry-picked, and one additional patch applied that I have just sent), I get a clean build on FBSD 13.
Regards,
/Bruce
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: 19.11.11 patches review and test
2021-12-17 15:48 ` Richardson, Bruce
@ 2021-12-17 17:57 ` Christian Ehrhardt
0 siblings, 0 replies; 33+ messages in thread
From: Christian Ehrhardt @ 2021-12-17 17:57 UTC (permalink / raw)
To: Richardson, Bruce; +Cc: stable
On Fri, Dec 17, 2021 at 4:48 PM Richardson, Bruce
<bruce.richardson@intel.com> wrote:
>
>
> > -----Original Message-----
> > From: Richardson, Bruce
> > Sent: Friday, December 17, 2021 2:56 PM
> > To: 'Christian Ehrhardt' <christian.ehrhardt@canonical.com>
> > Cc: stable@dpdk.org
> > Subject: RE: 19.11.11 patches review and test
> >
> > Hi Christian,
> >
> > just tried compiling latest 19.11 branch in dpdk-stable tree (which is
> > your 19.11.11-rc1 commit) on FreeBSD 13, and see the following error:
> >
> > [11/1452] Compiling C object
> > lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o
> > FAILED: lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o
> > cc -Ilib/librte_eal.a.p -Ilib -I../lib -I. -I.. -Iconfig -I../config -
> > Ilib/librte_eal/common/include -I../lib/librte_eal/common/include -
> > I../lib/librte_eal/freebsd/eal/include -Ilib/librte_eal/common -
> > I../lib/librte_eal/common -Ilib/librte_eal/common/include/arch/x86 -
> > I../lib/librte_eal/common/include/arch/x86 -Ilib/librte_eal -
> > I../lib/librte_eal -Ilib/librte_kvargs -I../lib/librte_kvargs -fcolor-
> > diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O3 -
> > include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-
> > nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -
> > Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -
> > Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -
> > Wno-missing-field-initializers -D_GNU_SOURCE -D__BSD_VISIBLE -fPIC -
> > march=native -DRTE_LIBEAL_USE_GETENTROPY -DALLOW_EXPERIMENTAL_API -MD -MQ
> > lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o -MF
> > lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o.d -o
> > lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o -c
> > ../lib/librte_eal/common/eal_common_options.c
> > ../lib/librte_eal/common/eal_common_options.c:1499:2: error: implicit
> > declaration of function 'CPU_NAND' is invalid in C99 [-Werror,-Wimplicit-
> > function-declaration]
> >
> > It looks to me that commit 9ed3385f "eal/freebsd: update CPU macro for
> > FreeBSD 13" needs to be applied to 19.11 branch.
> >
> > Other errors on FreeBSD 13 have been reported too, I'm looking into those.
>
> Looks like 03bff90ccfd6 ("contigmem: update for FreeBSD 13") could do with being cherry-picked too for 19.11.
>
> With that done (2 patches cherry-picked, and one additional patch applied that I have just sent), I get a clean build on FBSD 13.
They all look safe to me, applied all three now.
I have started build tests...
Not sure if I can tag -rc2 today, but if not today then still soon
(many build time fixes from many people since -rc1).
> Regards,
> /Bruce
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 33+ messages in thread
end of thread, other threads:[~2021-12-17 17:57 UTC | newest]
Thread overview: 33+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-09 14:43 19.11.11 patches review and test christian.ehrhardt
2021-12-13 4:14 ` Kalesh Anakkur Purayil
2021-12-13 11:06 ` Ferruh Yigit
2021-12-13 12:39 ` Christian Ehrhardt
2021-12-13 12:58 ` Ferruh Yigit
2021-12-13 13:32 ` Christian Ehrhardt
2021-12-13 13:49 ` Kalesh Anakkur Purayil
2021-12-13 14:07 ` Ferruh Yigit
2021-12-14 5:49 ` Kalesh Anakkur Purayil
2021-12-14 7:44 ` Christian Ehrhardt
2021-12-14 10:13 ` Ferruh Yigit
2021-12-14 11:39 ` Christian Ehrhardt
2021-12-14 12:08 ` Ferruh Yigit
2021-12-14 13:57 ` Christian Ehrhardt
2021-12-14 13:10 ` Ferruh Yigit
2021-12-14 13:58 ` Christian Ehrhardt
2021-12-14 14:46 ` Christian Ehrhardt
2021-12-14 14:52 ` Ferruh Yigit
2021-12-15 13:17 ` Christian Ehrhardt
2021-12-15 14:44 ` Ferruh Yigit
2021-12-16 7:21 ` Christian Ehrhardt
2021-12-14 7:14 ` Jiang, YuX
2021-12-14 7:45 ` Christian Ehrhardt
2021-12-14 8:05 ` Christian Ehrhardt
2021-12-15 11:04 ` Jiang, YuX
2021-12-15 13:16 ` Christian Ehrhardt
2021-12-17 7:05 ` Jiang, YuX
2021-12-17 7:47 ` Christian Ehrhardt
2021-12-17 14:55 ` Richardson, Bruce
2021-12-17 15:48 ` Richardson, Bruce
2021-12-17 17:57 ` Christian Ehrhardt
2021-12-14 13:51 ` Pei Zhang
2021-12-14 13:52 ` Christian Ehrhardt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).