From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by dpdk.org (Postfix) with ESMTP id 6886649E0 for ; Fri, 9 Nov 2018 07:53:20 +0100 (CET) Received: from mail-ed1-f72.google.com ([209.85.208.72]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1gL0fP-0006QE-Jg for stable@dpdk.org; Fri, 09 Nov 2018 06:53:19 +0000 Received: by mail-ed1-f72.google.com with SMTP id x1-v6so676749edh.8 for ; Thu, 08 Nov 2018 22:53:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KkXz+A8XLzOETaSaPvgZV0csNAKaKftOSlXGN2B2oU8=; b=YH1bWcuiHexOl0ZSa2Gjy3z96yLAzLVCTL4AI5jAgsMMhiyxpzcVQC+F80t+3tFIOh vY46xFi9RZlp4akldtcEKplh9Yfe/N65ubuvMAgjMo0hDo/REELh23V1UZSjrHEscCkT DC1XC9+00w4KxDk5AhY2pVZjMxGC3Xd4ONWW/yghLO+NAZbmXlEnSvW2xcTjDw6/TsYB lz+C3uje/zU7oebZ4B7zLldb24YI6PTJRGiD1HmcdNqsbGmQ3fiQtUtDdaMLNCajbHbY wkwnXTEArQDx/8IKHObJ+Tacb+fqxuN2hQI967P6GlCa4EkYhmJ4UQmmzuw3vZV1DrzM dJCA== X-Gm-Message-State: AGRZ1gItisHHgB24PIq7ubEHGGl5vXMXy9YYiJCDMW9WbhUMn+kPHEQ1 1INYBRjAqyyiZUya4IyBwNAI2FgNjSSSYIJpLNvJaLV560G7rh8HZcoTv5CR/ofJW+mODAdbiLd djNoOJ8TSzoshudfwrLO+hEFCvstOcIw9CkfFsJOO X-Received: by 2002:a17:906:5a0a:: with SMTP id p10-v6mr1027240ejq.43.1541746399107; Thu, 08 Nov 2018 22:53:19 -0800 (PST) X-Google-Smtp-Source: AJdET5d9idruEyLqsCgmxShnvoIjBpAU6RzitjEi4ArAa2QcCEZokIo/tTRZPgdxMFgoHvVbRjY/iCHmyNPhDZfLW70= X-Received: by 2002:a17:906:5a0a:: with SMTP id p10-v6mr1027222ejq.43.1541746398790; Thu, 08 Nov 2018 22:53:18 -0800 (PST) MIME-Version: 1.0 References: <20181029125329.17729-20-bluca@debian.org> <20181108180111.25873-1-bluca@debian.org> <20181108180111.25873-3-bluca@debian.org> In-Reply-To: <20181108180111.25873-3-bluca@debian.org> From: Christian Ehrhardt Date: Fri, 9 Nov 2018 07:52:52 +0100 Message-ID: To: Luca Boccassi Cc: yskoh@mellanox.com, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] patch 'mk: disable gcc AVX512F support' has been queued to LTS release 16.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2018 06:53:23 -0000 On Thu, Nov 8, 2018 at 7:01 PM Luca Boccassi wrote: > > Hi, > > FYI, your patch has been queued to LTS release 16.11.9 > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 11/10/18. So please > shout if anyone has objections. > > Also note that after the patch there's a diff of the upstream commit vs the patch applied > to the branch. If the code is different (ie: not only metadata diffs), due for example to > a change in context or macro names, please double check it. > > Thanks. > > Luca Boccassi Hi Luca, please be aware of the still ongoing discussion on this patch, see full thread around http://mails.dpdk.org/archives/dev/2018-November/118121.html > --- > From 8dbda3ba255c6045ffe3eb73f1d8e1f67186c22b Mon Sep 17 00:00:00 2001 > From: Yongseok Koh > Date: Sat, 3 Nov 2018 01:06:32 +0000 > Subject: [PATCH] mk: disable gcc AVX512F support > > [ upstream commit 8d07c82b239f7782be0d3afbb626390e2cb0c8f5 ] > > This is a workaround to prevent a crash, which might be caused by > optimization of newer gcc (7.3.0) on Intel Skylake. > > This disables AVX512F support of gcc by adding -mno-avx512f if it is > disabled in DPDK (CONFIG_RTE_ENABLE_AVX512=n). > > This does not apply to the meson build as that doesn't have such an option > but always enable AVX512F whenever supported. > > Bugzilla ID: 97 > > Signed-off-by: Yongseok Koh > --- > mk/rte.cpuflags.mk | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk > index 8bbccb9ed..c7027a0fe 100644 > --- a/mk/rte.cpuflags.mk > +++ b/mk/rte.cpuflags.mk > @@ -91,6 +91,11 @@ endif > > ifneq ($(filter $(AUTO_CPUFLAGS),__AVX512F__),) > CPUFLAGS += AVX512F > +else > +# disable AVX512F support of gcc as a workaround for Bug 97 > +ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > +MACHINE_CFLAGS += -mno-avx512f > +endif > endif > > # IBM Power CPU flags > -- > 2.19.1 > > --- > Diff of the applied patch vs upstream commit (please double-check if non-empty: > --- > --- - 2018-11-08 17:59:30.124667578 +0000 > +++ 0003-mk-disable-gcc-AVX512F-support.patch 2018-11-08 17:59:30.048751011 +0000 > @@ -1,8 +1,10 @@ > -From 8d07c82b239f7782be0d3afbb626390e2cb0c8f5 Mon Sep 17 00:00:00 2001 > +From 8dbda3ba255c6045ffe3eb73f1d8e1f67186c22b Mon Sep 17 00:00:00 2001 > From: Yongseok Koh > Date: Sat, 3 Nov 2018 01:06:32 +0000 > Subject: [PATCH] mk: disable gcc AVX512F support > > +[ upstream commit 8d07c82b239f7782be0d3afbb626390e2cb0c8f5 ] > + > This is a workaround to prevent a crash, which might be caused by > optimization of newer gcc (7.3.0) on Intel Skylake. > > @@ -13,7 +15,6 @@ > but always enable AVX512F whenever supported. > > Bugzilla ID: 97 > -Cc: stable@dpdk.org > > Signed-off-by: Yongseok Koh > --- > @@ -21,12 +22,12 @@ > 1 file changed, 5 insertions(+) > > diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk > -index 43ed84155..c3291b17a 100644 > +index 8bbccb9ed..c7027a0fe 100644 > --- a/mk/rte.cpuflags.mk > +++ b/mk/rte.cpuflags.mk > -@@ -68,6 +68,11 @@ endif > +@@ -91,6 +91,11 @@ endif > + > ifneq ($(filter $(AUTO_CPUFLAGS),__AVX512F__),) > - ifeq ($(CONFIG_RTE_ENABLE_AVX512),y) > CPUFLAGS += AVX512F > +else > +# disable AVX512F support of gcc as a workaround for Bug 97 > @@ -34,8 +35,8 @@ > +MACHINE_CFLAGS += -mno-avx512f > +endif > endif > - endif > > + # IBM Power CPU flags > -- > 2.19.1 > -- Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd