Re:

[Christian Ehrhardt <christian.ehrhardt@canonical.com>]

On Sun, Dec 12, 2021 at 3:20 PM Ali Alnubani <alialnu@nvidia.com> wrote:
>
> Hello,
>
> > -----Original Message-----
> > From: christian.ehrhardt@canonical.com
> > <christian.ehrhardt@canonical.com>
> > Sent: Tuesday, November 30, 2021 6:57 PM
> > Cc: Aaron Conole <aconole@redhat.com>; Abhinandan Gujjar
> > <abhinandan.gujjar@intel.com>; Ajit Khaparde
> > <ajit.khaparde@broadcom.com>; Akhil Goyal <gakhil@marvell.com>;
> > Alexander Kozyrev <akozyrev@nvidia.com>; Ali Alnubani
> > <alialnu@nvidia.com>; Alvin Zhang <alvinx.zhang@intel.com>; Aman Singh
> > <aman.deep.singh@intel.com>; Anatoly Burakov
> > <anatoly.burakov@intel.com>; Andrew Boyer <aboyer@pensando.io>;
> > Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>; Andy Moreton
> > <amoreton@xilinx.com>; Anoob Joseph <anoobj@marvell.com>; Apeksha
> > Gupta <apeksha.gupta@nxp.com>; Arek Kusztal
> > <arkadiuszx.kusztal@intel.com>; Ashish Gupta
> > <ashish.gupta@marvell.com>; Baruch Siach <baruch@tkos.co.il>; Beilei Xing
> > <beilei.xing@intel.com>; Bernard Iremonger
> > <bernard.iremonger@intel.com>; Bruce Richardson
> > <bruce.richardson@intel.com>; Chandubabu Namburu
> > <chandu@amd.com>; Chas Williams <chas3@att.com>; Chenbo Xia
> > <chenbo.xia@intel.com>; Chengchang Tang
> > <tangchengchang@huawei.com>; Chengwen Feng
> > <fengchengwen@huawei.com>; Ciara Loftus <ciara.loftus@intel.com>; Ciara
> > Power <ciara.power@intel.com>; Conor Fogarty <conor.fogarty@intel.com>;
> > Conor Walsh <conor.walsh@intel.com>; Cristian Dumitrescu
> > <cristian.dumitrescu@intel.com>; Dan Nowlin <dan.nowlin@intel.com>;
> > Dapeng Yu <dapengx.yu@intel.com>; Dariusz Sosnowski
> > <dsosnowski@nvidia.com>; David Christensen <drc@linux.vnet.ibm.com>;
> > David Hunt <david.hunt@intel.com>; David Marchand
> > <david.marchand@redhat.com>; Declan Doherty
> > <declan.doherty@intel.com>; Deepak Kumar Jain
> > <deepak.k.jain@intel.com>; Devendra Singh Rawat
> > <dsinghrawat@marvell.com>; Dmitry Kozlyuk <dkozlyuk@nvidia.com>;
> > Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>; Dmitry Malloy
> > <dmitrym@microsoft.com>; Eli Britstein <elibr@nvidia.com>; Evgeny
> > Schemeilin <evgenys@amazon.com>; Fan Zhang
> > <roy.fan.zhang@intel.com>; Feifei Wang <feifei.wang2@arm.com>; Ferruh
> > Yigit <ferruh.yigit@intel.com>; Fiona Trahe <fiona.trahe@intel.com>;
> > Gagandeep Singh <g.singh@nxp.com>; Gaoxiang Liu
> > <liugaoxiang@huawei.com>; Gregory Etelson <getelson@nvidia.com>;
> > Guoyang Zhou <zhouguoyang@huawei.com>; Haiyue Wang
> > <haiyue.wang@intel.com>; Harman Kalra <hkalra@marvell.com>; Harry van
> > Haaren <harry.van.haaren@intel.com>; Heinrich Kuhn
> > <heinrich.kuhn@corigine.com>; Hemant Agrawal
> > <hemant.agrawal@nxp.com>; Honnappa Nagarahalli
> > <honnappa.nagarahalli@arm.com>; Huichao Cai <chcchc88@163.com>;
> > Huisong Li <lihuisong@huawei.com>; Hyong Youb Kim
> > <hyonkim@cisco.com>; Idan Hackmon <idanhac@nvidia.com>; Igor Chauskin
> > <igorch@amazon.com>; Igor Romanov <igor.romanov@oktetlabs.ru>; Igor
> > Russkikh <irusskikh@marvell.com>; Igor Ryzhov <iryzhov@nfware.com>;
> > Ilyes Ben Hamouda <ilyes.ben_hamouda@6wind.com>; Ivan Ilchenko
> > <ivan.ilchenko@oktetlabs.ru>; Ivan Malov <ivan.malov@oktetlabs.ru>;
> > Jakub Grajciar <jgrajcia@cisco.com>; Jasvinder Singh
> > <jasvinder.singh@intel.com>; Jay Jayatheerthan
> > <jay.jayatheerthan@intel.com>; Jay Zhou <jianjay.zhou@huawei.com>;
> > Jerin Jacob <jerinj@marvell.com>; Jian Wang <jianwang@trustnetic.com>;
> > Jiawen Wu <jiawenwu@trustnetic.com>; Jie Wang <jie1x.wang@intel.com>;
> > Jingjing Wu <jingjing.wu@intel.com>; John Daley <johndale@cisco.com>;
> > John Griffin <john.griffin@intel.com>; John McNamara
> > <john.mcnamara@intel.com>; John W. Linville <linville@tuxdriver.com>;
> > Joyce Kong <joyce.kong@arm.com>
> > Subject:
> >
> > Subject: please help backporting some patches to stable release 19.11.11
> >
> > Hi commit authors (and maintainers),
> >
> > Despite being selected by the DPDK maintenance tool ./devtools/git-log-
> > fixes.sh
> > I didn't apply following commits from DPDK main to 19.11
> > stable branch, as conflicts or build errors occur.
> >
> > Can authors check your patches in the following list and either:
> >     - Backport your patches to the 19.11 branch, or
> >     - Indicate that the patch should not be backported
> >
> > Please do either of the above by December the 14th 2021 (More time than
> > usual as backports get harder).
> >
> > You can find the a temporary work-in-progress branch of the coming 19.11.11
> > release at:
> >     https://github.com/cpaelzer/dpdk-stable-queue
> > It is recommended to backport on top of that to minimize further conflicts or
> > misunderstandings.
> >
> > Some notes on stable backports:
> >
> > A backport should contain a reference to the DPDK main branch commit
> > in it's commit message in the following fashion:
> >     [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
> >
> > For example:
> >     https://git.dpdk.org/dpdk-
> > stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
> >
> > When sending the backported patch, please indicate the target branch in the
> > subject line, as we have multiple branches, for example:
> >     [PATCH 19.11] foo/bar: fix baz
> >
> > With git format-patch, this can be achieved by appending the parameter:
> >     --subject-prefix='PATCH 19.11'
> >
> > Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
> >
> > FYI, branch 19.11 is located at tree:
> >    https://git.dpdk.org/dpdk-stable
> >
> > Thanks.
> >
> > Christian Ehrhardt <christian.ehrhardt@canonical.com>
> >
> > ---
> >
> > Applying but breaking the build:
> >
> > 858a152ab5  Junxiao Shi      net/memif: allow stopping and closing device
> > c4d3e8fbe4  Ruifeng Wang     net/i40e: fix risk in descriptor read in scalar Rx
> > 7dc627426e  Olivier Matz     test/mbuf: fix access to freed memory
> > 86e361cdeb  David Marchand   test/cmdline: fix memory leak
> > 04bcc80204  Xuan Ding        net/virtio: fix indirect descriptor reconnection
> > 9de76dfb92  Ivan Ilchenko    net/virtio: fix Tx completed mbuf leak on device
> > stop
> > 5d903aee8a  Gaoxiang Liu     net/virtio: fix repeated freeing of virtqueue
> > 9c8c806487  Thomas Monjalon  test/crypto: fix minsize build
> > 96b25c496a  Haiyue Wang      net/ice: fix memzone leak after device init
> > failure
> >
> > ---
> >
> > Not Applying
> >
> [..]
> > 9465a5d5a0  Conor Walsh      net/nfp: remove unused message length
>
> I can reproduce a build failure (https://bugs.dpdk.org/show_bug.cgi?id=900) with Clang 13, and it's fixed by this patch.
> Let me know if you need help with backporting it.

Thanks, the backport was trivial (same change to another filename) and
works fine.
Also since it isn't really a functional change I do not think we need
to re-start another -rc for this one.
Applied.

> Thanks,
> Ali



-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd