From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5E69A00C3 for ; Wed, 15 Dec 2021 14:37:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A82840041; Wed, 15 Dec 2021 14:37:48 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id E21FB40041 for ; Wed, 15 Dec 2021 14:37:47 +0100 (CET) Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id A262540037 for ; Wed, 15 Dec 2021 13:37:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1639575467; bh=HcHGzkhcip4oFDKrGak8Hyv5l6KKIISaFmSkrS+o1os=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=D3NjmRrsOBOhcQLambmpr+1fT8iNhySO3deuxMKevabc/XlNPMD4bHDWB+6ZqPtMj F1xwLnK78+ILA8nmH82AR/9G8o3lGhAzxtD+g2/XopbildiEnP6G/McIrkNLUQh9On 4VCa/bXNK+K5yE2lnswT+qsWy1RlPnc/GSTm2cvqFKAmKieYRNeEtUaUAjlZFw9+eW swA3VOeagScCa+kvHlpWi26Gn2ogakjQDZks7NnG233JK7YNgXKt/KR7IRM1wDh180 +mRV2GNj5m5mTJdJOnJOkaODcWI6GDTJpfLxfjmCmoP0Fsure8GVqVSpIvNNDZVhfM hrbchwovnxPtw== Received: by mail-qk1-f200.google.com with SMTP id bk35-20020a05620a1a2300b0046d2a9b93dfso18924302qkb.16 for ; Wed, 15 Dec 2021 05:37:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HcHGzkhcip4oFDKrGak8Hyv5l6KKIISaFmSkrS+o1os=; b=7UptAPKa2iSiRzJ/5QLUZwjzUuleAQ0g1/7sEyuT4ohJ+5Sq/QA7xDo8CIh8SELUwY Up7tRMu5zktp3M68WC9ZessSIYnGrSwRyR9TnSgvjmfyy1E7yVj40HoghHr9iwBRdgdX +zqJ17K1iH3fYi/UH0lsahhw91lPbpA4jq2kU75ASrkepNEurEAVS5ymSg3W1zAxtB3H XiLbVgFTLKePRbVhS0c0U0iyPhgj9mVi67LTZfelPy6mXAhJ3NrV4NHQrPxtHmjvhlJE AzwA4dUooAvO7sj9SDJ8WZHIuDKyMM+PPscLmtLg9A9le/GlZ55YuKGiPpjtad6eemj4 7wkA== X-Gm-Message-State: AOAM530c6BIMO22IaqmX/m3r/JAfdlgoR8fMC9JarWuNNy3r9B11MdVe 9yKM6vrX/BnpXSPw7UUzjjMVrBpB4QV7eh+TDLtDfBNzb8Dr8JPV+z16oWApM4tNkQVRKK7+LVT X3hDscime8hZ10VpXZaHoGEIWgglnc9CpGeVru9K0 X-Received: by 2002:ac8:5aca:: with SMTP id d10mr12010892qtd.469.1639575466447; Wed, 15 Dec 2021 05:37:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJykOcSe34fcK0uDdmvX/pDxsOYLsKLuOuummP6R+TcCh3Dsqe2/qX5IgHHg1q6tB6r0YotaaMZy2WG1mCxpOPU= X-Received: by 2002:ac8:5aca:: with SMTP id d10mr12010875qtd.469.1639575466272; Wed, 15 Dec 2021 05:37:46 -0800 (PST) MIME-Version: 1.0 References: <20211215003544.371084-1-haiyue.wang@intel.com> <20211215003544.371084-2-haiyue.wang@intel.com> In-Reply-To: <20211215003544.371084-2-haiyue.wang@intel.com> From: Christian Ehrhardt Date: Wed, 15 Dec 2021 14:37:20 +0100 Message-ID: Subject: Re: [PATCH 19.11 v2 2/3] net/ice: build failure with make and clang 13 To: Haiyue Wang Cc: stable@dpdk.org, yux.jiang@intel.com, qi.z.zhang@intel.com, alialnu@nvidia.com, Qiming Yang , Wenzhuo Lu Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Dec 15, 2021 at 2:08 AM Haiyue Wang wrote: > > Disable the -Wunused-but-set-variable option for clang to avoid > compile warning. Agreed, as I explained on patch 3/3 this is not an issue for upstream as meson builds already set that flag. $ grep -Hrn -C 3 -- no-unused-but-set-variable | grep ice drivers/net/ice/base/meson.build-14-] drivers/net/ice/base/meson.build-15- drivers/net/ice/base/meson.build-16-error_cflags = ['-Wno-unused-value', drivers/net/ice/base/meson.build:17: '-Wno-unused-but-set-variable', drivers/net/ice/base/meson.build-18- '-Wno-unused-variable', drivers/net/ice/base/meson.build-19- '-Wno-unused-parameter', drivers/net/ice/base/meson.build-20-] drivers/net/ice/Makefile-31-CFLAGS_BASE_DRIVER += -Wno-unused-variable drivers/net/ice/Makefile-32- drivers/net/ice/Makefile-33-ifeq ($(shell test $(GCC_VERSION) -ge 44 && echo 1), 1) drivers/net/ice/Makefile:34:CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable drivers/net/ice/Makefile-35-endif drivers/net/ice/Makefile-36- drivers/net/ice/Makefile-37-endif The resulting makefile will now set it in gcc newer than 4.4 and globally on clang. That is ok as older gcc's would fail due to the unknown option. Applying to 19.11 LTS branch ... > Bugzilla ID: 902 > > Signed-off-by: Haiyue Wang > --- > drivers/net/ice/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ice/Makefile b/drivers/net/ice/Makefile > index 6c4d155268..370b33af60 100644 > --- a/drivers/net/ice/Makefile > +++ b/drivers/net/ice/Makefile > @@ -26,6 +26,7 @@ CFLAGS_BASE_DRIVER += > else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y) > CFLAGS_BASE_DRIVER += -Wno-unused-parameter > CFLAGS_BASE_DRIVER += -Wno-unused-variable > +CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable > else > CFLAGS_BASE_DRIVER += -Wno-unused-parameter > CFLAGS_BASE_DRIVER += -Wno-unused-variable > -- > 2.34.1 > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd