Re: [PATCH 19.11 4/4] Revert "net/ena: trigger reset on Tx prepare failure"

[Christian Ehrhardt <christian.ehrhardt@canonical.com>]

On Fri, Dec 3, 2021 at 4:09 PM Michal Krawczyk <mk@semihalf.com> wrote:
>
> This reverts commit 91867d8536914374062693fd5fddc08ae267a41f.
> ENA Tx logic in the DPDK v19.11 is a bit different than the one from
> which the original commit was backported (DPDK v21.08). As calculations
> of the available ring size is not very precise, ena_com_prepare_tx()
> function can fail because the ring is full - it's not a fault in the
> current logic, so it shouldn't print error logs nor trigger the device
> reset.

Yeah, that is in 19.11.10 - thanks for having a deeper look and sending that!
Applied (together with the other three of this series) to the WIP
branch of 19.11.11


> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
> ---
>  drivers/net/ena/ena_ethdev.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
> index 62c15f3c9..8f02ecde1 100644
> --- a/drivers/net/ena/ena_ethdev.c
> +++ b/drivers/net/ena/ena_ethdev.c
> @@ -2533,12 +2533,7 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
>                 rc = ena_com_prepare_tx(tx_ring->ena_com_io_sq,
>                                         &ena_tx_ctx, &nb_hw_desc);
>                 if (unlikely(rc)) {
> -                       PMD_DRV_LOG(ERR,
> -                               "Failed to prepare Tx buffers, rc: %d\n", rc);
>                         ++tx_ring->tx_stats.prepare_ctx_err;
> -                       tx_ring->adapter->reset_reason =
> -                               ENA_REGS_RESET_DRIVER_INVALID_STATE;
> -                       tx_ring->adapter->trigger_reset = true;
>                         break;
>                 }
>                 tx_info->tx_descs = nb_hw_desc;
> --
> 2.25.1
>


-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd