From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6340CA034F for ; Mon, 6 Dec 2021 09:31:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F56940040; Mon, 6 Dec 2021 09:31:55 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 86CD740040 for ; Mon, 6 Dec 2021 09:31:53 +0100 (CET) Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 4492C3F1B2 for ; Mon, 6 Dec 2021 08:31:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638779513; bh=FzMMlkzHvy04LeL0QuHRhKaecsL/TXqJUnaORF2Lzhg=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=sqS9SlaytGNM4AEnUniEqDagJtEXEnXbgWLnVHmNjWUbgDTv+lEcNujI0IGhEbvho o3WWRE0nuvI+NQqh3DODN44aMvyZxhvnv2fh8Ncgnw3ip8twQXgZlqY4JmtiixCcvg wZgPveyQXh3liMK+SQ3nkbuPcm14q2gCPFAcGdHzYYwQkt+kujGR0my5xbz89LmXUO wTw3QYDei8R4h4tORhPr7SlM7PLMsuFlTL9xtY5/IZM8T2vspbgxN2GaXkqMQke1sz z57vlAWTvjBKrLUr3WHfpNaHCP3aDU92nGIBpJgRyAILEna2xtHeg2THD5qoTrj/Zs zja/nJdIts+9w== Received: by mail-qk1-f199.google.com with SMTP id p18-20020a05620a057200b00467bc32b45aso10133503qkp.12 for ; Mon, 06 Dec 2021 00:31:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FzMMlkzHvy04LeL0QuHRhKaecsL/TXqJUnaORF2Lzhg=; b=RJwos6UWiIr/C5CfND1cs6Q/ggUahaEYg6Yz/iISExPey2ikD3SD4+VL3oQuuUnMA5 DrOn8bfAMw85+Ay62hvYVku//qe7DCgVfk5Wrd4B21pei4c+SQvbcOnGsub2yciCKKZU Q3mpgHE/OYWslsaJ0GzBZgwIkOWu2FbjUSGsH2sTVPKEDdnqYDoHQk8urheRGHNwtFms 9VhxpAwdF/Kwqfqi8kErbMGLkcdRMLC2AN3n9aMrELHrQesRv1tGy6tHPXuj1Lejz7TV A+920Kbo8rOF6zqXSzwgOvC2SmlWTkjI+1WalO4/i1fAciUfYpi53sUH9U1S+JKnI22t +qjw== X-Gm-Message-State: AOAM53349EByZzdAw83+O7KUFISP2f7qbMcexVd1Wtzz5Gp7vf2cXN4T 2vlUzuZEarcUW36tItbzbjkN3hOV/C3s6UaopzSsSW3M3pdZwv1V/W7ioYZDAYLGpGJ8QWqd12i fuT4SaXEs4duM4z8tOuvKZZR2wpVWWgLcZLQFC2rM X-Received: by 2002:a05:622a:1114:: with SMTP id e20mr38781564qty.427.1638779512442; Mon, 06 Dec 2021 00:31:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJzAZFM+D5pHDAYEaMopRJQMIkOlPePyC8jPkmLztrZUYV/9a7KzXj2sHXKQmNhEIspsQ04BX0sAM64ZYc3zadM= X-Received: by 2002:a05:622a:1114:: with SMTP id e20mr38781553qty.427.1638779512185; Mon, 06 Dec 2021 00:31:52 -0800 (PST) MIME-Version: 1.0 References: <20211203150859.3933-1-mk@semihalf.com> <20211203150859.3933-4-mk@semihalf.com> In-Reply-To: <20211203150859.3933-4-mk@semihalf.com> From: Christian Ehrhardt Date: Mon, 6 Dec 2021 09:31:26 +0100 Message-ID: Subject: Re: [PATCH 19.11 4/4] Revert "net/ena: trigger reset on Tx prepare failure" To: Michal Krawczyk Cc: stable@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Fri, Dec 3, 2021 at 4:09 PM Michal Krawczyk wrote: > > This reverts commit 91867d8536914374062693fd5fddc08ae267a41f. > ENA Tx logic in the DPDK v19.11 is a bit different than the one from > which the original commit was backported (DPDK v21.08). As calculations > of the available ring size is not very precise, ena_com_prepare_tx() > function can fail because the ring is full - it's not a fault in the > current logic, so it shouldn't print error logs nor trigger the device > reset. Yeah, that is in 19.11.10 - thanks for having a deeper look and sending that! Applied (together with the other three of this series) to the WIP branch of 19.11.11 > Signed-off-by: Michal Krawczyk > --- > drivers/net/ena/ena_ethdev.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c > index 62c15f3c9..8f02ecde1 100644 > --- a/drivers/net/ena/ena_ethdev.c > +++ b/drivers/net/ena/ena_ethdev.c > @@ -2533,12 +2533,7 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, > rc = ena_com_prepare_tx(tx_ring->ena_com_io_sq, > &ena_tx_ctx, &nb_hw_desc); > if (unlikely(rc)) { > - PMD_DRV_LOG(ERR, > - "Failed to prepare Tx buffers, rc: %d\n", rc); > ++tx_ring->tx_stats.prepare_ctx_err; > - tx_ring->adapter->reset_reason = > - ENA_REGS_RESET_DRIVER_INVALID_STATE; > - tx_ring->adapter->trigger_reset = true; > break; > } > tx_info->tx_descs = nb_hw_desc; > -- > 2.25.1 > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd