From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1A84A0C47 for ; Wed, 1 Dec 2021 16:39:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB95540140; Wed, 1 Dec 2021 16:39:15 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 3D04441C2E for ; Wed, 1 Dec 2021 16:39:14 +0100 (CET) Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 010AA3F1B8 for ; Wed, 1 Dec 2021 15:39:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638373154; bh=1p54LaQUZXNf6/u3hCs6fwrmKzoEfo02XfsvewNzfaM=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=euQbs/9ncz90zDj5Ze+Tvn19y03Yg503SBkGVhCwS4S4j7xZrO5qgfLJO9WKqzgGx demMryxKxxzP2hDCA9Vom5LD1xdmszZhmCzDrzRa5ZRAfHZ0xm4YHWkYAP28p2CU9f Pjr2SO+0zzlIbRa1h8KPUTtt220mMXXm4w6vU85x1OSCvZONqlGAOb9sPPwpa0dEyr qTu0cPX/+7Zo03dO+rQE5HwSdKuPV3g4ZGZz0qphPK84Y9ehk18kvX9TkojANf1NxZ nrp2Hh5k0Z4e+OyvnHKBc9K+a3hTAj1oHOw4DU1MU4ouilRjuECJJulFeEbaK1RDky N1pHD7+oJiSJA== Received: by mail-qt1-f199.google.com with SMTP id h8-20020a05622a170800b002acc8656e05so32505476qtk.7 for ; Wed, 01 Dec 2021 07:39:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1p54LaQUZXNf6/u3hCs6fwrmKzoEfo02XfsvewNzfaM=; b=cDoOBUutjXQSnOjWSSnl3yE7cUvPRcz1IcKoyJxnwAvAqyYoo7JZZlYH04B00HXajU zB7MJFmF/5rWVFuo4s+u6NrFMsBFo/xpFtKgsetPdhNELQLfh+T23itov1gO/gJiI5dY aP8p17Vn/Mcycsb2gsS7R9ZmgtzJjbz6vBF9qm9eAYHgIFTt4LEED2VhIW+1rwIDjsuR sK46Yp7lodYBYdzYB4bX3bLigeg14BRXeFEyEcnKgcnLhiXro+KHWb8cWhfC0mICxRAG 5zoOv5Gsd2Ai1RIxrCoaenzDy2J27VN6g6e0PMlpVntROqN6yZSywl97B8giOHV3WJyE /Rww== X-Gm-Message-State: AOAM5332WQpN0az5NO2pjKj+k5XISKFSBw+DJyGpIsgm59P7CbnRoHxB Boi1FotM4C9LWXKEwd58Ew9boqbSWPS4QRsOxU46bos82inssP07AqAeti+mfO1ZMtZlfmawFYC nQT1zuMX5fg4aziZdNyhERrG77ibjuBKa+DnpHJK2 X-Received: by 2002:a05:620a:1790:: with SMTP id ay16mr7012914qkb.43.1638373153077; Wed, 01 Dec 2021 07:39:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJy6FqvEAn0li+CzcDJc7zcU5bpqOfp6R017OSpLFkC+H2AD7GsR18ui9YdTyegD8H94w3Gq6+75zN3Mu61Ci4U= X-Received: by 2002:a05:620a:1790:: with SMTP id ay16mr7012890qkb.43.1638373152855; Wed, 01 Dec 2021 07:39:12 -0800 (PST) MIME-Version: 1.0 References: <1638355193-117871-1-git-send-email-tudor.cornea@gmail.com> In-Reply-To: <1638355193-117871-1-git-send-email-tudor.cornea@gmail.com> From: Christian Ehrhardt Date: Wed, 1 Dec 2021 16:38:47 +0100 Message-ID: Subject: Re: [PATCH 19.11] net/ixgbe: fix port initialization if MTU config fails To: Tudor Cornea Cc: stable@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Dec 1, 2021 at 12:10 PM Tudor Cornea wrote: > > [ upstream commit 2108930be123ab83c837e7dd6eb3078ec3482ad4 ] > Thanks, applied > On a VMware ESXi 6.0 setup with an Intel 82599 NIC the ports don't > seem to initialize anymore, while running testpmd. > > Configuring Port 0 (socket 0) > ixgbevf_dev_rx_init(): Set max packet length to 1518 failed. > ixgbevf_dev_start(): Unable to initialize RX hardware (-22) > Fail to start port 0: Invalid argument > Configuring Port 1 (socket 0) > ixgbevf_dev_rx_init(): Set max packet length to 1518 failed. > ixgbevf_dev_start(): Unable to initialize RX hardware (-22) > Fail to start port 1: Invalid argument > Please stop the ports first > > If the call to ixgbevf_rlpml_set_vf fails and we return prematurely, > we will not be able to initialize the ports correctly. > > Fixes: c77866a16904 ("net/ixgbe: detect failed VF MTU set") > > We can make this particular use case work correctly if we don't > return an error, which seems to be consistent with the overall > kernel ixgbevf implementation. > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/ > drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c?h=v5.14#n2015 > > Signed-off-by: Tudor Cornea > --- > drivers/net/ixgbe/ixgbe_rxtx.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c > index ed36a33..26b49a2 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > @@ -5545,11 +5545,9 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev) > * VF packets received can work in all cases. > */ > if (ixgbevf_rlpml_set_vf(hw, > - (uint16_t)dev->data->dev_conf.rxmode.max_rx_pkt_len)) { > + (uint16_t)dev->data->dev_conf.rxmode.max_rx_pkt_len)) > PMD_INIT_LOG(ERR, "Set max packet length to %d failed.", > dev->data->dev_conf.rxmode.max_rx_pkt_len); > - return -EINVAL; > - } > > /* > * Assume no header split and no VLAN strip support > -- > 2.7.4 > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd