[dpdk-stable] "app/testpmd: verify DCB config during forward config" is incompatible with the 19.11.x series

[dpdk-stable] "app/testpmd: verify DCB config during forward config" is incompatible with the 19.11.x series

[Christian Ehrhardt]

Hi,
this commit was targted at the stable series:

commit 43f1f8261136852357057b78aa49d354beaf3931
Author: Huisong Li <lihuisong@huawei.com>
Date:   Wed Apr 28 14:40:44 2021 +0800

    app/testpmd: verify DCB config during forward config

As part of that it removes pt_id as it was the last user.
But this does not work out without the following also in place.

commit 08dcd187068666c96e8a16604a1c96160ed310e9
Author: Huisong Li <lihuisong@huawei.com>
Date:   Wed Dec 2 20:48:55 2020 +0800

    app/testpmd: fix queue stats mapping configuration

Since the latter is rather massive I have for now dropped 43f1f8261
from the queue for 19.11.9.
Please consider creating a backport or letting me know that this change
isn't meant to be applied to 19.11.x


-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

Re: [dpdk-stable] "app/testpmd: verify DCB config during forward config" is incompatible with the 19.11.x series

[Huisong Li]

在 2021/6/1 19:24, Christian Ehrhardt 写道:
> Hi,
> this commit was targted at the stable series:
>
> commit 43f1f8261136852357057b78aa49d354beaf3931
> Author: Huisong Li <lihuisong@huawei.com>
> Date:   Wed Apr 28 14:40:44 2021 +0800
>
>      app/testpmd: verify DCB config during forward config
The above patch does not need to be applied to 19.11.x, it is ok.
> As part of that it removes pt_id as it was the last user.
> But this does not work out without the following also in place.
>
> commit 08dcd187068666c96e8a16604a1c96160ed310e9
> Author: Huisong Li <lihuisong@huawei.com>
> Date:   Wed Dec 2 20:48:55 2020 +0800
>
>      app/testpmd: fix queue stats mapping configuration
>
> Since the latter is rather massive I have for now dropped 43f1f8261
> from the queue for 19.11.9.
> Please consider creating a backport or letting me know that this change
> isn't meant to be applied to 19.11.x
>
BTW, the first patch does not conflict if the second patch is applied to 
19.11.x first.

Re: [dpdk-stable] "app/testpmd: verify DCB config during forward config" is incompatible with the 19.11.x series

[Christian Ehrhardt]

On Fri, Jun 4, 2021 at 3:52 AM Huisong Li <lihuisong@huawei.com> wrote:
>
>
> 在 2021/6/1 19:24, Christian Ehrhardt 写道:
> > Hi,
> > this commit was targted at the stable series:
> >
> > commit 43f1f8261136852357057b78aa49d354beaf3931
> > Author: Huisong Li <lihuisong@huawei.com>
> > Date:   Wed Apr 28 14:40:44 2021 +0800
> >
> >      app/testpmd: verify DCB config during forward config
> The above patch does not need to be applied to 19.11.x, it is ok.
> > As part of that it removes pt_id as it was the last user.
> > But this does not work out without the following also in place.
> >
> > commit 08dcd187068666c96e8a16604a1c96160ed310e9
> > Author: Huisong Li <lihuisong@huawei.com>
> > Date:   Wed Dec 2 20:48:55 2020 +0800
> >
> >      app/testpmd: fix queue stats mapping configuration
> >
> > Since the latter is rather massive I have for now dropped 43f1f8261
> > from the queue for 19.11.9.
> > Please consider creating a backport or letting me know that this change
> > isn't meant to be applied to 19.11.x
> >
> BTW, the first patch does not conflict if the second patch is applied to
> 19.11.x first.

Hi Huisong Li,
Yes it would apply, but it would not build.
On 19.11 there would still be uses of portid_t  pt_id left and since
in this patch it was removed from start_packet_forwarding it breaks
the build.
Just adding back the variable as a backport without further
investigation if that really would work out well and some testing
seemed too risky.


-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

Re: [dpdk-stable] "app/testpmd: verify DCB config during forward config" is incompatible with the 19.11.x series

[Huisong Li]

在 2021/6/4 13:01, Christian Ehrhardt 写道:
> On Fri, Jun 4, 2021 at 3:52 AM Huisong Li <lihuisong@huawei.com> wrote:
>>
>> 在 2021/6/1 19:24, Christian Ehrhardt 写道:
>>> Hi,
>>> this commit was targted at the stable series:
>>>
>>> commit 43f1f8261136852357057b78aa49d354beaf3931
>>> Author: Huisong Li <lihuisong@huawei.com>
>>> Date:   Wed Apr 28 14:40:44 2021 +0800
>>>
>>>       app/testpmd: verify DCB config during forward config
>> The above patch does not need to be applied to 19.11.x, it is ok.
>>> As part of that it removes pt_id as it was the last user.
>>> But this does not work out without the following also in place.
>>>
>>> commit 08dcd187068666c96e8a16604a1c96160ed310e9
>>> Author: Huisong Li <lihuisong@huawei.com>
>>> Date:   Wed Dec 2 20:48:55 2020 +0800
>>>
>>>       app/testpmd: fix queue stats mapping configuration
>>>
>>> Since the latter is rather massive I have for now dropped 43f1f8261
>>> from the queue for 19.11.9.
>>> Please consider creating a backport or letting me know that this change
>>> isn't meant to be applied to 19.11.x
>>>
>> BTW, the first patch does not conflict if the second patch is applied to
>> 19.11.x first.
> Hi Huisong Li,
> Yes it would apply, but it would not build.
> On 19.11 there would still be uses of portid_t  pt_id left and since
> in this patch it was removed from start_packet_forwarding it breaks
> the build.
> Just adding back the variable as a backport without further
> investigation if that really would work out well and some testing
> seemed too risky.
>
The "portid_t pt_i" is just a local variabl. If it is still be used in

start_packet_forwarding() on19.11, let's just leave it where it is.

I don't think it affects anything.

If that might be a bit risky, we can ignore this patch.