From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5C07A0C4C for ; Wed, 1 Dec 2021 11:26:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6A41A4067B; Wed, 1 Dec 2021 11:26:29 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 9FE5D4067B for ; Wed, 1 Dec 2021 11:26:28 +0100 (CET) Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id A1E9B3F1B3 for ; Wed, 1 Dec 2021 10:26:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638354386; bh=7Z8MzsSihm5/+zYqXd/sqHIovlc/es5Wqtw9hZHlvks=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=hKqmXlATTqNXy7fauZnatZ0edw+FxS9ysn8SWkb7sn8Rg0/gEL7cRGb06FBJ+vsDF e7S9tkcNHmqky0NS3WUm3CdAhrGDZqmupM2GUYoODM3cYtFCTA/pp6FEHy8aWP9LDI tGLwV+FZi4j+9ayC0/21HiXTXXyhmcEdYUjPwSepT88oL4efQ6uIJrmFDi/RkWqeV8 RSlih8ED0ozuW7pnPjZm+YUJQNtxNQOFU1PkrIce0vAs1Wlz3u79c4k0f5rZOFkj6s nAGajyXqyQeZ+Rx0tt3hZ8Lomj1Sc4BP4gWl0b7LeQqlwSlhgtZrpysM+xeqtdi0PL 3UsRohaELNsSw== Received: by mail-qk1-f199.google.com with SMTP id v13-20020a05620a440d00b00468380f4407so32382302qkp.17 for ; Wed, 01 Dec 2021 02:26:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7Z8MzsSihm5/+zYqXd/sqHIovlc/es5Wqtw9hZHlvks=; b=ZxOmEJYBY+cvbsBZzUPAW/VBiiTyXc/Wi8l0s4xs9xKvA2CwVizH52Z1ZSHn8/Aaf+ gtwpdrE8Zc1I/4MUEpGe/ZUU+Lr9C8HUi04FZlPTnO4UIDNM3+KfO6QTjthHkBrAerJV S23gRPN0QDFehhDjLghHsa2ry5QiAU2+zmB7OHeNaA7W4P5pAsqqxO3uTfgbpkFU6kYT Fm1CV6KkVFhm0gFT7xTHAGaHXhBi/A0LYWoVb++yuedU9uiHMhBg4jTPVhdUpigXQDIK dG3G7ZvjAHGd2+epszSrv7ud4IYaKHNxaaVm6fd22IfGdDXJZXKIN00bSl0GlkfZGHKY nu2w== X-Gm-Message-State: AOAM530DAAN3xqCDUKg6DvMIuVyfoz2rvtn6hdAjd+BX+WHqHdtgGHAK Esm385aMdFbyvNStUipDUn200NQTe17mklWmS62/TqLdgfCMJjfP9JNI/Y+0Bq0tWHyi1zI7wzp oE9luiOgX+bPRZGrxXTCowCOG6jf0d8CYyhIMAHCm X-Received: by 2002:ac8:5aca:: with SMTP id d10mr5576068qtd.469.1638354385485; Wed, 01 Dec 2021 02:26:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJyl4855kWXLrj86jBY4ccASD8Xuc363VTx9RlCOvULIYhPFOFv9n/sXh1VE4cUnhtxQNcR4qN8AlCS2WnESqLo= X-Received: by 2002:ac8:5aca:: with SMTP id d10mr5576036qtd.469.1638354385205; Wed, 01 Dec 2021 02:26:25 -0800 (PST) MIME-Version: 1.0 References: <20211130165631.2467343-1-christian.ehrhardt@canonical.com> In-Reply-To: From: Christian Ehrhardt Date: Wed, 1 Dec 2021 11:25:59 +0100 Message-ID: Subject: Re: To: "Wang, Haiyue" Cc: dpdk stable , Yunjian Wang Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org . T On Wed, Dec 1, 2021 at 2:59 AM Wang, Haiyue wrote: > > Hi Christian, > > Applying but breaking the build: > 96b25c496a Haiyue Wang net/ice: fix memzone leak after device init failure > > The build error is caused by calling new function 'rte_eth_dma_zone_free' which is not > defined in 19.11. > > But I think it may be fixed by > 1. Keep the patch for file "drivers/net/ice/ice_ethdev.c" > 2. Drop the patch for file "drivers/net/ice/ice_fdir_filter.c", then apply > (which is not in stable queue): > https://git.dpdk.org/dpdk/commit/?id=d3778bf39a1dd36181b11459ad3936501ca17f4d I'm tried combining 96b25c496a with d3778bf39 as the latter removes the reference to rte_eth_dma_zone_free The result LGTM at first - builds works fine now with both applied. It was filtered out by the tooling as it fixed an issue only present in a later release. Thanks for making me aware of it! > What do you think ? > > BR, > Haiyue > > > -----Original Message----- > > From: christian.ehrhardt@canonical.com > > Sent: Wednesday, December 1, 2021 00:57 > > Cc: Aaron Conole ; Gujjar, Abhinandan S ; Ajit > > Khaparde ; Akhil Goyal ; Alexander Kozyrev > > ; Ali Alnubani ; Zhang, AlvinX ; > > Singh, Aman Deep ; Burakov, Anatoly ; Andrew > > Boyer ; Andrew Rybchenko ; Andy Moreton > > ; Anoob Joseph ; Apeksha Gupta ; > > Kusztal, ArkadiuszX ; Ashish Gupta ; Baruch > > Siach ; Xing, Beilei ; Iremonger, Bernard > > ; Richardson, Bruce ; Chandubabu Namburu > > ; Chas Williams ; Xia, Chenbo ; Chengchang Tang > > ; Chengwen Feng ; Loftus, Ciara > > ; Power, Ciara ; Conor Fogarty > > ; Walsh, Conor ; Dumitrescu, Cristian > > ; Nowlin, Dan ; Yu, DapengX > > ; Dariusz Sosnowski ; David Christensen > > ; Hunt, David ; David Marchand > > ; Doherty, Declan ; Jain, Deepak K > > ; Devendra Singh Rawat ; Dmitry Kozlyuk > > ; Dmitry Kozlyuk ; Dmitry Malloy > > ; Eli Britstein ; Evgeny Schemeilin ; > > Zhang, Roy Fan ; Feifei Wang ; Yigit, Ferruh > > ; Trahe, Fiona ; Gagandeep Singh ; > > Gaoxiang Liu ; Gregory Etelson ; Guoyang Zhou > > ; Wang, Haiyue ; Harman Kalra ; Van > > Haaren, Harry ; Heinrich Kuhn ; Hemant Agrawal > > ; Honnappa Nagarahalli ; Huichao Cai > > ; Huisong Li ; Hyong Youb Kim ; Idan > > Hackmon ; Igor Chauskin ; Igor Romanov > > ; Igor Russkikh ; Igor Ryzhov ; > > Ilyes Ben Hamouda ; Ivan Ilchenko ; Ivan > > Malov ; Jakub Grajciar ; Singh, Jasvinder > > ; Jayatheerthan, Jay ; Jay Zhou > > ; Jerin Jacob ; Jian Wang ; > > Jiawen Wu ; Wang, Jie1X ; Wu, Jingjing > > ; Daley, John ; Griffin, John ; > > Mcnamara, John ; John W. Linville ; Joyce Kong > > > > Subject: > > > > Subject: please help backporting some patches to stable release 19.11.11 > > > > Hi commit authors (and maintainers), > > > > Despite being selected by the DPDK maintenance tool ./devtools/git-log-fixes.sh > > I didn't apply following commits from DPDK main to 19.11 > > stable branch, as conflicts or build errors occur. > > > > Can authors check your patches in the following list and either: > > - Backport your patches to the 19.11 branch, or > > - Indicate that the patch should not be backported > > > > Please do either of the above by December the 14th 2021 (More time than > > usual as backports get harder). > > > > You can find the a temporary work-in-progress branch of the coming 19.11.11 > > release at: > > https://github.com/cpaelzer/dpdk-stable-queue > > It is recommended to backport on top of that to minimize further conflicts or > > misunderstandings. > > > > Some notes on stable backports: > > > > A backport should contain a reference to the DPDK main branch commit > > in it's commit message in the following fashion: > > [ upstream commit ] > > > > For example: > > https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb > > > > When sending the backported patch, please indicate the target branch in the > > subject line, as we have multiple branches, for example: > > [PATCH 19.11] foo/bar: fix baz > > > > With git format-patch, this can be achieved by appending the parameter: > > --subject-prefix='PATCH 19.11' > > > > Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org". > > > > FYI, branch 19.11 is located at tree: > > https://git.dpdk.org/dpdk-stable > > > > Thanks. > > > > Christian Ehrhardt > > > > --- > > > > Applying but breaking the build: > > > > 858a152ab5 Junxiao Shi net/memif: allow stopping and closing device > > c4d3e8fbe4 Ruifeng Wang net/i40e: fix risk in descriptor read in scalar Rx > > 7dc627426e Olivier Matz test/mbuf: fix access to freed memory > > 86e361cdeb David Marchand test/cmdline: fix memory leak > > 04bcc80204 Xuan Ding net/virtio: fix indirect descriptor reconnection > > 9de76dfb92 Ivan Ilchenko net/virtio: fix Tx completed mbuf leak on device stop > > 5d903aee8a Gaoxiang Liu net/virtio: fix repeated freeing of virtqueue > > 9c8c806487 Thomas Monjalon test/crypto: fix minsize build > > 96b25c496a Haiyue Wang net/ice: fix memzone leak after device init failure > > > > --- > > > > Not Applying > > > > ed0ae3502f Ajit Khaparde net/bnxt: update ring group after ring stop start > > 94421842de Alexander Kozyrev net/mlx5: fix GENEVE and VXLAN-GPE flow item matching > > 9e61533df2 Alexander Kozyrev net/mlx5: fix GRE flow item matching > > 02220e5305 Alvin Zhang app/testpmd: fix txonly forwarding > > a78040c990 Alvin Zhang app/testpmd: update forward engine beginning > > c1c99d3421 Alvin Zhang net/ice: fix pointer of meta data > > 4fd15c6af0 Anatoly Burakov vfio: set errno on unsupported OS > > febc855b35 Andrew Rybchenko ethdev: forbid closing started device > > 0015b149bc Anoob Joseph test/crypto: fix missing return checks > > 156eee2177 Arek Kusztal common/qat: fix queue pair config overrun > > 0f2ffb49ce Baruch Siach net/af_xdp: fix zero-copy Tx queue drain > > 897e55c8d2 Bruce Richardson doc: fix Doxygen examples build on FreeBSD > > 2fc3e696a7 Chengchang Tang net/hns3: add runtime config for mailbox limit time > > 3fb0df3138 Chengchang Tang net/hns3: fix taskqueue pair reset command > > 0b77e8f3d3 Chengwen Feng net/hns3: optimize Tx performance > > 3cc817c195 Chengwen Feng net/hns3: optimize Tx performance by mbuf fast free > > c0daf3bd4b Ciara Power test/crypto: remove unnecessary stats retrieval > > 9465a5d5a0 Conor Walsh net/nfp: remove unused message length > > ccf0f002d2 Dapeng Yu net/bonding: fix memory leak on closing device > > 7775172c04 Dariusz Sosnowski net/mlx5: fix partial inline of fine grain packets > > fe629897de David Marchand app/testpmd: remove double dependency on bitrate lib > > b72099be7f David Marchand net/virtio-user: fix init when using existing tap > > 4a985f4e84 David Marchand test/service: fix race in attr check > > 9790fc2149 Dmitry Kozlyuk eal/freebsd: fix IOVA mode selection > > bc5bee028e Dmitry Kozlyuk net/mlx5: create drop queue using DevX > > c5042f93a4 Dmitry Kozlyuk net/mlx5: discover max flow priority using DevX > > 6a8b64fd5e Eli Britstein app/testpmd: fix packet burst spreading stats > > 5139502783 Ferruh Yigit ethdev: fix typos > > a1b2558cdb Ferruh Yigit kni: restrict bifurcated device support > > 451dc0fad8 Gaoxiang Liu vhost: fix crash on port deletion > > 9f151fd8df Gregory Etelson net/mlx5: add Ethernet header to GENEVE RSS expansion > > 690391dd0e Gregory Etelson net/mlx5: fix GENEVE protocol type translation > > be26e81bfc Gregory Etelson net/mlx5: fix GRE protocol type translation > > 861fa3796f Gregory Etelson net/mlx5: fix VXLAN-GPE next protocol translation > > 567473433b Huichao Cai ip_frag: fix fragmenting IPv4 fragment > > 013bb504c8 Huichao Cai ip_frag: revert fix fragmenting IPv4 fragment > > 841f869353 Huisong Li net/hns3: fix multi-process action register and unregister > > 19e67d8ebc Huisong Li net/hns3: fix residual MAC after setting default MAC > > 3232637177 Huisong Li net/hns3: fix secondary process reference count > > 443242212b Huisong Li net/hns3: unregister MP action on close for secondary > > 770d41bf33 Ilyes Ben Hamouda malloc: fix allocation with unknown socket ID > > 580f3af31c Ivan Ilchenko net/virtio: fix device configure without jumbo Rx offload > > c97e73779c Ivan Ilchenko net/virtio: fix split queue vectorized Rx > > e2ca43a35e Ivan Ilchenko net/virtio: fix Tx cleanup functions to have same signature > > 6474b59448 Ivan Malov net/virtio: fix Tx checksum for tunnel packets > > cbe70fded8 Jie Wang app/testpmd: fix DCB in VT configuration > > 655eae01f9 Jie Wang app/testpmd: fix RSS hash offload display > > 8cc79a1636 Jie Wang net/i40e: fix forward outer IPv6 VXLAN > > d5559ac589 Joyce Kong test/func_reentrancy: free memzones after test > > baedf29794 Kalesh AP net/bnxt: check FW capability for VLAN offloads > > 620e0290d1 Kalesh AP net/bnxt: fix VLAN indication in Rx mbuf > > 6c16a05c8c Kefu Chai doc: fix a typo in EAL guide > > 0c3fa68396 Lior Margalit net/mlx5: fix RSS expansion for L2/L3 VXLAN > > aa52e5f0f9 Lior Margalit net/mlx5: fix RSS expansion traversal over next nodes > > 76b5bdf828 Matan Azrad common/mlx5: create wrapped MR > > 8594e2a64f Matan Azrad common/mlx5: fix build for zero-length headroom array > > b6e9c33c82 Michael Baum net/mlx5: remove duplicated reference of Tx doorbell > > 8451e165b8 Michael Baum net/mlx5: workaround MR creation for flow counter > > e2a6d08bef Michal Krawczyk net/ena: advertise scattered Rx capability > > e8c838fde9 Michal Krawczyk net/ena: fix offload capabilities verification > > 3a822d79c5 Michal Krawczyk net/ena: fix per-queue offload capabilities > > 599ef84add Min Hu (Connor) net/hns3: fix mailbox communication with HW > > 818ce1132a Mohsin Kazmi net: fix checksum offload for outer IPv4 > > efc6f9104c Olivier Matz mbuf: fix reset on mbuf free > > de5bef335e Qiming Chen net/iavf: fix high CPU usage on frequent command > > 3affa0ef2d Qi Zhang net/ice/base: calculate logical PF ID > > 778602fe57 Ruifeng Wang net/i40e: fix risk in descriptor read in NEON Rx > > 35bd0a5c58 Sean Morrissey doc: capitalise PMD > > f8dbaebbf1 Sean Morrissey fix PMD wording > > a7e21843f0 Somnath Kotur net/bnxt: fix Rx next consumer index in mbuf alloc fail > > accf3cfce4 Tal Shnaiderman net/mlx5: fix software parsing support query > > c1a320bf89 Tal Shnaiderman net/mlx5: fix tunneling support query > > f86d553cc1 Tudor Cornea net/af_packet: fix ignoring full ring on Tx > > 2108930be1 Tudor Cornea net/ixgbe: fix port initialization if MTU config fails > > e30ef3a3a0 Vladimir Medvedkin test/hash: fix buffer overflow with jhash > > ad6f01945a Xuan Ding net/virtio: fix avail descriptor ID > > 68fa62924d Xueming Li net/mlx5: fix Altivec Rx > > 84cc857b5d Zhihong Peng net/virtio: fix check scatter on all Rx queues -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd