[dpdk-stable] Fwd: [dpdk-dev] [PATCH 1/2] examples/tep_term: Fix l4_len issue

[dpdk-stable] Fwd: [dpdk-dev] [PATCH 1/2] examples/tep_term: Fix l4_len issue

[Christian Ehrhardt]

CC Stable

---------- Forwarded message ----------
From: Michael Qiu <qdy220091330@gmail.com>
Date: Tue, Oct 18, 2016 at 7:49 AM
Subject: [dpdk-dev] [PATCH 1/2] examples/tep_term: Fix l4_len issue
To: dev@dpdk.org
Cc: jianfeng.tan@intel.com, Michael Qiu <qiudayu@chinac.com>


l4_len is not fixed, althrough mostly it is a fixed value,
but when guest using iperf to do some tests, the l4_len
will have another 12 bytes optional fields.

Fixes: 2bb43bd4350a("examples/tep_term: add TSO offload configuration")

Signed-off-by: Michael Qiu <qiudayu@chinac.com>
---
 examples/tep_termination/vxlan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/tep_termination/vxlan.c b/examples/tep_termination/
vxlan.c
index 5ee1f95..b57f867 100644
--- a/examples/tep_termination/vxlan.c
+++ b/examples/tep_termination/vxlan.c
@@ -147,7 +147,7 @@ process_inner_cksums(struct ether_hdr *eth_hdr, union
tunnel_offload_info *info)
                if (tso_segsz != 0) {
                        ol_flags |= PKT_TX_TCP_SEG;
                        info->tso_segsz = tso_segsz;
-                       info->l4_len = sizeof(struct tcp_hdr);
+                       info->l4_len = (tcp_hdr->data_off & 0xf0) >> 2;
                }

        } else if (l4_proto == IPPROTO_SCTP) {
--
1.8.3.1




-- 
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd

[dpdk-stable] Fwd: [dpdk-dev] [PATCH 2/2] examples/tep_term: Fix packet len for multi-seg mbuf

[Christian Ehrhardt]

CC Stable

---------- Forwarded message ----------
From: Michael Qiu <qdy220091330@gmail.com>
Date: Tue, Oct 18, 2016 at 7:49 AM
Subject: [dpdk-dev] [PATCH 2/2] examples/tep_term: Fix packet len for
multi-seg mbuf
To: dev@dpdk.org
Cc: jianfeng.tan@intel.com, Michael Qiu <qiudayu@chinac.com>


For multi-seg mbuf, ip->total_length should be pkt_len subtract
ether len.

Fixes: 4abe471ed6fc("examples/tep_term: implement VXLAN processing")

Signed-off-by: Michael Qiu <qiudayu@chinac.com>
---
 examples/tep_termination/vxlan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/tep_termination/vxlan.c b/examples/tep_termination/
vxlan.c
index b57f867..9142c8d 100644
--- a/examples/tep_termination/vxlan.c
+++ b/examples/tep_termination/vxlan.c
@@ -218,7 +218,7 @@ encapsulation(struct rte_mbuf *m, uint8_t queue_id)
        /* copy in IP header */
        ip = rte_memcpy(ip, &app_ip_hdr[vport_id],
                sizeof(struct ipv4_hdr));
-       ip->total_length = rte_cpu_to_be_16(m->data_len
+       ip->total_length = rte_cpu_to_be_16(m->pkt_len
                                - sizeof(struct ether_hdr));

        /* outer IP checksum */
--
1.8.3.1




-- 
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd