Re: [PATCH 20.11 1/2] Revert "regexdev: fix section attribute of symbols"

[Christian Ehrhardt <christian.ehrhardt@canonical.com>]

On Tue, Mar 29, 2022 at 2:10 PM <luca.boccassi@gmail.com> wrote:
>
> From: Luca Boccassi <bluca@debian.org>
>
> Causes symbols changes, so it's not appropriate for 20.11.
>
> This reverts commit 64452c878f225c147dfb7156e605f5b55da9f7c0.

Yeah this is what i suggested.
I already test with that, working.

+1
Reviewed-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
>  devtools/libabigail.abignore              | 4 ----
>  lib/librte_regexdev/rte_regexdev.h        | 4 ----
>  lib/librte_regexdev/rte_regexdev_driver.h | 3 ---
>  lib/librte_regexdev/version.map           | 9 ---------
>  4 files changed, 20 deletions(-)
>
> diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
> index 1414cdfba9..025f2c01bc 100644
> --- a/devtools/libabigail.abignore
> +++ b/devtools/libabigail.abignore
> @@ -7,7 +7,3 @@
>          symbol_version = INTERNAL
>  [suppress_variable]
>          symbol_version = INTERNAL
> -
> -; Ignore section attribute fixes in experimental regexdev library
> -[suppress_file]
> -        soname_regexp = ^librte_regexdev\.
> diff --git a/lib/librte_regexdev/rte_regexdev.h b/lib/librte_regexdev/rte_regexdev.h
> index 09d1718da9..df2312678c 100644
> --- a/lib/librte_regexdev/rte_regexdev.h
> +++ b/lib/librte_regexdev/rte_regexdev.h
> @@ -228,9 +228,6 @@ extern int rte_regexdev_logtype;
>  } while (0)
>
>  /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice.
> - *
>   * Check if dev_id is ready.
>   *
>   * @param dev_id
> @@ -240,7 +237,6 @@ extern int rte_regexdev_logtype;
>   *   - 0 if device state is not in ready state.
>   *   - 1 if device state is ready state.
>   */
> -__rte_experimental
>  int rte_regexdev_is_valid_dev(uint16_t dev_id);
>
>  /**
> diff --git a/lib/librte_regexdev/rte_regexdev_driver.h b/lib/librte_regexdev/rte_regexdev_driver.h
> index 6246b144a6..64742016c0 100644
> --- a/lib/librte_regexdev/rte_regexdev_driver.h
> +++ b/lib/librte_regexdev/rte_regexdev_driver.h
> @@ -32,7 +32,6 @@ extern "C" {
>   *   A pointer to the RegEx device slot case of success,
>   *   NULL otherwise.
>   */
> -__rte_internal
>  struct rte_regexdev *rte_regexdev_register(const char *name);
>
>  /**
> @@ -42,7 +41,6 @@ struct rte_regexdev *rte_regexdev_register(const char *name);
>   * @param dev
>   *   Device to be released.
>   */
> -__rte_internal
>  void rte_regexdev_unregister(struct rte_regexdev *dev);
>
>  /**
> @@ -52,7 +50,6 @@ void rte_regexdev_unregister(struct rte_regexdev *dev);
>   * @param name
>   *   The device name.
>   */
> -__rte_internal
>  struct rte_regexdev *rte_regexdev_get_device_by_name(const char *name);
>
>  #ifdef __cplusplus
> diff --git a/lib/librte_regexdev/version.map b/lib/librte_regexdev/version.map
> index 988b909638..8db9b17018 100644
> --- a/lib/librte_regexdev/version.map
> +++ b/lib/librte_regexdev/version.map
> @@ -1,7 +1,6 @@
>  EXPERIMENTAL {
>         global:
>
> -       rte_regex_devices;
>         rte_regexdev_attr_get;
>         rte_regexdev_attr_set;
>         rte_regexdev_close;
> @@ -12,8 +11,6 @@ EXPERIMENTAL {
>         rte_regexdev_enqueue_burst;
>         rte_regexdev_get_dev_id;
>         rte_regexdev_info_get;
> -       rte_regexdev_is_valid_dev;
> -       rte_regexdev_logtype;
>         rte_regexdev_queue_pair_setup;
>         rte_regexdev_rule_db_compile_activate;
>         rte_regexdev_rule_db_export;
> @@ -27,9 +24,3 @@ EXPERIMENTAL {
>         rte_regexdev_xstats_names_get;
>         rte_regexdev_xstats_reset;
>  };
> -
> -INTERNAL {
> -       rte_regexdev_get_device_by_name;
> -       rte_regexdev_register;
> -       rte_regexdev_unregister;
> -};
> --
> 2.34.1
>


-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd