From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D133A0506 for ; Tue, 29 Mar 2022 16:07:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5616440141; Tue, 29 Mar 2022 16:07:51 +0200 (CEST) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 5B93640141 for ; Tue, 29 Mar 2022 16:07:49 +0200 (CEST) Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 027973F174 for ; Tue, 29 Mar 2022 14:07:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1648562868; bh=PvbRgKoM8qOeni+4QqNqU2RkRxNZFXXUYhBWFfQ7sSU=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Aj733g608Y5wE5jQ2pTtGnMq7owJ74eAhgjSE7DXnGk7vUxc0QN8ERocv4jVsgxEI PBYYozBpL0tCuch8mPVIWAymm3nPIophFfIj9TwKK4X2Xo1A/s7tYerE2EXxISPBTX uoYqDfChY8/lAeLKwtwn8xioO+CW3rAqXE1OesYxtJDUQuKCqQMdje4yQT1tzLKBcV xrJuALhnnISmKkLhQDvlKCAKBfg0I12e1khQzcAZzw8Ihs00rgXOpTsd1vxVwFkLtI fEpX6Tiot/DpIAXQyYoTti4G/NcsvoF2oAwsLB+E8cZHPX7bKS0kYdSpmR1DJx3/hU WknYN3E6j2bSw== Received: by mail-qv1-f71.google.com with SMTP id t16-20020ad44850000000b00440e0f2a561so13802691qvy.11 for ; Tue, 29 Mar 2022 07:07:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PvbRgKoM8qOeni+4QqNqU2RkRxNZFXXUYhBWFfQ7sSU=; b=H/BoBFwsqT9vEdvMi7Oiu1BP4fRbaBcilwTv/AmnoRHFg1EpjQ/yE++gWZ1g1osH6X a6IPFUv+OuNQi1zJO/4zsG5fgRK9ZRCmGIBC56xYiZ/EiW//1fyJO/JRDEQpc0pVTmaY J7/WDekPfqVZRDwXKZqNGzH/7mC8b1CjAgUvxDxIm++BknTUTjLp0yBlaG+l/NiR7ZpP RIfyru8Mh6Vg9BTOd1hALiD3I+DXOm+q6yFwj/ksaQa9V4dbkpnXqKZZvfl/gDSI/Li1 kWpQx0RoEVQFvWk0/S59o3fu6EU4+/x0TWoZ3KgG4ASZeXR5PynE5S/T/XYIAIN2K343 MviA== X-Gm-Message-State: AOAM531Al8YSqzE3mmj2xpJG+BvPqMlQcwo+NDWOXf2WVGekePwBBbil AjLfUhULZthCuZ/F+iafi2LND2eHMxmcBUAHt+zlIY/eTMaI3bo0ssfHCzGtaJ2dePqE6LPqdFR 5EQD0/yPnXESepfL6Q/uDTjWifc8PV+Hry0oxVeVa X-Received: by 2002:a05:622a:492:b0:2e1:ee8a:b1c0 with SMTP id p18-20020a05622a049200b002e1ee8ab1c0mr27602928qtx.162.1648562866731; Tue, 29 Mar 2022 07:07:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9tTxDvMcNv3UBIErWwlBPes+7W8GO24fQk4NnhbQ6LWkJrGHQ4sSR0qrpqYlPd9qSDbKPIKm0kcZtEa9FKs8= X-Received: by 2002:a05:622a:492:b0:2e1:ee8a:b1c0 with SMTP id p18-20020a05622a049200b002e1ee8ab1c0mr27602865qtx.162.1648562866150; Tue, 29 Mar 2022 07:07:46 -0700 (PDT) MIME-Version: 1.0 References: <20220329120953.152396-1-luca.boccassi@gmail.com> In-Reply-To: <20220329120953.152396-1-luca.boccassi@gmail.com> From: Christian Ehrhardt Date: Tue, 29 Mar 2022 16:07:20 +0200 Message-ID: Subject: Re: [PATCH 20.11 1/2] Revert "regexdev: fix section attribute of symbols" To: luca.boccassi@gmail.com Cc: stable@dpdk.org, ktraynor@redhat.com, Luca Boccassi Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, Mar 29, 2022 at 2:10 PM wrote: > > From: Luca Boccassi > > Causes symbols changes, so it's not appropriate for 20.11. > > This reverts commit 64452c878f225c147dfb7156e605f5b55da9f7c0. Yeah this is what i suggested. I already test with that, working. +1 Reviewed-by: Christian Ehrhardt > Signed-off-by: Luca Boccassi > --- > devtools/libabigail.abignore | 4 ---- > lib/librte_regexdev/rte_regexdev.h | 4 ---- > lib/librte_regexdev/rte_regexdev_driver.h | 3 --- > lib/librte_regexdev/version.map | 9 --------- > 4 files changed, 20 deletions(-) > > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore > index 1414cdfba9..025f2c01bc 100644 > --- a/devtools/libabigail.abignore > +++ b/devtools/libabigail.abignore > @@ -7,7 +7,3 @@ > symbol_version = INTERNAL > [suppress_variable] > symbol_version = INTERNAL > - > -; Ignore section attribute fixes in experimental regexdev library > -[suppress_file] > - soname_regexp = ^librte_regexdev\. > diff --git a/lib/librte_regexdev/rte_regexdev.h b/lib/librte_regexdev/rte_regexdev.h > index 09d1718da9..df2312678c 100644 > --- a/lib/librte_regexdev/rte_regexdev.h > +++ b/lib/librte_regexdev/rte_regexdev.h > @@ -228,9 +228,6 @@ extern int rte_regexdev_logtype; > } while (0) > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice. > - * > * Check if dev_id is ready. > * > * @param dev_id > @@ -240,7 +237,6 @@ extern int rte_regexdev_logtype; > * - 0 if device state is not in ready state. > * - 1 if device state is ready state. > */ > -__rte_experimental > int rte_regexdev_is_valid_dev(uint16_t dev_id); > > /** > diff --git a/lib/librte_regexdev/rte_regexdev_driver.h b/lib/librte_regexdev/rte_regexdev_driver.h > index 6246b144a6..64742016c0 100644 > --- a/lib/librte_regexdev/rte_regexdev_driver.h > +++ b/lib/librte_regexdev/rte_regexdev_driver.h > @@ -32,7 +32,6 @@ extern "C" { > * A pointer to the RegEx device slot case of success, > * NULL otherwise. > */ > -__rte_internal > struct rte_regexdev *rte_regexdev_register(const char *name); > > /** > @@ -42,7 +41,6 @@ struct rte_regexdev *rte_regexdev_register(const char *name); > * @param dev > * Device to be released. > */ > -__rte_internal > void rte_regexdev_unregister(struct rte_regexdev *dev); > > /** > @@ -52,7 +50,6 @@ void rte_regexdev_unregister(struct rte_regexdev *dev); > * @param name > * The device name. > */ > -__rte_internal > struct rte_regexdev *rte_regexdev_get_device_by_name(const char *name); > > #ifdef __cplusplus > diff --git a/lib/librte_regexdev/version.map b/lib/librte_regexdev/version.map > index 988b909638..8db9b17018 100644 > --- a/lib/librte_regexdev/version.map > +++ b/lib/librte_regexdev/version.map > @@ -1,7 +1,6 @@ > EXPERIMENTAL { > global: > > - rte_regex_devices; > rte_regexdev_attr_get; > rte_regexdev_attr_set; > rte_regexdev_close; > @@ -12,8 +11,6 @@ EXPERIMENTAL { > rte_regexdev_enqueue_burst; > rte_regexdev_get_dev_id; > rte_regexdev_info_get; > - rte_regexdev_is_valid_dev; > - rte_regexdev_logtype; > rte_regexdev_queue_pair_setup; > rte_regexdev_rule_db_compile_activate; > rte_regexdev_rule_db_export; > @@ -27,9 +24,3 @@ EXPERIMENTAL { > rte_regexdev_xstats_names_get; > rte_regexdev_xstats_reset; > }; > - > -INTERNAL { > - rte_regexdev_get_device_by_name; > - rte_regexdev_register; > - rte_regexdev_unregister; > -}; > -- > 2.34.1 > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd