From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA271A00C2 for ; Mon, 28 Mar 2022 16:30:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C781A41104; Mon, 28 Mar 2022 16:30:26 +0200 (CEST) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id C637141104 for ; Mon, 28 Mar 2022 16:30:25 +0200 (CEST) Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 5D9793F17C for ; Mon, 28 Mar 2022 14:30:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1648477825; bh=oGKOvS/Uba3jWXq2NF2Snsc2IEvLl/ZIyAlWsoDjcro=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=eHc0ppfsrEehrOJHTJvTRhu8K1nf6+jEZB7ZeO9S+Ohurg91yG8R7MZP9CveTl0CI sqeJKmhQqthNBwGUq20whwsUvPohm5r+BtYY22PEkMQyVcbCFU8rHYpfEDEqCYxcie kqYwI/k+00aMTb+rHujk1TxlZ+/Rv2zTEuFX++BcmdFbd2/wr8He38U22wZ97+I9Za pm6XyUVmi0yparqqnp7iwiisY2BYU6Iu740LUAnTdBHoNzwQZZPs6eXSLu6ENd7QHc m6kqQFC5E6+srVTJoyJuuFnyHIF8sm6u2yYr2IvY8mh2wrn8DcwHmLDkbhUKwCbA3f s9yT40ehBPH2A== Received: by mail-qv1-f69.google.com with SMTP id x16-20020a0ce250000000b00432ec6eaf85so11444639qvl.15 for ; Mon, 28 Mar 2022 07:30:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oGKOvS/Uba3jWXq2NF2Snsc2IEvLl/ZIyAlWsoDjcro=; b=Md4wkop2BA+r22OHE9NiM5v3uXw+CAb0S2EdD6+D0TYKLHV9ONQOO3M55nO1t9cfdw nJ1jSNa+kUcghLI/mQZ1k5PX1m3ztn2eOngskFIUkt19RDJmYQgR0Dh70YcQ3gwOcQQO vr4/noJqLP8XIQCtHylC4HfgdKIBKMqGOsl0o8wxTGgGtBKBzJm7jHhh/GAs79Y11pze aZRpdJAzdUUWLKYknsQmNsAnnWVyGi5FfqaFOm6Bi936yllVY0jSxV3trywcz/+gHYDX fy7ha9EU76RnMr/S3KPmX6wSJAytLCmVwa2vxT5FThJHAU6rTdb6fnqNuCaPbCzLhbEo t5Sg== X-Gm-Message-State: AOAM531HbfNZQz8tRcRpxTKlf7YBsmO62P7TBmTd5g7MQUJy4hPwNyo+ kT2vIMgv4/6NWOLNsnUyhMOkcBBg0XwnTbtxs0lW37vpGzGbtoylsfrRPgTTzs8UyZ09chC963l HABj+SX5aFPSn7fU5XtPeFqpi/HGFB3oQq2LdzLHT X-Received: by 2002:a05:6214:21a6:b0:443:35df:b7be with SMTP id t6-20020a05621421a600b0044335dfb7bemr12065341qvc.46.1648477823970; Mon, 28 Mar 2022 07:30:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxPn7j0uljnSX8+3vODnqHZ+1Jwo03058DoGojFFvNOPmQlEva4CtgF5oWA/pAUYyLFG0IkXYp6pRMRd3VL5RU= X-Received: by 2002:a05:6214:21a6:b0:443:35df:b7be with SMTP id t6-20020a05621421a600b0044335dfb7bemr12065313qvc.46.1648477823678; Mon, 28 Mar 2022 07:30:23 -0700 (PDT) MIME-Version: 1.0 References: <20220325081606.3228-1-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: From: Christian Ehrhardt Date: Mon, 28 Mar 2022 16:29:57 +0200 Message-ID: Subject: Re: [PATCH 19.11] net/bnxt: fix a typo introduced in backport To: Ajit Khaparde Cc: Kalesh A P , dpdk stable Content-Type: multipart/alternative; boundary="00000000000019d11c05db4827f1" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org --00000000000019d11c05db4827f1 Content-Type: text/plain; charset="UTF-8" On Mon, Mar 28, 2022 at 3:46 PM Ajit Khaparde wrote: > On Sun, Mar 27, 2022 at 11:29 PM Christian Ehrhardt > wrote: > > > > On Fri, Mar 25, 2022 at 9:15 AM Kalesh A P > > wrote: > > > > > > From: Kalesh AP > > > > > > This patch fixes a typo introduced in the last backport. > > > Fixed a wrong check. > > > > Hi Kalesh, > > thanks for the fix. > > > > Since we already have entered -rc1 and testing I wanted to ask how > > sever this issue is. > > The options we have are > > a) not really an important issue, hold it back not and make it part of > > 19.11.13 later this year > > b) breaking bnxt too much, needs to get into 19.11.12 - but we would > > not reset testing (no new RC), you'd cover some bnxt related tests > > c) breaking bnxt too much and having potential to influence all > > things, taking into 19.11.12 and casting an -rc2 resetting tests for > > everyone > > > > I'm tempted to consider this a case for (b), but wanted to know if you > > agree and if you could make the related bnxt based re-test happen? > Christian, option (b) is fine. We can take care of bnxt related tests. > Thank you, applied without tagging -rc2 as agreed. For your testing it is here https://git.dpdk.org/dpdk-stable/log/?h=19.11 > Thanks > Ajit > > > > > Upstream code does not have this issue. > > > > > > Bugzilla ID: 977 > > > Fixes: 942eb8e842fc ("net/bnxt: fix xstats names query overrun") > > > > > > Signed-off-by: Kalesh AP > > > --- > > > drivers/net/bnxt/bnxt_stats.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/bnxt/bnxt_stats.c > b/drivers/net/bnxt/bnxt_stats.c > > > index 39fd100..bc181db 100644 > > > --- a/drivers/net/bnxt/bnxt_stats.c > > > +++ b/drivers/net/bnxt/bnxt_stats.c > > > @@ -612,7 +612,7 @@ int bnxt_dev_xstats_get_names_op(__rte_unused > struct rte_eth_dev *eth_dev, > > > if (rc) > > > return rc; > > > > > > - if (xstats_names != NULL || size < stat_cnt) > > > + if (xstats_names == NULL || size < stat_cnt) > > > return stat_cnt; > > > > > > for (i = 0; i < RTE_DIM(bnxt_rx_stats_strings); i++) { > > > -- > > > 2.10.1 > > > > > > > > > -- > > Christian Ehrhardt > > Staff Engineer, Ubuntu Server > > Canonical Ltd > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd --00000000000019d11c05db4827f1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Mon, Mar 28, 2022 at 3:46 PM Ajit = Khaparde <ajit.khaparde@br= oadcom.com> wrote:
On Sun, Mar 27, 2022 at 11:29 PM Christian Ehrhardt
<c= hristian.ehrhardt@canonical.com> wrote:
>
> On Fri, Mar 25, 2022 at 9:15 AM Kalesh A P
> <kalesh-anakkur.purayil@broadcom.com> wrote:
> >
> > From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> >
> > This patch fixes a typo introduced in the last backport.
> > Fixed a wrong check.
>
> Hi Kalesh,
> thanks for the fix.
>
> Since we already have entered -rc1 and testing I wanted to ask how
> sever this issue is.
> The options we have are
> a) not really an important issue, hold it back not and make it part of=
> 19.11.13 later this year
> b) breaking bnxt too much, needs to get into 19.11.12 - but we would > not reset testing (no new RC), you'd cover some bnxt related tests=
> c) breaking bnxt too much and having potential to influence all
> things, taking into 19.11.12 and casting an -rc2 resetting tests for > everyone
>
> I'm tempted to consider this a case for (b), but wanted to know if= you
> agree and if you could make the related bnxt based re-test happen?
Christian, option (b) is fine. We can take care of bnxt related tests.
<= /blockquote>

Thank you, applied without tagging -rc2 as = agreed.

For your testing it is here
=C2=A0
Thanks
Ajit
>
> > Upstream code does not have this issue.
> >
> > Bugzilla ID: 977
> > Fixes: 942eb8e842fc ("net/bnxt: fix xstats names query overr= un")
> >
> > Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> > ---
> >=C2=A0 drivers/net/bnxt/bnxt_stats.c | 2 +-
> >=C2=A0 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnx= t_stats.c
> > index 39fd100..bc181db 100644
> > --- a/drivers/net/bnxt/bnxt_stats.c
> > +++ b/drivers/net/bnxt/bnxt_stats.c
> > @@ -612,7 +612,7 @@ int bnxt_dev_xstats_get_names_op(__rte_unused= struct rte_eth_dev *eth_dev,
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (rc)
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0retu= rn rc;
> >
> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0if (xstats_names !=3D NULL || size &l= t; stat_cnt)
> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0if (xstats_names =3D=3D NULL || size = < stat_cnt)
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0retu= rn stat_cnt;
> >
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0for (i =3D 0; i < RTE_DIM(bnx= t_rx_stats_strings); i++) {
> > --
> > 2.10.1
> >
>
>
> --
> Christian Ehrhardt
> Staff Engineer, Ubuntu Server
> Canonical Ltd


--
Christian Ehrhardt
Staff Engineer, Ubuntu Ser= ver
Canonical Ltd
--00000000000019d11c05db4827f1--