From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: stable@dpdk.org
Subject: Re: [PATCH 19.11] eal/freebsd: fix incorrect variable name
Date: Fri, 17 Dec 2021 18:52:58 +0100 [thread overview]
Message-ID: <CAATJJ0LsG0dooHOortOP=r=-O2nPi6-dhagzwP9kzo=fbax5tA@mail.gmail.com> (raw)
In-Reply-To: <20211217153640.728005-1-bruce.richardson@intel.com>
On Fri, Dec 17, 2021 at 4:36 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> When the below commit was backported, the variable name was not corrected from
> "internal_conf" to "internal_config", leading to build errors.
>
Thanks, applied
> Fixes: 1f3a6bf92333 ("eal/freebsd: ignore in-memory option")
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> lib/librte_eal/freebsd/eal/eal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_eal/freebsd/eal/eal.c b/lib/librte_eal/freebsd/eal/eal.c
> index e148d431c1..554323a39b 100644
> --- a/lib/librte_eal/freebsd/eal/eal.c
> +++ b/lib/librte_eal/freebsd/eal/eal.c
> @@ -743,9 +743,9 @@ rte_eal_init(int argc, char **argv)
>
> /* FreeBSD always uses legacy memory model */
> internal_config.legacy_mem = true;
> - if (internal_conf.in_memory) {
> + if (internal_config.in_memory) {
> RTE_LOG(WARNING, EAL, "Warning: ignoring unsupported flag, '%s'\n", OPT_IN_MEMORY);
> - internal_conf.in_memory = false;
> + internal_config.in_memory = false;
> }
>
> if (eal_plugins_init() < 0) {
> --
> 2.34.1
>
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
prev parent reply other threads:[~2021-12-17 17:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 15:36 Bruce Richardson
2021-12-17 17:52 ` Christian Ehrhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAATJJ0LsG0dooHOortOP=r=-O2nPi6-dhagzwP9kzo=fbax5tA@mail.gmail.com' \
--to=christian.ehrhardt@canonical.com \
--cc=bruce.richardson@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).