From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0126A2EF3 for ; Sun, 15 Sep 2019 14:05:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9BF801BEB5; Sun, 15 Sep 2019 14:05:02 +0200 (CEST) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id BEA2C1BEB5 for ; Sun, 15 Sep 2019 14:05:01 +0200 (CEST) Received: by mail-io1-f65.google.com with SMTP id k5so47215877iol.5 for ; Sun, 15 Sep 2019 05:05:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netcope.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qX0Z1RjXG0N41BmjPqCNztkXsfWg7U17V0hdxSPLtSE=; b=lXjATGtKaWmIfmlgaByne8MfmKkV60l4cbGhvfoi38/foUN5hrsWTLcYTYXpoOFIRV 0htd79YSPic3eFTL97KwiuOMzDStEvYaZAPHmehWZuz+XleIthy72f5sMpkbeCtD9lML VfnvWRCNlvJeKT90mWKO7DahX+ce6gVcAXOEMMo9yNdjms8nQiZfsfhRaHy8tqxh8fNK /96dL4BNVpLPGZ70pow311LioikPfeHSfxHeMqhg+0E+SLuyPNN8bud8EohFC4KH3Rqu 5EIpbrJO0l49OdyE0QNFl4oQNhuZdbvSzNiLa/z6TJpdqpuwbdXQqmoaqNtEb4XNHY9H Zt3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qX0Z1RjXG0N41BmjPqCNztkXsfWg7U17V0hdxSPLtSE=; b=Hy5AagdQcR+9CE8N+nXVdRpFoEFSfltUiu7r2sRnGxQO6akT7DvFAO9xLMTi3d7rt/ s8aEz4etFiu0oCOnH9hfzPd8JVFMrC53N7vBjkgqBZobPl9BlmOnHsSVJ6Djlz4AohWA JHU9H2FhpCp5ivLhp4zAGDFhZDmPDr182HaVMO0yCdAQeVVmDkmp7K8qc/WEZdt8N1lH EwJUU7ly3njJOIkbU6YYkt11IbHaT5Ntx9d9HvQaiDyeCrRihKvSMtB9Aex9ENMD4aB3 Hz+G1ZgU3/961XEAa+7Xd2VL9Bo+SXYZYd+/5l8KAX23lNMwetdynCSNmw2eXxDt06t6 UPwA== X-Gm-Message-State: APjAAAXiLhfLQQ3gSfBQpO/S9SeDi9xOmZYKh0DIT9gZkMLq2DAeoyeo 0MhWdADc+0OptWT0oyW5ByTwh+H0NWd47/+aXA4sow== X-Google-Smtp-Source: APXvYqz6Wssh5QMByYqSiml4egEXnxawBeyG353extpZecrMgJn84KtHItJDHCVv3Xa23mrJwxYbNIXwzbEwSaWjINE= X-Received: by 2002:a6b:6d07:: with SMTP id a7mr1031894iod.261.1568549100932; Sun, 15 Sep 2019 05:05:00 -0700 (PDT) MIME-Version: 1.0 References: <20190914093700.11451-1-thomas@monjalon.net> <20190914093700.11451-2-thomas@monjalon.net> In-Reply-To: <20190914093700.11451-2-thomas@monjalon.net> From: =?UTF-8?Q?Jan_Reme=C5=A1?= Date: Sun, 15 Sep 2019 14:04:49 +0200 Message-ID: To: Thomas Monjalon Cc: bruce.richardson@intel.com, Rastislav Cernay , dev@dpdk.org, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH 1/2] net/nfb: fix dependency check X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Sat, Sep 14, 2019 at 11:37 AM Thomas Monjalon wrote: > > The library libnfb is part of netcope-common which provides > a pkg-config file: netcope-common.pc. > Looking for this .pc file - with dependency() - is preferred > than looking for the library - with cc.find_library(). > > If the library is not installed in a standard path, > it can be found thanks to PKG_CONFIG_PATH variable. > The previous solution required to use CFLAGS and LDFLAGS > environment variables. > > Fixes: 6435f9a0ac22 ("net/nfb: add new netcope driver") > Cc: stable@dpdk.org > > Signed-off-by: Thomas Monjalon Acked-by: Jan Remes > --- > drivers/net/nfb/meson.build | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/nfb/meson.build b/drivers/net/nfb/meson.build > index 4502c3f76..d53e8eca7 100644 > --- a/drivers/net/nfb/meson.build > +++ b/drivers/net/nfb/meson.build > @@ -3,14 +3,9 @@ > # Copyright(c) 2019 Netcope Technologies, a.s. > # All rights reserved. > > -dep = cc.find_library('nfb', required: false) > +dep = dependency('netcope-common', required: false) > reason = 'missing dependency, "libnfb"' > - > -build = dep.found() and cc.has_header('nfb/nfb.h', dependencies: dep) > - > -nc = dependency('netcope-common', required: false) > - > +build = dep.found() > ext_deps += dep > -ext_deps += nc > > sources = files('nfb_rx.c', 'nfb_tx.c', 'nfb_stats.c', 'nfb_ethdev.c', 'nfb_rxmode.c') > -- > 2.23.0 >