From: "Jan Remeš" <remes@netcope.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: bruce.richardson@intel.com, Rastislav Cernay <cernay@netcope.com>,
dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH 2/2] net/szedata2: fix dependency check
Date: Sun, 15 Sep 2019 14:05:55 +0200 [thread overview]
Message-ID: <CAAnEdtCtMKBQwxZ6GccuJ414pF-G+M4m4yUmh_HChVo7HQBneQ@mail.gmail.com> (raw)
In-Reply-To: <20190914093700.11451-3-thomas@monjalon.net>
On Sat, Sep 14, 2019 at 11:37 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> The library libsze2 provides a pkg-config file: libsze2.pc.
> Looking for this .pc file - with dependency() - is preferred
> than looking for the library - with cc.find_library().
>
> If the library is not installed in a standard path,
> it can be found thanks to PKG_CONFIG_PATH variable.
> The previous solution required to use CFLAGS and LDFLAGS
> environment variables.
>
> Fixes: 508cfe6be9f1 ("net/szedata2: add to meson build")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Jan Remes <remes@netcope.com>
> ---
> drivers/net/szedata2/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/szedata2/meson.build b/drivers/net/szedata2/meson.build
> index 032b42518..b53fcbc59 100644
> --- a/drivers/net/szedata2/meson.build
> +++ b/drivers/net/szedata2/meson.build
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright(c) 2018 Intel Corporation
>
> -dep = cc.find_library('sze2', required: false)
> +dep = dependency('libsze2', required: false)
> build = dep.found()
> reason = 'missing dependency, "libsze2"'
> ext_deps += dep
> --
> 2.23.0
>
prev parent reply other threads:[~2019-09-15 12:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190914093700.11451-1-thomas@monjalon.net>
2019-09-14 9:36 ` [dpdk-stable] [PATCH 1/2] net/nfb: " Thomas Monjalon
2019-09-15 12:04 ` Jan Remeš
2019-09-16 15:46 ` Thomas Monjalon
2019-09-16 15:51 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-09-14 9:37 ` [dpdk-stable] [PATCH 2/2] net/szedata2: " Thomas Monjalon
2019-09-15 12:05 ` Jan Remeš [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAnEdtCtMKBQwxZ6GccuJ414pF-G+M4m4yUmh_HChVo7HQBneQ@mail.gmail.com \
--to=remes@netcope.com \
--cc=bruce.richardson@intel.com \
--cc=cernay@netcope.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).