Re: [dpdk-dev] [PATCH] net/ice: fix wrong data path selection in secondary process

[Navin Srinivas <g.navinsrinivas@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3982 bytes --]

Thanks, I noticed it in the release and took the LTS version.
I do not see the previously noticed VF crash now on 20.11.4

Navin

On Tue, Feb 22, 2022 at 2:51 PM Kevin Traynor <ktraynor@redhat.com> wrote:

> On 22/02/2022 04:30, Zhang, Qi Z wrote:
> > Hi Srinivas:
> >
> > This is the fix for PF driver only, for VF we have a separated fix and
> it is not be captured in 20.11.3, but I saw the patches are already merged
> in stable tree.
> > You can try with latest 20.11.4-rc1,   or wait for 20.11.4 LTS.
> >
>
> 20.11.4 is already released. Xueming sent details here
>
> http://inbox.dpdk.org/announce/20220124084950.482883-1-xuemingl@nvidia.com/T/#u
>
> You can check the release notes (or git) for specific fixes
>
> https://git.dpdk.org/dpdk-stable/tree/doc/guides/rel_notes/release_20_11.rst?h=20.11
>
> > Regards
> > Qi
> >
> > From: Navin Srinivas <g.navinsrinivas@gmail.com>
> > Sent: Tuesday, February 22, 2022 11:56 AM
> > To: Zhang, Qi Z <qi.z.zhang@intel.com>
> > Cc: Wang, Yixue <yixue.wang@intel.com>; Yang, Qiming <
> qiming.yang@intel.com>; Zhang, Liheng <liheng.zhang@intel.com>; Dong, Yao
> <yao.dong@intel.com>; dev@dpdk.org; stable@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] net/ice: fix wrong data path selection
> in secondary process
> >
> > Hi,
> >
> > Is this tested on VFs? I saw crash on both PF as well as VF, on 20.11.1,
> but did not see PF crash on 20.11.3,
> > I'm seeing a crash on the secondary process when it receives packet on
> the VF, but PF doesn't crash now on 20.11.3
> >
> > So I suspect this is the patch which is fixing the issue on ICE
> secondary process crash on PF.
> >
> > Thanks & Regards,
> > Navin Srinivas
> >
> > On Thu, Jun 3, 2021 at 3:51 PM Zhang, Qi Z <qi.z.zhang@intel.com<mailto:
> qi.z.zhang@intel.com>> wrote:
> >
> >
> >> -----Original Message-----
> >> From: Wang, Yixue <yixue.wang@intel.com<mailto:yixue.wang@intel.com>>
> >> Sent: Thursday, June 3, 2021 6:04 PM
> >> To: Zhang, Qi Z <qi.z.zhang@intel.com<mailto:qi.z.zhang@intel.com>>;
> Yang, Qiming
> >> <qiming.yang@intel.com<mailto:qiming.yang@intel.com>>
> >> Cc: Zhang, Liheng <liheng.zhang@intel.com<mailto:liheng.zhang@intel.com>>;
> Dong, Yao
> >> <yao.dong@intel.com<mailto:yao.dong@intel.com>>; dev@dpdk.org<mailto:
> dev@dpdk.org>; stable@dpdk.org<mailto:stable@dpdk.org>
> >> Subject: RE: [PATCH] net/ice: fix wrong data path selection in secondary
> >> process
> >>
> >> Hi, Qi
> >>
> >> I've tested this patch and it works.
> >>
> >> Best Regards,
> >> Yixue.
> >>
> >>> -----Original Message-----
> >>> From: Zhang, Qi Z <qi.z.zhang@intel.com<mailto:qi.z.zhang@intel.com>>
> >>> Sent: Monday, May 24, 2021 17:08
> >>> To: Yang, Qiming <qiming.yang@intel.com<mailto:qiming.yang@intel.com>>
> >>> Cc: Zhang, Liheng <liheng.zhang@intel.com<mailto:
> liheng.zhang@intel.com>>; Wang, Yixue
> >>> <yixue.wang@intel.com<mailto:yixue.wang@intel.com>>; Dong, Yao <
> yao.dong@intel.com<mailto:yao.dong@intel.com>>; dev@dpdk.org<mailto:
> dev@dpdk.org>;
> >>> Zhang, Qi Z <qi.z.zhang@intel.com<mailto:qi.z.zhang@intel.com>>;
> stable@dpdk.org<mailto:stable@dpdk.org>
> >>> Subject: [PATCH] net/ice: fix wrong data path selection in secondary
> >>> process
> >>>
> >>> The flag use_avx2 and use_avx512 are defined as local variables, they
> >>> will not be aware by the secondary process, then wrong data path is
> >>> selected. Fix the issue by moving them into struct ice_adapter.
> >>>
> >>> Fixes: ae60d3c9b227 ("net/ice: support Rx AVX2 vector")
> >>> Fixes: 2d5f6953d56d ("net/ice: support vector AVX2 in Tx")
> >>> Fixes: 7f85d5ebcfe1 ("net/ice: add AVX512 vector path")
> >>> Cc: stable@dpdk.org<mailto:stable@dpdk.org>
> >>>
> >>> Reported-by: Yixue Wang <yixue.wang@intel.com<mailto:
> yixue.wang@intel.com>>
> >>> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com<mailto:
> qi.z.zhang@intel.com>>
> >
> > Tested-by: Yixue Wang <yixue.wang@intel.com<mailto:yixue.wang@intel.com
> >>
> >
> > Applied to dpdk-next-net-intel.
> >
> > Thanks
> > Qi
>
>

[-- Attachment #2: Type: text/html, Size: 8203 bytes --]