From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Cc: Kalesh A P <kalesh-anakkur.purayil@broadcom.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [PATCH 19.11] net/bnxt: fix a typo introduced in backport
Date: Mon, 28 Mar 2022 06:46:28 -0700 [thread overview]
Message-ID: <CACZ4nhsTgLOgvE45=4VURBBUArRDNQeLTahVbasBVD-NEMnhPQ@mail.gmail.com> (raw)
In-Reply-To: <CAATJJ0L_qJzFSnRZo711NUcVWm5hSJjyScf4EZEGV2a7bEWPhg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2098 bytes --]
On Sun, Mar 27, 2022 at 11:29 PM Christian Ehrhardt
<christian.ehrhardt@canonical.com> wrote:
>
> On Fri, Mar 25, 2022 at 9:15 AM Kalesh A P
> <kalesh-anakkur.purayil@broadcom.com> wrote:
> >
> > From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> >
> > This patch fixes a typo introduced in the last backport.
> > Fixed a wrong check.
>
> Hi Kalesh,
> thanks for the fix.
>
> Since we already have entered -rc1 and testing I wanted to ask how
> sever this issue is.
> The options we have are
> a) not really an important issue, hold it back not and make it part of
> 19.11.13 later this year
> b) breaking bnxt too much, needs to get into 19.11.12 - but we would
> not reset testing (no new RC), you'd cover some bnxt related tests
> c) breaking bnxt too much and having potential to influence all
> things, taking into 19.11.12 and casting an -rc2 resetting tests for
> everyone
>
> I'm tempted to consider this a case for (b), but wanted to know if you
> agree and if you could make the related bnxt based re-test happen?
Christian, option (b) is fine. We can take care of bnxt related tests.
Thanks
Ajit
>
> > Upstream code does not have this issue.
> >
> > Bugzilla ID: 977
> > Fixes: 942eb8e842fc ("net/bnxt: fix xstats names query overrun")
> >
> > Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> > ---
> > drivers/net/bnxt/bnxt_stats.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c
> > index 39fd100..bc181db 100644
> > --- a/drivers/net/bnxt/bnxt_stats.c
> > +++ b/drivers/net/bnxt/bnxt_stats.c
> > @@ -612,7 +612,7 @@ int bnxt_dev_xstats_get_names_op(__rte_unused struct rte_eth_dev *eth_dev,
> > if (rc)
> > return rc;
> >
> > - if (xstats_names != NULL || size < stat_cnt)
> > + if (xstats_names == NULL || size < stat_cnt)
> > return stat_cnt;
> >
> > for (i = 0; i < RTE_DIM(bnxt_rx_stats_strings); i++) {
> > --
> > 2.10.1
> >
>
>
> --
> Christian Ehrhardt
> Staff Engineer, Ubuntu Server
> Canonical Ltd
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]
next prev parent reply other threads:[~2022-03-28 13:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 8:16 Kalesh A P
2022-03-28 6:28 ` Christian Ehrhardt
2022-03-28 13:46 ` Ajit Khaparde [this message]
2022-03-28 14:29 ` Christian Ehrhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nhsTgLOgvE45=4VURBBUArRDNQeLTahVbasBVD-NEMnhPQ@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=christian.ehrhardt@canonical.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).