From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36D58A0C57 for ; Wed, 25 Aug 2021 05:51:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0024640041; Wed, 25 Aug 2021 05:51:16 +0200 (CEST) Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by mails.dpdk.org (Postfix) with ESMTP id D889840041 for ; Wed, 25 Aug 2021 05:51:15 +0200 (CEST) Received: by mail-qk1-f174.google.com with SMTP id e14so25706686qkg.3 for ; Tue, 24 Aug 2021 20:51:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LxfDtaPS9hHxLBaOaisZ7a0uA0S4RJplLZN9A+y41dM=; b=JH9E2go/3fTYL4Skz+lxQ5d4agaqCe+GQU6KNcjG7SkRSAjNpdMJXy0nkmag6LOkwJ dfiF9c0gJyW0zwoTCjQjoVSuTWHt4FCkVBPMReYCTftNsPJvLsAToStxoUExoq4dJXXV RewYnLjyY0ADC6NlamR7HB8x5tGZjKmZb5eq8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LxfDtaPS9hHxLBaOaisZ7a0uA0S4RJplLZN9A+y41dM=; b=KrNtosZsGdeaVy5bOg4whA/Qw9Vo0VQRYuHTgeFCtGNxgwT+XjyhIwIKfzG4ysV+cG DBZza0RY4nG9CVhIDQQiJnpT96zm2kTh2Xb0GiElP2ipTJrMDobS6NZpNBUpOur2j9mx YtXOQNVu/nc4vD7ioodfVsI4nusvr0ruiPWXVlaxY57+opaONSgaxdz8loHK3wcErHGh pA0ZSu82TcAwvfgQqWadXqDAXaFxG4woZuCC45U5gh5ZSrUEj0yQ4QbAX2C+G3YIPQt7 k8GRDmR9idTrquSDWnpCGhHamx2XHP4TRsfbrm0B7HoIRGxVngcULjlCLeuEjLcAYqIE Kqkw== X-Gm-Message-State: AOAM531g+7sBDsQRs3qWtD0SU5uPrZVgCl7MKUY4WYgRc6K8fE4/tn5P 02BVyvv3bJ+ciKXjedLuAXExUqeVkXmASclKoeB4iQ== X-Google-Smtp-Source: ABdhPJyJYjqY/T8XBzPlbXk85G3VxI7I3vPjYjANA1DP74xgf6JbTZZomBCnsRzTWIJgI1Ea9TwYqeKEL7k44nojtPI= X-Received: by 2002:a05:620a:179e:: with SMTP id ay30mr29620952qkb.333.1629863475144; Tue, 24 Aug 2021 20:51:15 -0700 (PDT) MIME-Version: 1.0 References: <20210825012901.80499-1-ajit.khaparde@broadcom.com> In-Reply-To: <20210825012901.80499-1-ajit.khaparde@broadcom.com> From: Ajit Khaparde Date: Tue, 24 Aug 2021 20:50:59 -0700 Message-ID: To: dpdk-dev Cc: dpdk stable , Somnath Kotur Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000007c23e505ca5a298c" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-stable] [PATCH] net/bnxt: fix VNIC config error in port start X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" --0000000000007c23e505ca5a298c Content-Type: text/plain; charset="UTF-8" On Tue, Aug 24, 2021 at 6:29 PM Ajit Khaparde wrote: > > During port stop/start sequence the Thor FW is returning an error. > This is because we are deriving incorrect active Rx ring and using > that wrong information in the bnxt_vnic_rss_cfg HWRM command. > > Fix it by using the rx_queue_state from eth_dev. > > Fixes: 0105ea1296c91 ("net/bnxt: support runtime queue setup") > Cc: stable@dpdk.org > > Signed-off-by: Ajit Khaparde > Reviewed-by: Somnath Kotur Patch applied to dpdk-next-net-brcm. > --- > drivers/net/bnxt/bnxt_hwrm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c > index eb9de45cb9..f29d574235 100644 > --- a/drivers/net/bnxt/bnxt_hwrm.c > +++ b/drivers/net/bnxt/bnxt_hwrm.c > @@ -5078,6 +5078,7 @@ static int > bnxt_vnic_rss_configure_p5(struct bnxt *bp, struct bnxt_vnic_info *vnic) > { > struct hwrm_vnic_rss_cfg_output *resp = bp->hwrm_cmd_resp_addr; > + uint8_t *rxq_state = bp->eth_dev->data->rx_queue_state; > struct hwrm_vnic_rss_cfg_input req = {.req_type = 0 }; > struct bnxt_rx_queue **rxqs = bp->rx_queues; > uint16_t *ring_tbl = vnic->rss_table; > @@ -5111,7 +5112,7 @@ bnxt_vnic_rss_configure_p5(struct bnxt *bp, struct bnxt_vnic_info *vnic) > > /* Find next active ring. */ > for (cnt = 0; cnt < max_rings; cnt++) { > - if (rxqs[k]->rx_started) > + if (rxq_state[k] != RTE_ETH_QUEUE_STATE_STOPPED) > break; > if (++k == max_rings) > k = 0; > -- > 2.21.1 (Apple Git-122.3) > --0000000000007c23e505ca5a298c--