patches for DPDK stable branches
 help / color / Atom feed
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Somnath Kotur <somnath.kotur@broadcom.com>
Cc: wangyunjian <wangyunjian@huawei.com>, dev <dev@dpdk.org>,
	jerry.lilijun@huawei.com,  xudingke@huawei.com,
	dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/bnxt: fix missed unlock reported by coverity
Date: Wed, 27 May 2020 18:05:12 -0700
Message-ID: <CACZ4nhsjF2HjB3+Kd-d+XEFu5gjQ=Hnj3LwP0X-yRJ8fF6K53g@mail.gmail.com> (raw)
In-Reply-To: <CAOBf=mvCQwgO+r6D5LsG0nrTcMWC3D_mYkAarDNfZxjensu5WA@mail.gmail.com>

On Wed, May 27, 2020 at 5:13 AM Somnath Kotur <somnath.kotur@broadcom.com>
wrote:

> On Wed, May 27, 2020 at 5:42 PM wangyunjian <wangyunjian@huawei.com>
> wrote:
> >
> > From: Yunjian Wang <wangyunjian@huawei.com>
> >
> > Coverity issue: 357741
> > Fixes: 02a95625fe9c ("net/bnxt: add flow stats in extended stats")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
>
Patch applied to dpdk-next-net-brcm. Thanks


> > ---
> >  drivers/net/bnxt/bnxt_stats.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/bnxt/bnxt_stats.c
> b/drivers/net/bnxt/bnxt_stats.c
> > index cfe193284..8df6922f5 100644
> > --- a/drivers/net/bnxt/bnxt_stats.c
> > +++ b/drivers/net/bnxt/bnxt_stats.c
> > @@ -1008,8 +1008,10 @@ int bnxt_flow_stats_req(struct bnxt *bp)
> >                 }
> >         }
> >
> > -       if (!in_flow_tbl_cnt)
> > +       if (!in_flow_tbl_cnt) {
> > +               bnxt_release_flow_lock(bp);
> >                 goto out;
> > +       }
> >
> >         rc = bnxt_update_fc_tbl(bp, counter_type, valid_en_tbl,
> >                                 in_flow_tbl_cnt);
> > --
> > 2.23.0
> >
> >
> Acked-by: Somnath Kotur <somnath.kotur@broadcom.com>
>

      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-27 12:11 wangyunjian
2020-05-27 12:13 ` Somnath Kotur
2020-05-28  1:05   ` Ajit Khaparde [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACZ4nhsjF2HjB3+Kd-d+XEFu5gjQ=Hnj3LwP0X-yRJ8fF6K53g@mail.gmail.com' \
    --to=ajit.khaparde@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=jerry.lilijun@huawei.com \
    --cc=somnath.kotur@broadcom.com \
    --cc=stable@dpdk.org \
    --cc=wangyunjian@huawei.com \
    --cc=xudingke@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox