From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot0-f172.google.com (mail-ot0-f172.google.com [74.125.82.172]) by dpdk.org (Postfix) with ESMTP id 9F7B57CD5 for ; Fri, 20 Apr 2018 05:33:03 +0200 (CEST) Received: by mail-ot0-f172.google.com with SMTP id p2-v6so8179910otf.3 for ; Thu, 19 Apr 2018 20:33:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=KP6wrEX7TDFmEF6wFfrs8spZ2C9BsU48Dpp0p+6NCN4=; b=SX7QdnCI6Sak89MDCZCWZNazOQK0qbR4RN1OJKdDwrzQSFszBEazKe4DSS06g13GV7 t5XzTq++tj3s2gpI3fvwAnmOE9nwZjoAr/1KuYO48zXcSxURufZ+gM6NMFYYclO2RmgG zatml4KnmXpK8yJxvxSHbStoTSEZlyNMhrDRc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=KP6wrEX7TDFmEF6wFfrs8spZ2C9BsU48Dpp0p+6NCN4=; b=e3CKbc7Zs8/EjXYZs3ORPrkR6TdbAAsDV853cExLEKJBjN0oF7kTz5EPXu4YuC7DeP zoCPProClkbFEAUO+Mn5vXcOLJ86OxftH+mFxjJ2Fx1c3yQESY2gIYtciX+IrUp5tIXa UgmoPYLrC5JbbYQe2LOWZUbMDdJBpBQ+hv40q8qFB0AydnbmQEbD4WUmU9FwL/2uir+L +MNSnIbjQIASdBVeXRaxJZovo8UvKk1mDFCECWQNTzczz+JHHjMFzNtEAdnA9u7cv/k3 h9+Uyk/G8f1ZBwFhNxINOZNbNH7qX0Svk6Llhs0pszMxGdWa0tKMcfLk+UityUJBomuG lYSg== X-Gm-Message-State: ALQs6tCaJ340iAJL7X6me31oFnXW9VJidZSeurvMNjEmqN0wnE46xz+t YSrPArNHmIIDVLMc+xQCxbGcV19qmWKEyPFRpBFA5A== X-Google-Smtp-Source: AIpwx4/bNCCkpflHS+dRKnEK9g/rYbyVOkMRhinUPs61dFitcXCezYv4m8FUZTLtWPTD7XJI9lx8bvtb8hkczQkyV4Y= X-Received: by 2002:a9d:2785:: with SMTP id c5-v6mr3203490otb.199.1524195182851; Thu, 19 Apr 2018 20:33:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.201.48.41 with HTTP; Thu, 19 Apr 2018 20:32:22 -0700 (PDT) In-Reply-To: References: <20180419235754.75550-1-ajit.khaparde@broadcom.com> <20180419235754.75550-3-ajit.khaparde@broadcom.com> From: Ajit Khaparde Date: Thu, 19 Apr 2018 20:32:22 -0700 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, dpdk stable Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-stable] [PATCH 2/3] net/bnxt: check vnic_id before issuing set_rx_mask X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Apr 2018 03:33:03 -0000 On Thu, Apr 19, 2018 at 5:47 PM, Ferruh Yigit wrote: > On 4/20/2018 12:57 AM, Ajit Khaparde wrote: > > In some cases bnxt_hwrm_cfa_l2_set_rx_mask is being called before > > VNICs are allocated. The FW returns an error in such cases. > > Prevent sending the command the FW by checking for a valid vnic id > > Hi Ajit, > > Commit title doesn't explain "why" but explains what has been done. It is > easier > to see "what" part from code but not easy to see "why" without > explanation. Here > commit log explain the reason and scope, only title doesn't reflect it. > Title > can be something like "fix firmware error" ... > Yes, Sure. I missed it. =E2=80=8BI was concentrating on keeping the title s= hort.=E2=80=8B > Please check patches with "check-git-log.sh", it will already complain > about > title, script complains about "_" to force explaining "why" instead of > using > variable/function names. > > Previous set you have sent has same problem, they are already in next-net > but if > you have bandwidth can you please check them too? If you can send revised > commit > log/title > =E2=80=8B=E2=80=8B > I can update them. "check-git-log.sh" will help to find failing ones. > =E2=80=8BWill do. Thanks =E2=80=8B > > <...> > > > @@ -594,7 +590,7 @@ static int bnxt_dev_start_op(struct rte_eth_dev > *eth_dev) > > } > > bp->dev_stopped =3D 0; > > > > - rc =3D bnxt_init_nic(bp); > > + rc =3D bnxt_init_chip(bp); > > Is this bnxt_init_nic()/bnxt_init_chip() changes related to what has been > described in commit log? If so can you explain in commit log why there ar= e > related? >