Re: [PATCH] net/bnxt: fix compatibility with some old firmwares

[Ajit Khaparde <ajit.khaparde@broadcom.com>]

[-- Attachment #1: Type: text/plain, Size: 1716 bytes --]

On Fri, Mar 18, 2022 at 8:03 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> This reverts commit 3972281f47b2cc0cf844698885f0e6b4228c0975.
>
> Reported by Red Hat QE: with older firmware versions (at least versions
> 20.6.112.0 and 20.6.143.0), initialisation never succeeds following this
> change.
> Revert it for now, waiting for a more complete fix.
>
> Fixes: 3972281f47b2 ("net/bnxt: fix device readiness check")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

Patch applied to dpdk-next-net-brcm. Thanks

> ---
>  drivers/net/bnxt/bnxt_hwrm.c | 9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
> index b4aeec593e..bff73a9566 100644
> --- a/drivers/net/bnxt/bnxt_hwrm.c
> +++ b/drivers/net/bnxt/bnxt_hwrm.c
> @@ -1244,11 +1244,6 @@ int bnxt_hwrm_ver_get(struct bnxt *bp, uint32_t timeout)
>         else
>                 HWRM_CHECK_RESULT();
>
> -       if (resp->flags & HWRM_VER_GET_OUTPUT_FLAGS_DEV_NOT_RDY) {
> -               rc = -EAGAIN;
> -               goto error;
> -       }
> -
>         PMD_DRV_LOG(INFO, "%d.%d.%d:%d.%d.%d.%d\n",
>                 resp->hwrm_intf_maj_8b, resp->hwrm_intf_min_8b,
>                 resp->hwrm_intf_upd_8b, resp->hwrm_fw_maj_8b,
> @@ -6149,10 +6144,6 @@ int bnxt_hwrm_poll_ver_get(struct bnxt *bp)
>         rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);
>
>         HWRM_CHECK_RESULT_SILENT();
> -
> -       if (resp->flags & HWRM_VER_GET_OUTPUT_FLAGS_DEV_NOT_RDY)
> -               rc = -EAGAIN;
> -
>         HWRM_UNLOCK();
>
>         return rc;
> --
> 2.23.0
>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]