From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5238FA04B1 for ; Wed, 23 Sep 2020 06:28:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 314241DC0E; Wed, 23 Sep 2020 06:28:47 +0200 (CEST) Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) by dpdk.org (Postfix) with ESMTP id 79D411DABC for ; Wed, 23 Sep 2020 06:28:42 +0200 (CEST) Received: by mail-oi1-f194.google.com with SMTP id 185so23586571oie.11 for ; Tue, 22 Sep 2020 21:28:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=q6WTMRFb8yb5y8mQ6SfyQ39fkJuM478I7k4wMxvpB4M=; b=RGRGmB7hIdz3RzbAMphbUtGfgPrHycC7fBaoRSlrYpqflP3AuaxTQXdrHucWjSBHrD h8GSi6fpNzmdr3me5uuQm7pJGkAEkFt+tj6P+6ZJ2lLGkpXkcleJDN2FHT4LpfY2yHOq iEJPpOx6DzNHirmMBzISqRWaRKiufjzyEOeRM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=q6WTMRFb8yb5y8mQ6SfyQ39fkJuM478I7k4wMxvpB4M=; b=KwExCnMj0Ob8sQXWNnRxXbKxpG59V3OZU79uXq70Ux72e2aHELNMzGFXab2minEBZT feeZL5YGv6/M0VIBkSpYAeMkYhvKIWa4LGqAnoaED5pnDl0lO893+5HBBLYkEuUdcTz5 JYUTfMev/CaFnvZXvdAzQGKC0bFt8Rb7YyPoIQATIhRHsyNN1N7xK6IOTL7YZu4SLROh TCb4mO5+NqtPUNBweROT50/3dHVhJs3e0h+hhm97F2+RugTGP5jOQJiWuww7qvbfuBVc qaW8e5LiBx31m0i6bHsu1SLggdigUd5t/UXx1Ld60+5kx0zLIx7+X0P8jZsIHejSTHGP GNhA== X-Gm-Message-State: AOAM532k6jfAyRtj3RqcPAxcOWoieEF730h0p6kw4iVZnVNMUd9kXuJ0 3s2SgW0LbnIRvf509o5kbFfoyGGO90FUbZe6rEHCJg== X-Google-Smtp-Source: ABdhPJydt5Spi57hTe7oZ5TepW54D/5DYlzWzBaJizmwtaBrlecB1hTwnTEy6Oi9OCra6d+3ZxEz4S4BlBY4UCNuiS0= X-Received: by 2002:aca:4904:: with SMTP id w4mr4697671oia.179.1600835321720; Tue, 22 Sep 2020 21:28:41 -0700 (PDT) MIME-Version: 1.0 References: <20200922053416.16818-1-somnath.kotur@broadcom.com> In-Reply-To: <20200922053416.16818-1-somnath.kotur@broadcom.com> From: Ajit Khaparde Date: Tue, 22 Sep 2020 21:28:25 -0700 Message-ID: To: Somnath Kotur Cc: dpdk-dev , Ferruh Yigit , Kalesh AP , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/bnxt: fix to not bring link down during reset recovery X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Mon, Sep 21, 2020 at 10:41 PM Somnath Kotur wrote: > From: Kalesh AP > > Driver should not send the phy_cfg request to bring link down > during reset recovery. If the driver sends the phy_cfg request > in recovery process, then FW needs to re-establish the link which > in turn increases the recovery time based on PHY type and link partners. > > Fixes: df6cd7c1f73a ("net/bnxt: handle reset notify async event from FW") > Cc: stable@dpdk.org > > Signed-off-by: Kalesh AP > Reviewed-by: Somnath Kotur > Patch applied to dpdk-next-net-brcm. Thanks > --- > drivers/net/bnxt/bnxt_ethdev.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c > b/drivers/net/bnxt/bnxt_ethdev.c > index 05e9a6a..e0afaac 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -1323,7 +1323,9 @@ static void bnxt_dev_stop_op(struct rte_eth_dev > *eth_dev) > > bnxt_cancel_fw_health_check(bp); > > - bnxt_dev_set_link_down_op(eth_dev); > + /* Do not bring link down during reset recovery */ > + if (!is_bnxt_in_error(bp)) > + bnxt_dev_set_link_down_op(eth_dev); > > /* Wait for link to be reset and the async notification to process. > * During reset recovery, there is no need to wait and > @@ -4377,7 +4379,7 @@ static void bnxt_write_fw_reset_reg(struct bnxt *bp, > uint32_t index) > > static void bnxt_dev_cleanup(struct bnxt *bp) > { > - bnxt_set_hwrm_link_config(bp, false); > + bp->eth_dev->data->dev_link.link_status = 0; > bp->link_info->link_up = 0; > if (bp->eth_dev->data->dev_started) > bnxt_dev_stop_op(bp->eth_dev); > -- > 2.10.1 > >