From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Damodharam Ammepalli <damodharam.ammepalli@broadcom.com>
Cc: dev@dpdk.org, ferruh.yigit@amd.com, david.marchand@redhat.com,
stable@dpdk.org
Subject: Re: [PATCH] net/bnxt: fix newline character in speed display
Date: Fri, 4 Oct 2024 13:55:42 -0700 [thread overview]
Message-ID: <CACZ4nhub0Y776A6DrraSHkipH-UTUAXDEouOC4xVYgS2GTmMYQ@mail.gmail.com> (raw)
In-Reply-To: <20241004204808.13191-1-damodharam.ammepalli@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 2215 bytes --]
On Fri, Oct 4, 2024 at 1:53 PM Damodharam Ammepalli
<damodharam.ammepalli@broadcom.com> wrote:
>
> Mistakenly "\n" sneaked into bnxt_print_link_info which
> prints the speed and lanes information of Broadcom Thor2 NIC.
> This patch removes this newline character.
>
> Fixes: 7bc8e9a227cc ("net/bnxt: support async link notification")
> Cc: stable@dpdk.org
> Signed-off-by: Damodharam Ammepalli <damodharam.ammepalli@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
> drivers/net/bnxt/bnxt_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index c6ad764813..18eba0c770 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -1383,7 +1383,7 @@ void bnxt_print_link_info(struct rte_eth_dev *eth_dev)
> eth_dev->data->port_id,
> (uint32_t)link->link_speed,
> (link->link_duplex == RTE_ETH_LINK_FULL_DUPLEX) ?
> - ("full-duplex") : ("half-duplex\n"),
> + ("full-duplex") : ("half-duplex"),
> (uint16_t)bp->link_info->active_lanes);
> else
> PMD_DRV_LOG(INFO, "Port %d Link Down\n", eth_dev->data->port_id);
> --
> 2.43.5
>
>
> --
> This electronic communication and the information and any files transmitted
> with it, or attached to it, are confidential and are intended solely for
> the use of the individual or entity to whom it is addressed and may contain
> information that is confidential, legally privileged, protected by privacy
> laws, or otherwise restricted from disclosure to anyone else. If you are
> not the intended recipient or the person responsible for delivering the
> e-mail to the intended recipient, you are hereby notified that any use,
> copying, distributing, dissemination, forwarding, printing, or copying of
> this e-mail is strictly prohibited. If you received this e-mail in error,
> please return the e-mail to the sender, delete it from your computer, and
> destroy any printed copy of it.
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]
next prev parent reply other threads:[~2024-10-04 20:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 20:48 Damodharam Ammepalli
2024-10-04 20:55 ` Ajit Khaparde [this message]
2024-10-07 2:59 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACZ4nhub0Y776A6DrraSHkipH-UTUAXDEouOC4xVYgS2GTmMYQ@mail.gmail.com \
--to=ajit.khaparde@broadcom.com \
--cc=damodharam.ammepalli@broadcom.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).