Re: [PATCH] net/bnxt: fix segmentation fault

[Ajit Khaparde <ajit.khaparde@broadcom.com>]

[-- Attachment #1: Type: text/plain, Size: 1471 bytes --]

On Wed, Nov 20, 2024 at 9:01 AM Ajit Khaparde
<ajit.khaparde@broadcom.com> wrote:
>
> From: Kishore Padmanabha <kishore.padmanabha@broadcom.com>
>
> The mbuf offload flags were not reset before the flags were
> populated with the received packet details. This causes certain
> applications to act differently on the offload flags. That can
> cause application to assert at many locations.
>
> Fixes: 65d2b0557ba3 ("net/bnxt: support Rx completion v3")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>
> Reviewed-by: Jay Ding <jay.ding@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

Fixed up a typo and merged into dpdk-next-net-brcm. Thanks


> ---
>  drivers/net/bnxt/bnxt_rxr.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_rxr.h b/drivers/net/bnxt/bnxt_rxr.h
> index 5e5496964f..7357ca4427 100644
> --- a/drivers/net/bnxt/bnxt_rxr.h
> +++ b/drivers/net/bnxt/bnxt_rxr.h
> @@ -535,6 +535,6 @@ bnxt_parse_csum_v3(struct rte_mbuf *mbuf, struct rx_pkt_cmpl_hi *rxcmp1)
>         uint16_t error_v2 = rte_le_to_cpu_16(v3_cmp->errors_v2);
>         uint32_t flags2 = rte_le_to_cpu_32(v3_cmp->flags2);
>
> -       mbuf->ol_flags |= bnxt_parse_csum_fields_v3(flags2, error_v2);
> +       mbuf->ol_flags = bnxt_parse_csum_fields_v3(flags2, error_v2);
>  }
>  #endif /*  _BNXT_RXR_H_ */
> --
> 2.39.5 (Apple Git-154)
>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]